Commit Graph

2117 Commits

Author SHA1 Message Date
Alex Chau e3b4b66d79 Merge "Support both grid and large tile with gridOnlyOverivew" into main 2025-01-14 12:24:19 -08:00
Alex Chau 9c85596111 Support both grid and large tile with gridOnlyOverivew
- With the introduction of Desktop windowing, we'll need to supprot grid task and large tile (desktop tile) coexisting
- The previous gridOnlyOverview aimed to have taskSize matches actual grid task size, and introduced another carouselTaskSize for scaling in swipe up carousel
- Now I'm reverting to pre-gridOnlyOverview implementation of having taskSize as both large tile size and carousel task size, and gridTaskSize as only task size in grid

TaskViewSimualtor
- Removed no longer needed carousel translation and related calculations
- mIsGridTask is now determined with DeviceProfile, so when swipeing to Desktop task it won't use grid task size

TaskView
- Removed no longer used nonGridPivotTranslationX

RecentsView
- Make getSelectedTaskBounds / getTaskBounds picks the correct taskSize

Fix: 359573248
Fix: 321697299
Fix: 325606690
Bug: 322816508
Test: Swipe up, quick switch, task launching with grid task and desktop tasks; repeat with RTL, three button, phone
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I14648c6682c53a4d06f9c9585d53f28dddef4f8f
2025-01-13 13:31:29 +00:00
Holly Jiuyu Sun 9d0cbfd689 Merge "Remove remaining "Item added to home screen" annoucement from talkback." into main 2025-01-08 10:15:49 -08:00
Sebastian Franco f59d3de3c6 Using pixels instead of DPI for selecting the grid size
Fix: 383132640
Bug: 386479043
Test: Screenshot test
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ic3eda69324e03cc6f049cd7d21dac7ab6a22271e
2025-01-07 10:32:07 -08:00
Stefan Andonian 25283f0f45 Fix for bug where Talkback announce Folder:null
Bug: 385046797
Test: Verified this works locally.
Flag: EXEMPT bug fix
Change-Id: I9ad23f351df078b6bd40ff861e13b9109bfa8993
2024-12-30 14:01:28 -08:00
Holly Sun ae654ddaff Remove remaining "Item added to home screen" annoucement from talkback.
Based on https://b.corp.google.com/issues/383457529#comment5, we should remove all app annouced confirmation.

Bug: 386247991
Test: build
Flag: EXEMPT a11y bug fix
Change-Id: I0ba2e282a42c0785c8bdad1be23adf2bf90a44b3
2024-12-26 15:02:39 -08:00
Anushree Ganjam 59137e44e2 Merge "Update the All apps label to "Apps list"" into main 2024-12-18 14:07:36 -08:00
Anushree Ganjam 8dae1be563 Update the All apps label to "Apps list"
Set the AccessibilityNodeInfo containerTitle to improve a11y for users
in predictionRow.

See expected behavior suggestion in  https://b.corp.google.com/issues/379640673#comment1

Video
Quickstep launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/eugH3ID7eenOuLwTszaLHk

Pixel launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/fftzwMRCy6N3o7OcwiGMdk

Bug: 379640673
Test: Manual
Flag: EXEMPT a11y bugfix
Change-Id: I23a8a142afb213c0801402a56bc134bc14f0f97d
2024-12-17 16:39:45 -08:00
Wen-Chien Wang 2badfc7ebc pin-shortcut: Add pin shortcut to the context menu
This cl adds the pin shortcut option to the context menu, where
it works on Home launcher, hotseat, and pinned apps on the
taskbar.
Currently the option is a no-op.

Bug: 375648361
Test: Manual. Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I5d1284a6e909fd75f14e81c3ae713da3cdc01ce3
2024-12-13 22:49:52 +00:00
Sunny Goyal 41e8057bbf Moving WMProxy to dagger
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I9a8031037f2167658b7bc212b59c9b11abbf2f03
2024-12-11 13:24:26 -08:00
Shamali Patwa 5fb8180b00 Merge "Remove the elevation on the DragView to avoid shadows underneath" into main 2024-12-06 23:40:38 +00:00
Shamali P cc21323af2 Remove the elevation on the DragView to avoid shadows underneath
In b/297952359 we are seeing that widgets with clipped outline
 elements end up showing shadows below their drag view. Which
 due to not maintaining clipping looks further bad.

It seems like, we don't really need the elevation for drag
view anymore - and presumably it was added for older android
 versions for shadow for folders. But, they don't have them
  anymore, so, removing elevation now.

 Note: The issue that during drag and drop, the dragged preview
 not showing clip to outline or shadows within widget's views is
 a separate issue related to the Picture API usage during drag
  and drop.

Bug: 297952359
Test: Screen record in comments
Flag: EXEMPT Bugfix

Change-Id: If31a0275938afe374d269a46cc950970033323f9
2024-12-06 21:10:51 +00:00
Shamali P 67df1f0d2c Use outline color token for bottom sheet.
- Per android design folks, "outline" is the right token to use
- They've also verified with material design folks that its the
 recommended value.

Bug: 378424549
Test: WIM contrast checker
Flag: EXEMPT BUGFIX
Change-Id: I3b45860da9405469600771d6ff5d1adea1e4ea4c
2024-12-05 14:54:09 +00:00
Shamali P 0e668e1b1d Update accessibility hint for widget cell that shows add button.
With tap to add feature, tapping widget cell reveals add button.

So, clarify the intent with ACTION_CLICK

Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
fbaron d1cd8c2ea6 Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: If1dafedc710ebc483fc7b6b5cd6cae6f70dc3cfc
2024-12-03 02:43:13 +00:00
Brandon Dayauon 9f1b9d1b13 Fix close button in workEDU card not 48dp.
Can use insets to make it appear the same small visual but have a 48dp tap target. Since delegating the touch to the 48dp,
we can make the imageButton clickable to false as it's instead being used by the 48dp frame.

- since there's no rtl catering for insets insets must have equal left and right values.
   * this means to reduce the end margin of the text to be given to the LEFT inset of the inset_rounded_action_button
   * reduce end margin of the linearlayout to be given to the right inset of the drawable.

bug:379794419
Test manually photos:
beforeRTL:https://drive.google.com/file/d/1-DzcjOTywgk6SFjfCX7AVnmfqsIfa1lh/view?usp=sharing
afterRTL:https://drive.google.com/file/d/1UERlZ7XdoF0NhFuQE-oMulqgW9sDq9cy/view?usp=sharing
before:https://drive.google.com/file/d/1h5_Ljsx1rLyKum1PK7IRwD14ps2SPKC3/view?usp=sharing
after:https://drive.google.com/file/d/1b_8rgrC8WlDIdQuO7gOXS0MDNCISfxWr/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I017d4d34ef6e42fa49543c5f787063b061c382dc
2024-11-27 14:02:31 -08:00
Treehugger Robot c4a90de0e9 Merge "Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints" into main 2024-11-27 21:17:43 +00:00
Marcelo Arteiro 8b63ee3420 Merge "Migrate materialColor* attributes into colors" into main 2024-11-27 14:55:47 +00:00
fbaron 493583435b Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I391e001ddee454baccbc0a8f1e002cc815722239
2024-11-26 00:38:19 +00:00
Ana Salazar Maldonado f9884f20f3 Avoid drawing the launcher pill outside the view bounds
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds.  Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Pinyao Ting d406bd8f2a Update the a11y announcement for the deep shortcut menu to "Shortcut Menu"
Bug: 378062790
Change-Id: Iebbf922d95be5a9f726d993ac9fb7a41fb2bcbc3
Test: manual
Flag: EXEMPT bugfix
2024-11-20 19:15:38 +00:00
Brandon Dayauon 74842f0c16 Merge "Fix work tab accessbility issues." into main 2024-11-19 18:44:14 +00:00
Sebastián Franco 3448777679 Merge "Changing name of RowCount to GridDimension to be more general" into main 2024-11-19 05:36:43 +00:00
Brandon Dayauon df5e51ce34 Fix work tab accessbility issues.
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.

bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp

Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
2024-11-18 15:16:41 -08:00
Marcelo Arteiro fede690863 Merge "Aligning Android color tokens with Material" into main 2024-11-15 14:50:53 +00:00
Saumya Prakash 52866fc596 Merge "Add Manage Windows option to Taskbar long press menu" into main 2024-11-15 08:57:49 +00:00
Saumya Prakash dbaf1028db Add Manage Windows option to Taskbar long press menu
This change adds an option to the long press menu on Taskbar apps to
view open instances of the calling apps. It will only show on apps that
support multi instance (ex. Chrome).

Bug: 315989246
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ie1e001c4cec831c751bcbf448aaa68bb90fb24ca
2024-11-15 06:34:28 +00:00
Sebastian Franco 394a7e64f8 Changing name of RowCount to GridDimension to be more general
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I7ca46babf0c4ce647a4c98a7dd0326b35450479f
2024-11-14 18:58:16 -08:00
Treehugger Robot 27fc554d2e Merge "Add OldGrid field for GridOption so we can properly filter out the old grids when the flag is on" into main 2024-11-13 21:16:43 +00:00
fbaron 6c91ef9191 Add OldGrid field for GridOption so we can properly filter out the old grids when the flag is on
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: NexusLauncherImageTests, DeviceProfileDumpTest
Change-Id: I8e3ff70d2f3008d1de7c8419290ff44c18c72e70
2024-11-13 11:31:50 -08:00
Marcelo Arteiro 7ddef8f82d Aligning Android color tokens with Material
Original change was reverted because of a flag misplacement. Fixed now.

Script also updated to generate update resource files.

Bug: 376195115
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Ieefa4a675a1cd140e6e86a51cbca85faa52870c7
2024-11-13 13:58:33 +00:00
Brandon Dayauon df14fffa54 Add elevation to workFAB to create a shadow
Unable to use md.sys.elevation.level3 but codesearched and
looked it up that this is equivalent to 6dp.

bug: 375597648
Test:
before: https://drive.google.com/file/d/1fp2l5p4wW2Gf3duC2qQ_brQ-xY0bTnOF/view?usp=sharing
after: https://drive.google.com/file/d/19xSAnWJURuwrjhMiywfjNT2vD0G2GoFP/view?usp=sharing
Flag: NONE adding elevation
Change-Id: I484609b4dc817b6d76701f60da51c3ec89bc8755
2024-11-12 15:33:10 -08:00
ELIYAZ MOMIN (xWF) a438f7be54 Merge "Revert "Aligning Android color tokens with Material"" into main 2024-11-12 16:35:18 +00:00
ELIYAZ MOMIN (xWF) 866b7e3cee Revert "Aligning Android color tokens with Material"
Revert submission 30126328-material-token-sync

Reason for revert: <Potential culprit for b/378661448  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Reverted changes: /q/submissionid:30126328-material-token-sync

Change-Id: Ifd0490a876081f3e50f674abc504bf5ba9be2df9
2024-11-12 15:12:01 +00:00
Treehugger Robot 76eadb7c5c Merge "Aligning Android color tokens with Material" into main 2024-11-12 12:40:17 +00:00
Federico Baron 0c5177c817 Merge "Add mounted mode image tests and remove some image tests for OneGrid" into main 2024-11-11 19:17:42 +00:00
Marcelo Arteiro e2a68036b7 Aligning Android color tokens with Material
Script also updated to generate update resource files.

Bug: 376195115
Test: presubmit
Flag: EXEMPT bugfix

Change-Id: I7f0fc8db36d8400559c3d5817e8331b973343dc3
2024-11-11 15:35:24 +00:00
fbaron c1b68f4f6d Add mounted mode image tests and remove some image tests for OneGrid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest, AllAppsImageTest, FolderImageTest
Change-Id: I1d51596d50d63b00614a2efd342cce72d9a4af8e
2024-11-09 01:21:40 -08:00
Matthew Mourgos ba81c0f345 Merge "Add focus ring to widgets header" into main 2024-11-08 21:44:05 +00:00
Sebastian Franco 9e4c99befd Adding Launcher Mode settings to Launcher settings
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Iab688ebdb8449f9258b61f59a0afe97875f82a81
2024-11-07 21:17:10 -08:00
Matthew Mourgos 7820eab80c Add focus ring to widgets header
Change the widgets header drawable to be a selector with the
state_focused property in addition to the state_expanded property. The
focused items are drawn with a focus ring with no ripple, while the
unfocused items have a ripple.

Bug: 365120324
Test: focus traversal through left widget picker pane
Flag: EXEMPT bug fix
Change-Id: I710cb9e2d727a061e0c19df15526e8c832f6366b
2024-11-07 12:56:16 -08:00
Shamali P 1c173e96be Define the list entry and view holder for the view all button
Child cl updates the adapter & picker to use this list entry type.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: I69e82fb7df24270dac4cc0afd003e98247280552
2024-11-07 14:01:29 +00:00
Brandon Dayauon 270e1c3dc4 Merge changes from topic "implementWorkSchedulerViewAndUpdateColorsOfFab" into main
* changes:
  Make sure work button is collapsed when keyboard is up upon going to app drawer
  Implement the work scheduler view and update colors of FAB
2024-11-06 19:57:26 +00:00
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Treehugger Robot 230b2f50a7 Merge "Fix flag guarding for oneGridRotationHandling" into main 2024-11-06 17:04:05 +00:00
fbaron 49f7df0444 Fix flag guarding for oneGridRotationHandling
Bug: 364711064
Flag: com.android.launcher3.one_grid_rotation_handling
Test: n/a
Change-Id: Ic0027bf82912bf56470a8abc29880599820b3352
2024-11-05 16:29:26 -08:00
Anushree Ganjam 2d55010135 Make ContextualEduStatsManager injected by Dagger (13/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I0150ad8edeac1746e27b7d919891d02e648413be
2024-11-05 14:53:01 -08:00
Shamali P ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
Treehugger Robot 9486f5b455 Merge "OneGrid Grid Option Updates" into main 2024-10-30 22:06:11 +00:00