Commit Graph

1152 Commits

Author SHA1 Message Date
Sihua Ma 2bad402275 Change home screen state description to manifest page change
Bug: 383247157
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I1c2d3aa90d2b4ee9a1beaa4fbe7db57e79ae49dc
2025-01-03 00:00:48 +00:00
Brandon Dayauon 4973c18fe4 Make work edu close button not say "Close, Image" in a11y.
Moved content description to the bigger container since that's what takes the touch input anyways.
Now says "Close, double click to activate"

bug: 383945600
Test: manually
Flag: EXEMPT bug fix
Change-Id: Ic35602022f057db59f683c5bd07a3d16fa4983f2
2024-12-23 14:02:14 -08:00
Brandon Dayauon 9f1b9d1b13 Fix close button in workEDU card not 48dp.
Can use insets to make it appear the same small visual but have a 48dp tap target. Since delegating the touch to the 48dp,
we can make the imageButton clickable to false as it's instead being used by the 48dp frame.

- since there's no rtl catering for insets insets must have equal left and right values.
   * this means to reduce the end margin of the text to be given to the LEFT inset of the inset_rounded_action_button
   * reduce end margin of the linearlayout to be given to the right inset of the drawable.

bug:379794419
Test manually photos:
beforeRTL:https://drive.google.com/file/d/1-DzcjOTywgk6SFjfCX7AVnmfqsIfa1lh/view?usp=sharing
afterRTL:https://drive.google.com/file/d/1UERlZ7XdoF0NhFuQE-oMulqgW9sDq9cy/view?usp=sharing
before:https://drive.google.com/file/d/1h5_Ljsx1rLyKum1PK7IRwD14ps2SPKC3/view?usp=sharing
after:https://drive.google.com/file/d/1b_8rgrC8WlDIdQuO7gOXS0MDNCISfxWr/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I017d4d34ef6e42fa49543c5f787063b061c382dc
2024-11-27 14:02:31 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Brandon Dayauon 74842f0c16 Merge "Fix work tab accessbility issues." into main 2024-11-19 18:44:14 +00:00
Shamali Patwa 797b636491 Merge "Add container around the previews in the pin widget sheet." into main 2024-11-19 00:02:47 +00:00
Brandon Dayauon df5e51ce34 Fix work tab accessbility issues.
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.

bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp

Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
2024-11-18 15:16:41 -08:00
Shamali P 9f80ecfc83 Add container around the previews in the pin widget sheet.
We did it in past for app-specific picker. Updating the same for the
pin sheet - verified change with Jane Park.

Bug: 379675391
Flag: EXEMPT BUGFIX
Test: Verified with pin sheet and wallpaper colors
Change-Id: I37e7ac93757e95e1940567e800a376256e0b8ed8
2024-11-18 20:41:12 +00:00
Shamali P 1ce33c8537 Make overscroll in recommendation section limit within its bounds.
Previously, it stretched the parent container, which on close
 observation looked odd.

Bug: 360061549
Flag: EXEMPT BUGFIX
Test: Opened picker and tested that stretch doesn't overflow.
Change-Id: I531b91131f7f86f37df21ab0f67a778c4ae7843f
2024-11-15 23:34:34 +00:00
Brandon Dayauon 7a609d8f1b Merge "Add elevation to workFAB to create a shadow" into main 2024-11-13 17:50:28 +00:00
Brandon Dayauon df14fffa54 Add elevation to workFAB to create a shadow
Unable to use md.sys.elevation.level3 but codesearched and
looked it up that this is equivalent to 6dp.

bug: 375597648
Test:
before: https://drive.google.com/file/d/1fp2l5p4wW2Gf3duC2qQ_brQ-xY0bTnOF/view?usp=sharing
after: https://drive.google.com/file/d/19xSAnWJURuwrjhMiywfjNT2vD0G2GoFP/view?usp=sharing
Flag: NONE adding elevation
Change-Id: I484609b4dc817b6d76701f60da51c3ec89bc8755
2024-11-12 15:33:10 -08:00
Shamali P 697dcf44ac Maintain selected or last header on clicking "Show all" button
Bug: 356127021
Test: Manual and tapl test
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Change-Id: I762695f9999e5ea4c722dbedde6d7efabd3ab0cb
2024-11-12 22:31:14 +00:00
Shamali P d39c31da74 Adjust the bottom padding padding on the left pane in picker
Right now, with 24dp bottom padding, the last item is partially visible
behind that padding. And makes the touch target for last item small.
This is more visible when show all button ends up there.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Unit tests
Change-Id: If2743f73bec0ea244fef7eb1fa3efc903876914b
2024-11-07 14:02:02 +00:00
Shamali P 1c173e96be Define the list entry and view holder for the view all button
Child cl updates the adapter & picker to use this list entry type.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: I69e82fb7df24270dac4cc0afd003e98247280552
2024-11-07 14:01:29 +00:00
Shamali P 8694df5f59 Move search widgets list view besides the personal/work lists
With the sticky header removed from two pane, the search results list
should to be aligned similar to the work / personal lists relative
to the search bar container.

Bug: N/A
Test: Manual
Flag: EXEMPT cleanup
Change-Id: I5cca57ca1861d3135d3b72fe84f75607555ea5ed
2024-11-07 14:01:17 +00:00
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Brandon Dayauon 0b2acd6516 Merge changes from topic "AddWorkSchedulerInWorkProfileFlag" into main
* changes:
  Add work_scheduler_in_work_profile flag.
  Remove layoutTransitions for current FAB and use custom animation.
2024-10-29 20:17:02 +00:00
Brandon Dayauon a7123472ce Remove layoutTransitions for current FAB and use custom animation.
Have background contain left and right padding of 16dp.
That way upon collapse, its easier to animate so that every other view's space but the icon is removed.
Spec when expanded/collapsed: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2839-365095&node-type=text&m=dev

bug: 361589193
Test: manually - video:https://drive.google.com/file/d/1K7HCpayZBa_oo9p3XV10QQX4miTy_d3q/view?usp=sharing
withRTL: https://drive.google.com/file/d/1NfUEyEvzjfQamujv4EqLNBqB47mPNG1Y/view?usp=sharing
Flag: NONE just changing expandedFAB to use custom animations from layoutTransition

Change-Id: I7948633850a1010175eb4f0248daff22cf2f2c87
2024-10-29 09:50:13 -07:00
Shamali P be18ff2b7d Fix issue that items were invisible in 2-pane picker with talkback.
Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: Id8419e51bf20a38f203ce2422bae6290babcd63e
2024-10-25 23:00:36 +00:00
Treehugger Robot 1160d080f4 Merge "Fix cropped folder name text in arabic" into main 2024-10-09 19:35:13 +00:00
Liam Lee Pong Lam 644aad280b Merge "Implement focus state on personal/work tab button" into main 2024-10-04 20:33:00 +00:00
Shamali P adc171b313 Move padding from parent to WidgetPagedView and siblings in 2-pane pkr
WidgetPagedView seems to rely on padding to position it such that
 talkback doesn't focus on it before sticky header.

Bug: 348107507
Test: With talkback
Flag: EXEMPT bugfix

Change-Id: I2fcdc0cbf027a7a8c1bee104f85a61f700faf776
2024-10-02 16:55:59 +00:00
Toni Barzic 2c72b9bd1a Fix cropped folder name text in arabic
Centralize the folder name within folder footer using gravity property
instead of adding padding to the folder name view. Padding as calculated
was cropping the folder name to the text line height, which was
insuficient in some cases, as eveidenced by the linked bug.

Bug: b/358006967
Test: Open a folder on home screen with arabic system language.
      Verify that the folder name displays correctly.
Flag: EXEMPT bugfix

Change-Id: I4436c224f7f6541f447e3a5354ff870cf4d50698
2024-09-26 04:57:45 +00:00
Liam, Lee Pong Lam d4488bfd72 Implement focus state on personal/work tab button
figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0
result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5
hsv: https://hsv.googleplex.com/4794951907934208

Bug: 327430110
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369
2024-09-25 20:34:49 +00:00
Toni Barzic 667fe050ff Make widget sheet layout container not focusable
SpringRelativeLayout views in widgets sheets UI are non-actionable
containers, and as such they would ideally not receive focus. They were
made focusable as a workaround for an issue where back action was no-op
when widget search text box was focused, and there were no other
focusable elements in the UI b/197129170.
WidgetSearchBarController handles back action by clearing
focus, which ends up refocusing the search text box. This CL, removes
this back action override, and let's back action through - it will end
up being handled by `WidgetsFullSheet.onBackInvoked` which resets the
search.

Bug: 365120544
Test: Manual - verified back action with widget search active (and in
      case with no results) in emulator
Flag: EXEMPT bugfix

Change-Id: I1fed37372521947b7d4644047807dc451b0119a4
2024-09-11 18:50:56 +00:00
Sunny Goyal 42becd041b Cleanup unused workspacePageIndicator
Fix: 270395278
Flag: NONE removing dead code
Test: verify everything still works the same
Change-Id: Id0eda5c5994c3323a8d16900678fbd7b39911b62
2024-08-27 12:23:21 -07:00
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Shamali P 8c965c67dc Adjust tap target of the profile tabs in picker
Uses insets on background drawable to maintain visual size.

Bug: 360245807
Test: Accessibility scanner
Flag: EXEMPT bugfix
Change-Id: I1fbc7c2c782a1e331dd1ba77b0a3bf8aad277792
2024-08-20 00:42:32 +00:00
Brandon Dayauon 4f7d4c2975 Set maxLines for private space header to 1.
This is an issue for large font/display that in the arabic language will clip the Private text.

bug: 357942579
Test manually: https://drive.google.com/file/d/1FFZpXmfwKlRG7mvmSCtc1dtjwUjuXjfW/view?usp=sharing
Flag: NONE bugix

Change-Id: I22943237e10b502edb6aae6845fbe6027fda1323
2024-08-14 13:47:37 -07:00
Brandon Dayauon 085ee66233 Remove padding on background and icon.
This padding causes the x to look pointy.

bug:342246204
Test:
before padding:https://screenshot.googleplex.com/GU8ZKEcGPH7DaAD
after padding: https://screenshot.googleplex.com/aRGtiKMQ8jyMWsw
Flag: NONE Padding change

Change-Id: I910914b742bfbb5bf0122ebb1b950ce95c43e9ed
2024-07-22 11:26:11 -07:00
Marcelo Arteiro f38d98d1a6 Align color resources in launcher projects.
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.

Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
2024-07-19 14:22:21 +00:00
Shamali Patwa 1407aeca8d Merge changes from topic "ls-picker-filter" into main
* changes:
  Consider the widget option menu choice in search results
  Show only filtered / default widgets in standalone activity by default
  Add a 3 dot vertical menu and styles (child cl makes it functional)
  Set default widgets and all widgets separately from standalone activity
  Update the widget picker activity theme for popup menus styling
2024-07-18 14:14:42 +00:00
Shamali P 2e2d4ff603 Add a 3 dot vertical menu and styles (child cl makes it functional)
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I99985098034f6336f683b1ff3a47dce2aa8e596a
2024-07-17 22:56:41 +00:00
Brandon Dayauon 0e5640376e Remove enableLayoutTransitions for private space.
Get rid of layoutTransitions as they are not reliable, see here: https://docs.google.com/document/d/1ExSemBvzzVv-I9tUCVzdLeN-lDb2hTSOM886UYSH-Qk/edit?usp=sharing&resourcekey=0-aBCCLnrB7KtkhIeyUOkKyw
Instead use actual animatorSet to do the animating.
- This also fixes the timings so that the pill transition happens at the same time of the icon alpha animation.
Made member variable for lockText and settingButton.

bug:346298256
Test:
before: See bug
after manually- video: https://drive.google.com/file/d/1B7PIgrGWMJTphc1b5CvCkyg-QYx3TTN3/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I049b84dbe1279a0becb090db8660975dc5c5961e
2024-07-17 10:35:53 -07:00
Brandon Dayauon 197fbabf2c Merge "Make close button to use google symbol library icon and update close color button" into main 2024-07-09 21:53:49 +00:00
Brandon Dayauon 6073fa296c Make close button to use google symbol library icon and update close color button
spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2df5f2c9773_4_0
CloseButtonColor to be scLOW
CloseIconColor to be onSurface

bug: 342246204
Test: manually photos:
beforeLT: https://drive.google.com/file/d/14O61WzHmeAhOdGirUci2u9vot3FWcSKo/view?usp=sharing
beforeDT: https://drive.google.com/file/d/1Dt75_sRIWNHMuwqnYzE1WvjRTZFHWJ8-/view?usp=sharing
afterLT: https://drive.google.com/file/d/1npg-icWcsEN5OCgMtP1oU7mB-gGuT6_n/view?usp=sharing
afterDT: https://drive.google.com/file/d/11LTC_61QTg4tX0SUO23cAbLaP7aoSnh-/view?usp=sharing
Flag: NONE Color change
Change-Id: I0c47c927c5c8094a018e6f18061e99fc4bd901de
2024-07-09 09:39:03 -07:00
Shamali P 96ebf67b9f Update the title and description provided by intent params.
Bug: 347288851
Flag: EXEMPT flagged in sys ui
Test: Manual (automated covered in b/339716822)
Change-Id: I71f21bc48fd03dbbe2b3804b7fcade5940606917
2024-07-03 15:49:32 +00:00
Mady Mellor 58a6bbac4a Update bubble bar overflow to have a unique resId
This allows the overflow to be tested properly in end-to-end tests.

Flag: com.android.wm.shell.enable_bubble_bar
Test: atest OverflowBubbleTest (with other CL)
Bug: 347312208
Change-Id: Ice969434f9c40602c4b2d1a5baf6ba0509534a56
2024-06-18 16:43:32 -07:00
Brandon Dayauon 736527a127 Make PrivateSpaceSettingsButton instead of having just the imageView.
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class

bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
2024-05-31 17:05:13 -07:00
Brandon Dayauon ae0e957eea Update private space divider thickness and padding per spec.
Thickness (height) is 2dp.
Padding above and below the divider is 32dp.

bug: 340307977
test manually:
before: https://drive.google.com/file/d/1H364XUILz3gTLOENQL5zQBOELcza7YBk/view?usp=sharing
after: https://drive.google.com/file/d/1HCsnj2s9TwlzIjKL1aHbBqO15nkPoOLj/view?usp=sharing
after vertical padding: https://drive.google.com/file/d/1HS1SFVj9RfvuxHPGyk0PH5dGQum3spqe/view?usp=sharing
Flag: None

Change-Id: I64e9a228e9095449c4ef5f7680d92d234ab96f9f
2024-05-20 16:24:14 -07:00
Oli Thompson 9305badf5a Merge "Show edu card when managed profile removed" into main 2024-05-20 10:38:19 +00:00
Oli Thompson 3ea1acb8ca Show edu card when managed profile removed
Reset the work edu card bit so the edu card shows if the managed profile is removed

Also remove padding from the close button so it doesn't clip. screenshot https://screenshot.googleplex.com/96Yc6yExZ57btxG

Bug: 315449027
Bug: 293642345
Test: manual
Flag: NONE
Change-Id: I60cfc0c258d28a6674aec41862c1770550a14955
2024-05-15 14:19:03 +00:00
Brandon Dayauon 1d3ddb877d Add floatingMaskView when animating to mimic bottom container.
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation

bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING

Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
2024-05-13 11:08:05 -07:00
Willie Koomson 49e364cd0b Remove shadow on Add button
Set android:stateListAnimator to @null to remove default shadow on Add
button.

Bug: 333736273
Test: manual, check shadow on device
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ifa66801963e69582935806eb8a39dcfe624ffdc7
2024-05-06 22:26:24 +00:00
Willie Koomson 1156e8419a Hide add button text if cell is too narrow
If the WidgetCell is not wide enough, hide the add button text and show
an icon-only plus button.

Bug: 333735974
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ieb0b2e679bd4a5785a0f7f01e177ad412a355ce7
2024-05-02 19:55:41 +00:00
Willie Koomson 61dc97ecb2 Update font settings to match POR
Updates font color, size, weight, and line height for text in the widget
picker to match POR and pass a11y test.

Bug: 317948371
Flag: NONE
Test: Accessibility Scanner contrast test
Change-Id: I3c7676c507b81a616876206681972ebb9fefd0c3
2024-05-02 19:55:33 +00:00
Willie Koomson 21379bfbbc Merge "Remove widget education tip dialog" into main 2024-04-26 20:23:21 +00:00
Willie Koomson d731ba2ff1 Remove widget education tip dialog
This change removes the widget education tip dialog, and the arrow
tip view. These are no longer needed now that taps are handled by
showing an add button.

Bug: 335318980
Test: `pm clear com.google.android.apps.nexuslauncher` and open widget
 picker
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: I9b24a41604880f5f94939c02b94f1a9f6a6c83d5
2024-04-25 22:56:36 +00:00
Himanshu Gupta 578f1a474e Merge "Fix Accessbility bugs for PS." into main 2024-04-25 17:03:54 +00:00