Commit Graph

494 Commits

Author SHA1 Message Date
minch fb2e514de8 Initial implementation of the AddDesktopButton
Add the AddDesktopButton to the view hierarchy behind the flags.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug: 382057498
Test: Manual
Change-Id: I5748d8c18d8f5204fa1fb0717c4a8098bfde1537
2025-01-15 18:42:18 +00:00
Treehugger Robot 9fdf9efdd2 Merge "multiple-desktops: Add new desktop button xml file" into main 2024-12-04 14:02:41 +00:00
minch 7fbc82cab1 multiple-desktops: Add new desktop button xml file
- Add the skeleton xml file for the new desktop button
- Add the icon for this button as well
- Create the kotlin file for this button

Flag: EXEMPT as added files haven't connected with the production logic
Fix: 379941322
Test: None
Change-Id: I5c7ea2c061f0f9539483221f40c892626103d11e
2024-12-04 10:26:42 +00:00
Brandon Dayauon 9f1b9d1b13 Fix close button in workEDU card not 48dp.
Can use insets to make it appear the same small visual but have a 48dp tap target. Since delegating the touch to the 48dp,
we can make the imageButton clickable to false as it's instead being used by the 48dp frame.

- since there's no rtl catering for insets insets must have equal left and right values.
   * this means to reduce the end margin of the text to be given to the LEFT inset of the inset_rounded_action_button
   * reduce end margin of the linearlayout to be given to the right inset of the drawable.

bug:379794419
Test manually photos:
beforeRTL:https://drive.google.com/file/d/1-DzcjOTywgk6SFjfCX7AVnmfqsIfa1lh/view?usp=sharing
afterRTL:https://drive.google.com/file/d/1UERlZ7XdoF0NhFuQE-oMulqgW9sDq9cy/view?usp=sharing
before:https://drive.google.com/file/d/1h5_Ljsx1rLyKum1PK7IRwD14ps2SPKC3/view?usp=sharing
after:https://drive.google.com/file/d/1b_8rgrC8WlDIdQuO7gOXS0MDNCISfxWr/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I017d4d34ef6e42fa49543c5f787063b061c382dc
2024-11-27 14:02:31 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Brandon Dayauon df5e51ce34 Fix work tab accessbility issues.
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.

bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp

Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
2024-11-18 15:16:41 -08:00
Matthew Mourgos ba81c0f345 Merge "Add focus ring to widgets header" into main 2024-11-08 21:44:05 +00:00
Matthew Mourgos 7820eab80c Add focus ring to widgets header
Change the widgets header drawable to be a selector with the
state_focused property in addition to the state_expanded property. The
focused items are drawn with a focus ring with no ripple, while the
unfocused items have a ripple.

Bug: 365120324
Test: focus traversal through left widget picker pane
Flag: EXEMPT bug fix
Change-Id: I710cb9e2d727a061e0c19df15526e8c832f6366b
2024-11-07 12:56:16 -08:00
Shamali P 1c173e96be Define the list entry and view holder for the view all button
Child cl updates the adapter & picker to use this list entry type.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: I69e82fb7df24270dac4cc0afd003e98247280552
2024-11-07 14:01:29 +00:00
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Brandon Dayauon a7123472ce Remove layoutTransitions for current FAB and use custom animation.
Have background contain left and right padding of 16dp.
That way upon collapse, its easier to animate so that every other view's space but the icon is removed.
Spec when expanded/collapsed: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2839-365095&node-type=text&m=dev

bug: 361589193
Test: manually - video:https://drive.google.com/file/d/1K7HCpayZBa_oo9p3XV10QQX4miTy_d3q/view?usp=sharing
withRTL: https://drive.google.com/file/d/1NfUEyEvzjfQamujv4EqLNBqB47mPNG1Y/view?usp=sharing
Flag: NONE just changing expandedFAB to use custom animations from layoutTransition

Change-Id: I7948633850a1010175eb4f0248daff22cf2f2c87
2024-10-29 09:50:13 -07:00
Brandon Dayauon 7e1149471a Update letter list textview background color to spec.
Spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2746-180205&node-type=frame&m=dev

bug: 358673724
Test: manually - photo: https://drive.google.com/file/d/1RWlaSRHbXCYhsY1F3nzruldQnABszUiz/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: I03cd4fbf1e76a7ad34983ace18a69a52116e7834
2024-10-15 15:01:25 -07:00
Brandon Dayauon 7e1ca3965b Merge changes from topic "fastScrollerPrivateSpaceDrawableToLetters" into main
* changes:
  Add spannedDrawable for the divider in the letter fastScroller.
  Only have private space drawable section for beginning of private space section and keep letters for everything else.
2024-10-11 22:33:53 +00:00
Brandon Dayauon c9ac51c521 Add spannedDrawable for the divider in the letter fastScroller.
Divider exported from: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2751-194737&node-type=frame&m=dev

bug:358673724
Test photo: https://drive.google.com/file/d/1I_Mu7mjxboP3puAJuiA9X9V3ogFR0oin/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ica5f05befbd63dc93b9c50bbbd6821cd931d148b
2024-10-10 16:31:41 -07:00
Brandon Dayauon 9d60a18c5c Only have private space drawable section for beginning of private space section and keep letters for everything else.
spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2746-180205&node-type=frame&m=dev
As of recent request: Only using the bubble background for everything and have private space go back to using letters.

Will include divider in followup.

bug:358673724
Test photo: https://drive.google.com/file/d/1dC3fgfWiumhyLm4vI-VfnXIYQyjPyrnk/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: I30487581eec4bd3e1921de4e3d899cfe2e2a703f
2024-10-10 16:31:39 -07:00
Liam, Lee Pong Lam d4488bfd72 Implement focus state on personal/work tab button
figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0
result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5
hsv: https://hsv.googleplex.com/4794951907934208

Bug: 327430110
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369
2024-09-25 20:34:49 +00:00
Saumya Prakash 4cf02b8538 Merge "Add "New Window" option to Taskbar menu." into main 2024-09-20 18:20:36 +00:00
Saumya Prakash 8e0ed4b01b Add "New Window" option to Taskbar menu.
This change adds a new menu option to Taskbar that is invoked when long
pressing an icon. It createds a new instance for an app if the app
supports multi instance in Desktop Mode.

Bug: 315344726
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ibc42fbb1ad485496cd938af730b86e051cea559a
2024-09-19 21:30:43 +00:00
Sunny Goyal 4f9ba255a4 Cleaning up some enabled features
Bug: 270394468
Bug: 270393900
Bug: 270390907
Bug: 270390930
Bug: 270390937
Bug: 270391693
Bug: 270391638
Bug: 270395177
Bug: 270395269
Flag: EXEMPT legacy flags cleanup
        ENABLE_SHOW_KEYBOARD_OPTION_IN_ALL_APPS
        ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
        ENABLE_DEVICE_SEARCH
        ENABLE_HIDE_HEADER
        ENABLE_TWOLINE_ALLAPPS
        IME_STICKY_SNACKBAR_EDU
        FOLDER_NAME_MAJORITY_RANKING
        SCROLL_TOP_TO_RESET
        ENABLE_SEARCH_UNINSTALLED_APPS
        ENABLE_HOME_TRANSITION_LISTENER

Test: Presubmit
Change-Id: Ia392c10fc65616405cc4d4a2b8ed566e3bb7d386
2024-09-13 14:24:27 -07:00
Marcelo Arteiro 13d9588f88 Merge "Updates many launcher color to new dynamic tokens" into main 2024-09-04 11:27:16 +00:00
Shamali Patwa 94c4dbfbbb Merge "Reuse widget picker's surface color in add item dialog." into main 2024-08-27 13:55:03 +00:00
Shamali P 0cac409a60 Reuse widget picker's surface color in add item dialog.
In ag/28129361 add item dialog's color was changed to reference
material color token defined in launcher theme. But add item activity
inherits from Theme.Translucent.NoTitleBar for its appearance (while
launcher theme uses deviceDefault.Light), so, cannot inherit as is from
the launcher theme. Since, there is already a token specific for widget
picker surface color imported via widgetTheme, using it so it stays
in sync with main picker.

Bug: 354604590
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I61ed5e65b0efd065490a54251028cde5888e4391
2024-08-26 23:16:25 +00:00
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Shamali P 8c965c67dc Adjust tap target of the profile tabs in picker
Uses insets on background drawable to maintain visual size.

Bug: 360245807
Test: Accessibility scanner
Flag: EXEMPT bugfix
Change-Id: I1fbc7c2c782a1e331dd1ba77b0a3bf8aad277792
2024-08-20 00:42:32 +00:00
Vinay Joglekar fee62395a2 Merge "Update desktop icon/app Chip with the new icon" into main 2024-08-12 09:03:14 +00:00
vinayjoglekar 7a73c2db59 Update desktop icon/app Chip with the new icon
Add desktop icon/app Chip text

Test: OverviewDesktopTaskImageTest
BUG: 320310236
Flag: EXEMPT resource only update
Change-Id: I6a41cff78690777745b8dcbfea1b8fadee200f96
2024-08-09 11:22:54 +00:00
Mady Mellor 1cc100844c Add a bubble option to launcher long press menus
- Add a launcher "system shortcut" to bubble deep shortcuts or apps
- For shortcuts, save the shortcut info to use to produce the bubble
- Add an interface so that the system shortcut can call through to
  sysui proxy

Flag: com.android.wm.shell.enable_bubble_anything
Test: manual - enable the flag and try to bubble a shortcut via the
               longpress menu on launcher
             - try bubbling an app on launcher
             - try bubbling an app from the taskbar
Bug: 342245211
Change-Id: I1ef49e1628ba0be9cea05073ecd9cd66bf67f88f
2024-08-08 21:23:13 +00:00
Charlie Anderson e5ace06d81 Merge "Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-08-05 04:24:32 +00:00
Brandon Dayauon 785f8c1f03 Merge "Fix app install icon colors by "reverting" small color change that applies to the private install icon." into main 2024-08-03 04:17:02 +00:00
Brandon Dayauon 766411813d Fix app install icon colors by "reverting" small color change that applies to the private install icon.
Original big color change for reference: ag/28129361

bug:355065774
Test manually:
after LT: https://drive.google.com/file/d/1Wi09fvakgGev_kbRso4LggXRb4GLYCsL/view?usp=sharing
after DT: https://drive.google.com/file/d/1g5NOeV50ekEJl0-7hiSWYLPKsCCGbndP/view?usp=sharing
Flag: NONE color fix

Change-Id: Ie078eefe2b4b2ecf6aa1a086242ba643f42c038b
2024-08-02 11:32:14 -07:00
Charlie Anderson fe23e711fd Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 00fb1adab4.
Also fixes test applyIconAndLabel_setsImageSpan_whenInactiveArchivedApp.

Bug: 350758155
Fixes: 356166053
Test: unit test
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I93f2ac47dc3a8fa81d59e0f089385d2b3fe93306
2024-08-02 17:26:02 +00:00
Charlie Anderson 00fb1adab4 Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 114e84908f.

Reason for revert: b/356166053

Change-Id: I30dfbc5da1caecd89b4b23aafe4de8e9efede6a0
2024-07-31 14:08:16 +00:00
Charlie Anderson 114e84908f Handles Bold Text setting for inline icon by providing bolded cloud icon
Bug: 350758155
Test: locally tested + unit tests
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I6e1fccbb7c8cb87a7e2675a60b05bf0cb402acf2
2024-07-26 11:17:39 -04:00
Brandon Dayauon 085ee66233 Remove padding on background and icon.
This padding causes the x to look pointy.

bug:342246204
Test:
before padding:https://screenshot.googleplex.com/GU8ZKEcGPH7DaAD
after padding: https://screenshot.googleplex.com/aRGtiKMQ8jyMWsw
Flag: NONE Padding change

Change-Id: I910914b742bfbb5bf0122ebb1b950ce95c43e9ed
2024-07-22 11:26:11 -07:00
Marcelo Arteiro 0d6190eb52 Updates many launcher color to new dynamic tokens
Bug: 335442983
Test: Manual
Flag: EXEMPT bugfix
Change-Id: Ic453ae6a717bb274682242f7af5b0551313672a4
2024-07-19 21:31:31 +00:00
Marcelo Arteiro f38d98d1a6 Align color resources in launcher projects.
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.

Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
2024-07-19 14:22:21 +00:00
Shamali P 2e2d4ff603 Add a 3 dot vertical menu and styles (child cl makes it functional)
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I99985098034f6336f683b1ff3a47dce2aa8e596a
2024-07-17 22:56:41 +00:00
Charlie Anderson d5acd6a016 Add new Cloud archived app icon and support for inline icons for BubbleTextView
- Can now set start drawable for BubbleTextView title with setTextWithStartIcon()
 - App Archiving cloud overlay icon will be disabled when flag on

Bug: 350758155
Test: locally tested B&R with pre-archiving
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I4d395a7ea7dc5ee11259f897d45b83eabdabb766
2024-07-16 19:39:03 -04:00
Brandon Dayauon 155f842636 Update workEDU background color to scHighest
bug: 342246204
Test: manually photos:
beforeDT: https://drive.google.com/file/d/14qJDNK2044KQXLLr3NgKMnxRcGysGcf3/view?usp=sharing
beforeLT: https://drive.google.com/file/d/1qwKBSUjGXtqY8PVep7ZT0FhABx2kFGFt/view?usp=sharing
afterLT: https://drive.google.com/file/d/1-rR-5x-vp0WUTlGV8rJMHiHnhQ07FfXC/view?usp=sharing
afterDT: https://drive.google.com/file/d/1szHqOSudhqEF4_AId9xD77YKTmGJt09n/view?usp=sharing
Flag: NONE Color change
Change-Id: I7d41581c613bd719515fcf491967327c989bf91b
2024-07-11 10:40:12 -07:00
Brandon Dayauon 6073fa296c Make close button to use google symbol library icon and update close color button
spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2df5f2c9773_4_0
CloseButtonColor to be scLOW
CloseIconColor to be onSurface

bug: 342246204
Test: manually photos:
beforeLT: https://drive.google.com/file/d/14O61WzHmeAhOdGirUci2u9vot3FWcSKo/view?usp=sharing
beforeDT: https://drive.google.com/file/d/1Dt75_sRIWNHMuwqnYzE1WvjRTZFHWJ8-/view?usp=sharing
afterLT: https://drive.google.com/file/d/1npg-icWcsEN5OCgMtP1oU7mB-gGuT6_n/view?usp=sharing
afterDT: https://drive.google.com/file/d/11LTC_61QTg4tX0SUO23cAbLaP7aoSnh-/view?usp=sharing
Flag: NONE Color change
Change-Id: I0c47c927c5c8094a018e6f18061e99fc4bd901de
2024-07-09 09:39:03 -07:00
Brandon Dayauon ae0e957eea Update private space divider thickness and padding per spec.
Thickness (height) is 2dp.
Padding above and below the divider is 32dp.

bug: 340307977
test manually:
before: https://drive.google.com/file/d/1H364XUILz3gTLOENQL5zQBOELcza7YBk/view?usp=sharing
after: https://drive.google.com/file/d/1HCsnj2s9TwlzIjKL1aHbBqO15nkPoOLj/view?usp=sharing
after vertical padding: https://drive.google.com/file/d/1HS1SFVj9RfvuxHPGyk0PH5dGQum3spqe/view?usp=sharing
Flag: None

Change-Id: I64e9a228e9095449c4ef5f7680d92d234ab96f9f
2024-05-20 16:24:14 -07:00
Brandon Dayauon 726f3b4480 Update install app icon colors to spec:
The + in the icon is onSurface.
Everything else within the circle is material_color_surface_container_lowest.

spec: https://docs.google.com/presentation/d/1_f2nAcmZMywF0D1-9fJv1slUQVerIpJ0b1uUmZDpKXo/edit?resourcekey=0-nxjnkIp8z-ECp8angeQJZg#slide=id.g239ecda44ed_0_18

bug: 340307977
Test:
before: https://screenshot.googleplex.com/Bss6VHDt7JfjsEU
after: https://screenshot.googleplex.com/5qxqQ6segow2Nxh
Flag: None
Change-Id: I300e8513d15e428338cb1e20f65fbe3a0b62bc35
2024-05-20 15:46:43 -07:00
Brandon Dayauon 1d3ddb877d Add floatingMaskView when animating to mimic bottom container.
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation

bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING

Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
2024-05-13 11:08:05 -07:00
Willie Koomson 1156e8419a Hide add button text if cell is too narrow
If the WidgetCell is not wide enough, hide the add button text and show
an icon-only plus button.

Bug: 333735974
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ieb0b2e679bd4a5785a0f7f01e177ad412a355ce7
2024-05-02 19:55:41 +00:00
Brandon Dayauon 782af232e3 Merge "Update badge color to textColorPrimaryInverse" into main 2024-04-23 20:42:56 +00:00
Brandon Dayauon 4f781aeac0 Update badge color to textColorPrimaryInverse
Just got updated textColorPrimaryInverse color to use on badge to support the themedness. This color
is consistent with the popup icon colors that is already being used.

bug:324574278
Test after:
dark theme: https://drive.google.com/file/d/1Q9BKlbw0bi5yz-wzPa160JMBEqK7QKcJ/view?usp=sharing
light theme: https://drive.google.com/file/d/1QH_FSOo8H63K_8WKfiDuV1ypGqctYMqt/view?usp=sharing
Flag: None

Change-Id: If59e20356d80b234ad405cfe6995d474dbfe5c57
2024-04-23 11:13:22 -07:00
Shamali Patwa a80e199798 Merge "Keep rounded corners while scrolling in right pane & fix scrollbar size." into main 2024-04-19 22:43:39 +00:00
Brandon Dayauon 24db282ed4 Merge changes Ied2efcf6,I07579635 into main
* changes:
  Polish workFAB with updated spec.
  Fix workFAB alignment.
2024-04-19 00:59:19 +00:00
Shamali P 5f7eb1f2ee Keep rounded corners while scrolling in right pane & fix scrollbar size.
[demo](http://screencast/api/gif/NDU4MTQ5ODE3Mzc4NDA2NHxhYmUzMDcxNy04MA/image)

Bug: 333734241
Test: screencast
Flag: N/A
Change-Id: Ifb522ca2c0a1092bf41c630e336b19c81d504c26
2024-04-18 22:32:30 +00:00