Commit Graph

6597 Commits

Author SHA1 Message Date
Treehugger Robot d255cbdfd7 Merge "Initial implementation of the AddDesktopButton" into main 2025-01-15 15:40:07 -08:00
minch fb2e514de8 Initial implementation of the AddDesktopButton
Add the AddDesktopButton to the view hierarchy behind the flags.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug: 382057498
Test: Manual
Change-Id: I5748d8c18d8f5204fa1fb0717c4a8098bfde1537
2025-01-15 18:42:18 +00:00
Bill Yi 6f539e4019 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-01-14 16:28:14 -08:00
Alex Chau e3b4b66d79 Merge "Support both grid and large tile with gridOnlyOverivew" into main 2025-01-14 12:24:19 -08:00
Bill Yi 522a8d230e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5ca8d3c28881c372c6d7928f7c46948ad1ca199b
2025-01-13 19:08:16 -08:00
Alex Chau 9c85596111 Support both grid and large tile with gridOnlyOverivew
- With the introduction of Desktop windowing, we'll need to supprot grid task and large tile (desktop tile) coexisting
- The previous gridOnlyOverview aimed to have taskSize matches actual grid task size, and introduced another carouselTaskSize for scaling in swipe up carousel
- Now I'm reverting to pre-gridOnlyOverview implementation of having taskSize as both large tile size and carousel task size, and gridTaskSize as only task size in grid

TaskViewSimualtor
- Removed no longer needed carousel translation and related calculations
- mIsGridTask is now determined with DeviceProfile, so when swipeing to Desktop task it won't use grid task size

TaskView
- Removed no longer used nonGridPivotTranslationX

RecentsView
- Make getSelectedTaskBounds / getTaskBounds picks the correct taskSize

Fix: 359573248
Fix: 321697299
Fix: 325606690
Bug: 322816508
Test: Swipe up, quick switch, task launching with grid task and desktop tasks; repeat with RTL, three button, phone
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I14648c6682c53a4d06f9c9585d53f28dddef4f8f
2025-01-13 13:31:29 +00:00
Sunny Goyal 1138f5fe59 Simplifying IconShape
Removing various custom shapes and replacing it with a generic shape implementation. This works with any valid svg path.

Bug: 366237794
Flag: EXEMPT refactor
Test: atest IconShapeTest
Change-Id: I4665bc657b8bffc4d4efa30cebe00341b3140c55
2025-01-09 15:04:46 -08:00
Holly Jiuyu Sun 9d0cbfd689 Merge "Remove remaining "Item added to home screen" annoucement from talkback." into main 2025-01-08 10:15:49 -08:00
Sebastian Franco f59d3de3c6 Using pixels instead of DPI for selecting the grid size
Fix: 383132640
Bug: 386479043
Test: Screenshot test
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ic3eda69324e03cc6f049cd7d21dac7ab6a22271e
2025-01-07 10:32:07 -08:00
Sihua Ma 67db76e847 Merge "Change home screen state description to manifest page change" into main 2025-01-06 10:37:20 -08:00
Sihua Ma 2bad402275 Change home screen state description to manifest page change
Bug: 383247157
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I1c2d3aa90d2b4ee9a1beaa4fbe7db57e79ae49dc
2025-01-03 00:00:48 +00:00
Bill Yi bc10021468 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id232e97de49ea623ca1257573d66875f8a71e467
2025-01-02 15:56:34 -08:00
Stefan Andonian 25283f0f45 Fix for bug where Talkback announce Folder:null
Bug: 385046797
Test: Verified this works locally.
Flag: EXEMPT bug fix
Change-Id: I9ad23f351df078b6bd40ff861e13b9109bfa8993
2024-12-30 14:01:28 -08:00
Holly Sun ae654ddaff Remove remaining "Item added to home screen" annoucement from talkback.
Based on https://b.corp.google.com/issues/383457529#comment5, we should remove all app annouced confirmation.

Bug: 386247991
Test: build
Flag: EXEMPT a11y bug fix
Change-Id: I0ba2e282a42c0785c8bdad1be23adf2bf90a44b3
2024-12-26 15:02:39 -08:00
Treehugger Robot eda3c8ec60 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-26 11:58:20 -08:00
Brandon Dayauon 4973c18fe4 Make work edu close button not say "Close, Image" in a11y.
Moved content description to the bigger container since that's what takes the touch input anyways.
Now says "Close, double click to activate"

bug: 383945600
Test: manually
Flag: EXEMPT bug fix
Change-Id: Ic35602022f057db59f683c5bd07a3d16fa4983f2
2024-12-23 14:02:14 -08:00
Bill Yi 92c8fd4f33 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I213c57c4a8b3f1009ca14c35cb15b161b2d172e0
2024-12-20 20:16:53 -08:00
Bill Yi e6382d45f0 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-19 11:40:38 -08:00
Anushree Ganjam 59137e44e2 Merge "Update the All apps label to "Apps list"" into main 2024-12-18 14:07:36 -08:00
Anushree Ganjam 8dae1be563 Update the All apps label to "Apps list"
Set the AccessibilityNodeInfo containerTitle to improve a11y for users
in predictionRow.

See expected behavior suggestion in  https://b.corp.google.com/issues/379640673#comment1

Video
Quickstep launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/eugH3ID7eenOuLwTszaLHk

Pixel launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/fftzwMRCy6N3o7OcwiGMdk

Bug: 379640673
Test: Manual
Flag: EXEMPT a11y bugfix
Change-Id: I23a8a142afb213c0801402a56bc134bc14f0f97d
2024-12-17 16:39:45 -08:00
Bill Yi 62ca42caa6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1281d2102a0680883a4d15b04163e3e246315ce4
2024-12-16 17:45:40 -08:00
Wen-Chien Wang 2badfc7ebc pin-shortcut: Add pin shortcut to the context menu
This cl adds the pin shortcut option to the context menu, where
it works on Home launcher, hotseat, and pinned apps on the
taskbar.
Currently the option is a no-op.

Bug: 375648361
Test: Manual. Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I5d1284a6e909fd75f14e81c3ae713da3cdc01ce3
2024-12-13 22:49:52 +00:00
Sunny Goyal daf46a09b2 Merge "Moving WMProxy to dagger" into main 2024-12-12 15:27:19 -08:00
Sunny Goyal 41e8057bbf Moving WMProxy to dagger
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I9a8031037f2167658b7bc212b59c9b11abbf2f03
2024-12-11 13:24:26 -08:00
Bill Yi 899c7dccd7 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I210bc6d13a279fcf4601a790cbc89f0ebea9ad8a
2024-12-10 15:02:23 -08:00
Shamali Patwa 5fb8180b00 Merge "Remove the elevation on the DragView to avoid shadows underneath" into main 2024-12-06 23:40:38 +00:00
Shamali P cc21323af2 Remove the elevation on the DragView to avoid shadows underneath
In b/297952359 we are seeing that widgets with clipped outline
 elements end up showing shadows below their drag view. Which
 due to not maintaining clipping looks further bad.

It seems like, we don't really need the elevation for drag
view anymore - and presumably it was added for older android
 versions for shadow for folders. But, they don't have them
  anymore, so, removing elevation now.

 Note: The issue that during drag and drop, the dragged preview
 not showing clip to outline or shadows within widget's views is
 a separate issue related to the Picture API usage during drag
  and drop.

Bug: 297952359
Test: Screen record in comments
Flag: EXEMPT Bugfix

Change-Id: If31a0275938afe374d269a46cc950970033323f9
2024-12-06 21:10:51 +00:00
Bill Yi 3f04014298 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-06 21:09:52 +00:00
Bill Yi 1d6340ae0b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I21f7c3e58c26ce8f280cc67f55f73d6cc5695a61
2024-12-05 22:42:07 -08:00
Shamali P 67df1f0d2c Use outline color token for bottom sheet.
- Per android design folks, "outline" is the right token to use
- They've also verified with material design folks that its the
 recommended value.

Bug: 378424549
Test: WIM contrast checker
Flag: EXEMPT BUGFIX
Change-Id: I3b45860da9405469600771d6ff5d1adea1e4ea4c
2024-12-05 14:54:09 +00:00
Shamali P 0e668e1b1d Update accessibility hint for widget cell that shows add button.
With tap to add feature, tapping widget cell reveals add button.

So, clarify the intent with ACTION_CLICK

Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
Treehugger Robot 9fdf9efdd2 Merge "multiple-desktops: Add new desktop button xml file" into main 2024-12-04 14:02:41 +00:00
minch 7fbc82cab1 multiple-desktops: Add new desktop button xml file
- Add the skeleton xml file for the new desktop button
- Add the icon for this button as well
- Create the kotlin file for this button

Flag: EXEMPT as added files haven't connected with the production logic
Fix: 379941322
Test: None
Change-Id: I5c7ea2c061f0f9539483221f40c892626103d11e
2024-12-04 10:26:42 +00:00
fbaron d1cd8c2ea6 Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: If1dafedc710ebc483fc7b6b5cd6cae6f70dc3cfc
2024-12-03 02:43:13 +00:00
Brandon Dayauon 345901fdb0 Merge "Fix close button in workEDU card not 48dp." into main 2024-12-02 20:39:20 +00:00
Treehugger Robot fedf7fa5e2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-30 21:27:38 +00:00
Bill Yi 5e7bda3b84 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1688b8e845f0eb1185950e16c6ab11d686edc873
2024-11-27 17:35:47 -08:00
Brandon Dayauon 9f1b9d1b13 Fix close button in workEDU card not 48dp.
Can use insets to make it appear the same small visual but have a 48dp tap target. Since delegating the touch to the 48dp,
we can make the imageButton clickable to false as it's instead being used by the 48dp frame.

- since there's no rtl catering for insets insets must have equal left and right values.
   * this means to reduce the end margin of the text to be given to the LEFT inset of the inset_rounded_action_button
   * reduce end margin of the linearlayout to be given to the right inset of the drawable.

bug:379794419
Test manually photos:
beforeRTL:https://drive.google.com/file/d/1-DzcjOTywgk6SFjfCX7AVnmfqsIfa1lh/view?usp=sharing
afterRTL:https://drive.google.com/file/d/1UERlZ7XdoF0NhFuQE-oMulqgW9sDq9cy/view?usp=sharing
before:https://drive.google.com/file/d/1h5_Ljsx1rLyKum1PK7IRwD14ps2SPKC3/view?usp=sharing
after:https://drive.google.com/file/d/1b_8rgrC8WlDIdQuO7gOXS0MDNCISfxWr/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I017d4d34ef6e42fa49543c5f787063b061c382dc
2024-11-27 14:02:31 -08:00
Treehugger Robot c4a90de0e9 Merge "Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints" into main 2024-11-27 21:17:43 +00:00
Marcelo Arteiro 8b63ee3420 Merge "Migrate materialColor* attributes into colors" into main 2024-11-27 14:55:47 +00:00
fbaron 493583435b Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I391e001ddee454baccbc0a8f1e002cc815722239
2024-11-26 00:38:19 +00:00
Bill Yi 040aad2cb2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-25 18:54:47 +00:00
Ana Salazar Maldonado f9884f20f3 Avoid drawing the launcher pill outside the view bounds
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds.  Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
Bill Yi 0018279493 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4a880f6ed65b4053f7b58562757b9c3a70ed2d5e
2024-11-21 21:18:29 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Pinyao Ting d406bd8f2a Update the a11y announcement for the deep shortcut menu to "Shortcut Menu"
Bug: 378062790
Change-Id: Iebbf922d95be5a9f726d993ac9fb7a41fb2bcbc3
Test: manual
Flag: EXEMPT bugfix
2024-11-20 19:15:38 +00:00
Treehugger Robot 33a9c4936b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-19 21:49:29 +00:00
Brandon Dayauon 74842f0c16 Merge "Fix work tab accessbility issues." into main 2024-11-19 18:44:14 +00:00
Sebastián Franco 3448777679 Merge "Changing name of RowCount to GridDimension to be more general" into main 2024-11-19 05:36:43 +00:00
Bill Yi 54d198b191 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5fbd48cc57813d4982e2f1c72f879bd442608b94
2024-11-18 20:01:02 -08:00