The flake was caused by the fact that addOnDrawListener(), the redraw is not guaranteed. This ultimately results to the workspace loading never finishing.
Forcing the redraw.
Bug: 267200150
Test: atest Launcher3Tests:com.android.launcher3.celllayout.ReorderWidgets#simpleReorder --rerun-until-failure
Flag: N/A
Change-Id: I47683425150a07ab2632e2bebdeca4d304e30d1b
The update will always be considered as failed because we always return 0 for all the commits.
Test: N/A
Bug: 234700507
Change-Id: I33ee8af996cef62dbc14349f9a7dd3cb72836ab6
It looks like if shouldClearVisibleEntries() evaluates to true and we clear mVisibleEntries, we get an Inconsistency IndexOutOfBounds error, the same as the one reported in the crash.
Bug: 276766307
Test: Verify that with these changes the widgets still update correctly when changing languages
Change-Id: I9f92e61d967aab2c8297cfc2fb4b04193df67650
- LauncherWidgetHolder.startListening is called before Launcher.setupView, so it's possible for getWorkspace() to be called as part of the appWidgetRemovedCallback. Reordered these calls to fix this null pointer
Flag: not needed
Fixes: 283850341
Test: Screenshot tests
Change-Id: Ied1f23647721fc4199eab2a5a79def1e306b00f3
In the other method createAreaForResize we add 1 to the cellX
to account for the seam in the Multipace CellLayout but we don't
account for that on performReorder and we need to add a cellWidth
Also, some methods are not running when the seam is added so their
result are wrong. Now all methods are being accounted for.
Fix: 277709417
Test: atest ReorderAlgorithm
Test: atest MulticellReorderAlgorithm
Change-Id: I7a4ca55f7b9cd7cf94481c880fe152e0a3bb3cf3
This shouldn't change anything in the grids, only calculate the sizes of the grid.
Bug: 277064708
Test: CalculatedWorkspaceSpecTest
Test: WorkspaceSpecsTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: Id1f90ef44f5b869113d063bad17589e7e88d1d20
This reverts commit 45ef9b6c01.
Reason for revert: As promised, sysUi changes introduced in Launcher for AppCloning are being reverted. (This is the only CL that was merged)
Change-Id: I9fc72c333d48ca51558578d0d79038b49b3ebb5b
Test: Manual by building sysUi
* changes:
[Folder] Fix bug where folder name and page indicator is visible when cancelling folder open animation
Fix bug where quickly ending folder animation with back swipe caused icons not clipped to folder
We should resgiter all AnimatorListeners before starting folder open animation.
Fix: 282158620
Test: https://b.corp.google.com/issues/282822254#comment2
Change-Id: I1136ede464f37c174296921594ef887d90844eb5
1. Fix a race condition that the new animation is reading stale UI state which should have been reset in previous animation.
2. Don't set clipChildren=true on folder page view during open folder animation
Fix: 282158620
Test: open folder and quickly back swipe, verify app icons are still clipped
Change-Id: I5f0877fe4157533563df922ba50a6ad540c9ba6e
Sunny Goyal
Vadim Tryshev
Schneider Victor-tulias
Jagrut Desai
Nick Chameyev
TreeHugger Robot
Anushree Ganjam
Treehugger Robot
Sihua Ma
Fengjiang Li
fbaron
Vinit Nayak
Alex Chau
Brandon Dayauon
Stefan Andonian
Sebastian Franco
Thales Lima
Himanshu Gupta
Charlie Anderson
Hyunyoung Song