Commit Graph

12553 Commits

Author SHA1 Message Date
Vinit Nayak 8e307ba50a Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev 2023-04-03 14:58:29 +00:00
Mike Schneider 65b1561a68 Change the use of ScreenLifecycle to WakefulnessLifecycle.
This is a better fit for the signal in launcher, since it identifies
whether the device is awake or asleep, where asleep also inclues AoD

Test: manual, unit tests
Bug: 275319714

Change-Id: I6d6a6694ab018d182606c5554377caec1986bc08
2023-04-03 16:47:12 +02:00
Pat Manning 9330d4991e Stash taskbar on swipe to go home for 3p fallback launcher.
Follow up to b/21916480, which was reverted due to test failures which are now fixed.

Fix: 269070986
Test: manual. Install launcher3WithoutQuickstepDebug and swipe to home from within an app.
Change-Id: I52fad88a25325e5c38a600ccf90b30ebf60bf71a
2023-04-03 10:09:11 +00:00
Sunny Goyal ef6b0c0700 Adding a Teamfood flag option
This allows a targetting a collection of flags to a specific group
either using rollout or via opt-in

Flag: N/A
Bug: 274517185
Test: Verified that the team food flag controls dependent-flags
Change-Id: I7e02964d778e3fbf54eda0f34bab8ec5a1206e40
2023-04-02 18:20:30 +00:00
Winson Chung 36ceb49b23 Merge "Fix gesture insets issue for IMEs" into tm-qpr-dev am: 13bf1598b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22382921

Change-Id: I96e3e19cef288f3c62bcd72121673de75b740ccc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-02 04:09:40 +00:00
Winson Chung 13bf1598b9 Merge "Fix gesture insets issue for IMEs" into tm-qpr-dev 2023-04-02 03:26:14 +00:00
Ikram Gabiyev 094c50ea32 Merge "Create an animation for instance filtering" into udc-dev 2023-04-01 21:42:20 +00:00
Winson Chung 8436e0b382 Fix gesture insets issue for IMEs
- Setting the override frame for the gesture insets sources prevents
  the insets from being calculated correctly for the IME window
- Update the set of provided insets based on the current nav mode
  so that we don't report gesture insets in button nav

Bug: 265614886
Test: Dump IME window insets for button/gesture nav
Change-Id: I22f9d09a66b50d6e2fb5002af19058657a06404d
Merged-In: I22f9d09a66b50d6e2fb5002af19058657a06404d
2023-04-01 06:37:47 +00:00
Winson Chung 71b16784c0 Merge "Fix gesture insets issue for IMEs" into udc-dev 2023-04-01 06:37:31 +00:00
Jeremy Sim 9f0a6b8e82 App Pairs (behind flag): Add Overview menu item, icon, tests
This is the first of several patches implementing the App Pairs feature behind a flag.

This patch includes:
- The icon asset for the "Save app pair" menu option
- The menu option, which will appear in the Overview drop-down menu for split pairs
- Some tests ensuring that the menu item appears when appropriate

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: 2 tests in TaplTestsSplitscreen.java
Change-Id: I174f2c66e7eb6d83ff7fe501eb82cc48e727022c
2023-03-31 17:16:56 -07:00
Sihua Ma 5ade3e1fef Attempt to fix concurrent modification issue in QuickstepWidgetHolder
Test: N/A
Bug: 275100497
Change-Id: I5db18ff38aa280c2a9957c457ac9565570933513
2023-03-31 17:06:43 -07:00
Fengjiang Li dcefed1c98 [Predictive Back] Gate feature under experiment flag
As predictive back will be launched for U-QPR, we should gate it to avoid it leaked to U launch.

Test: turn on/off ENABLE_BACK_SWIPE_LAUNCHER_ANIMATION flag and verify predicitive back is turned on/off
Bug: 264920023
Change-Id: Ieee14ca9d49f052f183d8734d62443b890210544
2023-03-31 14:14:03 -07:00
Evan Rosky b8f82c1a9d Merge "Improve transition logging" into udc-dev 2023-03-31 20:43:15 +00:00
Ikram Gabiyev 3334730a61 Create an animation for instance filtering
Create an animation for multi instance filtering
demo in recents view.

Bug: 253520408
Bug: 276488398
Test: manually reproduce the steps in the bug

Change-Id: I9f5b4a29f18101b8e33d4e43514dcd8a6c49a7a9
2023-03-31 20:30:19 +00:00
TreeHugger Robot 331ab34a2a Merge "Revert "Revert "Simplifying some page indicator dots attributes so that it can""" into udc-dev 2023-03-31 20:10:37 +00:00
Winson Chung 711189df8c Fix gesture insets issue for IMEs
- Setting the override frame for the gesture insets sources prevents
  the insets from being calculated correctly for the IME window
- Update the set of provided insets based on the current nav mode
  so that we don't report gesture insets in button nav

Bug: 265614886
Test: Dump IME window insets for button/gesture nav
Change-Id: I22f9d09a66b50d6e2fb5002af19058657a06404d
2023-03-31 19:41:51 +00:00
Brian Isganitis 7d8b81df09 Merge "Clean up device profile change listeners for AllApps." into tm-qpr-dev am: 4500171c6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22338655

Change-Id: I54c6fb31077ed06f6e0122dca3e47e3a7e6f8f34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 17:33:17 +00:00
Sunny Goyal 7025765c72 Revert "Revert "Simplifying some page indicator dots attributes so that it can""
This reverts commit 0263a679f2.

Reason for revert: Trying again to confirm if this was the actual cause of regression

Change-Id: I2a663015d7ecdcf315634d8a976bf8294b58981d
2023-03-31 17:10:15 +00:00
Brian Isganitis 4500171c6b Merge "Clean up device profile change listeners for AllApps." into tm-qpr-dev 2023-03-31 16:42:07 +00:00
Brian Isganitis cdfdd444bc Merge "Clean up device profile change listeners for AllApps." into udc-dev 2023-03-31 16:41:54 +00:00
TreeHugger Robot bc55b29cfe Merge "Fix task bar unstashing and stashing when triggering back gesture using the trackpad" into udc-dev 2023-03-31 15:27:08 +00:00
Winson Chung b793def6ab Merge "Adding check for recents interface before calling back" into udc-dev 2023-03-31 06:21:50 +00:00
Winson Chung 78486a253d Adding check for recents interface before calling back
- If SysUI crashes, there's a brief period where the interfaces
  are reset before SysUI rebinds to Launcher

Fixes: 276354061
Test: Presubmit
Change-Id: Id1a1a1f41b48b9a7d86c1637cc06b662b5d17914
2023-03-31 06:21:41 +00:00
Riddle Hsu 77a6164f7a Merge "Reduce no-op IPC when swiping up" into udc-dev 2023-03-31 05:11:54 +00:00
Tracy Zhou f3e9f870bd Fix task bar unstashing and stashing when triggering back gesture using the trackpad
Need to defer starting recents animation. Instead of starting at touch down, will defer to passing initial slop. For the back gesture, launcher gesture nav will cancel the motion events from the input monitor passing the initial slop since it's not detected as a swipe up gesture.

Fixes: 276390218
Test: 3-finger horizontal swipe to go back, and make sure the task bar stay stashed through the transition
Change-Id: I03376c4d9696a9e5679b74e36ec142efa882981b
2023-03-30 21:04:13 -07:00
TreeHugger Robot 552fe5ec52 Merge "Don't stash immediately when drag was canceled" into tm-qpr-dev am: d9dd75d2cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22316250

Change-Id: I5f1189de25670ff70fe5bc4b39ed4cbc41a676cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 01:23:49 +00:00
Jerry Chang d571e89311 Merge "Fix wrong surface positioning when animating a split pair to home" into udc-dev 2023-03-31 01:12:57 +00:00
TreeHugger Robot d9dd75d2cc Merge "Don't stash immediately when drag was canceled" into tm-qpr-dev 2023-03-31 00:08:44 +00:00
Evan Rosky 8869bb5f40 Improve transition logging
Adding debug-names to remote transitions so that
they can be identified across processes

Bug: 276349701
Test: existing tests since this doesn't change logic
Change-Id: I41400feeb2dd91971f8c750613085c80af309aea
2023-03-30 15:28:43 -07:00
Vinit Nayak ecca8eacbc Default to using SplitSelectSource drawable if TaskView icon drawable is null
* Alternative solution could be to set
onTaskViewVisibilityChanged(true) for the taskView that is about
to be dismissed so it loads it's taskIcon/thumbnail back from the cache
* However, that does still leave us open to race conditions (even though
we can be reasonably confident the icon is probably in the cache)
* Also made other changes to allow already public fields on some classes
to be mockable for unit testing

Fixes: 275267738
Test: Tested with fullscreen task at end of overview,
GroupedTaskView at end of overview,
Initiating split from home,
Initiating split from overview actions,
Initiating split from overview app icon

Change-Id: Ic9059c93c07b90f61c9f418d5d36d6ba201ff96a
2023-03-30 15:26:57 -07:00
Sebastian Franco 7fcb30d2c7 Correctly disposing of LauncherUnlockAnimationController
In SystemUiProxy we don't need to check for null before calling
setLauncherUnlockAnimationController becase that function is already
checkingh fo nulls, so it was preventing the variable from getting
cleaned.

Fix: 275418590
Test: flake should dissapear or be reduced
Change-Id: I8cf5dad57678493167354e137a18e37b37f3e58b
2023-03-30 21:39:46 +00:00
Jagrut Desai 3aaae66d37 Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev am: d1d0fb8607 am: 99e6efe6f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22242613

Change-Id: I2cd41ac48e58ac04f4600f6d63b5915fc260c48f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 18:40:46 +00:00
Jon Miranda 258b331c49 Merge "Align taskbar so that it does not overlap with nav buttons." into tm-qpr-dev am: e008411f00 am: eb1bc63ffa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22315699

Change-Id: I41ea7b65f0ffaaa7c2fae79d349763b6841204f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 18:39:44 +00:00
Schneider Victor-tulias 6468ce77b8 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev am: 1db2fcbd19 am: cafab1d7cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119029

Change-Id: Id6121e8c572666f182e0b2d0ca250c636236f19f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:28:13 +00:00
Schneider Victor-tulias f8f602d76c Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4 am: d8e5795131
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: Ic5d6ce2a870f19c960baab3af8abfb1faee248f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:16:22 +00:00
Jagrut Desai 99e6efe6f3 Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev am: d1d0fb8607
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22242613

Change-Id: I34aa4182c74483c6dd94adb119bda9a30a8240aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:06:00 +00:00
Jon Miranda eb1bc63ffa Merge "Align taskbar so that it does not overlap with nav buttons." into tm-qpr-dev am: e008411f00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22315699

Change-Id: I72655d251013fddd9736963cc68e842c58941569
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:05:45 +00:00
Schneider Victor-tulias cafab1d7cc Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev am: 1db2fcbd19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119029

Change-Id: Ie1f24b78ea9f49a1089e15331cadc35af0073490
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:18 +00:00
Schneider Victor-tulias d8e5795131 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: I916c0e191cb2e335b9e393ea76c34cff39778481
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:04 +00:00
Riddle Hsu b1ca1b777f Reduce no-op IPC when swiping up
In SplitScreenController#onGoingToRecentsLegacy, it also ignores:
if (ENABLE_SHELL_TRANSITIONS) return null;

This avoids a latency from the 2-way IPC before calling
RecentsAnimationListener#onRecentsAnimationStart.

Bug: 275508603
Test: Swipe-up
Change-Id: If1aa847bd92b2a16812a5181b4476d9a35619a76
2023-03-30 15:49:40 +00:00
Arthur Hung b5c44b60c0 Merge "Handling statusbar color when back navigation (2/2)" into udc-dev 2023-03-30 11:23:03 +00:00
Jagrut Desai d1d0fb8607 Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev 2023-03-29 23:26:26 +00:00
Tony Wickham 52f046e027 Don't stash immediately when drag was canceled
Instead, keep the taskbar open for the normal timeout.

Test: Drag an app from taskbar and drop back in taskbar, ensure taskbar
stays open until 5 second timeout; Drag an app from taskbar and drop
into split screen, ensure taskbar stashes immediately
Flag: ENABLE_TRANSIENT_TASKBAR true
Fixes: 275019813

Change-Id: I06ca0eccbfe313dbae8f6d96c7c09bb659f6a27b
Merged-In: I06ca0eccbfe313dbae8f6d96c7c09bb659f6a27b
2023-03-29 23:10:11 +00:00
TreeHugger Robot 2514a15a85 Merge "Don't stash immediately when drag was canceled" into udc-dev 2023-03-29 23:04:38 +00:00
Sunny Goyal 1fc1cd002f Merge "Revert "Simplifying some page indicator dots attributes so that it can"" into udc-dev 2023-03-29 21:22:10 +00:00
Jon Miranda 156ff34f35 Align taskbar so that it does not overlap with nav buttons.
Fixes: 275510698
Bug: 259712417
Test: View device where taskbar should be start aligned
      Update Display size to make everything bigger
      Observe that taskbar icons never overlap nav buttons
Flag: ENABLE_TRANSIENT_TASKBAR true

Change-Id: I246374518f21c4b92d3e02e5582c929a471d9305
2023-03-29 21:04:03 +00:00
Sunny Goyal 0263a679f2 Revert "Simplifying some page indicator dots attributes so that it can"
This reverts commit a5ead45967.

Reason for revert: b/274169859

Change-Id: Id214694ae4f61cd70796c6f7e932c1fdef82d746
2023-03-29 19:11:03 +00:00
Schneider Victor-tulias 1db2fcbd19 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev 2023-03-29 18:54:22 +00:00
Brian Isganitis d43d7c3702 Clean up device profile change listeners for AllApps.
Test: https://b.corp.google.com/issues/260177372#comment1
Bug: 260177372
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d17261029af89ef03b860686d1d3c6651e7c8e13)
Merged-In: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
Change-Id: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
2023-03-29 18:46:47 +00:00
Brian Isganitis d17261029a Clean up device profile change listeners for AllApps.
Test: https://b.corp.google.com/issues/260177372#comment1
Bug: 260177372
Change-Id: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
2023-03-29 14:18:14 -04:00