Commit Graph

12553 Commits

Author SHA1 Message Date
Schneider Victor-tulias e861fa05bc Merge "Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0" into main 2023-11-28 16:23:47 +00:00
Schneider Victor-tulias ed2eba9beb Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0
We will need to send formatted strings to the ProtoLog api, so it is simpler to use CompoundString as the default string storage in ActiveGestureLog.

Refactored CompoundString to be able to be broken down into a formattable string.

Flag: N/A
Fixes: 313640579
Test: ran launcher, completed gestures, dumped gesture logs
Change-Id: I5f290d1860c6bac5047cbf361537829fbe986685
2023-11-28 16:23:38 +00:00
Helen Cheuk 4a6d4994c3 Merge "Remove excess entry before putting new item" into main 2023-11-28 13:03:53 +00:00
Sergey Pinkevich 6c7ddc9b90 Fix blinking for the active tile
Call of `buildAnimationController` within `View#onApplyWindowInsets` if endTarget is not null.

Bug: 312439564
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual - took a screen recording:
Before - https://drive.google.com/file/d/1P2GsTi0xCZFjAsTQKonMMADHGkKuxMe0/view?usp=sharing
After - https://drive.google.com/file/d/1xkbFa-2Xp1OwmPrKLcqE2cYshVRXY2YV/view?usp=sharing

Change-Id: I6eb2a48bb548e20c1d36a058921ff8e1a0983cad
2023-11-28 12:24:40 +00:00
Johannes Gallmann 1de8952a30 Fix task window losing scale when going back to home
Bug: 305934426
Flag: NONE
Test: Manual, i.e. testing back to home with different devices and device orientations
Change-Id: I3eddbc918de95be713aecb469501b01e6b7b3d3b
2023-11-28 11:33:29 +01:00
Federico Baron f378be865d Merge "Fix activity leak in QuickstepLauncher" into main 2023-11-28 00:02:30 +00:00
Sunny Goyal 0069e54f1e Removing unnecessary iconFactory class when generating badged icon
Bug: 276957152
Test: Verified on device
Flag: None
Change-Id: I31ca3ef939684b16c0134d19f0add574b4b59706
2023-11-27 15:44:31 -08:00
fbaron c04ad685f5 Fix activity leak in QuickstepLauncher
Fix: 312397873
Test: TaplAppIconMenuTest#testLaunchMenuItem
Flag: NONE
Change-Id: I63fe5fa5b3f2d301017dc6fb375e7a56e3e5fb4d
2023-11-27 18:10:45 +00:00
helencheuk f2fc14ec4c Remove excess entry before putting new item
It is to fix gpu memory usage increase. Remove excess entry first so its max memory usage should not increase

Fix: 309182285
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: N/A
Change-Id: I40b4ec50c09001e6ee9d012bdcdd1444230daac3
2023-11-27 14:57:38 +00:00
Helen Cheuk 946a2493eb Merge "Not show hover border on select mode" into main 2023-11-27 14:21:29 +00:00
Alex Chau c95a4e6b1d Merge "Revert "Remove logs for bug investigation"" into main 2023-11-24 14:02:39 +00:00
Pat Manning 78a2dd66b2 Merge "Close allapps on press of ESC key." into main 2023-11-24 12:30:04 +00:00
Pat Manning a7a04fe901 Close allapps on press of ESC key.
Fix: 310206847
Test: TaplOpenCloseAllApps
Flag: NONE
Change-Id: I9b9f958eb2889680b731dd7134fce2793e62eb74
2023-11-24 11:03:13 +00:00
Johannes Gallmann e36c615716 Fix crash in LauncherBackAnimationController
Bug: 312949302
Flag: NONE
Test: Manual, i.e. testing quick fling back to home gesture
Change-Id: I670b2f02cab097b1d7a202a5b07fbda33d372ac8
2023-11-24 10:11:46 +01:00
Sebastián Franco 525b0343f8 Merge "Moving classes inside of CellLayout to their own file" into main 2023-11-24 01:27:13 +00:00
Sebastian Franco 5f0af4f633 Moving classes inside of CellLayout to their own file
This is a no-op change ensure this we have ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I6ffe2a1260f869a4686a9f1e652dd1ab6d406269
2023-11-23 23:13:56 +00:00
Schneider Victor-tulias 2b988e5fd2 Fix NPE in TaskAnimationManager
Flag: N/A
Fixes: 312949734
Test: ran launcher and launched overview from home and app
Change-Id: I7894749ac196dfd07b5e2bfa5d801040ef9b34c6
2023-11-23 14:16:17 -05:00
Alex Chau 58a8c12713 Revert "Remove logs for bug investigation"
This reverts commit dad61a0098.

Reason for revert: b/279059025

Change-Id: Id8fcd1ddf67d7df0a23c81e3ddf3849c26c529bd
2023-11-23 19:01:16 +00:00
Schneider Victor-tulias 71afdf2f19 Refactor LottieAnimationColorUtils to enforce proper usage
Flag: N/A
Fixes: 312941637
Test: launched all set page and gesture nav tutorial
Change-Id: Iaa320fea0e78a93c4e955f617cb821a47aac6f96
2023-11-23 18:28:10 +00:00
Pat Manning 3e43b8a996 Merge "Do not hide icon app chip menu when resetting color tint." into main 2023-11-23 14:23:24 +00:00
Pat Manning c078064450 Do not hide icon app chip menu when resetting color tint.
Fix: 312372713
Test: Manual.
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iab860eb7e69ddb47913b01040ca706a8d829abe6
2023-11-23 12:25:02 +00:00
helencheuk b4cda2adbe Not show hover border on select mode
Fix: 295175854
Test: TaskViewTest
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states Nextfood
Change-Id: I81b1af27b590ea509e8ec84a9d3ff008f31da21f
2023-11-23 10:51:58 +00:00
Tracy Zhou 7ce0d39c41 [taskbar/navbar unification] Do not shift back button after unlocking in phone mode
Fixes: 312495129
Test: Back button doesn't move (stay on the left side) when unlocking from the small screen. Back button shifts from the right side to the final position after unlocking from the big screen
Change-Id: Idd9379cee0a0be49c443ee485b4dc0f4ea248366
2023-11-21 19:19:14 -08:00
Andy Wickham 2aee5ff67a Adds withPackageName to StatsLogger creation
This lets you specify a package name which will be logged by the
returned StatsLogger (rather than retrieving from the ItemInfo).

Bug: 292227499
Test: Manual with other change in topic
Change-Id: I3650f9f02f6cbe560e1c21262ba1cb893702a49e
2023-11-21 15:41:50 -08:00
Pat Manning 4c5ea5fd02 Show taskbar pinning dialog on right-click.
Fix: 308768942
Test: Manual.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I37e49452fada944186c8300562061bf9650a0d0a
2023-11-21 14:51:15 +00:00
Pat Manning 06ecd24ee3 Allow right-click of taskbar icons to launch long-click menu.
Fix: 290459491
Test: TaplTestsTaskbar#testOpenMenuViaRightClick
Flag: NONE.
Change-Id: Ide85f62e5b08d5261f15871e85d3250cc66d0919
2023-11-21 14:45:31 +00:00
Andreas Agvard b4be53477c Adds recovery flow for Search feature
Bug: 308840938
Flag: LEGACY ENABLE_LONG_PRESS_NAV_HANDLE TEAMFOOD
Test: Manual
Change-Id: Ia1dc7c644647503453c3f810569126fcb6407a5d
2023-11-21 13:36:18 +01:00
Johannes Gallmann b1e14f85be Use Decelerate Interpolator for predictive back to home window scaling
Bug: 311365390
Flag: NONE
Test: Manual, i.e. verifying back to home behaviour on device
Change-Id: Ib26edc13d9573b9c7e23f23b3abe9cd7e19809e7
2023-11-21 09:22:06 +01:00
Johannes Gallmann 862b48e591 Prevent scaled window from leaving screen bounds for back to home
Bug: 311365390
Flag: NONE
Test: Manual, i.e. testing back to home behaviour for predictive back
Change-Id: I5427e6f69b28aacd9ad7e805e42b0a4f7c09d4f5
2023-11-21 09:02:38 +01:00
Tracy Zhou 43c46e5787 Merge "Make sure the hotseat icons are always visible in phone mode" into main 2023-11-21 06:14:08 +00:00
Tony Wickham e1f770df2f Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: I48b4c809025a9bab0a37ada1317adee823b1a8f9
2023-11-20 23:41:01 +00:00
Pat Manning 54acb41e8c Merge "Do not hide persistent taskbar during input for physical keyboard." into main 2023-11-20 23:29:55 +00:00
Brian Isganitis 78ccf9c3e6 Merge "Adding TASKBAR entry state for Taskbar Toast." into main 2023-11-20 21:03:03 +00:00
Andreas Agvard 37eac5b585 Merge "Adds a debug & server configurable delay to search haptic hint" into main 2023-11-20 18:04:10 +00:00
Schneider Victor-tulias ca7147b289 Merge "Add debug logs for TIS ACTION_DOWN handling" into main 2023-11-20 17:41:01 +00:00
Andreas Agvard fc74c095d6 Adds a debug & server configurable delay to search haptic hint
Fix: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED

Change-Id: Ic050e8426ef91b28e6bf1dc4d86839eaa20b0dc0
2023-11-20 12:49:54 +01:00
Pat Manning a401e15553 Do not hide persistent taskbar during input for physical keyboard.
Fix: 255818649
Test: TaplTestsQuickstep
Flag: NONE.
Change-Id: Id5495163f43464125bfcbd9e255f18e24183d67a
2023-11-20 10:45:05 +00:00
Pat Manning d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Andreas Agvard ef8df12ff8 Merge "Makes deep press for LPNH toggelable" into main 2023-11-17 07:51:16 +00:00
Winson Chung 92851c5030 Merge "Don't open PiP when freeform is opened from recent" into main am: 0c531d5dbb am: f3eb5388d1 am: d127c1108b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2743811

Change-Id: I48a134a3545eb190c4ef085641d0233e68660046
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-17 00:29:58 +00:00
Winson Chung d127c1108b Merge "Don't open PiP when freeform is opened from recent" into main am: 0c531d5dbb am: f3eb5388d1
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2743811

Change-Id: If62d1d831854acf9b5ec2e8c27458594e72bba27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-16 23:58:07 +00:00
Winson Chung f3eb5388d1 Merge "Don't open PiP when freeform is opened from recent" into main am: 0c531d5dbb
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2743811

Change-Id: I41d412ee0c6d5c6dacd875c549b724b439e1d542
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-16 23:24:23 +00:00
Pat Manning 43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Andreas Agvard 0fc7d52863 Makes deep press for LPNH toggelable
By default when deep press is detected (https://developer.android.com/reference/android/view/MotionEvent#CLASSIFICATION_DEEP_PRESS)
during LPNH triggers the long press action immediately. This change makes this toggelable.

Flag is set to enabled by default, which leads to the default behavior.

Fix: 310952290
Test: Manual
Flag: LEGACY ENABLE_LPNH_DEEP_PRESS ENABLED
Change-Id: I970fed697979ee528e54b8be0139d842f3a64c43
2023-11-16 17:55:34 +01:00
Schneider Victor-tulias 4b794d57de Add debug logs for TIS ACTION_DOWN handling
Flag: N/A
Bug: 311094603
Test: Ran launcher and attempted several gestures
Change-Id: I08c6544226ed0ad385821c3309b2845a485cf900
2023-11-16 10:05:33 -05:00
Sergey Pinkevich 172eb5896b Merge "Show split screen action for each task" into main 2023-11-16 10:03:44 +00:00
Fengjiang Li 1da44348cf Merge "Add unit test for RecentsAnimationDeviceState.java" into main 2023-11-15 23:05:32 +00:00
Achim Thesmann daca6d0747 Merge "Opt in recents PendingIntent for BAL" into main 2023-11-15 22:27:27 +00:00
Fengjiang Li b3007a9e3d Add unit test for RecentsAnimationDeviceState.java
Bug: 299466828
Flag: N/A
Test: test device boot without issue
Change-Id: Iaa1a7cff547e03eaacc950702c2e7cd34846e987
2023-11-15 13:01:51 -08:00
Sergey Pinkevich ead5259f9a Show split screen action for each task
Remove previous condition:
1. `taskView.containsMultipleTasks()` - there is already a check to filter out "Split screen" item: https://googleplex-android.googlesource.com/platform/packages/apps/Launcher3/+/refs/heads/main/quickstep/src/com/android/quickstep/TaskOverlayFactory.java#68

Edit previous condition:
2. `notEnoughTasksToSplit` - condition saying if there is less than 2 recent tasks. We still should give the possibility to split the screen if Taskbar is not presented

Bug: 305958994
Flag: NONE
Test: manual - took a photo (https://screenshot.googleplex.com/7doU5z9AjxxETUo)

Change-Id: I3fdfea987c426d557a91b0a25af368069e8af3f8
2023-11-15 15:14:50 +00:00