Commit Graph

12553 Commits

Author SHA1 Message Date
Johannes Gallmann f151bfdd53 Add vsync id to predictive back transactions
Bug: 331808052
Flag: ACONFIG com.android.window.flags.predictive_back_system_anims TRUNKFOOD
Test: Manual, i.e. recorded perfetto trace and verified that missedFrames metrics showed up
Change-Id: I3dc5900ddedcb70467de7667f1555862dee5b45d
2024-04-02 17:35:45 +02:00
fbaron c0c0bdbc38 Fix null pointer in FloatingWidgetView
Flag: NONE
Test: NONE
Bug: 331868669
Change-Id: I350e6660ea1936bb9ee799c3d2c840c57876fef4
2024-04-01 13:17:49 -07:00
Shamali P 7ae51788da Update the WidgetPickerActivity to display recommendations for hub host
- Accepts a ui_surface param of format "widgets{_hub}" and existing
widgets on the surface to be excluded from predictions
- Refactored the widgets prediction update task to extract reusable
logic that maps the predictions to widget items and reused it.

http://screencast/cast/NjE1MTA5MDI0NzU2NTMxMnwzMGE3NTMwNi1hZg

Bug: 326092660
Test: WidgetsPredictionHelperTest and see screencast above.
Flag: N/A
Change-Id: I6ceeb752c167893bab4ed496cedc5e8081e1b950
2024-04-01 20:16:37 +00:00
Fengjiang Li 01cc273537 Add LAUNCHER_ALL_APPS_SEARCH_BACK jank instrumentation
Bug: 330405993
Test: prefetto trace TBD
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I1fb2876fb29bc360cbb8dc8c1605215f28383c3c
2024-04-01 11:12:50 -07:00
Liran Binyamin 1bc33421de Merge "Initial animation of new bubble bar bubble" into main 2024-04-01 17:54:59 +00:00
Ats Jenk 599ed3ba06 Merge "Create drop target for bubble bar" into main 2024-04-01 17:14:55 +00:00
Jeremy Sim 370d05a276 Merge "Update save app pair icon" into 24D1-dev 2024-03-30 03:36:21 +00:00
Jeremy Sim da4ba9336e Merge "Reparent folders and app pairs" into main 2024-03-30 03:06:44 +00:00
Sukesh Ram 5c34cf2d06 Fix Taskbar Background Visibility After Entering IME then Overview.
Fixed issue whereby taskbar background disappears as expected when the IME switcher is present, but does not appear again if the overview button is pressed after this state.

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 297472865
Change-Id: If1074b28870c794db8a87dd6cd59f9656dc7c15d
2024-03-29 16:08:43 -07:00
Jeremy Sim 742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00
Treehugger Robot 520d91f93b Merge "Don't toggle scrollbar during predicitve back swipe to avoid flicker" into main 2024-03-29 09:56:10 +00:00
Ats Jenk f221b8a7de Create drop target for bubble bar
When dragging bubble bar in launcher, show drop target when drag passes
middle of the screen.

Bug: 330585397
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual
Change-Id: I52c3e9ac0b7c36e2207640baf75dc44300b522ef
2024-03-28 14:21:33 -07:00
Alex Chau 170306d54a Update Split button visibility based on DeviceProfile change
- Updating Split button visibility in notifyPageSwitchListener() is sometimes too late and causes OverviewActions failed to re-center after removing Split button
- Instead, update Split button visibility based on DeviceProfile change in updateDimension(), which is the ultimate source of information impacting button visibility

Fix: 321291049
Test: Clear all tasks, fold, launch app, swipe up to Overivew
Flag: None
Change-Id: If518cb02429011fedfb8df3dd05dd7ab180d849a
2024-03-28 21:10:12 +00:00
Liran Binyamin 074a3a66b0 Initial animation of new bubble bar bubble
This change animates a new bubble bar bubble. Currently only handles the case where the bubble is added when the bubble bar is stashed.
There's no synchronization with the stash handle yet either.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Test: atest BubbleBarViewAnimatorTest
Change-Id: Ic3f5edc0dde204f871cf7e1288bd50620e6beebb
2024-03-28 11:30:56 -04:00
Uwais Ashraf 1a4052a44f Merge "Remove unused code and fix warnings" into main 2024-03-28 14:03:36 +00:00
Alex Chau 2165ad7b0e Revert "Log split button visibility to debug spacing issue"
This reverts commit 2d55c9c679.

Reason for revert: Logs not helpful in figuring out the issue and is too spammy
Bug: 321291049
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a5d55fe5efad4db1678dfe7960f82df68b664b7d)
Merged-In: I88a4350277ea3e965493da6386cf4c83c5c564e4
Change-Id: I88a4350277ea3e965493da6386cf4c83c5c564e4
2024-03-28 12:13:30 +00:00
Alex Chau c7dea26289 Merge "Revert "Log split button visibility to debug spacing issue"" into main 2024-03-28 12:12:29 +00:00
Schneider Victor-tulias 5a85b4f2df Close the KQS view when touching the gesture nav region
Also, stop handling KQS open/close during gestures

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328689890
Fixes: 328689534
Fixes: 328692760
Test: attempted gestures while KQS is shown. attempted KQS while attempting gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:14d912b062e69fe8bc4729b6f8b40e53d5b4a669)
Merged-In: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
Change-Id: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 07:27:09 +00:00
wilsonshih cc39a10dd0 Do not report finish in mergeAnimation...
...if the handler don't know how to process the transition.
So the Transitions can pass that transition to next handler.

Flag: NONE
Bug: 328619216
Test: manual, use alt+tab to relaunch a task where it's activity
is destroyed.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7130116894eb7f756a16da6b5ff0e754a356d50d)
Merged-In: Idf3f78103a56e91806ec2f6e364c6e8e7f4e205c
Change-Id: Idf3f78103a56e91806ec2f6e364c6e8e7f4e205c
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 07:21:57 +00:00
Schneider Victor-tulias 3d001dee6b Update KQS task view layouts to new specs
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.

- Updated icon position and size
- Added some blur to the thumbnail

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dba7cbae1adfde615060598a55b5ee0edfedef9f)
Merged-In: I2b20100ddeb562291edf5f0bacbce916002eee45
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 06:56:20 +00:00
Jeremy Sim de9b132f08 Update save app pair icon
This CL changes the save app pair menu icon to the latest spec. It looks good!

Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
(cherry picked from commit 1d48159bd5)
2024-03-28 04:44:18 +00:00
Jeremy Sim c61f4ede3c Merge "Update save app pair icon" into main 2024-03-28 01:44:55 +00:00
Fengjiang Li 61102b66e8 Merge "Extend CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK to start as early as when user starts predictive back swipe" into main 2024-03-28 01:02:00 +00:00
Luca Zuccarini b65bc82efb Merge "Move interfaces to the shared library." into main 2024-03-28 00:17:47 +00:00
Andy Wickham d6b0dc8970 Merge "Consolidate settings for Assist." into 24D1-dev 2024-03-27 23:56:23 +00:00
Fengjiang Li 10c03e499d Extend CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK to start as early as when user starts predictive back swipe
Bug: 330405993
Test: prefetto trace https://ui.perfetto.dev/#!/?s=58c0513fe0190f84ea1621a96d790a53b83fefc1ee402085b0d75bfc7b51e019
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I76c32975e5ae6dcb0395d2eee68417f761455262
2024-03-27 16:03:47 -07:00
Brian Isganitis 346776b4d6 Merge "Force refresh AllAppsActionManager for tests." into main 2024-03-27 19:25:43 +00:00
Jeremy Sim 1d48159bd5 Update save app pair icon
This CL changes the save app pair menu icon to the latest spec. It looks good!

Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
2024-03-27 11:33:26 -07:00
Brandon Dayauon 50f9dbd0a5 Disable two line text legacy flag.
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.

bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Merged-In: Idef427bad6551ae56b13e35393e076b8e000af5a
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-27 17:07:04 +00:00
Jagrut Desai bc657f64c3 Merge "Remove Taskbar Pinning menu when in three button navigation mode" into main 2024-03-27 16:46:53 +00:00
Uwais Ashraf 2725da5dd1 Remove unused code and fix warnings
Bug: 330326121
Test: Presubmit - change is a no-op
Flag: NA
Change-Id: If656113fce6bae82466d9482a92a15f689da00b6
2024-03-27 16:17:07 +00:00
helencheuk a3d40b0501 Add focus outline to overview clear all button
Use the same class BorderAnimator in TaskView to draw focus outline with padding between button and outline as UX design

Bug: 324911125
Test: Manual, launcher overview, use keyboard left arrow to show clear all button, outline should be shown
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Change-Id: I62ac2ce7a8f62170421b4318c9fa58805384187b
2024-03-27 14:15:08 +00:00
Liran Binyamin 65bf9fac38 Merge "Move PhysicsAnimator to wm/shell/shared" into main 2024-03-27 14:00:03 +00:00
Luca Zuccarini 8fe1d9c8ae Move interfaces to the shared library.
Bug: 323863002
Flag: NA
Test: NA, just a move
Change-Id: I8390bdbc226f53da2cbdf2c4321a67e7b7223bec
2024-03-27 04:42:35 +00:00
Gina Ko 5b845d2831 Reapply "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99
The revert was not supposed to be auto-merged.

This reverts commit 5a3bf93d82, reversing
changes made to 84f8002586.

Bug: 331384026
Change-Id: Ieb11a8544db90259aae856c4af805c37ce9e68cc
2024-03-26 15:03:31 -07:00
Liana Kazanova 5a3bf93d82 Revert "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26720630

Change-Id: I235f6d6263be6e39a583ac7b1a0783bfc77533c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-26 20:57:12 +00:00
Jagrut Desai c6f09490f7 Remove Taskbar Pinning menu when in three button navigation mode
Test: Manual
Bug: 331167630
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD
Change-Id: I257d1d3c0b3b37ef639578d0ccc6ec8d23d3d266
2024-03-26 13:42:09 -07:00
Liana Kazanova 036a83cd99 Revert "Support toggling Taskbar All Apps with 3P Launcher."
This reverts commit 176f186a6d.

Reason for revert: DroidMonitor: Potential culprit for http://b/331438065 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ie375277ad2f65199749f0211ab50037d4b37e664
Merged-In: Ie375277ad2f65199749f0211ab50037d4b37e664
2024-03-26 20:34:09 +00:00
Sunny Goyal 62a11974fa Merge "Cleaning up some build configurations" into main 2024-03-26 20:00:51 +00:00
Vinit Nayak 926e03f5e5 Merge "Revert^2 "Call setOverviewDragState() whenever taskbar is recreated"" into main 2024-03-26 17:59:31 +00:00
Alex Chau c093b26a0f Merge "Ensure SAVE_APP_PAIR is only used for GroupedTaskView" into main 2024-03-26 17:28:45 +00:00
Sunny Goyal 77954bae4e Cleaning up some build configurations
> Removing Launcher3Go-without-quickstep
> Removing src_ui_overrides to src_no_quickstep
> Removing unnecessary code swpa for GO builds

Bug: 330920490
Flag: None
Test: Presubmit, everything builds
Change-Id: I5746dbc7c5a37c1d99d78b55bf2a6adce1a711c9
2024-03-26 17:16:52 +00:00
Brian Isganitis b02811f1d3 Force refresh AllAppsActionManager for tests.
Flag: NONE
Test: Manual
Fix: 330514236
Change-Id: I32990fe115c79963f9635eabacccd89e2815f098
2024-03-26 13:11:30 -04:00
Schneider Victor-tulias b4d102e75a Merge "Add debug logs to ActivityTracker" into main 2024-03-26 17:02:13 +00:00
Liran Binyamin 40bdec4710 Move PhysicsAnimator to wm/shell/shared
Flag: NONE
Bug: 280605790
Bug: 322791067
Test: no behavior change. relying on presubmits
Change-Id: Ica5e388f8fb3d07a4865e72e310f3f2bdfe01579
2024-03-26 11:50:08 -04:00
Alex Chau d1bc3b39f7 Ensure SAVE_APP_PAIR is only used for GroupedTaskView
- Check if TaskView is GroupedTaskView before casting to avoid a crash, caused by DesktopTaskView.containsMultipleTasks() is true but is not a GroupedTaskView

Fix: 331226084
Test: With Talkback on and Desktop task, go to Overview
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: Ic2f1b940bb5a6b0cf452465b9cc15ebf4c256858
2024-03-26 10:46:59 +00:00
Johannes Gallmann 360d3cd16c Merge "Play predictive animation when quickly restarting back gesture after cancel" into main 2024-03-26 08:00:57 +00:00
Jeremy Sim 46ca78ee78 Merge "Refactor how app pair icons draw" into main 2024-03-26 02:39:37 +00:00
Brian Isganitis 176f186a6d Support toggling Taskbar All Apps with 3P Launcher.
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.

Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
Change-Id: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
(cherry picked from commit c113b277e6)
2024-03-26 01:16:39 +00:00
Treehugger Robot a8efc84122 Merge "Using xml override instead of code swap for predicted icon" into main 2024-03-26 00:53:37 +00:00