- Fallback to using a transparent drawable for the split select icon
if one can't be resolved
Flag: EXEMPT bugfix
Bug: 342465270
Test: Instructions from the bug
Change-Id: I5e4366b08bf438df96669ad3742bc9fb998bf0b3
Matches the prediction helper (the prediction service ignores added
widgets if launch location doesn't match the pattern. The size / pos
details however aren't used, so we pass defaults.
With this, prediction service may be able to predict widgets that
aren't already added, hence providing more suggestions.
Bug: N/A
Test: Unit test
Flag: EXEMPT BUGFIX
Change-Id: Ieaba4c9a8354dc96ea2bc70cafa106978037c572
Also Added some debug logs
Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 340426016
Test: Forced NaN and checked logs
Change-Id: Iee3536e764752a79f97e77c2ccaa8fdaa81a6eef
If the gesture nav mode switches to button nav mode mid gesture, specifically while a recents animation start is pending, then we never invalidate AbsSwipeUpHandler. This leaves the LauncherInitListener registered in the ActivityTracker until the AbsSwipeUpHandler is invalidated by something like a quick switch. Since the AbsSwipeUpHandler is not invalidated by pressing the home button, this leaves the home button seeming unresponsive.
Also added some clean up logic and debug logging to AbsSwipeUpHandler.onTasksAppeared since this path was confusing this investigation.
Flag: NONE code clean up, debug logs and bug fix
Fixes: 340748907
Test: adb shell cmd overlay enable-exclusive --category com.android.internal.systemui.navbar.threebutton && adb shell am start -n <component> while mid-gesture
Change-Id: I72f0656a2a2b92006d2d13ba5868062f2f0aec33
Hotseat supports adjusting its layout to make room for bubbles when
needed. There are 2 events that trigger this:
1. When Hotseat's layout is reset, it checks for whether bubbles
are showing.
2. When Bubble Bar visibility changes it notifies hotseat so that
it can update itself.
Folding the device is recreated triggers both hotseat layout reset
and recreation of taskbar, but the order in which these happen is not
guaranteed. Sometimes hotseat checks for the status of bubble bar
which may be visible if taskbar hasn't been recreated yet.
This change makes sure that hotseat updates itself after taskbar is
recreated and the ui controller is set, so that it cleans up any
adjustments it may have if bubbles are not visible.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349430356
Test: manual
- unfold the device
- create bubbles
- observe hotseat adjusts itself for the bubble bar
- fold the device
- observe bubble bar is gone and hotseat shows correctly
Change-Id: I58d925c178b02c22583488ae081d478bbbbccc8c
When returning false in a onLongClickListener, the touch event gets dispatched to onClickListener at release.
Fixes: 351457303
Test: long press and short press both result in one haptic feedback
Flag: EXEMPT bugfix
Change-Id: Id173a2d1fcf2f61c3289c653809207425b468a82
- Made TaskThumbnailViewDeprecated nullable in TaskContainer, with non-null getter that requires feature flag to be on/off
- Removed TaskThumbnailViewDeprecated.setTaskOverlay, as it'll now be null with feature flag on
- Removed TaskThumbnailViewDeprecated from DesktopTaskView xml
- Simplifed DesktopTaskView binding logic, to always get thumbnailViews from viewPool, removeView and recycle all thumbnailViews in onRecycle
- Didn't implement view pooling of TaskThumbnailView due to difficulty with TaskContainer not being recycled togetehr with TaskThumbnailView
Bug: 338360089
Test: TaskThumbnailViewModelTest
Test: manual testing for DesktopTaskView for both enable_refactor_task_thumbnail on and off
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I38a6dfc6bc561689578d1660794f91d30bad4a68
* changes:
Override DisplayController on main thread.
Add annotations for manipulating secure settings.
Don't use UiThreadTest for Taskbar Unit tests.
Suspend Launcher taskbar while removed for tests.
* RecentsView#onAttachedToWindow relies on splitSelectStateController
being initialized, so we now do it before RecentsActivity calls
setContentView()
Bug: 332643607
Test: Couldn't repro before or after :(
Flag: EXEMPT bugfix
Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
* Extract out both the top level split root leash
as well as the left and right split root leashes
* Set windowCorner radius on the left/right roots
Test: No more flicker near divider when launching app
pair (see comment for video in CL)
Flag: EXEMPT bugfix
Bug: 349387413
Change-Id: I6fce290d1e7766e55c2f11cc8c365f0c29087c0f
- Also migrated getScaledInsets method into TaksOverlay
Bug: 335606129
Test: TaskOverlayViewModelTest
Test: TaskOverlayHelper is not tested because it should be a view-based screenshot test for TaskOverlay, which is currently impossible until we refactor TaskOverlay to MVVM
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I07a8657ff0fe925d8021875310e3ed12a712ba7a
By default, tests will run with user setup complete and kids mode
disabled.
Test: TaskbarUnitTestRuleTest
Flag: TEST_ONLY
Bug: 230027385
Change-Id: If6c74b3b2c07aa0eac5b6bda933b565351d65188
This approach is less destructive than completely destroying Taskbar
while still ensuring it will not try to recreate itself.
Test: Taskbar Unit Tests
Bug: 230027385
Flag: TEST_ONLY
Change-Id: Ida0f7cc0b9c5b1d53bbadc2bb9fd81689c7f3940
This change stores the bubble that was dismissed by drag temporarily
in BubbleBarView so that when we remove the bubble, we can avoid
updating it as part of the animation.
This is step 1 in this change. Next I'll look into removing the
bubble immediately after dismissing it from the menu, and lastly
update sysui to not send the removal event back to launcher.
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 349826879
Test: manual
- have bubbles in the bubble bar and expand it
- drag a bubble to dismiss it
- observe the bubble does not reappear in the bar during
the animation
Change-Id: I6628ce779db4aac8d82edd4ecf2a25dedf8feef9
Removed the check on safeInsets#top and apply the offset.
Updated also the comment.
Flag: EXEMPT bugfix
Bug: 331128612
Test: Hold unfolded foldable in different orientation, enter PiP
Test: Hold folded foldable in different orientation, enter PiP
Change-Id: I56442ab2c4bfb1bf7ac68561aee8c0cc1fb183a8
Bug: 309059057
Test: Quickswitched with split and fullscreen apps in
portrait and landscape
Flag: EXEMPT bugfix
Change-Id: If175d2d3008b71372610cf380d44bad7a07aa255
Schneider Victor-tulias
Liran Binyamin
Treehugger Robot
Vinit Nayak
Winson Chung
Shamali Patwa
Tracy Zhou
Alina Zaidi
Alex Chau
Uwais Ashraf
Brian Isganitis
Olivier St-Onge
Pat Manning
Zak Cohen
Hongwei Wang
Saumya Prakash