Commit Graph

12553 Commits

Author SHA1 Message Date
Sunny Goyal 9f006f1460 Merge "Removing unused SearchSessionManager" into tm-dev am: 34f51fbfc4 am: f81b1952aa am: 9f1fe52467
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18085661

Change-Id: Icf982387d79d7bf595e3aede7640bd0632c123cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-30 00:30:25 +00:00
Anushree Ganjam f6254c5947 Do not add HOTSEAT_ICONS to visible elements for device type "phone" in
ALL_APPS State

HOTSEAT_ICONS got added to visible elements for ALL_APPS State in ag/16992837.

============================================================
Phone
Before:
HotSeat present in view hierarchy - https://hsv.googleplex.com/4906040983289856?node=41
Video: https://b.corp.google.com/issues/228803923#comment9

After:
HotSeat not present in view hierarchy - https://hsv.googleplex.com/5379653922455552?node=42
Video: https://b.corp.google.com/issues/228803923#comment11
============================================================

Tablets

I couldn't test this implementation on tablet. But I have verified on a phone
locally by adding HOTSEAT_ICONS to visible elements and then verifying
"IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS" get set and hotseat icons are not focusable in all apps.
Video : https://b.corp.google.com/issues/228803923#comment14

============================================================

Bug: 228803923
Bug: 227565451

Test: Manual. See the video attached in bug.
Change-Id: I055e3bb61c8cfd240e0fe1000fe3a391a150f6d1
2022-04-29 23:33:48 +00:00
Sunny Goyal 34f51fbfc4 Merge "Removing unused SearchSessionManager" into tm-dev 2022-04-29 23:30:13 +00:00
TreeHugger Robot fd6aa6953c Merge "Update TaskOverlay corner radius as fullscreen parameters are updated." into tm-dev am: 47a137e05d am: 3f6d27b025 am: b78d5f10f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18083412

Change-Id: I4aba2aee9531587321717ee428a804a8ed0f7648
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 23:18:00 +00:00
Schneider Victor-tulias 8e0e88bb2f Update home, back and overview gesture tutorial introductions to be clearer for blind users
Added A11Y strings for the home, back and overview gesture tutorial step introductions. These strings give clearer instructions that work with talkback.

Fixes: 202492454
Test: manual
Change-Id: I1eefd6ecf3e3c576a7c1cf6dbf7b824e5be13860
2022-04-29 16:09:11 -07:00
Pat Manning d377c88aad Merge "Re-land "Animate overivew actions view hiding on scroll."" into tm-dev am: d9ddf6c12b am: 2049688659 am: 669c6f5790
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17707271

Change-Id: I737975cd5e5ee7abfc3ecd5d532a825f38260819
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 22:44:16 +00:00
TreeHugger Robot 47a137e05d Merge "Update TaskOverlay corner radius as fullscreen parameters are updated." into tm-dev 2022-04-29 22:34:31 +00:00
Pat Manning 0a459a82e2 Merge "Finish recents animation on activity destroyed." into tm-dev am: d44f9c9741 am: 3664e04036 am: fa8e4bcdfd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17943734

Change-Id: Ie16d930960d1db5139716ae318ea4e6efd235a7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 22:10:27 +00:00
Thales Lima 313df994c6 Fix hotseat width to span a number of columns am: 828875cd12 am: ab5faf06a8 am: 14527d5f6d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983445

Change-Id: I8329fc48f69cad4699e94639e2ef266997690acd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 21:38:07 +00:00
Alex Chau f39cc126bf Tune AllApps dismiss animation
- Avoid overriding interpolator in AllAppsTransitionController.setStateWithAnimation as it's no longer needed and it'll wrongly override interpolator for ANIM_ALL_APPS_FADE
- Override ANIM_ALL_APPS_FADE to FINAL_FRAME in QuickstepAtomicAnimationFactory for tap deadzone to dismiss animation, also added EMPHASIZED_ACCELERATE for the dismiss animation
- Tuned dismiss animation across form factors to 300ms

Fix: 220336617
Test: manual
Change-Id: I4b3e827b503dcb1dd39f0bd99d4c1dd5ffdba0f3
2022-04-29 20:31:26 +01:00
Shan Huang b2ffc2d1e0 Merge "Fix screen rounded corner flicker." into tm-dev am: 8073fc8daf am: 8f92b76c67
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17948370

Change-Id: Ief2f9eccb38d29f59c618960b6845efcffc7bc56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 19:29:54 +00:00
Mateusz Cicheński 136b7838a8 Merge "Make Hotseat report shelf height on large screen devices." into tm-dev am: f312acc081 am: a7cc8ed3ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17969666

Change-Id: I03eb36fef3ca5a9fdb7b091d708e628eec5a5702
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 19:28:02 +00:00
Shan Huang c2ccb951ce Merge "Fix screen rounded corner flicker." into tm-dev am: 8073fc8daf am: 276a31bbf8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17948370

Change-Id: I6331e568fc55b51257e48a59d1159dfacc775ac3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 18:28:03 +00:00
Mateusz Cicheński 41bff8dedd Merge "Make Hotseat report shelf height on large screen devices." into tm-dev am: f312acc081 am: cc3cc0428e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17969666

Change-Id: I0ddee24a2ffc755ce72804b828becaa106623b10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 18:27:45 +00:00
Schneider Victor-tulias c4de960bbf Merge changes from topic "taskbar-misc-fixes-master"
* changes:
  Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
  Fix taskbar 3-button truncation on rotate
2022-04-29 18:17:14 +00:00
Pat Manning d9ddf6c12b Merge "Re-land "Animate overivew actions view hiding on scroll."" into tm-dev 2022-04-29 18:01:30 +00:00
Pat Manning d44f9c9741 Merge "Finish recents animation on activity destroyed." into tm-dev 2022-04-29 17:43:21 +00:00
Zak Cohen f2cd2f7748 Update TaskOverlay corner radius as fullscreen parameters are updated.
Bug: 230470826
Test: Build and run
Change-Id: I3b6914bf7423ec60d28d2d06ee5225de1b6862c1
2022-04-29 10:27:53 -07:00
Thales Lima 828875cd12 Fix hotseat width to span a number of columns
Bug: 227344807
Test: manual
Change-Id: Ice4e37929bcbb8c9cf3af340e67b6bec002578bd
2022-04-29 14:56:30 +00:00
Pat Manning d08e03388f Re-land "Animate overivew actions view hiding on scroll."
Reverts commit f5f14acba3

Bug: 228137694
Bug: 221113300
Change-Id: I683092796f5de0476e09692897d80a3655ae6925
2022-04-29 13:49:09 +00:00
Pat Manning 0fd3b13d01 Finish recents animation on activity destroyed.
Do not remove acitivity lifecycle callback on reset.

Test: TaplTestsQuickstep.java testQuickSwitchFromApp
Fix: 228137694
Change-Id: I454db1d029af479624999f2e5736aea1a8a97b87
2022-04-29 11:55:40 +00:00
Sunny Goyal a3f014d737 Removing unused SearchSessionManager
Bug: 220922858
Test: Presubmit
Change-Id: I8264a2e9b978a850aa6ce69fcb698b0a3494c6c5
2022-04-28 19:44:03 -07:00
Shan Huang 8073fc8daf Merge "Fix screen rounded corner flicker." into tm-dev 2022-04-28 19:34:37 +00:00
Mateusz Cicheński f312acc081 Merge "Make Hotseat report shelf height on large screen devices." into tm-dev 2022-04-28 18:48:11 +00:00
Anushree Ganjam 98d71a1b3c Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev am: fa693be19f am: 34fc3c4aee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18011182

Change-Id: Ie5758ee4aa04d4236442fb78c6e68de92e3c54f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-28 06:04:46 +00:00
Anushree Ganjam e9466b3f94 Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev am: fa693be19f am: 168362edd2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18011182

Change-Id: I62f302fbdaf1b37988f6a56c8cf501a454cb2382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-28 06:03:36 +00:00
Anushree Ganjam fa693be19f Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev 2022-04-28 04:52:01 +00:00
Anushree Ganjam 5cc7ff0990 Revert "Refactors Search results into separate RV for Toast."
This reverts commit 6729f0b950.

Reason for revert: This change caused b/230648542.

Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.

Bug: 206905515
Bug: 230648542

Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
2022-04-28 01:37:49 +00:00
TreeHugger Robot 0975972d99 Merge "Remove unnecessary updatePivots" into tm-dev am: e19522bede am: e8bfbb4c21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983443

Change-Id: Ibb2b200d10998cc8ef4cba355b5c04a50a455150
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 19:06:11 +00:00
Alex Chau a95d18b430 Merge "Update overview actions alignment" into tm-dev am: a80efcee9f am: 0a4e0923d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17888303

Change-Id: Ief8f521e87f98491cd777e02cf90461a8409b9a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 19:05:10 +00:00
Jerry Chang bc2fbc78e3 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94 am: d49286cc28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: I9723a3669b746b8fc79eeddad63cf0199f054c17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 19:03:42 +00:00
TreeHugger Robot 5ed4ac94b9 Merge "Remove unnecessary updatePivots" into tm-dev am: e19522bede am: 6d7db81e74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983443

Change-Id: I9fa56bb4e2060b00919c1014ecae2a5472f578d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 17:35:10 +00:00
Alex Chau 9f1635718c Merge "Update overview actions alignment" into tm-dev am: a80efcee9f am: c7fee694e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17888303

Change-Id: I128b4f0f8e8990fed7df5957485089271e298807
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 13:20:27 +00:00
Alex Chau 2a6e364e91 Remove unnecessary updatePivots
- Follow-up of http://ag/17888303 to remove extra code that didn't get clean up

Bug: 209981696
Test: manual
Change-Id: I37f68dd52adacfd033eaeaeca52c98a4a06d556d
2022-04-27 13:57:39 +01:00
Alex Chau a80efcee9f Merge "Update overview actions alignment" into tm-dev 2022-04-27 12:24:24 +00:00
Jerry Chang 1833317d5d Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94 am: 448ae578f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: Ia8b5e52d278d8ac280d5827dba3c64dcdbe93220
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 04:12:22 +00:00
Jerry Chang 59939e9e94 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev 2022-04-27 03:02:57 +00:00
Tracy Zhou 023537038d Originate split select animation from the original icon view instead of the split menu icon
Bug: 226395821
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/ed355c4f-b9d3-4b85-870f-2decb0b786db
Change-Id: I7277a9de212328d6f580bff5d28338ea0c058d99
2022-04-26 18:00:25 -07:00
Mateusz Cicheński 76fb120994 Make Hotseat report shelf height on large screen devices.
Test: http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ckTLvEEiaCugieedwOU6tj
Bug: 198311114
Change-Id: I9d5bc6ab031fb6d07d5205581c33aa5ab9b45a8c
2022-04-26 23:34:22 +00:00
Tracy Zhou 9660c41b4c Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: 7148e74f1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I3db055b4066d721eccc9ca6cdc70d25aec0b3574
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 18:25:22 +00:00
Tracy Zhou 4622349c69 Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: dbb368b40f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I7d029e2545795697f30dcb064139d48cc525b6ba
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 18:24:49 +00:00
Tracy Zhou 7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
Shan Huang 3e952539a1 Fix screen rounded corner flicker.
We've previously always played transitions with a fixed start corner
radius. This should however be an interpolated value based on gesture
progress.

Bug: 230115505
Test: Turn on predictive animations. Try completing a back swipe as well
as canceling a back swipe. Observe corner radius to make sure there's no
flicker.

Change-Id: Iae2517d969ed1b779bced866407b939b3a011b68
2022-04-26 17:16:22 +00:00
TreeHugger Robot 16a13ec3e6 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: 14615df286
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I10c86da47d157bb99d3422719f2f9c8acf8fc568
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:11:39 +00:00
TreeHugger Robot cea10a4fb4 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: eb4fa04985
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I76d64e3b7cd443423b3bbe291e82717c4f4d2ffa
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:11:14 +00:00
Schneider Victor-tulias 9c1a452a1d Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
Bug: 221455508
Test: opened all apps, widgets, -1 screen, notifications shade and keyboard in various combinations and orders; locked screen, launched app, returned home with the back/home buttons, opened overview
Change-Id: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
2022-04-25 14:57:13 -07:00
Schneider Victor-tulias 8aa99c72b1 Fix taskbar 3-button truncation on rotate
- Fixed truncation issue in overview and home on rotation
- Fixed 3 buttons translating incorrectly when switching to/from overview

Fixes: 205057824
Fixes: 215482458
Test: Manual
Change-Id: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
2022-04-25 13:40:57 -07:00
Vinit Nayak 2d1a69e58b Revert "Revert "Use new onStartSplitLegacy when starting split f..."
Revert submission 17918609-revert-17779173-startSplitLegacy-OOWPZEFFGI

Reason for revert: Running through TH
Reverted Changes:
I6d81e0584:Revert "Use new onStartSplitLegacy when starting s...
I754bc308f:Revert "Remove check for preventing re-parenting n...

Change-Id: I6eea82f34b3680020b49ec7fe19eb61cc68286a5
2022-04-25 19:55:31 +00:00
Alex Chau a2fc764405 Update overview actions alignment
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile

Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
2022-04-25 19:20:21 +01:00
Jerry Chang c3865b86e4 Fix divider bar won't fade-in as the other splitting tasks
Bug: 226271407
Test: manual check the divider bar fade-in animation after launchTasks
Change-Id: I5ea7c6ea5ac3f3550b28e9c0f854e70edcfc97b0
2022-04-25 15:41:28 +00:00