Commit Graph

12553 Commits

Author SHA1 Message Date
Evan Rosky eaaf065b73 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev 2022-09-01 21:11:01 +00:00
Alex Chau 3193522616 Change wallpaper depth value in AllApps bottomsheet
- Cap AllApps wallpaper zoom to workspaceContentScale rather than all the way to max depth (config_wallpaperMaxScale)
- Changed both workspace scale and depth interpolator to correlate with AllApps threshold

Bug: 240580498
Test: manual
Change-Id: I0342a37c72206268dcffc5697a212704a41b020f
2022-09-01 21:26:30 +01:00
Hyunyoung Song a0de27c120 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev am: 0397cb0ce7 am: b8be0b7594
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19806634

Change-Id: I2aa6182f90da775239ad1c27ab518614386bb759
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 19:57:06 +00:00
Holly Sun 03caf49826 Update container for ItemInfo.
See https://docs.google.com/document/d/1eAxQ9p263FI8-ZdkOsiQoarhpwm9aOdncqfJUD42o1Q/edit?resourcekey=0-GJyyDut-Tfy29akzHyoz0Q for the debugging process.
Test: see video https://drive.google.com/file/d/1qpD7070v0qOaBEuYS0WoZauawyhL54MQ/view
Fix: 234848972

Change-Id: I2ed5d24d11ab2081c6faa5d040d72a9d1646e5ca
2022-09-01 12:10:31 -07:00
Sunny Goyal f2c6bf8346 Moving view capture dump to a service to allow longer timeout
Bug: 243827665
Test: Verified on device
Change-Id: I7273cc14d86620b52aaf71c7ea293bd643d881f9
2022-09-01 11:57:23 -07:00
Hyunyoung Song 0397cb0ce7 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev 2022-09-01 15:50:39 +00:00
Pat Manning ee1caf18c6 Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev am: e51e6446ad am: ff3accd144
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19659547

Change-Id: Ie1d9cf06bf012a9ae596ff1e7cc1240ae50b7e90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 14:46:18 +00:00
Pat Manning d8d75c104d Merge "Update grouped task view thumbnail splash interpolation to match regular task." into tm-qpr-dev am: a3ebbbeba5 am: 0934cb2770
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19803194

Change-Id: Iab0a378396176f019bd42d700ef36dce13c1a16a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 14:45:51 +00:00
Pat Manning e51e6446ad Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev 2022-09-01 14:01:57 +00:00
Pat Manning a3ebbbeba5 Merge "Update grouped task view thumbnail splash interpolation to match regular task." into tm-qpr-dev 2022-09-01 13:30:33 +00:00
Pat Manning 401f6bb0d4 Undim kids nav icons on a11y focus and click.
Fix: 241298057
Test: manual
Change-Id: I9a330bde4641a01b4d19dc83c8f25f56a69328c8
2022-09-01 12:42:04 +01:00
hyunyoungs 91ca748819 Fix blurry wallpaper when user locks on all apps surface
Bug: 242746421
Test: manual

TL;DR;;
setState toState= NORMAL called when locking screen on ALLAPPS screen
but mSurface==null
hence depth is not reset to NORMAL state

Change-Id: I26a37f7de8b0ecd481b36eebf07e1b79f8b0035c
2022-08-31 22:05:45 -07:00
Tony Wickham 2be2312543 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev am: d833fe4a12 am: 94894d8d88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19472817

Change-Id: Ib419b6f6fad396917f5b477e5c20ca5bd425a165
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 01:43:50 +00:00
Tony Wickham d833fe4a12 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev
* changes:
  Fix taskbar stash state not persisting properly across recreate
  Add support to Tapl to recreateTaskbar
  Don't rely on QuickstepLauncher instance for tests
2022-09-01 00:52:54 +00:00
Evan Rosky 10c1c017c9 Only animate to hotseat when launcher is on home screen
Was assuming that resume == home-screen; however, in shell
transitions, launcher is resumed while overview is active,
so make sure it is both resumed AND "isTaskbarAligned"
before making the to-hotseat animation

Bug: 241800590
Test: Open an app, long-press taskbar to stash, long-press again
      to unstash
Change-Id: I117afcb006c363e50205f27f014ffc30d6f2896a
2022-08-31 22:53:02 +00:00
Pat Manning 038e112e9d Update grouped task view thumbnail splash interpolation to match regular task.
Follow-up to ag/19730966

Fix: 244433374
Test: follow up after b/238405972
Change-Id: I5c3c05dd51234b568e8f99c075e0f3384bca4741
2022-08-31 18:10:11 +01:00
Brian Isganitis 1e2fde5232 Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-qpr-dev am: 5166c5da3f am: b28748f662
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19290025

Change-Id: I32fdcd76559f05ecd0f6d890f49f62ea532bccae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-31 03:16:14 +00:00
Brian Isganitis 5166c5da3f Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-qpr-dev 2022-08-31 02:14:38 +00:00
TreeHugger Robot bcbba897fc Merge "Add app predictions to secondary display app drawer & fix tab UI." into tm-qpr-dev 2022-08-31 00:01:21 +00:00
Schneider Victor-tulias 7ba044f10b Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev am: ff5ad47a06 am: 520bf2e892
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19300928

Change-Id: I7830f925e70d89f84fce7da317403e03dacbb419
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 23:55:39 +00:00
Schneider Victor-tulias ff5ad47a06 Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev 2022-08-30 22:42:46 +00:00
Sukesh Ram 1b4869fcbc Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
(cherry picked from commit 9e5fe63a22)
Merged-In: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-08-30 22:30:03 +00:00
Brian Isganitis 14aa82a02a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev am: 168482688a am: f898db348a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19283295

Change-Id: Id8c0372759306567ed50b2d3e33cdbb060c7f65d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 21:13:38 +00:00
Brian Isganitis c043d45c42 Snap to last task if swiping down at a greater Y than X velocity.
If you swipe down slightly diagonally, it will almost always be treated as a swipe to the next task rather than a return to the current task. If we are swiping down and the Y velocity is grater, we should snap to the current task instead.

Test: Manually in fully gestural mode.
Bug: 222117127
Change-Id: I8c3cd483f7ceefe0de1e24b6e98918b12428ed10
2022-08-30 20:59:40 +00:00
Tony Wickham e74569e935 Fix taskbar stash state not persisting properly across recreate
Because we check supportsVisualStashing() in
TaskbarStashController#init(), we need to avoid using
TaskbarUIController to provide that value since TaskbarUIController
isn't initialized until a bit later than the other controllers. So I
moved the logic from supportsVisualStashing() back to
TaskbarStashController, but still allow TaskbarUIController to override
it (e.g. for DesktopTaskbarUIController).

After that fix, I noticed that force stopping launcher (to test the fix)
would briefly show the taskbar background before resetting the stashed
state. This is also due to LauncherTaskbarUIController not being ready
immediately, since that's what sets FLAG_IN_APP due to launcher being
paused. To work around this, I set FLAG_IN_APP to true by default in
TaskbarStashController#init(), since that is the most common case, and
taskbar background/stashed handle isn't shown on home anyway.

Test: Force stop launcher while taskbar is stashed, verify it recreates
as stashed without background flicker; same when changing wallpaper
color on home or in app; also tested when taskbar isn't stashed and in 3
button mode for good measure
Test: testHideTaskbarPersistsOnRecreate
Fixes: 235986838

Change-Id: Ie55bd70e8288d5ad7433dde970f18c176831d747
2022-08-30 13:42:04 -07:00
Tony Wickham c8e824dbdb Add support to Tapl to recreateTaskbar
Also moved references of "tasbkar_view" to share TASKBAR_RES_ID constant

Test: compiles; see follow up CLs
Bug: 235986838
Change-Id: I69bcfa975550e567f3daa35af8a810546297d79c
2022-08-30 13:40:45 -07:00
Brian Isganitis 168482688a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev 2022-08-30 20:09:10 +00:00
Schneider Victor-tulias 038922a653 Add gesture nav error state tracking and logging
- Added ActiveGestureErrorDetector
- Removed startQuickstep logs; these were confusing and not helpful in ActiveGestureLogs

Test: printed logs after several gestures
Bug: 227514916
Design: go/gesture-nav-logging
Change-Id: Ia2a7e4f90a3a371d9a92190aa66eb07acd061d6c
2022-08-30 12:18:29 -07:00
Pat Manning 7a5048297d Merge "Refactor overview progress as splash progress." into tm-qpr-dev am: b4a30ab955 am: 99bce932a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19730966

Change-Id: I3abd3fd009ed7d6d7f4754bcece6a594bab3db61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 14:17:18 +00:00
Pat Manning b4a30ab955 Merge "Refactor overview progress as splash progress." into tm-qpr-dev 2022-08-30 13:29:53 +00:00
Pat Manning 81dc9ad131 Refactor overview progress as splash progress.
This also avoids showing splash in split select state

Fix: 242284413
Test: follow up after b/238405972
Change-Id: I2e83fa3d030e8a74edb4152c472dbf02ac5a80b1
2022-08-30 11:23:08 +01:00
Tony Wickham b6f593042d Don't rely on QuickstepLauncher instance for tests
Instead, bind to TouchInteractionService and use that binder to call into taskbar.

Test: TaplTestsTaskbar
Bug: 235986838
Change-Id: I222522bc53c9d1698542fbae52c37889f14abf41
2022-08-29 17:27:27 -07:00
Brian Isganitis 5208317c64 Merge "Add doc clarifying Taskabr icon alpha consumer purpose." into tm-qpr-dev am: a4636922a6 am: e5f48d27db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19040760

Change-Id: I4b1c43eb7e117f655e1a19664b8875ffb8179a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 21:44:42 +00:00
Brian Isganitis 2303eb0aac Simplify calculateEndTarget logic.
This method has grown quite large and has a lot of if-else nesting. We
can address these readability issues by defining some helper methods for
specific cases (e.g. flingY and non-fling).

Bug: 222117127
Test: Manual
Change-Id: Ia6012dbcee9a842b4b5bd2ffdb9aea978cfdfc26
2022-08-29 20:47:32 +00:00
Brian Isganitis dc643f9bea Add doc clarifying Taskabr icon alpha consumer purpose.
The motivation ternary `alpha > 0 ? 0 : 1` was not immediately clear, so adding some clarification for future readers.

Test: No
Change-Id: I558e86153e68572a519317dba7fbba180cb5678e
Fix: 239074423
2022-08-27 20:46:49 +00:00
Alex Chau 20eb0e3f67 Replace shelf height with keep clear areas registration in Launcher.
This affects Hotseat only for now. Taskbar will be occluded when unstashed.

When in gesture nav and with auto-enter pip, we need to pre-register the Hotseat
keep clear areas, as otherwise the event appears after the animator is started
and current logic doesn't allow to update those destination bounds in the animator.

Test: manually, existing tests pass
Bug: 183746978

Change-Id: I4d97ca77225d3502acac1fb6b5e3eff3e81285ed
2022-08-25 22:52:17 +00:00
Schneider Victor-tulias 305a1df9d9 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev am: 7fb96a5305 am: 2ed4c84e68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19517498

Change-Id: If267d42f6d15fef03373ffe0c77fc1ebb1a7dd3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 21:31:02 +00:00
Schneider Victor-tulias 7fb96a5305 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev
* changes:
  Update ActiveGestureLog to store n-gestures rather than n-events.
  Add input consumer selection reason to active gesture logs
  Collapse EventLogArray into ActiveGesture log.
2022-08-25 20:42:13 +00:00
Schneider Victor-tulias 976fdbe623 Update ActiveGestureLog to store n-gestures rather than n-events.
Test: printed logs after several gestures
Bug: 227514916
Change-Id: I562abc6c5c43e53a53b085234b0be01dae90ac06
2022-08-25 17:05:01 +00:00
Schneider Victor-tulias 24637f50c5 Add input consumer selection reason to active gesture logs
Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I7a48d960ef5a41ddee95153fa08a2345f00cbef7
2022-08-25 10:03:30 -07:00
Schneider Victor-tulias a0cd3e0295 Collapse EventLogArray into ActiveGesture log.
EventLogArray is never used directly, only used as a super class of ActiveGestureLog. Simplifying the hierarchy to simplify follow-up changes.

Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I0916f969a776953ddc4886846ad2f4936566e7d7
2022-08-25 09:59:13 -07:00
Sunny Goyal 4b0dc5b562 Inlining BaseQuickstepLauncher to QuickstepLauncher am: d6801af69a am: 85c106aba1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668510

Change-Id: If899cc781782346d4aedd1562033c774171388fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 23:21:10 +00:00
Sunny Goyal d6801af69a Inlining BaseQuickstepLauncher to QuickstepLauncher
Bug: 243022799
Test: Presubmit
Change-Id: I3706fc1f10d88ea73bd873c7e94c3e78795791eb
2022-08-24 12:51:21 -07:00
Evan Rosky 2cfc8abceb Merge "Use SysUI/Shell's transaction apply token in Launcher" 2022-08-24 15:02:47 +00:00
Jeff Chang 7cffefbe9b Merge "Launch split task with correct UserHandle" into tm-qpr-dev am: 831f5ee748 am: ede6d7b35c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668512

Change-Id: I64778a8e2f7930a5a132c897e3dee6dbd2532e36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 08:52:12 +00:00
Jeff Chang 831f5ee748 Merge "Launch split task with correct UserHandle" into tm-qpr-dev 2022-08-24 07:48:09 +00:00
Winson Chung 19da9249dc Merge "Defer adding surface changed callback until view root is valid" into tm-qpr-dev am: c04576ad6e am: 9411d64586
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19628908

Change-Id: I8bb7d072097f0b1b22fac5f63ea8e525e3b88af5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:27:03 +00:00
Pinyao Ting 292d0d3dc9 Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev am: 775b0d21dc am: ff8f09b5b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19679564

Change-Id: I569d5e6fd9ebbcb31266c6683c129481ee3c2144
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:08:54 +00:00
Jeff Chang 9f27fa3687 Launch split task with correct UserHandle
PendingIntent#getActivity gets the owner UserHandle from the app
context. That makes the activity launch fail since the app only exists
in the work profile environment(secondary user).

This CL gets the correct Userhandle from Launcher and use
PendingIntent#getActivityAsUser to launch split task.

Bug: 242039471
Test: Launch Google chat by shortcut to enter split (work-profile)
Change-Id: Ie1db8a858bf9cee700cb3ff3a9e607a5d1dbad30
2022-08-24 10:39:04 +08:00
Evan Rosky 6e326cf205 Use SysUI/Shell's transaction apply token in Launcher
Launcher and SysUI/Shell have a lot of interactions
that require careful synchronization and ordering (at-least
with shell-transitions). As a result, they need to share
the same apply token or else some operations can end up
out-of-order despite being applied in-order.

Bug: 242193885
Test: Open an app, quickswitch repeatedly.
Change-Id: I4cbe8b5db28516db7a08b4022f1199f3f6b89591
2022-08-24 00:06:18 +00:00