Commit Graph

12553 Commits

Author SHA1 Message Date
Vinit Nayak 26fee57f37 Null out mSplitHiddenTaskView when resetting split selection state
* May have accidentally been removed in ag/19984439

Fixes: 248153819
Test: Repro in bug doesn't occur
Change-Id: Icdc04de84c28963d36368f9672baf5993cd87d8a
2022-09-22 16:27:47 -07:00
Winson Chung 8ae6b852d7 Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"
This reverts commit 240b064cdb.

Reason for revert: b/248344141

Change-Id: I559e583ddea4a68b4291ceb8ba119500d051ed36
2022-09-22 22:10:20 +00:00
Vinit Nayak 061e6f5dd5 Merge "Prevent taps on initial TaskView animated into split select" into tm-qpr-dev 2022-09-22 21:56:55 +00:00
Mady Mellor ceff6537ee Set package name on the floating intent
Test: treehugger
Bug: 237678727
Change-Id: I70923e62893cd6578fa3fa21e025cd5cf5e15edf
2022-09-22 12:08:41 -07:00
Thales Lima c9a317c7a2 Change taskbar edu size to wrap around icons
Bug: 217262479
Test: manual
Change-Id: I766394f4f64d5ba76c1bf50de9d06526376e6662
2022-09-22 14:36:10 -04:00
Sebastian Franco e7c222cdb5 Check for null when calling getCreatedActivity which is marked as Nullable
Fix: 243508135
Test: compiles
Change-Id: Id1ff2cf68fa10690a1bbec60a0c17cceab9db8d1
2022-09-22 13:03:15 -05:00
Schneider Victor-tulias 418b1f8e82 Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev 2022-09-22 17:25:24 +00:00
Mady Mellor 13b7e00fff Merge "Add a button for floating tasks to taskbar (behind a flag)" into tm-qpr-dev 2022-09-22 14:58:13 +00:00
Nicolò Mazzucato 112d516f59 Merge "Fix taskbar instrumentation crash" into tm-qpr-dev am: 98e4e461fe am: a2c42f1696
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19964665

Change-Id: I93406800a8e2abd7ff972940eb76169705f6e501
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 10:08:13 +00:00
Nicolò Mazzucato 98e4e461fe Merge "Fix taskbar instrumentation crash" into tm-qpr-dev 2022-09-22 08:28:41 +00:00
Stefan Andonian 61ad44d4b3 Merge "Copying ViewCapture from last frame when possible." into tm-qpr-dev am: 94502428a9 am: 886f34e9c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19803004

Change-Id: I207e2663d6fa10f266fc85fd5bcd51892be8ee40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 01:56:30 +00:00
Andy Wickham 7e080b29c3 Merge "Reduces vertical padding of predicted apps in All Apps." into tm-qpr-dev am: a297508c15 am: c6ed393aae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19937149

Change-Id: Icfc5ef8d7461ddf70b8685b6689899468681aced
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 00:31:03 +00:00
Vinit Nayak 5144be3903 Prevent taps on initial TaskView animated into split select
Fixes: 247843657
Test: Tapping on animating taskView as soon as
split top is selected from app menu doesn't result
in starting split prematurely.

Change-Id: I94455d9bab381e5223f70cab981830d51a8fad6b
2022-09-21 16:57:53 -07:00
Stefan Andonian 94502428a9 Merge "Copying ViewCapture from last frame when possible." into tm-qpr-dev 2022-09-21 22:44:53 +00:00
Schneider Victor-tulias 2dc0c7e18f Merge "Update page index update logs" into tm-qpr-dev am: c4928df98b am: e87055e2dd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19993478

Change-Id: I7c84d304f0ef4116ea97efb383fed0835fb77371
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-21 21:46:39 +00:00
Winson Chung a16aed3400 Merge "Fix case of gesture being stuck when the Launcher is stopped mid-gesture" into tm-qpr-dev am: a4512046cf am: 0b07c8daba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19939112

Change-Id: I559fb957ec8907057a8176d1cdcb903a09ef391a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-21 21:46:30 +00:00
Schneider Victor-tulias e64a8cfb20 Allow Taskbar stashing for external tests
Moved Taskbar stashing enabling logic to QuickstepTestInformationHandler to allow external tests to use the Taskbar API

Test: TaplTestsTaskbar
Bug: 240129939
Change-Id: I0ede8e4767cbe068328997a3afd51f9d5df2799a
2022-09-21 10:44:23 -07:00
Andy Wickham a297508c15 Merge "Reduces vertical padding of predicted apps in All Apps." into tm-qpr-dev 2022-09-21 17:25:39 +00:00
Stefan Andonian 7308c39049 Copying ViewCapture from last frame when possible.
Bug: 242867462
Test: Used system.nanotime to time the performance improvements
before and after. Verified correct behavior by coloring dirty
views differently in the go/web-hv tool and ensuring that the
hierarchies were emitted correctly for dirty and clean views.

Change-Id: I624572170bc914ed2c9d329e37e64a88203f87f4
2022-09-21 16:38:01 +00:00
Schneider Victor-tulias c4928df98b Merge "Update page index update logs" into tm-qpr-dev 2022-09-20 21:50:36 +00:00
Winson Chung a4512046cf Merge "Fix case of gesture being stuck when the Launcher is stopped mid-gesture" into tm-qpr-dev 2022-09-20 19:51:08 +00:00
Mady Mellor 78c899314e Add a button for floating tasks to taskbar (behind a flag)
Test: manual - build launcher3, enable the feature flag on tablet with
               a valid app installed, open an app, observe that there
               is NO button in taskbar because launcher3 doesn't have
               populated config
Bug: 237678727
Change-Id: Ic261608898eb9a9220cffacd0c6060a32c10a74f
2022-09-20 10:41:12 -07:00
Jeremy Sim 32efe203ea Merge "Update animations for TM-QPR: Home > OverviewSplitSelect transition" into tm-qpr-dev am: 5227613acb am: 768cb2cc1a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956354

Change-Id: I8efe44c29b39caeb9b61998ad8323f914c7a0a10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-20 16:33:38 +00:00
Jeremy Sim bddb9c8326 Merge "Fix small bug with DWB banners not animating out promptly" into tm-qpr-dev am: c3c4be206c am: e9a0d41e2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19984439

Change-Id: I55bfbddd983fe4fa5470f2056742cea6f681fd31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-20 16:32:49 +00:00
Jeremy Sim 5227613acb Merge "Update animations for TM-QPR: Home > OverviewSplitSelect transition" into tm-qpr-dev 2022-09-20 15:09:33 +00:00
Jeremy Sim c3c4be206c Merge "Fix small bug with DWB banners not animating out promptly" into tm-qpr-dev 2022-09-20 15:09:10 +00:00
Nicolo' Mazzucato 52909d0b5f Fix taskbar instrumentation crash
This was crashing when there were no views in the taskbar. Now, we're using getDragLayer, that will be always there.

Bug: 245690391
Test: TaskbarExpandCollapse
Change-Id: I4475adb0c6c425fca54af02bb071ed3e5f42d927
2022-09-20 14:01:40 +00:00
Jeremy Sim f3bfe4e156 Update animations for TM-QPR: Home > OverviewSplitSelect transition
This change updates the animation for initiating a split from the home screen. Also fixes a bug where icons were getting severely pixelated mid-animation.

Fixes: 236759099
Fixes: 244499770
Test: Manual
Change-Id: I56a76cbf286bd30540f3debdcb681d39c890a445
2022-09-19 22:02:54 -07:00
Jeremy Sim 2fbddc4949 Fix small bug with DWB banners not animating out promptly
This CL fixes an issue where initiating split select on a task with a DWB banner would result in the DWB banner sticking around long after the thumbnail itself fades, interfering visually with the rest of the animation.

Fixed by hiding all child views of the taskview when splitting, instead of just the thumbnail.

Fixes: 247257724
Test: Manual
Change-Id: I4dbeccf8dd28431749df5e78482e80aacf5df55a
2022-09-19 21:58:38 -07:00
Jeremy Sim cc895f0a31 Merge "Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition" into tm-qpr-dev am: 37f83cf246 am: 78a9e49933
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19936637

Change-Id: Ib8e854dc0cdbf63dd7e4f022c9c6acbb7a9486db
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-20 03:54:25 +00:00
Jeremy Sim 37f83cf246 Merge "Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition" into tm-qpr-dev 2022-09-20 02:55:46 +00:00
Schneider Victor-tulias f5c1242bee Update page index update logs
We are currently logging the wrong value, updating the logged value to getNextPage

Bug: 227514916
Test: manually checked logs
Change-Id: Ic1991644e1e52ba1b06e3f30e035577f01a46d4e
2022-09-19 21:37:56 +00:00
Jeremy Sim 72404a94ef Merge "Fix issue with Overview thumbnails appearing blank in certain situations" into tm-qpr-dev am: 3ad08cd2b8 am: 210d26d320
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19984956

Change-Id: Ib218c939f977da4ee0e3bbeaad8f9f39bc8d3056
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 21:11:26 +00:00
Jeremy Sim 3ad08cd2b8 Merge "Fix issue with Overview thumbnails appearing blank in certain situations" into tm-qpr-dev 2022-09-19 19:56:57 +00:00
Jeremy Sim a4ba516797 Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition
This change updates the animation for confirming a split.

Includes:
- New timings
- A new interface, SplitAnimationTimings, that centralizes timing values for splitscreen animations

Fixes: 241126570
Test: Manual
Change-Id: I61339964a7254618b368b17f00fda8f5efb53de4
2022-09-19 12:04:33 -07:00
TreeHugger Robot 8eed4f30a9 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev am: 69c04c21c5 am: ab6be24eec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19976255

Change-Id: Ie607c03fb5aa6ca01648ebfeeba10cecf2d3bf80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 18:30:23 +00:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Jeremy Sim 08a9bcac1f Fix issue with Overview thumbnails appearing blank in certain situations
This CL fixes an issue where canceling any Launcher animation by entering Quick Switch would cause Overview to appear with all thumbnail tiles blank.

The issue occurred because we recently added a reset() to Overview that triggered on all state transition animation cancels. This fixed some issues, but introduced this bug.

Fixed by tailoring the reset() to only fire on animation cancels within BaseRecentsView and FallbackRecentsView.

Fixes: 246232494
Fixes: 243471493
Test: Manual
Change-Id: I175a22d52597a63e164a6f3b9353c62b199b0712
2022-09-17 16:01:46 -07:00
Jeremy Sim 85397e333f Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev am: c528e7e818 am: 69a22b907f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19960985

Change-Id: I807a208f233234a6dd35ac6de5546fb0b824ccc5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 22:50:56 +00:00
Jeremy Sim c528e7e818 Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev 2022-09-17 21:45:24 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
Vinit Nayak d887b56183 Reset TaskView transformations on orientationHandler change
* Transformations in the old orientation handler
(ex. translate X for portrait) aren't reset when
device changes to fake landscape (starts modifying translate Y).
The new translations are picked up correctly, this resets the
old ones.

Test: Bug no longer repros.
Rotated device while scrolling through tasks, no change in
behavior from before.
Can't think of other instances where tasks are in motion
and orientation handler can change.
Fixes: 233316942

Change-Id: Ie07340e69a2c93b71b1dabb8029c96ad05a4d4a1
2022-09-16 16:45:50 -07:00
Jeremy Sim 7917ff31cc Fix two bugs with rotation in split select state
This CL fixes two bugs that were triggered by rotating in split select state:
1) Rotating in split select state will no longer cause a jittery animation to play
2) Initiating split from home, then rotating will no longer create extra split placeholders on screen

The bugs were present because handleSplitSelectionState() animated every state transition into SplitSelect, including SplitSelect > SplitSelect (which happens when rotating). This caused a jittery animation to play, and in certain cases, caused additional copies of FloatingTaskView and SplitInstructionsView to be created.

Fixed by auto-skipping animations for SplitSelect > SplitSelect, and by safely removing views when entering SplitSelect (to prevent duplicates).

Fixes: 242965515
Fixes: 243088958
Test: Verified visually on-device.
Change-Id: Iab813b1fe599bfdc550fe9a1d354b28cedb4b659
2022-09-16 15:28:33 -07:00
Hongwei Wang 2515a14429 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev am: 93f650d3e0 am: 334b1e0ee6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969480

Change-Id: I964f5f6c6984a4d2b5e1fa85fd6c480ea3cf568c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 20:37:07 +00:00
Hongwei Wang 93f650d3e0 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev 2022-09-16 19:26:33 +00:00
TreeHugger Robot 5a469bd163 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev am: af2fe7fd12 am: d7d05d1d7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967481

Change-Id: I3729ee399399d7bbea5e0569f132ce53690b45df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:52:21 +00:00
TreeHugger Robot af2fe7fd12 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev 2022-09-16 16:50:04 +00:00
Alex Chau fa83199e62 Turn off changing depth in wallpaper picker
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
2022-09-16 16:39:47 +08:00
TreeHugger Robot 1508328e72 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev am: 9fb4802a67 am: 3d021d46d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19975454

Change-Id: Ifa5a7419ff4a314b3ac1aaa9a90da6eb63d814df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 08:38:55 +00:00
TreeHugger Robot 9fb4802a67 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev 2022-09-16 06:23:07 +00:00