Commit Graph

12553 Commits

Author SHA1 Message Date
Alex Chau 950a10738b Fix STATE_DEPTH stuck at 1 after setting wallpaper
- Made BaseDepthController.setDepth/mDepth private, all get/set should be done through STATE_DEPTH or WIDGET_DEPTH
- Generified ClampedDepthProperty into Utilities.ClampedProperty to apply on STATE_DEPTH

Bug: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: I53cdedf970fd7ffba6a952c4edf4b34251b01f07
2022-10-18 17:07:17 +01:00
Thales Lima e9d4044483 Remove KtR workaround
Bug: 229947409
Test: m -j128 Launcher3QuickStep Launcher3QuickStepGo Launcher3 Launcher3Go NexusLauncherRelease NexusLauncherDebug SearchLauncherQuickStep SearchLauncher LauncherGoGoogle
Change-Id: I5792cc6b30dfa856747a1576ef3cb195952c25c7
(cherry picked from commit 51e164688e)
Merged-In: I5792cc6b30dfa856747a1576ef3cb195952c25c7
2022-10-18 13:06:23 +00:00
Vinit Nayak 392f8878cd Prevent restoring split selection state for fallback overview
* Add flag to explicitly not restore
OVERVIEW_SPLIT_SELECT
* FallbackRecentsView then resets state in
RecentsView if our endState is ever not split selection

Fixes: 253178217
Test: Used launcher developer option to
force use separate recents activity. Tested w/
3 button nav + gesture.

Change-Id: I26c9994bf853e9a005300a02aa143991958fc461
2022-10-17 17:52:16 -07:00
Vinit Nayak d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Vinit Nayak 391b79c084 Merge "Landscape 3 button nav on taskbar phone supported" 2022-10-17 20:14:36 +00:00
Schneider Victor-tulias e738336001 Fix missing screenshots on rotate from recents view select state
Rotating while in the recents view select state causes all taskview screenshots to disappear. Removing the transition to overview also fixes this, but leaves launcher in an incorrect state.

- Updated API to allow transitioning states without animation.
- Removed the animation to update the state correctly while keeping the ui working.

Fixes: 251067808
Test: rotated back and forth on large and small devices, before and after entering select mode
Change-Id: I5bf89ceb1f6b27cde9f7638f32fee3a78ad85ff6
2022-10-17 09:56:03 -07:00
Pat Manning 5889bc3729 Add launcher metrics for tracking kids nav mode change events.
Fix: 241762670
Test: wwdebug && wwlogcat
Change-Id: I24432f2cd0dddbcc5991645b60a1a8e91dc431e5
2022-10-17 14:06:38 +01:00
Cole Faust 50ec4afe25 Fix errorprone warnings that should be errors
This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: If17d2944bfd3e7ab10592a4c74c956203c356f81
2022-10-16 13:35:16 -07:00
Brian Isganitis 2d6371aa34 Implement overlay window for Taskbar EDU and All Apps.
Having EDU in the same window as Taskbar causes it to be above All Apps
and other system views such as the notification tray. This change
refactors the existing All Apps window to accomodate more AFVs so that
EDU can also exist in it.

Demo: http://shortn/_Qcki3gwvf7

Test: Manual
Fix: 232177330
Change-Id: I1bef31d798041a90a0c3e033e71be63898fa5fbc
2022-10-14 22:36:14 +00:00
Sebastián Franco 8f357c149e Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev am: 73b8ee9390 am: 5e8c248e1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20122918

Change-Id: I51de393340bf6fa5537a145a71ec9d46d4e2beff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 21:46:41 +00:00
Sebastián Franco 73b8ee9390 Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev 2022-10-14 20:43:34 +00:00
TreeHugger Robot 77041294ee Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: 6ccf536f94 am: 22b6d5112b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20164543

Change-Id: I37a6bdf3a792e1861d1e57b5f8b41fa3178a6885
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 19:49:27 +00:00
TreeHugger Robot 6ccf536f94 Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-14 18:42:05 +00:00
Zim 83776629df Disable Launcher AIDL_TAG tracing special case
Since we enable generate_traces by default for the system and
signature apps, we can remove this special case

Test: Manual
Bug: 161393989
Change-Id: Iff92c0a729a9b9b038fb6310c7509925c59547b6
Merged-In: Iff92c0a729a9b9b038fb6310c7509925c59547b6
2022-10-14 19:28:50 +01:00
Alex Chau 47a07bc704 Decouple taskbar background from overveiw scrim if taskbar is in overview
- Removed all forceHideBackground calls if taskbar would be in overview
- Make overview scrim transparent regardless of stash state if taskbar would be in overview

Fix: 234139692
Test: Go to overview from app with ENABLE_TASKBAR_IN_OVERVIEW on/off and taskbar stashed/unstashed
Change-Id: I29e811cb93894e6c9e7a75c0ea493719f15eeccb
2022-10-14 17:45:41 +01:00
Pat Manning 31cf44c48c Add launcher metrics for tracking kids nav mode change events.
Bug: 241762670
Test: wwdebug && wwlogcat
Change-Id: I5bf05ce1660078951896e0e331bbe74f8f2ebc5f
2022-10-14 16:24:32 +00:00
TreeHugger Robot 3b13487a07 Merge "Update taskbar state when launcher pauses" into tm-qpr-dev am: a1734ad12e am: 8d7387042f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20192617

Change-Id: I2f777edae7bf0c81b3eed62ba391a8f6d863fd02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 04:27:21 +00:00
TreeHugger Robot a1734ad12e Merge "Update taskbar state when launcher pauses" into tm-qpr-dev 2022-10-14 03:23:40 +00:00
Alex Chau 632e69b801 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev am: 41ab3f3e14 am: d8465a72cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20139153

Change-Id: I50ed52d8dca4108e57b6ed964e26da28227073d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 01:40:32 +00:00
Alex Chau 41ab3f3e14 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev 2022-10-14 00:31:32 +00:00
Evan Rosky 14145d131a Update taskbar state when launcher pauses
With shell-transit, we need to defer updating state when resumed
(until we commit a transient launch state); however, for pause
this isn't necessary. In fact, now that taskbar exists in overview,
we must update state on-pause since the taskbar is no-longer
already-closed.

Bug: 253473765
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep#testOverview
Change-Id: I347da03a211f5b2685f7b18666b2ebb93a1731ef
2022-10-14 00:11:25 +00:00
Nicolò Mazzucato 09fb35bfb0 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev am: 4afab0b210 am: c757108519
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175247

Change-Id: I0881823031d7bb1cd7188902e6c29d36f45a64c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 23:58:12 +00:00
Vinit Nayak 831a4f0e1d Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-13 23:22:38 +00:00
Nicolò Mazzucato 4afab0b210 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev 2022-10-13 23:06:50 +00:00
Vinit Nayak 0f6526e0c4 Improve TaskMenuView layouts for split pairs
* Instead of basing calculations on the TaskView view,
use the TaskThumbnailView as the anchor.
This helps us prevent having to re-calculate positions
that were already done to layout the thumbnails
* TODO: Gracefully handle re-positioning task menu view
on rotation

Bug: 249693334
Test: Manual, opening task menu view in
land/seascape in portrait, w/ and w/o home rotation

Change-Id: I02da96d2735657d5340e23056de69392ff8452c4
2022-10-13 14:15:14 -07:00
Alex Chau 3868775549 Merge "Only support manual stashing while in app" into tm-qpr-dev am: e966537123 am: 2104aac3bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20178104

Change-Id: I9f35db00fa8b4017207ad3ecaa3a3aa02a626ec2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 14:51:55 +00:00
Alex Chau e966537123 Merge "Only support manual stashing while in app" into tm-qpr-dev 2022-10-13 13:48:46 +00:00
Nicolo' Mazzucato 74c3a0024b Cancel unfold animation when rotation changes
In DeviceFoldStateProvider.kt, FOLD_UPDATE_FINISH_HALF_OPEN is emitted if the rotation changes while the animation is in progress.

 This targets the case when the device goes to tabletop mode during the transition.

+ Using RotationChangeProvider to fix problems when the new orientation change was received in a background thread unexpectedly. This fixes: (1) wrong launcher icons movement after the rotation, and (2) wrong dark overlay scrim after rotation.

+ Minor formattig fixes by ktfmt

Bug: 241743859
Test: DeviceFoldStateProviderTest && NaturalRotationUnfoldProgressProviderTest && manual stress testing
Change-Id: Iee234e4b832cad8298b69356fce7c14d75e89ccc
2022-10-13 09:16:44 +00:00
TreeHugger Robot 09b3d0609f Merge "Desktop tile that is a snapshot of desktop" into tm-qpr-dev am: 24dd3f57b2 am: 97c4e6d04d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20027847

Change-Id: I412f8cd5ce2fc3383e9f7f08e254ff42efddd78b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 21:51:23 +00:00
TreeHugger Robot 24dd3f57b2 Merge "Desktop tile that is a snapshot of desktop" into tm-qpr-dev 2022-10-12 21:10:16 +00:00
Evan Rosky 985f7de915 Revert^2 "Enable Shell Transitions"
2be4e88eda

Change-Id: I8cd0d125ecaa8201bf5d9c8e087f1c5c901e1fa0
2022-10-12 21:06:38 +00:00
Yein Jo 632468dc00 Merge "Revert "Enable Shell Transitions"" 2022-10-12 21:00:05 +00:00
Yein Jo 2be4e88eda Revert "Enable Shell Transitions"
Revert "Enable Shell Transitions"

Revert "Enable Shell Transitions"

Revert "Enable Shell Transitions"

Revert submission 19199517-enable_shell_transit

Reason for revert: DroidMonitor-triggered revert due to breakage, bug b/253049434 b/253109117 b/253181889 b/253271977
Reverted Changes:
I85f9565b3:Enable Shell Transitions
I75d0fe964:Enable Shell Transitions
I0565e423a:Enable Shell Transitions
I98bf8f0aa:Enable Shell Transitions

Change-Id: I6ad85a8f8168cdd40cb66eb58b9ea6a936bc2315
2022-10-12 20:57:48 +00:00
Alex Chau 38dae63910 Only support manual stashing while in app
- For taskbar in overview, don't allow stashing

Fix: 253042515
Test: With taskbar in overview, long press do nothing. Taskbar is still stashable in app
Test: Without taskbar in overview, taskbar still transform to nav handle in overview
Change-Id: I8f353a473a8570df72acda2338c4b984a69dc5c0
2022-10-12 18:16:50 +01:00
Sebastian Franco d468299c0f Moving the class LayoutParams to a file outside CellLayout
I'm moving the LayoutParams to another file to start the decoupling
of the Reorder outside of the CellLayout.

Also, I change the name from LayoutParams to LauncherLayoutParams to prevent confusion with ViewGroup.LayoutParams making it explicit that this are different LayoutParams.

Bug: 188081026
Test: atest ReorderWidget
Change-Id: I92251c5540ffcf5ece7b933e6f6c836eb825c997
2022-10-12 16:14:42 +00:00
Evan Rosky 3ecceb8680 Merge "Enable Shell Transitions" 2022-10-12 16:08:27 +00:00
Pat Manning de2aefe5d6 Merge "Use wm shell splash screen animation to reveal app after tasks have appeared." into tm-qpr-dev am: a283b551d2 am: e793bac632
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19886384

Change-Id: I6474fc429e326bfedad7813b5b11ad5aa217492e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 11:55:47 +00:00
Pat Manning a283b551d2 Merge "Use wm shell splash screen animation to reveal app after tasks have appeared." into tm-qpr-dev 2022-10-12 11:34:41 +00:00
TreeHugger Robot 61d513fa56 Merge "First pass at Taskbar layout UI polish for SUW" into tm-qpr-dev am: 5c4b6b50d7 am: dd1a143a29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20086056

Change-Id: I75f2750949b10f690f1210fef85aeb98342f4452
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 03:37:39 +00:00
TreeHugger Robot 5c4b6b50d7 Merge "First pass at Taskbar layout UI polish for SUW" into tm-qpr-dev 2022-10-12 02:27:37 +00:00
TreeHugger Robot 1bfe930931 Merge "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly." into tm-qpr-dev am: 1337b31b3f am: 997edd2dad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20076231

Change-Id: I04ee6b7e1cd23991f46c28395471ecbaebc86424
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 01:22:52 +00:00
TreeHugger Robot 1337b31b3f Merge "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly." into tm-qpr-dev 2022-10-12 00:17:33 +00:00
Vinit Nayak 2081742cb7 First pass at Taskbar layout UI polish for SUW
Bug: 231906478
Change-Id: I5d55d1e33f928d4b8034c356565a0f9d8bc5c3fb
2022-10-12 00:04:27 +00:00
Schneider Victor-tulias a0be92c830 Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly.
Bug: 244593270
Test: Manually checked logs
Change-Id: Ie6d0395a45a025d1562a722154d3dd3b42618ccc
2022-10-11 15:12:13 -07:00
Brian Isganitis 56d4571bbf Merge "Move recents controller to end of params for easier merging." 2022-10-11 20:53:44 +00:00
Alex Chau de1d8456d3 Merge "Fix positioning of split instruction and share targets with taskbar in overview" into tm-qpr-dev am: e2791f0cf6 am: 94183eeaf9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20132885

Change-Id: I67023a798eeba419834cdc91a89b3dc2e3b9aee1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 15:05:01 +00:00
Alex Chau e2791f0cf6 Merge "Fix positioning of split instruction and share targets with taskbar in overview" into tm-qpr-dev 2022-10-11 14:04:57 +00:00
Alex Chau 0733ebd3c1 Run setCurrentPage in applyLoadPlan after scroll initialized
- Also combined the 2 setCurrentPage call in applyLoadPlan into 1
- Otherwise setCurrentTask may set to page 1 unexpectedly due to page 0's scroll being invalid and out of range

Bug: 246283207
Bug: 238461210
Test: Split screen with 2 apps, click back, go to overview again, should snap to focsued task
Change-Id: I3b57655c810668fe244659437fbd4a745ca02d21
2022-10-11 12:36:35 +01:00
Brian Isganitis 67c20e0d99 Move recents controller to end of params for easier merging.
Test: Compiles
Fix: 252899814
Change-Id: I7c6a464b0d6b40bbda9b4fae3da153629e4346dc
2022-10-10 17:48:51 -07:00
Ats Jenk 3c59d9b345 Desktop tile that is a snapshot of desktop
Create a desktop recents tile that shows a snapshot of the freeform
tasks running on desktop.
Scales them down and positions them in the same location as they would
be on the desktop.

Bug: 244348395
Test: manual
Change-Id: Ieb5830a331691844769003189f557c4b7e4cd35c
2022-10-10 15:50:31 -07:00