Commit Graph

12553 Commits

Author SHA1 Message Date
TreeHugger Robot 602ef0772d Merge "Add logs to aid missing unfold animation on launcher investigation" into tm-qpr-dev am: db8b97068b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20637474

Change-Id: I30d189b40676bdc62f4c5d8fa243eae9b10b23d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 19:24:07 +00:00
TreeHugger Robot db8b97068b Merge "Add logs to aid missing unfold animation on launcher investigation" into tm-qpr-dev 2022-12-07 19:06:21 +00:00
Ats Jenk 8f5b9dd833 Check for both proto flags for common logic
Desktop mode has prototype 1 and prototype 2.
Check for both flags when logic is shared.

Bug: 260645044
Test: manual, check desktop mode 1 works
Change-Id: I40e84440222a9d5f007c2450606cd7c8f9628da2
2022-12-07 10:12:37 -08:00
Luca Zuccarini 43e3d45042 Update timings for the Home <> All Apps transition.
Also updates some interpolators to make the manual and atomic
transitions more homogeneous.

Also also updates the commit point so it matches the transition point
between the two states exactly.

Note: the background scale is currently too much, and it needs to be 1/3
of the total distance to match the Workspace scaling. To do this, we
simply scale down the depth by a factor of 3 when calling the background
zoom-out API in the DepthController.

Bug: 254835725
Test: see videos in bug

Change-Id: I605546921e9ee4dfc852794c56495c72f0b916e1
2022-12-07 13:12:16 +00:00
Andy Wickham 0adad24408 Adds header protection on tablet all apps panel.
Removes background and manually draws it while drawing scrim. Then
draws header protection on top as needed.

Currently this only applies to all apps from Launcher, as Taskbar
doesn't seem to use the same scrim flow. So taskbar adds the same
static background that was previously used.

Demo videos: https://drive.google.com/drive/folders/11PyFsrLV6-QhU_E-zD3s5bfzZK2nOU87?resourcekey=0-E41uw5TP9xuqTifLAs71yw&usp=sharing

Test: Manually on phone and tablet with dark/light mode, floating
search bar on/off, work profile present/absent, taskbar/home entry
Bug: 240670050

Change-Id: I81dcc956d9dbbc7552c8a227a49741bcf71eed71
2022-12-06 18:31:33 -08:00
Tony Wickham 9672a48111 Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev am: ef8677169c am: c9740c89aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20622942

Change-Id: I10bd52418d769a97521ab318fcf5c7328c073943
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 20:30:22 +00:00
Nicolo' Mazzucato 1ee66e943a Add logs to aid missing unfold animation on launcher investigation
Bug: 261320823
Test: Manual
Change-Id: If714750c85ee49e66e21462ab9d2675ab0be8b55
2022-12-06 13:06:01 +00:00
Tony Wickham c9740c89aa Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev am: ef8677169c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20622942

Change-Id: Ia758acdad42c8f95b9ee52d37d0bf7a3f2c63e80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 06:29:09 +00:00
Tony Wickham ef8677169c Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev 2022-12-06 06:12:23 +00:00
Tony Wickham 7286c5be98 Add feature flag to force taskbar to be persistent.
This will allow us to test taskbar pinning before the entrypoint for
such a setting is finalized.

Test: manual, TODO: will need to update TaplTestsTaskbar to account for
this mode
Flag: FORCE_PERSISTENT_TASKBAR [off]
Bug: 258604917

Change-Id: I4535978563ffbe9a6cc6ece7720cdb75e787ff44
2022-12-06 00:51:46 +00:00
TreeHugger Robot 036fe83e63 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev am: c4d6dee069 am: f77ad4afd4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20555112

Change-Id: Ia4e2a6627346fd949a7001c5bbdddbe3f41bb474
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 21:46:08 +00:00
TreeHugger Robot f77ad4afd4 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev am: c4d6dee069
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20555112

Change-Id: I5907940eac2de90c913e1d8ed965b35f013815f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 21:13:20 +00:00
TreeHugger Robot c4d6dee069 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev 2022-12-05 20:25:47 +00:00
Shan Huang 2f7f5ec3dd Merge "Rename BackEvent to IBackEvent in LauncherBackAnimationController." 2022-12-05 19:38:38 +00:00
Schneider Victor-tulias 65dda6d03e Cancel gestures on launcher destroy
A wide variety of gesture navigation bugs were caused if launcher happened to be recreated mid-gesture and we didn't handle it gracefully. Updated lifecycle callbacks to immediately cancel the ongoing gesture if launcher is destroyed.

Fixes: 244593270
Fixes: 257976590
Test: forcefully(programmatically) recreate on every other gesture nav handle touch down; check that following gestures are not broken and animations are not frozen
Change-Id: Ia8e936e26a42cfe26fc6bcd9eefb25d37bc08749
2022-12-05 08:11:50 -08:00
Sebastián Franco c3de48a1fc Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev am: fba141a3dc am: e8786a176d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20611319

Change-Id: I4af5bb8a74b14a98fdc1a54d7a1986258e553b97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 02:14:59 +00:00
Sebastián Franco e8786a176d Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev am: fba141a3dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20611319

Change-Id: Idb38e0a166a18455a2bed40822c0ed8547359b8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 01:59:43 +00:00
Sebastián Franco fba141a3dc Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev 2022-12-03 01:32:25 +00:00
Brian Isganitis bd243ad674 Merge "Reduce top padding of Taskbar's All Apps tray." into tm-qpr-dev am: a5953002d4 am: 658905ee9f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20579485

Change-Id: If97b283fef552753f6a5add4a692ccda2ef0798c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 22:26:45 +00:00
Brian Isganitis 658905ee9f Merge "Reduce top padding of Taskbar's All Apps tray." into tm-qpr-dev am: a5953002d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20579485

Change-Id: I2b9f37784bf89d7249d239b1575c00124c838ac1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 21:53:45 +00:00
Sebastian Franco 2ceb3b5088 Adding screen ID parameter in CellLayoutLayoutParams
Bug: 188081026
Test: launcher compiles, this test doesn't change existing logic only the model
Change-Id: I7bcf6452d5ecb9b50914defc311ad06839220c92
2022-12-02 13:40:34 -08:00
Brian Isganitis a5953002d4 Merge "Reduce top padding of Taskbar's All Apps tray." into tm-qpr-dev 2022-12-02 21:10:55 +00:00
Jon Miranda 36c8093a4a Merge "Add transient taskbar sizing for twoPanel devices." into tm-qpr-dev am: 01e90b7787 am: 9c053594e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20613321

Change-Id: Ia185a4d3e1eb014109842c37fe5f30e746ba7bfd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 20:03:28 +00:00
Jon Miranda 9c053594e9 Merge "Add transient taskbar sizing for twoPanel devices." into tm-qpr-dev am: 01e90b7787
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20613321

Change-Id: Id47761c23154fe04e0cb1a5c1e7807ad02c22f1b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 19:29:06 +00:00
Jon Miranda 01e90b7787 Merge "Add transient taskbar sizing for twoPanel devices." into tm-qpr-dev 2022-12-02 18:58:08 +00:00
TreeHugger Robot e5b7e43dab Merge "Removing SearchActionItemInfo" into tm-qpr-dev am: cfa199537b am: d48a078c78
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20537169

Change-Id: If4a0f59f32b7b2e74313ac1076abbcdaf74ab96b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 18:22:31 +00:00
TreeHugger Robot d48a078c78 Merge "Removing SearchActionItemInfo" into tm-qpr-dev am: cfa199537b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20537169

Change-Id: I8345c99ddf6fd22802f0c4ca0ed8ca56ee263f2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 17:45:52 +00:00
TreeHugger Robot cfa199537b Merge "Removing SearchActionItemInfo" into tm-qpr-dev 2022-12-02 17:31:25 +00:00
TreeHugger Robot 7b7253db66 Merge "Fade in/out taskbar when launching apps from or back to AllApps/-1" into tm-qpr-dev am: c10a003aa0 am: 979fa6725c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411894

Change-Id: I8afb35dee1feb91b2b27563efd1c58efc51d97c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 13:04:33 +00:00
TreeHugger Robot 979fa6725c Merge "Fade in/out taskbar when launching apps from or back to AllApps/-1" into tm-qpr-dev am: c10a003aa0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411894

Change-Id: Idbed5a030b1e000a250c1a59446553ab7b4dc73d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 12:28:57 +00:00
TreeHugger Robot c10a003aa0 Merge "Fade in/out taskbar when launching apps from or back to AllApps/-1" into tm-qpr-dev 2022-12-02 11:40:25 +00:00
Jon Miranda 6ab0bc6d76 Merge "Fix window x-axis movement after gesture ends." into tm-qpr-dev am: 12053e958f am: fb6fe0ce82
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590521

Change-Id: I8c2ae63af9a2c768e3cc586ce808775fbec62c15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 03:31:14 +00:00
Vinit Nayak f8c0da187c Merge "Update for stashed taskbar animation" into tm-qpr-dev am: 18d5634176 am: a5bb63d39a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470413

Change-Id: Icd28b632d9df39cca246024e76ca232b16492428
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 02:47:06 +00:00
Jon Miranda a4aaf1aced Add transient taskbar sizing for twoPanel devices.
Bug: 259712417
Test: on two panel device, on tablet device
Change-Id: Iae273b6bbfb254288c234aa5882f39eb0b6a88b1
2022-12-01 16:28:29 -08:00
Jon Miranda fb6fe0ce82 Merge "Fix window x-axis movement after gesture ends." into tm-qpr-dev am: 12053e958f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590521

Change-Id: Ia8007f6d5d36d59292cf53233f20c244322099aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-01 20:21:15 +00:00
Jon Miranda 12053e958f Merge "Fix window x-axis movement after gesture ends." into tm-qpr-dev 2022-12-01 20:03:57 +00:00
Vinit Nayak a5bb63d39a Merge "Update for stashed taskbar animation" into tm-qpr-dev am: 18d5634176
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470413

Change-Id: I641cdf68d3e3b58e9ce77a12d16082d55297d4b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-01 19:47:32 +00:00
Vinit Nayak 18d5634176 Merge "Update for stashed taskbar animation" into tm-qpr-dev 2022-12-01 19:26:11 +00:00
Alex Chau cd76ac24b6 Fade in/out taskbar when launching apps from or back to AllApps/-1
- Added isHotseatIconTopWhenAligned to control both iconAlignment and stash animation to just fade in if hotseat icon isn't on top of the screen in the aligned state

Fix: 257355864
Fix: 213455090
Test: Launch apps from/back to home, taskbar animate from/to hotseat
Test: Launch apps from/back to AllApps/-1, taskbar fade in/out
Test: Repeat aboth with transient or persistent taskbar
Change-Id: I6bdae615ff9e199d23cbfe2d26c8d46a08fbc436
2022-12-01 18:56:30 +00:00
Brian Isganitis deac0d529a Reduce top padding of Taskbar's All Apps tray.
The top padding looks too high because the code is assuming we have a
search bar at the top of the bottom sheet. Until we implement search, we
should temporarily reduce padding for the taskbar implementation.

Before:
  - No tabs: https://screenshot.googleplex.com/AAPdR5nbwepWQ82.png
  - Tabs: https://screenshot.googleplex.com/3DnQp6PKhqXyRag.png

After:
  - No tabs: https://screenshot.googleplex.com/A8enwnSs8r78ccj.png
  - Tabs: https://screenshot.googleplex.com/A3fAy2bXgmSPrG9.png

Test: Manual
Bug: 216683257
Change-Id: Ie0837acc3aed162b9428a209962be2a102c515c8
2022-12-01 00:21:28 +00:00
Vinit Nayak 3b1f5849ce Update for stashed taskbar animation
* Strangely if you swipe up with a split pair
and then tap on the live tile to go back to
fullscreen this animates fairly correctly.
However, if you drag the focused pair back to fullscreen
the bottom app does not unclip as expected

Bug: 219411750
Test: Swipe up w/ stashed taskbar in portrait.
Thumbnail cutout doesn't appear when dragging to
fullscreen

Change-Id: Ia6e7aae10389d9fefa4adbfce540171bbe0a9180
2022-11-30 11:56:40 -08:00
Sunny Goyal 9a616213e1 Removing SearchActionItemInfo
> Instead introducing an interface for handling click events
> Linking this interface to other UI which handle clicks

Bug: 259733681
Test: Presubmit and verified manually
Change-Id: I9cbf2d009d64254f513deb909a151e46e860d039
2022-11-30 10:59:07 -08:00
Tracy Zhou 08d9e33a38 Animate split confirmation after second app selection from workspace am: c91ef50257 am: e69081984b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20556280

Change-Id: I2bc2597380955929566799b9d6a8a77ba00fe348
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 08:52:42 +00:00
Tracy Zhou e69081984b Animate split confirmation after second app selection from workspace am: c91ef50257
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20556280

Change-Id: Id2591ad19fe0164027d514417457ca4b2bda97b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 08:23:30 +00:00
Tracy Zhou c91ef50257 Animate split confirmation after second app selection from workspace
Fixes: 239824922
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/099acb31-1e05-4d00-a670-590c177a846e
Change-Id: Ifb769afcaf694a1157444f273da69331db15ab1a
2022-11-30 03:39:02 +00:00
Tracy Zhou 3f24a03df7 Merge "Correct onActionDown trackpad offset values" 2022-11-30 02:53:23 +00:00
Vinit Nayak 5b625f32ac Merge "Send corrent SUW insets for taskbar portrait vs landscape" into tm-qpr-dev am: 792a827309 am: 5d84ac3640
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546386

Change-Id: If3ffeb06fa79a1c6d135c2c6bd2cf4cba4a0ba48
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 01:44:02 +00:00
Vinit Nayak 5d84ac3640 Merge "Send corrent SUW insets for taskbar portrait vs landscape" into tm-qpr-dev am: 792a827309
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546386

Change-Id: Ifb13e200987d1a3475c1116589d87c57376c8179
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 01:13:40 +00:00
Vinit Nayak 792a827309 Merge "Send corrent SUW insets for taskbar portrait vs landscape" into tm-qpr-dev 2022-11-30 00:50:51 +00:00
Jon Miranda 3d748c3a7f Merge "Allow touches on transient taskbar if ime is present." into tm-qpr-dev am: 912e6dd64d am: 1c96b6584c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20544543

Change-Id: I3ef3c9ed96db3cb36f99d3dd465e88513a4c00ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-29 23:35:23 +00:00