Commit Graph

785 Commits

Author SHA1 Message Date
Treehugger Robot bf044d730c Merge "Move InstantAppResolver to Dagger." into main 2025-04-18 18:06:15 -07:00
Andy Wickham 303b52f84a Merge "Make TaskbarOverlayContext overrideable." into main 2025-04-18 15:02:50 -07:00
Anushree Ganjam 59d5401f59 Move InstantAppResolver to Dagger.
Helps us to delete ResourceBasedOverride class.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9320e0309e2ae4370dcbf2f6f62d704712876bd5
2025-04-18 20:14:14 +00:00
Andy Wickham 33c7b3dcf1 Make TaskbarOverlayContext overrideable.
Bug: 371343636
Flag: EXEMPT refactor
Test: with other change
Change-Id: I46c4bcb88d21890e66e7db7240d3450d75d74354
2025-04-18 01:24:56 +00:00
Andy Wickham 51a0a3829a Update All Apps colors to use shared sysui resources.
This includes the new scrim color and panel treatment documented
here: https://docs.google.com/presentation/d/1BKFfB2LAIDoaA5aLs8did6IcUw_pktrSWI5xmypkl3s/edit?slide=id.g3484dcfffc6_1_203&resourcekey=0-HpXwztiEYGe0BYQzUeBBbQ#slide=id.g3484dcfffc6_1_203

Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I810aaa84eda218ab33112c9a5c1561cdb088b310
2025-04-17 19:14:18 +00:00
Andy Wickham 16a024df71 Adds Blur and BlurFallback styles for All Apps.
Technically these styles can be used throughout Launcher, e.g.
Widget Picker and Folders, but this CL only applies it to All Apps.

At a high level, views wishing to apply transparency to show blur
should use these new attr values rather than colors directly.

When blur changes, e.g. starting or stopping battery saver, the
style is re-applied and revelant views are invalidated. For
Launcher, this is handled by DepthController, and for Taskbar it's
handled by a CrossWindowBlurListener.

Also updated the Private Space animation slightly to account for
the translucent decorators (specifically, we can't use the mask
view to cover them when blur is enabled).

Screenshots: https://drive.google.com/drive/folders/1tU472KHotgEBpT-Ec9VOBWPBf_YdVqv2?resourcekey=0-ebf7W8O6iDJ4UVMtRzTABg&usp=sharing
Private Space animations: https://drive.google.com/file/d/1h5pn8Xb17TPcbujr7uSAJNTq8kwNZoIp/view?usp=drive_link&resourcekey=0-TzpaJ16Gg8_QJctBx4oiIg
Private Space QS Tile animations: https://drive.google.com/file/d/1dCuqnqd5z2kSBEakGobMlEkMwFDBWRbJ/view?usp=drive_link&resourcekey=0-qRVFPb-a6OzaZQOf4x86Jw

Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ia9f581f50d1adc0830569656bdeb751deb710a9c
2025-04-15 16:42:56 -07:00
Saumya Prakash 178b49beb3 Merge "Remove the skip button from the gesture tutorial" into main 2025-04-15 15:29:37 -07:00
Saumya Prakash ebfcad524b Remove the skip button from the gesture tutorial
This change removes the legacy skip button from the gesture tutorial. It
is not needed in the current version of the gesture tutorial.

Bug: 400485351
Test: Run tutorial and observe no change as this was for the legacy
tutorial that is no longer in use.
Flag: EXEMPT bugfix

Change-Id: Ice384a0b5811fdc0d09da58ade68539aa146d84d
2025-04-14 23:35:10 +00:00
Brandon Dayauon b570514ee0 Merge "Add nudgeView to Taskbar.xml" into main 2025-04-11 16:28:59 -07:00
Brandon Dayauon 1fc6f916d3 Add nudgeView to Taskbar.xml
Aiai will send a broadcast to Launcher and will animate the stashHandleView and nudgeView accordingly.
Verified on large screen device that transient taskbar is not affected as its not in scope at the moment.

bug:409121556
Test: manual - video in bug
Flag: com.android.launcher3.nudge_pill

Change-Id: I740e5d81dd008a230aa089f311d38bac665fc227
2025-04-11 13:24:22 -07:00
Sam Cackett bf69d6e6a5 Merge "Add TaskContentView wrapper to TaskThumbnailView" into main 2025-04-09 23:54:40 -07:00
Brian Isganitis 8c6dd04740 Merge "Expose desktop experience CD Taskbar flag to SecondaryDisplayLauncher." into main 2025-04-09 13:33:40 -07:00
samcackett 2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Brian Isganitis b7a5dc0017 Expose desktop experience CD Taskbar flag to SecondaryDisplayLauncher.
Flag: EXEMPT refactor
Fix: 407924023
Test: go/testedequals
Change-Id: I06344f023eb1fab697f25276bc82e1be0209e4a8
2025-04-08 17:17:15 -04:00
Schneider Victor-Tulias 02d9e5043a Fix grammar issue with all set page subtitle
Flag: EXEMPT bug fix
Fixes: 392616062
Test: launched all set page with empty and test devices names
Change-Id: I885603f64478642c825e15563f5526399114f0f2
2025-04-08 10:31:19 -04:00
Jordan Silva 434e4931a3 Merge "Update Overview buttons styles and layout" into main 2025-04-03 13:48:07 -07:00
Jordan Silva f99a50c2e4 Update Overview buttons styles and layout
This CL update the style of Overview Buttons to support Wallpaper Blur feature.
- Overview action button background, padding and spacing updated.
- Clear all button style updated to match action buttons.
- Select button drawable updated.

Bug: 404479758
Fix: 407665072
Flag: com.android.launcher3.enable_overview_desktop_tile_wallpaper_background
Test: OverviewImageTest
Change-Id: I89b781928c4b49155df9dfb5af5e81775ab5b87b
2025-04-02 11:59:25 -07:00
Jagrut Desai 75a26fc793 Merge "Set Content Description for Taskbar edu animation view" into main 2025-03-31 14:55:28 -07:00
Treehugger Robot b40c6b9fb3 Merge changes from topic "update-marquee-chip" into main
* changes:
  Fix chip elevation when expanded
  Update marquee to show only when chip is expanded
2025-03-28 16:53:28 -07:00
Jagrut Desai ef2a69715c Set Content Description for Taskbar edu animation view
Test: Manual, Presubmit
Bug: 400902721
Flag: EXEMPT bugfix
Change-Id: I318e36720a507f1328aaf856c75c8d837dd6b8fa
2025-03-28 14:44:37 -07:00
Jordan Silva 612aac88cb Update marquee to show only when chip is expanded
- Introduced title and titleCollapsed to change the text when expanded and collapsed using only 2 dots for truncate the text, similar to ellipsize="marquee".

- Removed ellipsize="marquee" from the XML to prevent chip relayout when entering in Overview. See b/406969521.

Fix: 406969521
Fix: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ia95eb8b7ec6d22b9d576defe7c66a4950ee1dca3
2025-03-28 14:28:54 -07:00
Liran Binyamin 036e1ae8d5 Updates to bubble bar drag zones
1. Pass bubble bar size properties to DragZoneFactory for generating
   a drop target for the bubble bar.
2. Update the dismiss X circle position.

Flag: com.android.wm.shell.enable_bubble_to_fullscreen
Fixes: 404920503
Fixes: 404916611
Test: manual
       - turn enable_bubble_to_fullscreen flag on
       - drag the bubble bar and an individual bubble through the
         dismiss zone
       - observe behavior
       - repeat with flag off to verify existing behavior
Change-Id: I877648763e3043551f678e382abd97c7e625b483
2025-03-27 14:30:55 -04:00
Treehugger Robot b932dea54e Merge "Implement spring animations for running state changes." into main 2025-03-26 21:06:14 -07:00
Jordan Silva 8134ad2b53 Use a specific dimension for the overview app chip menu bottom margin
Fix: 401476868
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Id6932958bd694f28fdad4004946106a28f726cb2
2025-03-26 09:12:54 -07:00
Li Lin 4a947f8209 Growth Framework nudge resource changes.
These resources changes will be used in a follow up CL that implement
the nudge view.

Note that most of the values and layout are temporarily placeholder and  subject
to change in follow up CL as the mock is being finalized.

Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I1d88da404637200b44bd2a3a5719f52d68011fbf
2025-03-25 19:58:52 -07:00
Alex Chau 7034889756 Revert "Remove redundant FrameLayout from task_header_view.xml"
Revert submission 32215257-b/401469907-remove-redundant-headerview-layout

Reason for revert: b/403826044, b/402277471

Reverted changes: /q/submissionid:32215257-b/401469907-remove-redundant-headerview-layout

Change-Id: I5c619179c849f8b65484937ed0c37623612316f8
2025-03-20 11:11:00 +00:00
Priyanka Advani (xWF) 92aef0d99a Revert^3 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit bca368924c.

Reason for revert: Droidmonitor created revert due to b/404894013. Will be verifying through ABTD before submission.

Change-Id: If43e23bca9f7e62f26ee3c977cac643fcda3e3e6
2025-03-19 12:56:55 -07:00
Brian Isganitis c0a8f7ea99 Implement spring animations for running state changes.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 402683858
Test: go/testedequals
Change-Id: Icc4a3a61b6c0997564a4dcdd8eb7768459d5f2ef
2025-03-19 14:34:13 -04:00
Sam Cackett bca368924c Revert^2 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit 1048b2711c.

Reason for revert: Reland CL with fix

Original message:
Inflate TaskThumbnailViewDeprecated as TaskContentView

If the enableRefactorTaskThumbnail is false, then inflate
TaskThumbnailViewDeprecated as TaskContentView so that the behaviour
matches the previous pre-factor behaviour

Fix: 402277471
Bug: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual. See bug

Change-Id: Ib43331023d99316c7b0c9de2ab81e379db58bb50
2025-03-19 10:05:25 -07:00
Sunny Goyal d7a1c17988 Merge "Moving LauncherAppWidgetHolder to dagger" into main 2025-03-17 10:42:15 -07:00
Mady Mellor 3894947741 Merge "Update dragged elevation to use shared value (at 3dp)" into main 2025-03-14 16:10:01 -07:00
Jagrut Desai 56a8bf548f Merge "Taskbar Icon changes" into main 2025-03-14 14:29:08 -07:00
Sunny Goyal 66916cda10 Moving LauncherAppWidgetHolder to dagger
This would allow customizing the widget holder in LauncherPreview

Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
2025-03-14 14:19:29 -07:00
Mady Mellor 609f2b3143 Update dragged elevation to use shared value (at 3dp)
- Had to bump elevation of drop target so need to bumpe elevation
  of dragged views

Flag: com.android.wm.shell.enable_bubble_anything
Test: manual / visual - drag a bubble or drag expanded view and observe
                        the drop targets
Bug: 403276099
Change-Id: I15a1deb055c590b1f46261fcc307120fcb685c08
2025-03-14 13:56:29 -07:00
Jagrut Desai 4fe0b79fde Taskbar Icon changes
Test: Manual
Bug: 379158656
Flag: com.android.wm.shell.enable_gsf
Change-Id: Ic4ec9a7c634231c2592cfcd6ba6c8f8252c2dd98
2025-03-14 09:26:32 -07:00
Treehugger Robot 64927397af Merge "Fix KQS arrow button padding" into main 2025-03-14 08:14:16 -07:00
Toni Barzic 3c07c2156f Fix KQS arrow button padding
The padding values were set to their totals.
They needed to be halved.

Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: None
Change-Id: Icae56e02fa6082b7f99b9fef265d6220b613d06b
2025-03-14 04:58:38 +00:00
Treehugger Robot 9b577bc9b5 Merge "Mark KQS arrow strings translatable" into main 2025-03-13 12:41:19 -07:00
Toni Barzic 026306b793 Mark KQS arrow strings translatable
Bug: 397975686
Flag: EXEMPT bugfix
Test: None
Change-Id: I3911a7c9b9cd19388934355e684941acc27a1c01
2025-03-13 10:17:31 -07:00
Treehugger Robot 6fcd77c19a Merge "Update KQS task view borders" into main 2025-03-12 12:21:08 -07:00
Treehugger Robot f0e0e8b7ec Merge "Remove redundant FrameLayout from task_header_view.xml" into main 2025-03-12 11:31:52 -07:00
Andy Wickham ccb3a5c25c Adds all_apps_blur flag.
This enables blur both for Taskbar and Launcher, but in slightly
different ways.

For Taskbar All Apps, we apply blur to the overlay window, and
for Launcher All Apps, we utilize the existing DepthController to
blur the wallpaper window. For similicity, we currently fade out
workspace/hotseat to avoid awkward view + window blurs which
don't look that good. This is not the POR, but I think it achieves
most of the effect and will help us get some blur exposure.

Separately I will continue to investigate options such as blurring
workspace in a clever way so it feels blended with the wallpaper,
reusing the Taskbar window and connecting it to LauncherState, or
using a SurfaceView (though I spent quite some time trying this and
it seemed the same as the original issue).

In both cases, we use a 20-30% opacity scrim with a set color, and a
panel that blends 40% opacity of a dark/light color with 10% white.

Also updated some incorrect isTablet checks which really should have
been checking shouldShowAllAppsOnSheet(), which includes the
all_apps_sheet_for_handheld flag.

Demo: https://drive.google.com/file/d/1Ov9Dg3R9YHNfisfxNf97ZIhlDeEA1IWj/view?usp=sharing&resourcekey=0-l_SDpqpS4HtOb10a3b_jNg

Other upcoming improvements: interpolator tweaks, colors of things
inside the app panel (tabs, private space, search results, etc).

Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic7063cd822f39a5977715b5477f825bf11e57bdf
2025-03-11 23:34:03 +00:00
Toni Barzic 94db320a84 Update KQS task view borders
Updates border color to have more contrast to the background, and adds
2dp padding between the border and the task content view - done by
updating BorderAnimator not to assume the border width and stroke are
the same.

Adding padding between the border and task view content exopsed an issue
where the second thumbnail in a split task's borders were not clipped
correctly when adding a border (it looked like the clip rect was not
properly scaled down). This is addressed by moving the tack view
background (and the outline) from the root KeyboardQuickSwitchTaskViews
to the content views (i.e. moving the outline to the view that does not
get scaled when adding a border, and having the second thumbnail end
edge of the clip rectangle match the clip rectangle of the clipped
ancestor view).

Bug: 398770098
Test: Manual
Flag: EXEMPT (a11y) bug fix

Change-Id: Ie058c932411a6b47815b0abf756f739c55b8342f
2025-03-11 22:00:59 +00:00
samcackett d88fb62c4d Remove redundant FrameLayout from task_header_view.xml
Move feature flag logic to the state mapper

Fix: 401469907
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest
Change-Id: Ic6ee5bef438ae2782816f526b003e1fb91992065
2025-03-11 16:49:52 +00:00
Treehugger Robot a6533ae04b Merge "Improve KQS accessibility" into main 2025-03-10 12:49:00 -07:00
Toni Barzic 394d5e0010 Improve KQS accessibility
Adds accessible pane name, and content description for keyboard quick
switch view. Improves content description for task views, by having it
provide the task position in the task list. Also, sets a task content
description immediately when it gets associated with a task, even if the
task description is not available at the time. Accessibility focus for a
task may be requested as the KQS view is shown, so the task view should
have a meaningful content description from the start.

While here, update KQS to focus first task  by default when opened from
taskbar.

Bug: 399032757
Test: Manual, with Talkback enabled - open KQS via taskbar overflow view,
      and Alt+Tab, and verify Talkback announcements are informative
      (e.g. no "Pixel launcher" utterance).
      Also atest NexusLauncherTests:TaplTestsKeyboardQuickSwitch
Flag: EXEMPT bug fix

Change-Id: I3688954ab383035c1db35c5eb7a0ddf9a39a123f
2025-03-10 17:35:04 +00:00
Brian Isganitis 26f9468db1 Animate changes in Taskbar recents indicators.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 356394053
Test: go/testedequals
Change-Id: Ic018695254bbfea11469c3579e242089b00b90f5
2025-03-07 15:47:48 -05:00
Wen-chien Wang 8444f38c92 Merge "pin-shortcut: Tracks hotseat states and adds unpin option for taskbar" into main 2025-03-03 16:50:48 -08:00
Treehugger Robot 51a3a87b14 Merge "Arrows to scroll recent tasks in KQS" into main 2025-03-03 16:44:25 -08:00
Mykola Podolian c095f8b318 Merge "Added accessibility action to move taskbar icon to the bubble bar" into main 2025-03-03 10:31:03 -08:00