Commit Graph

13428 Commits

Author SHA1 Message Date
Schneider Victor-tulias 7232569baf Merge "Remove old logs associated to b/200572078" 2022-02-25 21:03:31 +00:00
Adam Cohen d99230439f Merge "Fix DnD logic for determining current drag screen / panel" into tm-dev am: 28890edfe3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17008136

Change-Id: I9cba5ae69b0a464cd090505812914ae92e83f0d4
2022-02-25 20:29:51 +00:00
Schneider Victor-tulias c4240fd429 Remove old logs associated to b/200572078
b/200572078 is no longer reproducing. Removing old logs and closing the bug

Fixed: 200572078
Test: remote tests
Change-Id: I7100ec33d5c92fc951b82f4118184453a388d772
2022-02-25 10:08:22 -08:00
Luca Zuccarini dfa9ee5ceb Merge "Ensure that the Hotseat respects the margins of the QSB." 2022-02-25 15:10:49 +00:00
Shikha Malhotra 20f1328b96 Top row of first workspace screen occupied only when QSB is placed at
the top.

This CL facilitates making the Feature Flag QSB_ON_FIRST_SCREEN as false
for LauncherLilyGoogle to make sure that that the top row on the first
screen is not blocked for QSB. Hinging it on BuildConfig allows it be
overwritten in LauncherLilyGoogle.

Bug: 208136186
Bug: 188511548

Test: Manually tested that top row of the first screen is not occupied
and does not clear the shortcuts after a power cycle for LauncherLilyGoogle.

Change-Id: I9113e2e2f2c0a160a2e1caf0ef3c5f86c6ec54b8
2022-02-25 13:31:23 +00:00
Luca Zuccarini 410c75a442 Ensure that the Hotseat respects the margins of the QSB.
Before this change they were ignored by onMeasure(), so that the QSB
couldn't rely on margins for its positioning.

Bug: 217477426
Test: manual
Change-Id: Ifecd3d40ea584273b7857d19b25a90dbafe1c656
2022-02-25 10:49:36 +00:00
Adam Cohen f2f302bcf6 Fix DnD logic for determining current drag screen / panel
=> we want to use the extremum of finger location and object
   center for snapping to a new screen (max when snapping to right,
   min when snapping to left)
=> when selecting a panel within the current screen, we want to
   rely strictly on the object center to determine selection; there
   is plenty of space to be consistent here, and extremum logic
   could cause thrashing back and forth with no page movement.

Test: Manual. See videos in b/221104663. On two-panel and one-panel
      test dragging a widget between different screens with
      different starting positions of where the widget goes down.

Bug 221104663

Change-Id: I8f0f13f07b753752087a90c4bacb76cfbf7aa5bf
2022-02-24 16:13:12 -08:00
Jeremy Sim 36c1b55ee8 Merge "Fix small positioning bug with DWB banner in landscape" 2022-02-24 21:38:25 +00:00
Alex Chau 67d7be9c36 Add extra logs for launcher not initialized
- Add logs to figure out why launcher model is not loaded properly in a test

Bug: 215233405
Test: None
Change-Id: If9e6a18ed2955928fe4ad57e6d7aa34e39c32036
2022-02-24 16:28:54 +00:00
Alex Chau ae22b4ef92 Merge changes from topic "presubmit-am-952ee9e047b74f5a98db7eb7aea662e4"
* changes:
  [automerge] Fix incorrect accessibility announcement on two panel home 2p: 2dacbee028 2p: 9e2f80ef75
  [automerge] Fix incorrect accessibility announcement on two panel home 2p: 2dacbee028
  Fix incorrect accessibility announcement on two panel home
2022-02-24 11:51:59 +00:00
Alex Chau 1c01af74c6 Merge "Fix incorrect accessibility announcement on two panel home" into tm-dev 2022-02-24 11:51:59 +00:00
Jeremy Sim 87fad7b984 Fix small positioning bug with DWB banner in landscape
The DWB banner is now positioned correctly when the task thumbnail is set as a secondary split view.

Fixes: 220637396
Test: Manual testing on local Pixel 6
Change-Id: I3bcb0eb09d2a607b2891bc9f63f3a0b03668f48e
2022-02-23 18:35:47 -08:00
TreeHugger Robot 3c4f8e3e0e Merge "Use color tokens for all apps entry buttons." into tm-dev am: 582ab494dc am: 952d4defeb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16991026

Change-Id: I3bd5a2046e927f729b610d7f8a0ba3a5224340c7
2022-02-24 00:57:23 +00:00
TreeHugger Robot 582ab494dc Merge "Use color tokens for all apps entry buttons." into tm-dev 2022-02-24 00:07:47 +00:00
Presubmit Automerger Backend fbe267a6db [automerge] Fix incorrect accessibility announcement on two panel home 2p: 2dacbee028 2p: 9e2f80ef75
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16968684

Bug: 200009004
Change-Id: I08eac641bbc74db49e4f98c3f2ddf24c7088f65c
2022-02-23 23:00:36 +00:00
Presubmit Automerger Backend 9e2f80ef75 [automerge] Fix incorrect accessibility announcement on two panel home 2p: 2dacbee028
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16968684

Bug: 200009004
Change-Id: I80c2c625a76ae95e7987f345a80070d2b39c26d5
2022-02-23 23:00:31 +00:00
Andras Kloczl 2dacbee028 Fix incorrect accessibility announcement on two panel home
- Divide total pages by panelCount if two panel is active
- Increment target column when moving an item to right panel

Test: manual
Bug: 200009004
Change-Id: Ia8d2d760dc5e8b413e5b1150c049f7fa3ec26513
2022-02-23 22:35:12 +00:00
TreeHugger Robot c089baa668 Merge "Remove Taskbar and Taskbar EDU flags." into tm-dev 2022-02-23 20:10:02 +00:00
Alex Chau a691a126f2 Merge changes from topic "allapps_bottomsheet_motion" into tm-dev am: d8f81e9bf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16967984

Change-Id: I65849784b90c39780ba3ff95f57b1dcf9e86d0b9
2022-02-23 19:57:45 +00:00
Jon Miranda 48a2f7a0ac Use color tokens for all apps entry buttons.
Bug: 220356537
Bug: 205803230
Test: manual, dark mode, light mode
Change-Id: I0973d5aa9ab1ccbdcc78c1e411cbbf63953f2f94
2022-02-23 19:47:33 +00:00
Thales Lima 2f1ae6a1b5 Merge "Create new logic for grid migration" into tm-dev am: bfb275bf21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16976104

Change-Id: I646e0c030aaa7c7a111ba1ad295332617bcf5af8
2022-02-23 19:44:47 +00:00
Alex Chau d8f81e9bf4 Merge changes from topic "allapps_bottomsheet_motion" into tm-dev
* changes:
  Tune AllApps bottom sheet VisD and motion
  Put taskbar all apps in separate overlay window and stash taskbar.
2022-02-23 19:11:51 +00:00
Vinit Nayak 58c27cce73 Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
(cherry picked from commit ec4adc1d5a)
2022-02-23 18:14:28 +00:00
TreeHugger Robot 9f7ceb1c91 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev am: 49cb99a420
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16967985

Change-Id: I05ccfa5901e84dd103348ae16dad28cb1edb2408
2022-02-23 18:14:14 +00:00
Thales Lima bfb275bf21 Merge "Create new logic for grid migration" into tm-dev 2022-02-23 18:07:06 +00:00
Alex Chau b8c22e1155 Tune AllApps bottom sheet VisD and motion
- Make AllApps bottom sheet solid and appears from bottom
- Teleport AllApps bottom sheet as user drag to reduce drag range
  - Consider teleport interpolation for state transition sdetection
- Tuned workspace motions for AllApps bottom sheet (no translate, shrink)
- Add portrait vertical translate for tablet portrait including taskbar AllApps
- Updated bottom sheet handle and created common variables for other bottom sheets

Bug: 208599118
Test: manual on tablet AllApps, taskbar Allapps and handheld AllApps
Change-Id: I69dba5f155914cd012cc8ef3be1ef71fb2be5a40
2022-02-23 17:08:06 +00:00
Thales Lima 0a7ff8780f Create new logic for grid migration
Fixes 217564863
Test: manual, changing grids from Wallpaper & Style and checking against spec

Change-Id: I94cf77111b37810282527f1a212b6e4126d3eba1
2022-02-23 15:20:50 +00:00
TreeHugger Robot 49cb99a420 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev 2022-02-23 02:40:11 +00:00
Schneider Victor-tulias 2763365eb6 Fix icon loading null pointer.
Filtering out icon itemInfos with null component names when loading icons in bulk

Test: manual
Fixes: 220380324
Fixes: 220345439
Change-Id: I0e6f9ae0a363d17497207c92eadcac64ca42693f
(cherry picked from commit 5597e4825d)
2022-02-22 18:38:07 +00:00
Nicolo' Mazzucato 5765d42ada Fix jump in animation for hotseat while re-arranging icons
While re-arranging icons the hotseat remains in scale 1.0f, while the workspace reduces it's scale (as defined by SpringLoadedState.java). Previously, the code to aggregate animations was assuming hotseat and workspace always had the same scale.

MultiScaleProperty.get() was being used to set the starting value of the animation. Previously, it was returning the last aggregated value. However, this value was correct only for the workspace, but not for the hotseat. Returning the current view scale makes it always correct.

Bug: 220271046
Test: Dragged icons from hotseat to workspace, and verified animation didn't jump
Change-Id: Ic01776c1d8e3967624626ed7c44d194a06295790
2022-02-22 18:27:26 +01:00
kholoud mohamed e454c2922b [automerge] Fix crash when loading string cache 2p: 9b38947b32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16966227

Change-Id: I1a52b09250c9ca65ba52b2c0a7c3971ec6d4cf16
2022-02-21 11:29:33 +00:00
kholoud mohamed 9b38947b32 Fix crash when loading string cache
Crash was caused by a null context in ModelDelegate

Fixes: 218305827
Test: manual
Change-Id: I1b046e24427dbdc6752ac100f488c428838ac31f
2022-02-21 11:29:24 +00:00
TreeHugger Robot 0a7af9869e Merge "Fix icon loading null pointer." 2022-02-19 05:11:40 +00:00
Schneider Victor-tulias 5597e4825d Fix icon loading null pointer.
Filtering out icon itemInfos with null component names when loading icons in bulk

Test: manual
Fixes: 220380324
Change-Id: I0e6f9ae0a363d17497207c92eadcac64ca42693f
2022-02-18 16:25:05 -08:00
TreeHugger Robot 5e8dc0e137 Merge changes I16515518,Idf7c880d
* changes:
  Remove popup container drag listener on close complete.
  Revert "Remove popup container drag listener on close complete."
2022-02-18 20:54:08 +00:00
Brian Isganitis 16467b3256 Remove popup container drag listener on close complete.
Bug: 217162588
Test: Verified removal once drag is finished. Verified working on secondary display launcher.
Change-Id: I16515518c6d488b74450456306abbfff646ac11b
2022-02-18 19:27:49 +00:00
Brian Isganitis f10ecccdf7 Revert "Remove popup container drag listener on close complete."
This reverts commit 1f7afc7740.

Reason for revert: Not all activity contexts have a drag controller, so this will cause a crash within those (e.g. SecondaryDisplayLauncher).

Change-Id: Idf7c880d8213951d06fecc3fb8cf6e8efd2037b0
2022-02-18 10:47:11 -08:00
Vinit Nayak 84124f7902 Merge "Remove Taskbar and Taskbar EDU flags." 2022-02-18 04:04:06 +00:00
TreeHugger Robot 49141ccf2e Merge "Revert "Clear all DragView in onSaveInstanceState"" 2022-02-17 20:45:46 +00:00
Tracy Zhou a2215455da Merge "Correct order of split action buttons" 2022-02-17 19:13:26 +00:00
Thales Lima 73087f4b2c Merge "Stop using bottom inset in preview" 2022-02-17 15:28:09 +00:00
Thales Lima 83b345338b Stop using bottom inset in preview
We are not using the bottom inset (navbar) in Launcher anymore, so we should not use it in preview as well.

Fixes 205284107
Test: manual

Change-Id: Iefd71b3cbe8e738c4559716af8c85015ba7c3c41
2022-02-17 13:35:41 +00:00
Tracy Zhou 0551313a9b Correct order of split action buttons
Fixes: 219988163
Fixes: 217965089
Test: https://screenshot.googleplex.com/8LNMBeEQhMVnDSm
Change-Id: I760c0b8085069181d9a1cdc582ac7d58a08f4724
2022-02-17 00:14:50 -08:00
Vinit Nayak ec4adc1d5a Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
2022-02-16 17:42:21 -08:00
Schneider Victor-tulias 76d56ee5a1 Re-enable bulk icon loading
Bug: 195674813
Test: manual
Change-Id: I8cc02cb8648797e55a83bbb184ed2cd5088a1626
2022-02-16 12:23:34 -08:00
Schneider Victor-tulias ee9a54b470 Merge "Fix blank workspce icons on Launcher data refresh." 2022-02-16 19:31:33 +00:00
TreeHugger Robot 64162f1e05 Merge "Update TAPL object hierarchy in preparation for Taskbar TAPL tests" 2022-02-16 18:20:06 +00:00
TreeHugger Robot 19fff8cb74 Merge "Do not theme icons when the original view is not themed." 2022-02-16 17:13:10 +00:00
Brian Isganitis 860e675abe Merge "Remove popup container drag listener on close complete." 2022-02-16 03:33:49 +00:00
Schneider Victor-tulias d6279ae641 Update TAPL object hierarchy in preparation for Taskbar TAPL tests
See design at: go/taskbar-tapl-tests

Test: Ran tests remotely
Bug: 215218813
Change-Id: I1c2ceac8954973ea3ae5b2f797fdfb96ba7a6ec4
2022-02-15 13:33:26 -08:00