Commit Graph

559 Commits

Author SHA1 Message Date
TreeHugger Robot 6ad150d8a0 Merge "Remove long press on home button for kids mode." into tm-dev am: 8d5c3e91cf am: f6ccde8079
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18230546

Change-Id: I68a99489ca0d9dfe3c14fd8198ee625c01e702e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-09 22:17:43 +00:00
Vinit Nayak bb22b0994f Merge "Extend recents button hitbox on tablet" into tm-dev am: 46d95995aa am: e50b15862e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17958719

Change-Id: I14bfce27e1e9255b24c7b43293bc20f7b6833638
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-09 22:01:08 +00:00
TreeHugger Robot 8d5c3e91cf Merge "Remove long press on home button for kids mode." into tm-dev 2022-05-09 19:22:11 +00:00
Vinit Nayak 46d95995aa Merge "Extend recents button hitbox on tablet" into tm-dev 2022-05-09 18:46:01 +00:00
Pat Manning 52bb52aeb4 Remove long press on home button for kids mode.
Fix: 229961238
Test: manual
Change-Id: Idb50d4e142b1d1b0539a71b7a727d00dc76c6a68
2022-05-09 16:57:33 +01:00
TreeHugger Robot aebd373465 Merge "Finish mIconAlignmentForLauncherState animation before animating to new value" into tm-dev am: 062d96721c am: 235de12d1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18198384

Change-Id: If264111747c6bde581e4fe7f017af984a791d89a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-07 16:26:18 +00:00
Vinit Nayak b1436b0ae7 Extend recents button hitbox on tablet
* Extends hitbox when recents is tapped
when going from taskbar to overview.
* Extended region lasts for 400ms after
the animation ends.

Fixes: 225885714
Test: Manual, added unit test
Change-Id: I8766279c1a5bf6867f8d69ddd3af2aa3565deec2
2022-05-06 17:04:47 -07:00
Alex Chau 78357f7979 Finish mIconAlignmentForLauncherState animation before animating to new value
Fix: 230630665
Test: Launch app and return home, taskbar animation should be smooth
Change-Id: Ie6c7daac7f185a51476a9d076dde628d57ff77eb
2022-05-06 17:34:07 +01:00
Alex Chau 2403d1b30c Allow BaseState.getTransitionDuration to read DeviceProfile am: a717d1621d am: 6612d6ed4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18185502

Change-Id: I608ba1031e7b02a7be43acb47fb25d6fa1f1c002
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-05 19:09:04 +00:00
Alex Chau a717d1621d Allow BaseState.getTransitionDuration to read DeviceProfile
- Changed handheld duration to AllApps to 600

Bug: 227745955
Test: manual
Change-Id: I6f6642440dda3e39947231c2d38e8b60d152e08f
2022-05-05 14:44:00 +01:00
Sunny Goyal 56b19b5399 Merge "Replacing ItemInfoMatcher with predicate" into tm-dev am: f76524151d am: 59264fc190
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18124001

Change-Id: Ib24c1548dfdf1e209721a022bc2cf7ee205e7e40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-03 20:31:53 +00:00
Sunny Goyal f76524151d Merge "Replacing ItemInfoMatcher with predicate" into tm-dev 2022-05-03 20:04:55 +00:00
Jon Miranda 12da7c72f6 Merge "Fix all app button taskbar animation in LTR and RTL." into tm-dev am: e73c3075c1 am: 83d448595a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18119607

Change-Id: Ie6839e8c88792a5da3b41a1ac069d50fbddb06a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-03 17:46:03 +00:00
Sunny Goyal 32084d49d3 Replacing ItemInfoMatcher with predicate
This removed unnecessary componentName lookups when it
is not required. Many checks just rely on IDs and
userHandle

Bug: 231153610
Test: Presubmit
Change-Id: Ief93954abc5861062a9f55dc2ef181d3de106c62
2022-05-03 10:07:22 -07:00
Jon Miranda e73c3075c1 Merge "Fix all app button taskbar animation in LTR and RTL." into tm-dev 2022-05-03 17:03:22 +00:00
TreeHugger Robot d7ecfa1f9e Merge "Tune AllApps dismiss animation" into tm-dev am: f1a4296cd0 am: d00ce3a13e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757986

Change-Id: I408e7daaae4a2101a80d1921f8517d6673add6a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-03 13:34:46 +00:00
TreeHugger Robot f1a4296cd0 Merge "Tune AllApps dismiss animation" into tm-dev 2022-05-03 11:23:46 +00:00
Jon Miranda e7b977ddd5 Fix all app button taskbar animation in LTR and RTL.
Bug: 225154998
Test: Open app, view taskbar, go back to home
      Repeat for both RTL, LTR

Change-Id: Ifdc8074bef6e5f5a447a1f4110ccb387b18a7ea9
2022-05-02 15:31:21 -07:00
Schneider Victor-tulias 9b6babf839 Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
Bug: 221455508
Test: opened all apps, widgets, -1 screen, notifications shade and keyboard in various combinations and orders; locked screen, launched app, returned home with the back/home buttons, opened overview
Change-Id: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
Merged-In: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
(cherry picked from commit 9c1a452a1d)
2022-05-02 18:45:01 +00:00
Schneider Victor-tulias c0b30dc266 Fix taskbar 3-button truncation on rotate
- Fixed truncation issue in overview and home on rotation
- Fixed 3 buttons translating incorrectly when switching to/from overview

Fixes: 205057824
Fixes: 215482458
Test: Manual
Change-Id: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
Merged-In: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
(cherry picked from commit 8aa99c72b1)
2022-05-02 18:12:00 +00:00
Alex Chau f39cc126bf Tune AllApps dismiss animation
- Avoid overriding interpolator in AllAppsTransitionController.setStateWithAnimation as it's no longer needed and it'll wrongly override interpolator for ANIM_ALL_APPS_FADE
- Override ANIM_ALL_APPS_FADE to FINAL_FRAME in QuickstepAtomicAnimationFactory for tap deadzone to dismiss animation, also added EMPHASIZED_ACCELERATE for the dismiss animation
- Tuned dismiss animation across form factors to 300ms

Fix: 220336617
Test: manual
Change-Id: I4b3e827b503dcb1dd39f0bd99d4c1dd5ffdba0f3
2022-04-29 20:31:26 +01:00
Schneider Victor-tulias c4de960bbf Merge changes from topic "taskbar-misc-fixes-master"
* changes:
  Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
  Fix taskbar 3-button truncation on rotate
2022-04-29 18:17:14 +00:00
Anushree Ganjam e9466b3f94 Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev am: fa693be19f am: 168362edd2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18011182

Change-Id: I62f302fbdaf1b37988f6a56c8cf501a454cb2382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-28 06:03:36 +00:00
Anushree Ganjam fa693be19f Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev 2022-04-28 04:52:01 +00:00
Anushree Ganjam 5cc7ff0990 Revert "Refactors Search results into separate RV for Toast."
This reverts commit 6729f0b950.

Reason for revert: This change caused b/230648542.

Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.

Bug: 206905515
Bug: 230648542

Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
2022-04-28 01:37:49 +00:00
Tracy Zhou 4622349c69 Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: dbb368b40f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I7d029e2545795697f30dcb064139d48cc525b6ba
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 18:24:49 +00:00
Tracy Zhou 7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
TreeHugger Robot cea10a4fb4 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: eb4fa04985
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I76d64e3b7cd443423b3bbe291e82717c4f4d2ffa
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:11:14 +00:00
Schneider Victor-tulias 9c1a452a1d Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
Bug: 221455508
Test: opened all apps, widgets, -1 screen, notifications shade and keyboard in various combinations and orders; locked screen, launched app, returned home with the back/home buttons, opened overview
Change-Id: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
2022-04-25 14:57:13 -07:00
Schneider Victor-tulias 8aa99c72b1 Fix taskbar 3-button truncation on rotate
- Fixed truncation issue in overview and home on rotation
- Fixed 3 buttons translating incorrectly when switching to/from overview

Fixes: 205057824
Fixes: 215482458
Test: Manual
Change-Id: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
2022-04-25 13:40:57 -07:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
Tony Wickham 33474c4f7a Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e am: a9359fc943
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: I629c619a20e39c327fb20f788a02f610b7c8bbf3
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:47:01 +00:00
Tony Wickham aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
2022-04-22 17:28:35 -07:00
Tony Wickham efdae030a6 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 am: b8bfa20d79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I14e26af5f266999bbc7f7a3ad528f96fa652ebff
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 23:42:28 +00:00
Tony Wickham 357c622572 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev 2022-04-22 22:55:10 +00:00
Tony Wickham ae15c42ce6 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 am: 8426275608
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I90101494f32fa6b15b5085b75a78fb80bc8d3cfc
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:22:09 +00:00
Tony Wickham 741e4aeb95 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev 2022-04-22 19:55:31 +00:00
TreeHugger Robot c1cf8b0e95 Merge "Disallow long press below taskbar icons" into tm-dev am: 8e0177813a am: c922594e6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17872520

Change-Id: I763257e603be7845bd63478505266651a4895bba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 17:59:32 +00:00
TreeHugger Robot 8e0177813a Merge "Disallow long press below taskbar icons" into tm-dev 2022-04-21 17:16:42 +00:00
Tony Wickham f286f9cb98 Address a couple small followups for TaskbarInsetsController
- Added no-op onDestroy()
- Reformated some if conditions, also adding
  AbstractFloatingView.hasOpenView()

Test: TaplTestsTaskbar
Bug: 215411414
Change-Id: I89b39ca5fabd03f5ac0f25d6ef69170683cf060d
2022-04-21 16:16:02 +00:00
Tony Wickham a681cf6abe Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets
- This allows us to distinguish taskbar's ITYPE_EXTRA_NAVIGATION_BAR insets from its ITYPE_BOTTOM_TAPPABLE_ELEMENT insets
- Set nav bar insets as before (contentInsets)
- Set tappable elements insets the same, except when taskbar is stashed, in which case set to 0

Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME, open Calculator (which uses tappableElement() insets) and Contacts (which uses systemBars())
Fixes: 215411414
Change-Id: If00f7a590b0780715d5b8159f5135054364ce84e
2022-04-21 16:15:41 +00:00
Tony Wickham 74641da5b8 Merge "Move taskbar insets logic to TaskbarInsetsController" into tm-dev 2022-04-20 23:43:50 +00:00
Tony Wickham 81bff9becd Disallow long press below taskbar icons
Test: long press below icons, doesn't stash; can still swipe up
Fixes: 201239461
Change-Id: Ifdf355138d7958c0442814d968f0722f54e12ae1
2022-04-20 13:58:53 -07:00
Tony Wickham 36c9d888d8 Move taskbar insets logic to TaskbarInsetsController
Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME
Bug: 215411414
Change-Id: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
Merged-In: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
2022-04-20 19:27:48 +00:00
Tony Wickham 2965948ae1 Merge "Move taskbar insets logic to TaskbarInsetsController" 2022-04-20 19:27:29 +00:00
Brian Isganitis 6e8f550b37 Merge "Log taskbar all apps entrypoint, launches, and drags" into tm-dev am: 6d780af405 am: e6588aa656
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17694348

Change-Id: Ic5c91ff514f2826ba4ddff354ed8e08d5a294b0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 18:46:15 +00:00
Brian Isganitis 6d780af405 Merge "Log taskbar all apps entrypoint, launches, and drags" into tm-dev 2022-04-20 17:13:52 +00:00
Tony Wickham 0a73beb65d Move taskbar insets logic to TaskbarInsetsController
Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME
Bug: 215411414
Change-Id: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
2022-04-19 23:24:04 +00:00
Tony Wickham 847af35765 Merge "Move Taskbar background drawing to TaskbarBackgroundRenderer" into tm-dev am: 8bb0bdc42b am: 0a3c742918
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17766315

Change-Id: I22ac9e8cbcb8799be72b560cf65d3c8897755f2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-15 23:38:04 +00:00
Mady Mellor fbb099961d Fix crash/flicker with taskbar when canceling drag and drop am: 729eb8458b am: 45f1b56c88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17776925

Change-Id: If0deadd3eee7bf8943c377c7631b746ce27612d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-15 23:37:17 +00:00