Commit Graph

13523 Commits

Author SHA1 Message Date
Andras Kloczl 68e1af2bc2 Separate workspace item finding logic
Extract the item finding logic from AddWorkspaceItemsTask
to a separate class and write tests.

Test: AddWorkspaceItemsTaskTest.kt , WorkspaceItemSpaceFinderTest.kt
Bug: 199160559
Change-Id: Ie1bc4fcd4f94cd7cb0601c21bbdf273452b9dd1f
2022-03-29 13:31:31 +01:00
Thales Lima 60dc19cb71 Merge "Fix height of hotseat" into tm-dev 2022-03-22 11:43:13 +00:00
Thales Lima f49dce6961 Merge "Reset the size of hotseat cells" into tm-dev 2022-03-22 10:06:22 +00:00
Becky Qiu fd6b0d5617 Merge "[OneSearch] Add a flag to guard QSB animations." into tm-dev 2022-03-22 00:58:07 +00:00
Jeremy Sim c0422b8a48 Merge "Fix issue with split thumbnails overflowing during rotation" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim 8746367f40 Merge "Fix paired icon placement in landscape/seascape" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim cab1ef1a9d Merge "Fix small positioning bug with DWB banner in landscape" into tm-dev 2022-03-22 00:17:43 +00:00
TreeHugger Robot f8137e5ecb Merge "Fix overriden deep shortcut titles and icons" into tm-dev 2022-03-21 20:56:13 +00:00
Luca Zuccarini 24fab62d35 [OneSearch] Add a flag to guard QSB animations.
Bug: 225749858
Test: manual
Change-Id: Ib725b9bcec235d2e23cf93b2f86d0dc9cd0600cb
2022-03-21 19:00:23 +00:00
Thales Lima 7d14923195 Fix height of hotseat
Hotseat size was going behind workspace unnecessarily, causing some issues and also had the wrong hotseat height which was cutting the icons in folders.

Fixes: 224713923
Fixes: 221101290
Test: manual
Change-Id: I2646abc4a6aaa5bf2ea85e55e2f3618f8d7efd9b
2022-03-21 18:32:22 +00:00
Alex Chau c9f3cc36bb Merge "Update overview grid icon sizes and paddings" into tm-dev 2022-03-21 17:08:31 +00:00
TreeHugger Robot 016dd3656d Merge "Adjust edit state drop targets, workspace scaling, and margins per device type and orientation." into tm-dev 2022-03-21 17:07:10 +00:00
Thales Lima c307cd137f Merge "Add more border space options" into tm-dev 2022-03-21 15:14:18 +00:00
Thales Lima 2017ee0208 Merge "Correct inline qsb for foldables" into tm-dev 2022-03-21 14:30:19 +00:00
kholoud mohamed af6641414c RESTRICT AUTOMERGE Fix newAPI lint error
Fixes: 225612636
Test: m -j out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-report.txt
Change-Id: Ib7f7df0010702b0f26d99bbd7b27ee38a6ed5e17
2022-03-21 10:50:29 +00:00
Kholoud Mohamed ac0574781c Merge "RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3" into tm-dev 2022-03-19 06:30:09 +00:00
Jeremy Sim bf6f171f84 Fix issue with split thumbnails overflowing during rotation
Fixes a set of issues in Overview where you could cause split thumbnails to overflow their contents into each other by rotating the phone in certain ways.

The issue occurred because StagedSplitBounds objects have their height and width assigned differently depending on if they were created while the phone was in portrait or landscape.

Fixed by adding a conditional check in PortraitPagedViewHandler#setSplitTaskSwipeRect and LandscapePagedViewHandler#setSplitTaskSwipeRect.

Fixes: 218784856
Fixes: 218779313

Test: Manual on local devices
Change-Id: I04b4f4344250da34616ab1744af22fa41b9aba9b
(cherry picked from commit 1d6b7f2abf)
2022-03-19 00:10:54 +00:00
Jeremy Sim b42345273c Fix paired icon placement in landscape/seascape
In grouped task view, paired icons will now align better with task thumbnails.

Fixes: 218783211

Test: Extensive manual testing on local device(s).
Change-Id: I372d2ee90302a8d96ace048ff4f82126d9b2b363
(cherry picked from commit d6826c74a4)
2022-03-19 00:10:16 +00:00
Jeremy Sim 3b687a5092 Fix small positioning bug with DWB banner in landscape
The DWB banner is now positioned correctly when the task thumbnail is set as a secondary split view.

Fixes: 220637396
Test: Manual testing on local Pixel 6
Change-Id: I3bcb0eb09d2a607b2891bc9f63f3a0b03668f48e
(cherry picked from commit 87fad7b984)
2022-03-19 00:09:22 +00:00
Alex Chau d826f04b93 Merge "Use correct config.smallestScreenWidthDp when creating Resource in DeviceProfile" into tm-dev 2022-03-18 17:51:10 +00:00
Schneider Victor-tulias c8c761621b Fix overriden deep shortcut titles and icons
Bulk Icon loading causes all icons that share a component name to share a title and bitmap. This didn't work for deep shortcuts since they were already being loaded individually. Added a check to filter out deep shortcuts.

Note: If future traces show that individual deep shortcut loading is taking too long, then deep shortcut loading can be refactored into bulk icon loading.

Fixes: 224891898
Test: manual
Change-Id: I112fcd4a889071e5b523d56731bad8ecdee08abc
2022-03-18 17:50:22 +00:00
Pat Manning 1acf2b18af Adjust edit state drop targets, workspace scaling, and margins per device type and orientation.
Bug: 202971709
Test: manual
Change-Id: Id1817cd3c7e7bfa5b0aa8aa20565b791ad871f64
2022-03-18 17:43:28 +00:00
Brian Isganitis 8198cb6f3f Merge "Move activity starting logic into new ActivityContext extension." into tm-dev 2022-03-18 16:43:48 +00:00
Alex Chau a6907dc8c9 Use correct config.smallestScreenWidthDp when creating Resource in DeviceProfile
- This is a regression from ag/17070486 when tested, likely because DeviceProfiles are no longer re-created when changing display sizes, so correct values need to be calculated on the starting state

Bug: 221961069
Test: verify smallestWidth specific resource on changing display sizes
Change-Id: I1539bad4b35b36f0056d59307ab5fbec23a71f49
2022-03-18 15:24:07 +00:00
Thales Lima 44cc3a2e21 Add more border space options
This give options to landscape layouts to have different border options

Bug: 222109350
Test: manual and HSV
Change-Id: If823dd09c945438f77e57ff80a8a0c4fc0b4c8a6
2022-03-18 14:28:24 +00:00
Thales Lima 2903a624ce Correct inline qsb for foldables
Fixes 223565967
Test: manual and HSV

Change-Id: I40ef17142f90a8b29cdec44a36249eb2b800734a
2022-03-17 13:52:19 +00:00
Alex Chau 2e48760e97 Update overview grid icon sizes and paddings
- Introduced additional page spacign for clear all button to match mocks

Fix: 222664142
Test: Quick switch to last task and immediately enter overview
Test: Dismiss last task in overview grid
Change-Id: I4d2f93d843c50b10051f3fb17027cd06e86707e1
2022-03-17 13:44:21 +00:00
Becky Qiu 025bf08e2f Merge "[Avocado] Use device config for arm2 flags instead." into tm-dev 2022-03-17 06:39:54 +00:00
Brian Isganitis bde3c8b6bd Move activity starting logic into new ActivityContext extension.
This code branch is needed for taskbar, so needs to be moved from the
activity classes to an interface that both can share.

Test: Manual
Bug: 216683257
Change-Id: I042c0dcf08207d94847b9d7a1783acc14613ef5f
2022-03-16 13:59:03 -07:00
Alex Chau 3e40089771 Merge "Change grid migration to start from top to bottom" into tm-dev 2022-03-16 18:12:13 +00:00
Thales Lima 8cd020bb1d Reset the size of hotseat cells
When resetting the hotseat layout, the size of cells also can be changed based on changes in DeviceProfile. In this case, the border size changes when rotating the device.

Fixes 216071526
Test: manual and HSV

Change-Id: Idf7b7972e7be347a991cad1cb8ee8cf95cbc4a87
2022-03-16 17:49:40 +00:00
Becky Qiu 85025d248d [Avocado] Use device config for arm2 flags instead.
Bug: 224861508
Test: manual
Change-Id: Ib42ddb3808cf84ed1511754bf3f8bbcf5d100894
2022-03-15 17:13:56 -07:00
TreeHugger Robot 8dff7ca830 Merge "Close taskbar all apps on popup notification and app info shortcut tap." into tm-dev 2022-03-15 22:57:20 +00:00
TreeHugger Robot 2f06a23ed7 Merge "Fix NPE in BubbleTextView" into tm-dev 2022-03-15 22:18:02 +00:00
TreeHugger Robot e0380381b7 Merge "Add event tracking to the gesture navigation tutorial." into tm-dev 2022-03-15 22:12:29 +00:00
TreeHugger Robot b66fc8b145 Merge "Tune widget picker bottom sheet VisD for large screen" into tm-dev 2022-03-15 21:33:50 +00:00
TreeHugger Robot d21c51c932 Merge "Remove ENABLE_ONE_SEARCH" into tm-dev 2022-03-15 19:26:39 +00:00
kholoud mohamed e210b47c20 RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3
Bug: 217388602
Bug: 218875965
Test: atest EnterpriseResourcesTests
Test: manual
Change-Id: I095a1da30766e4b4eab33f42b034601b3322eb3d
2022-03-15 17:24:04 +00:00
Alex Chau d5859e80d7 Change grid migration to start from top to bottom
Fix: 222236363
Test: GridSizeMigrationTaskV2Test
Test: 4x4 -> 4x5/5x5 migration, 5x5 -> 4x5/4x4 migration
Change-Id: Id5d87b5d0bf9d7cc9154de81dd5edfb0ca9fa633
2022-03-15 17:21:24 +00:00
Jon Miranda fe74997235 Fix NPE in BubbleTextView
- Icon can be null when we use BTV for text only

Bug: 223809081
Test: manual
Change-Id: I9efd8e4b420127beb249b20e71ae37c359bb6467
2022-03-15 10:02:39 -07:00
Andras Kloczl 142b054e06 Tune widget picker bottom sheet VisD for large screen
Test: Open widget picker by long pressing the home screen.
Open app specific widget picker by long pressing an app icon
that has widgets. Try both landscape and portrait, also on
phone/tablet/foldable.
Bug: 214215594

Change-Id: I7b4b3a8d7421f1d4df84d49a18b465693a17bd7b
2022-03-15 14:01:59 +00:00
TreeHugger Robot deae9343be Merge "Pass in dbFile from idpGridState for grid migration" into tm-dev 2022-03-14 21:33:16 +00:00
Schneider Victor-tulias b82d945953 Add event tracking to the gesture navigation tutorial.
- Added logs for tutorial step shown/completed and for tutorial skip.
- Added shared preference tracking for tutorial steps completed and for tutorial skip.

Bug:
Test: manual
Change-Id: I47dbdb394db80c5687e98fb034a3883b33f6fd3c
2022-03-14 13:14:05 -07:00
Shikha Malhotra 763fd21b34 Merge "Top row of first workspace screen occupied only when QSB is placed at the top." into tm-dev 2022-03-14 16:53:01 +00:00
Alex Chau 85978e7dc8 Merge "Use overview_actions_height from Resources to calculate OverviewActionsView alignment" into tm-dev 2022-03-14 11:21:32 +00:00
Hyunyoung Song aed4675433 Remove ENABLE_ONE_SEARCH
TL;DR;;
It's no longer bound to the lifecycle of application

Bug: 223750757
Bug: 221956299

Test: device_config commands

Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
Change-Id: I044bf00fe7272439d2ed4def419f91b4d786fb7a
2022-03-11 09:50:05 -08:00
Shikha Malhotra 7884332174 Top row of first workspace screen occupied only when QSB is placed at
the top.

This CL facilitates making the Feature Flag QSB_ON_FIRST_SCREEN as false
for LauncherLilyGoogle to make sure that that the top row on the first
screen is not blocked for QSB. Hinging it on BuildConfig allows it be
overwritten in LauncherLilyGoogle.

Bug: 208136186
Bug: 188511548

Test: Manually tested that top row of the first screen is not occupied
and does not clear the shortcuts after a power cycle for LauncherLilyGoogle.

Change-Id: I9113e2e2f2c0a160a2e1caf0ef3c5f86c6ec54b8
2022-03-11 13:04:55 +00:00
Hyunyoung Song 234b1e0655 Merge "Revert "Add entry and cursor location in GetSuggestionRequest"" into tm-dev 2022-03-11 06:26:04 +00:00
TreeHugger Robot 3b6ba0d252 Merge "Update using tabs boolean immediately if it changes." into tm-dev 2022-03-11 02:28:52 +00:00
TreeHugger Robot 6b7e469088 Merge "Add taskbar TAPL tests" into tm-dev 2022-03-11 00:00:36 +00:00