Commit Graph

15339 Commits

Author SHA1 Message Date
Pat Manning a0e328abe7 Merge "Add test to access overview app menu." into udc-qpr-dev 2023-08-02 18:02:29 +00:00
Pat Manning ccf611234a Add test to access overview app menu.
Approved tapl DD: go/tapl-overview-task-menu-app-info

Fix: 292081139
Test: TaplTestsQuickstep.
Change-Id: Ic74267ec80b0a8c6af502a445d355f0420d8f569
2023-08-02 17:20:03 +01:00
Ats Jenk 97c6160359 Merge "Fix tap on navbar handle when on desktop" into udc-qpr-dev 2023-08-01 17:28:57 +00:00
Ats Jenk 342d6b9bf2 Merge "Flag stashing desktop when going home" into udc-qpr-dev 2023-08-01 17:16:03 +00:00
Pat Manning bd83b29883 Merge "Set taskbar to fullscreen for tooltip only once it is shown." into udc-qpr-dev 2023-08-01 14:55:34 +00:00
Pat Manning a3d564ce34 Set taskbar to fullscreen for tooltip only once it is shown.
Fix: 293490434
Test: TaskbarHoverToolTipControllerTest
Change-Id: Iba59ce241933a52e7f49036188660bef93ea6dcb
2023-08-01 14:33:59 +01:00
Pat Manning 0baeedbc75 Merge "Prevent showing action button edu tooltip in grid only overview." into udc-qpr-dev 2023-08-01 11:39:38 +00:00
Brian Isganitis d280c2f946 Back open-close animation with an AnimatorSet.
Subclasses can add more animations to the set to animate other
components in sync with themselves.

Test: Manual
Bug: 289290185
Flag: No
Change-Id: I96d9afe166e243bb0d2a9cecb8158e2e7d431a6c
2023-07-31 19:47:26 +00:00
Andy Wickham ea12dd4e39 Merge "Make some things public for reuse." into udc-qpr-dev 2023-07-31 18:19:22 +00:00
Vinit Nayak 89976ecae4 Merge "Remove split instructions view on split launch success" into udc-qpr-dev 2023-07-31 18:13:12 +00:00
Ivan Tkachenko 2de68329fd Merge "Bubble bar dismiss interaction" into udc-qpr-dev 2023-07-31 17:54:43 +00:00
Ivan Tkachenko 8d25d999e7 Merge "Bubble bar dismiss" into udc-qpr-dev 2023-07-31 17:54:17 +00:00
Johannes Gallmann 19721d5e28 Merge "Extract Launcher resource interpolators to Animation Library" into udc-qpr-dev 2023-07-31 12:36:43 +00:00
Ats Jenk 7d72bcd46e Fix tap on navbar handle when on desktop
Tapping on navbar handle was hiding the stashed taskbar handle.
When tappin on navbar handle, it starts the recents animation. Which
gets cancelled. Normally, the fullscreen app being visible, it means
launcher activity will be paused after. But when on desktop, launcher is
visible in the background and we need to manually set it to paused
state.
When recents gesture is cancelled after navbar handle tap, the gesture
end state is null. Detect this in DesktopVisibiltyController and mark
launcher as paused in this case.

Bug: 286140120
Flag: persist.wm.debug.desktop_mode_2
Test: open an app on desktop, tap on navbar, observe that user remains
      on desktop
Change-Id: Iee915026265721d42a0b722d6b1595521f20a59a
2023-07-28 17:33:00 -07:00
Andy Wickham 2f72b2efb8 Make some things public for reuse.
Test: With sister change.
Flag: N/A
Bug: 292000892
Change-Id: I8a20b9d4d5df748f90d907a10fe99d066d700170
2023-07-28 16:15:20 -07:00
Andy Wickham fd35baa3f8 Merge "Revert^2 "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-28 21:57:54 +00:00
Liran Binyamin 43e67c277b Merge "Set the stash handle bounds deterministically" into udc-qpr-dev 2023-07-28 19:54:42 +00:00
Liran Binyamin 5c936d6246 Merge "Don't animate in the bubble bar unless there are bubbles" into udc-qpr-dev 2023-07-28 19:54:29 +00:00
Ivan Tkachenko 90a769d1d3 Bubble bar dismiss interaction
A single bubble and the bubble stack dismiss functionality is implemented using `BubbleDragController`. It attaches a touch listener to the corresponding views and handles gesture interactions.
* When the view is long clicked the dragging to dismiss interaction starts. It scales up the dragged view and presents the dismiss view in the bottom of the window.
* When the bubble or the bubble stack is dragged close to the dismiss target area, it gets pulled towards it and sticks to it. The `MagnetizedObject` and `MagneticTarget` classes are used for it.
* When the dragged view is released outside of the dismiss area, it moves back to the initial position with animation.
* When the dragged bubble is released inside of the dismiss area, it will dismiss the bubble with animation and remove it from the stack.
* When the dragged bubble bar stack is released inside the dismiss area, all the bubbles will get dismissed and the bubble bar will dissapear.

Bug: 271466616
Test: manual, TBD
Flag: WM_BUBBLE_BAR
Change-Id: I83393898be61ec522db92688ac2e111ef7d72fe6
2023-07-28 18:17:09 +00:00
Ivan Tkachenko 18373d2a54 Bubble bar dismiss
* Added WMShell related proxy methods.
* Added DismissView dimensions and drawable resources.
* Added DismissView extension file to set it up with dimen and drawable resource ids.

Bug: 271466616
Test: manual, TBD
Flag: WM_BUBBLE_BAR
Change-Id: Iddac977a9c8a63facee45e9dd2eb234bb18d030b
2023-07-28 17:13:09 +00:00
Vinit Nayak a1d0d8269c Remove split instructions view on split launch success
* We weren't removing the instance of the view
that is created when split initiated from workspace
* Fewer bugs like this once RecentsView + workspace
instructions view are consolidated

Bug: 292590703
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Swiping to home after split apps launch
hides the view

Change-Id: I6b5037c024e6e0c456b687bc802076f691a955b2
2023-07-27 14:11:27 -07:00
Treehugger Robot 42b5cf6ee6 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-07-27 19:23:44 +00:00
Luca Zuccarini cf5703f614 Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-qpr-dev 2023-07-27 09:58:26 +00:00
Andy Wickham be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Bill Yi ca00f219c2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I129f717c91f3f0cce914a9e6c0a0315ef3720cac
2023-07-26 13:41:04 -07:00
Liran Binyamin f172c0b3b5 Set the stash handle bounds deterministically
The bounds of the bubble stash handle is calculated based on the bounds of
the bubble bar. The problem is that the bubble bar could be invisible, which
results in incorrect bounds set for the handle.

This change sets the bounds for the handle based on the width of the screen.

Fixes: 290992144
Test: Manual
        - Remove bubbles
        - Restart Launcher
        - Open the bubble test app and double tap on a chat
        - Observe that the handle animates in
Change-Id: Ida260014d59b88387de010891c18057f3b091e93
2023-07-26 15:38:58 -04:00
Liran Binyamin 95d84f5e06 Don't animate in the bubble bar unless there are bubbles
Fixes: 290608658
Test: Manual:
      - Remove all bubbles
      - Lock and unlock device
      - Observe that bubble bar is not displayed

      - Remove all bubbles
      - Restart launcher process
      - Observe that bubble bar is not displayed

Change-Id: I850d307394230968f86abc23ba0b4e94f55e10f0
2023-07-26 15:38:47 -04:00
Treehugger Robot 17988825f2 Merge changes I45b6f858,I28120248 into udc-qpr-dev
* changes:
  Verifying that ViewCapture data is not empty
  Restoring starting capturing existing activity.
2023-07-26 18:33:07 +00:00
Ats Jenk 38a7faf04e Merge "Use hasBeenResumed() for checking if launcher is resumed" into udc-qpr-dev 2023-07-26 18:18:11 +00:00
Treehugger Robot 46c1b631d6 Merge "Add jank monitor for CUJ_QUICK_SWITCH from home screen" into udc-qpr-dev 2023-07-26 16:16:47 +00:00
Luca Zuccarini 627d67549f Animate depth from the right value on Taskbar All Apps launches.
`MyDepthController` in `QuickstepTransitionLauncher` assumes that we
want the background to always animate the same way, matching the rest
state of the workspace (depth == 0). However, in Taskbar All Apps the
background is visible, and depth != 0. We now initialize the one-off
`DepthController` for launches to take into account the latest depth set
by the top level `DepthController`, so there is no jumpcut at the
beginning of the animation.

Note that in my opinion we should use the same `DepthController` for all
cases, rather than having this one-off. I'm looking into the feasibility
of that change, but for now this fixes the issue at hand.

Fix: 292959100
Flag: N/A
Test: manual, see videos in the bug

Change-Id: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
2023-07-26 15:37:44 +00:00
Ats Jenk cf25610a28 Flag stashing desktop when going home
Put logic to stash desktop apps behind a flag. Turn it off by default.

Bug: 292109910
Flag: persist.wm.debug.desktop_stashing
Test: turn off the flag, open an app on the desktop and go home
      observe that user is taken to home screen and subsequent launches
      are in full screen
      turn on the flag, open app on the desktop and go home
      observe that there is a toast shown for desktop and next app is
      launched to desktop
Change-Id: Ic6f9a3644bb09d4fb877f4694843a7c20969f925
2023-07-25 14:20:00 -07:00
Tracy Zhou 2a8a40c4a8 Merge "Add quick switch to trackpad gesture tests" into udc-qpr-dev 2023-07-25 20:11:22 +00:00
randypfohl d2739609b5 Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730 am: b947238a9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: Iacb77a5aa57db4adeecbc96a477c441a9a88937a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:04:32 +00:00
Tony Wickham 2ea942b813 Add jank monitor for CUJ_QUICK_SWITCH from home screen
Flag: None
Test: adb logcat -b events | grep jank_cuj_events
  - Verified quick switch from home gets begin and end
  - Verified quick switch then swipe back or up to home
    gets begin and cancel
  - Verified quick switch then swipe up to overview
    gets begin and cancel
Fixes: 290323639
Change-Id: I4f1991251b111c0531b30c48ba610ce85dcafdd3
2023-07-25 19:18:20 +00:00
randypfohl b947238a9e Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: Ife4db9cda8ecd85ee21e51575a7bc24c37882ee7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 19:07:48 +00:00
Ats Jenk f0be4fa573 Use hasBeenResumed() for checking if launcher is resumed
ag/23852178 introduced a clean up for launcher state when invoking
transient taskbar. It was checking launcher activity resumed state with
`isResumed()` method. This breaks transient taskbar for desktop mode as
we are marking the launcher activity to be paused using the launcher
flags. `hasBeenResumed()` method is the one we can used instead as it is
checking the launcher flags and not the resumed state of the activity
itself.

Bug: 292266259
Test: open transparent activity on top of launcher
      unstash taskbar
      go home
Test: move an app to desktop, unstash taskbar
Change-Id: I98d14dbfdde4b857f50e62206fc0f308e8f54231
2023-07-25 11:18:29 -07:00
Tracy Zhou bfef402e1e Add quick switch to trackpad gesture tests
Bug: 23895346
Test: presubmit
Change-Id: I85f3e010757595763f58ea81a13671fe49604b76
2023-07-25 10:55:40 -07:00
Schneider Victor-tulias d33fc05022 Merge "Fix broken gesture nav edu on tablets in portrait." into udc-qpr-dev 2023-07-25 17:01:37 +00:00
Greg Kaiser b095594afd Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-25 16:44:28 +00:00
Greg Kaiser f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Jagrut Desai 8997e5626a Merge "Branching Taskbar visible/hidden assertion from testQuickSwitchToPreviousAppForTablet" into udc-qpr-dev 2023-07-25 04:14:47 +00:00
Andy Wickham 03b5f8b1d1 Merge "Change Overview Actions to round buttons." into udc-qpr-dev 2023-07-24 19:56:23 +00:00
Vadim Tryshev 101ea3e4e5 Restoring starting capturing existing activity.
ag/24138143 made the rule to produce empty captures in many cases.

ag/24138143 aimed to fix a leak that was caused by a local var
alreadyOpenActivity still referring the activity when the leak check
executes.

Fixing that by moving the variable to a method startCapturingExistingActivity.

Bug: 291638593
Test: local, presubmit
Flag: N/A
Change-Id: I281202488c6c85e2e2c5b5b3300e26d808167104
2023-07-24 19:09:48 +00:00
Stefan Andonian a540ce2046 Add ViewCapture to Taskbar
Bug: 242867462
Test: Verified that the correct UI data showed up on go/web-hv.
Change-Id: I0904300887684d76d4a1c16ff4ba6986506d4a06
2023-07-24 17:20:11 +00:00
Treehugger Robot 979ae6b463 Merge "Remove debug logs" into udc-qpr-dev 2023-07-24 17:18:15 +00:00
Jagrut Desai ee8db05450 Branching Taskbar visible/hidden assertion from testQuickSwitchToPreviousAppForTablet
- There seems to be test corruption that is coming from the TwoPanelWorkspaceTest as they are getting marked ignored from assumption exception.

- We are branching the logic of asseting taskbar depending on taskbar variant until we figure out how we can run test with TaskbarSwitchMode test annotation and pass it on first attempt. This is cunrrently not working for above reason.

Test: Presubmit
Bug: 286084688
Flag: not needed
Change-Id: I77a141455eceffd11fa8f74a7e204de9b36384fd
2023-07-24 09:49:11 -07:00
Tracy Zhou dc6d7e1e51 Merge "Add pressBack test to TaplTestsTrackpad" into udc-qpr-dev 2023-07-24 16:32:19 +00:00
Alex Chau 3e65e52381 Remove debug logs
Fix: 283944974
Test: None
Change-Id: Ibb30d2b6c92f62669494a0f305ad21b49562532b
2023-07-24 13:10:34 +01:00
Johannes Gallmann a82eebd286 Extract Launcher resource interpolators to Animation Library
Bug: 292080029
Test: atest InterpolatorResourcesTest
Change-Id: I65dba4eb3f96844d4f9a4d0af608c0bd8e77ccc2
2023-07-22 09:52:53 +02:00