Commit Graph

58436 Commits

Author SHA1 Message Date
Schneider Victor-tulias ff5ad47a06 Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev 2022-08-30 22:42:46 +00:00
Sukesh Ram efe8916d0a Made popupContainer's shadow & arrow visible in secondary display am: 924852fec5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19789527

Change-Id: Ie186f7728435b7e27a2015f931c726db2a1eddfe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 22:31:35 +00:00
Sukesh Ram 1b4869fcbc Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
(cherry picked from commit 9e5fe63a22)
Merged-In: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-08-30 22:30:03 +00:00
Brian Isganitis 14aa82a02a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev am: 168482688a am: f898db348a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19283295

Change-Id: Id8c0372759306567ed50b2d3e33cdbb060c7f65d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 21:13:38 +00:00
Brian Isganitis c043d45c42 Snap to last task if swiping down at a greater Y than X velocity.
If you swipe down slightly diagonally, it will almost always be treated as a swipe to the next task rather than a return to the current task. If we are swiping down and the Y velocity is grater, we should snap to the current task instead.

Test: Manually in fully gestural mode.
Bug: 222117127
Change-Id: I8c3cd483f7ceefe0de1e24b6e98918b12428ed10
2022-08-30 20:59:40 +00:00
Tony Wickham e74569e935 Fix taskbar stash state not persisting properly across recreate
Because we check supportsVisualStashing() in
TaskbarStashController#init(), we need to avoid using
TaskbarUIController to provide that value since TaskbarUIController
isn't initialized until a bit later than the other controllers. So I
moved the logic from supportsVisualStashing() back to
TaskbarStashController, but still allow TaskbarUIController to override
it (e.g. for DesktopTaskbarUIController).

After that fix, I noticed that force stopping launcher (to test the fix)
would briefly show the taskbar background before resetting the stashed
state. This is also due to LauncherTaskbarUIController not being ready
immediately, since that's what sets FLAG_IN_APP due to launcher being
paused. To work around this, I set FLAG_IN_APP to true by default in
TaskbarStashController#init(), since that is the most common case, and
taskbar background/stashed handle isn't shown on home anyway.

Test: Force stop launcher while taskbar is stashed, verify it recreates
as stashed without background flicker; same when changing wallpaper
color on home or in app; also tested when taskbar isn't stashed and in 3
button mode for good measure
Test: testHideTaskbarPersistsOnRecreate
Fixes: 235986838

Change-Id: Ie55bd70e8288d5ad7433dde970f18c176831d747
2022-08-30 13:42:04 -07:00
Brian Isganitis f898db348a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev am: 168482688a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19283295

Change-Id: Ibcb77046543c1faf45652eccf6082382a8b3c27a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 20:41:54 +00:00
Tony Wickham c8e824dbdb Add support to Tapl to recreateTaskbar
Also moved references of "tasbkar_view" to share TASKBAR_RES_ID constant

Test: compiles; see follow up CLs
Bug: 235986838
Change-Id: I69bcfa975550e567f3daa35af8a810546297d79c
2022-08-30 13:40:45 -07:00
Sukesh Ram 924852fec5 Made popupContainer's shadow & arrow visible in secondary display
Reduced elevation of app drawer to 0dp because it was conflicting with popup container elevation

Test: Manual
Change-Id: I222866ddfc44ebf9ecd9787bb448e502339a1688
Fix: 233932585
(cherry picked from commit 354fe14cd4)
2022-08-30 20:27:33 +00:00
Brian Isganitis 168482688a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev 2022-08-30 20:09:10 +00:00
Schneider Victor-tulias 038922a653 Add gesture nav error state tracking and logging
- Added ActiveGestureErrorDetector
- Removed startQuickstep logs; these were confusing and not helpful in ActiveGestureLogs

Test: printed logs after several gestures
Bug: 227514916
Design: go/gesture-nav-logging
Change-Id: Ia2a7e4f90a3a371d9a92190aa66eb07acd061d6c
2022-08-30 12:18:29 -07:00
Pat Manning 7a5048297d Merge "Refactor overview progress as splash progress." into tm-qpr-dev am: b4a30ab955 am: 99bce932a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19730966

Change-Id: I3abd3fd009ed7d6d7f4754bcece6a594bab3db61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 14:17:18 +00:00
Pat Manning e63dd25a54 Use full screen width for drop target buttons to support higher screen densities from truncating text.
Scale oversized text down if after all computations it will still be truncated at higher densities.

Fix: 239401464
Test: manual. To follow up with screenshot test: b/241386128
Change-Id: Ie088d0631b0d13beb2d9f9d5396a56f7b971dee1
2022-08-30 14:57:42 +01:00
Pat Manning 99bce932a2 Merge "Refactor overview progress as splash progress." into tm-qpr-dev am: b4a30ab955
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19730966

Change-Id: I7f1f488f8b0e284e0ac7ba4de1b68561a825fd8c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 13:47:22 +00:00
Pat Manning b4a30ab955 Merge "Refactor overview progress as splash progress." into tm-qpr-dev 2022-08-30 13:29:53 +00:00
Pat Manning 5cf4d207f2 Merge "Launch tasks before testing switch to overview." into tm-qpr-dev am: 8463ab771e am: d6f5350f26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19719106

Change-Id: I508373ba1b659b8cf108521e309568289d9be7f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 12:14:19 +00:00
Pat Manning d6f5350f26 Merge "Launch tasks before testing switch to overview." into tm-qpr-dev am: 8463ab771e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19719106

Change-Id: I0775d5238bf510f3daa0c65df4b87dfff1280a81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 11:44:29 +00:00
Pat Manning 81dc9ad131 Refactor overview progress as splash progress.
This also avoids showing splash in split select state

Fix: 242284413
Test: follow up after b/238405972
Change-Id: I2e83fa3d030e8a74edb4152c472dbf02ac5a80b1
2022-08-30 11:23:08 +01:00
Pat Manning 8463ab771e Merge "Launch tasks before testing switch to overview." into tm-qpr-dev 2022-08-30 10:10:45 +00:00
TreeHugger Robot 26cbbd2621 Merge "Added margin of size 24dp above search bar on secondary display" into tm-qpr-dev am: 40b6d6038c am: 8e196fcfd2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19775935

Change-Id: I0c2dfe7d16a9a9fccdc4a2bfbbf65bc4ab6cd754
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 07:08:23 +00:00
TreeHugger Robot 8e196fcfd2 Merge "Added margin of size 24dp above search bar on secondary display" into tm-qpr-dev am: 40b6d6038c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19775935

Change-Id: I789e92b43aaa76af54939c39e63734081aef81c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 06:38:48 +00:00
TreeHugger Robot 40b6d6038c Merge "Added margin of size 24dp above search bar on secondary display" into tm-qpr-dev 2022-08-30 06:02:49 +00:00
Sebastian Franco 897fe1c39d [automerger skipped] Adding flag to improve the icons reordering on foldables am: 47558a6201 am: 0c7f6ad370 -s ours
am skip reason: Merged-In Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb with SHA-1 ffae7d256c is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19735100

Change-Id: I9d5215a3a4d9aed8fc40edcbe5b48ef5e847324e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 01:09:28 +00:00
Sebastian Franco 0c7f6ad370 Adding flag to improve the icons reordering on foldables am: 47558a6201
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19735100

Change-Id: I79f6afe3783d68300e49ee1e37ef755b97c6ec9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 00:38:59 +00:00
Tony Wickham b6f593042d Don't rely on QuickstepLauncher instance for tests
Instead, bind to TouchInteractionService and use that binder to call into taskbar.

Test: TaplTestsTaskbar
Bug: 235986838
Change-Id: I222522bc53c9d1698542fbae52c37889f14abf41
2022-08-29 17:27:27 -07:00
Android Build Coastguard Worker aac8d5eb31 Snap for 9005101 from 2886ff0826 to tm-qpr1-release
Change-Id: I3e11ec298ca7e444feeea9c4a2e6a15e4af8bed0
2022-08-29 23:30:43 +00:00
Sukesh Ram bf520a5935 Added margin of size 24dp above search bar on secondary display
Test: Manual
Change-Id: I5debc810385eced54aaed436489b16f36367194c
(cherry picked from commit 958dcd2f4f)
Bug: 244224274
2022-08-29 22:24:59 +00:00
Sebastian Franco 47558a6201 Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
Merged-In: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-29 22:08:20 +00:00
Sebastián Franco b35a9e51fc Merge "[Merge conflict tmp-qpr] Adding flag to improve the icons reordering on foldables" 2022-08-29 22:03:29 +00:00
Brian Isganitis 5208317c64 Merge "Add doc clarifying Taskabr icon alpha consumer purpose." into tm-qpr-dev am: a4636922a6 am: e5f48d27db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19040760

Change-Id: I4b1c43eb7e117f655e1a19664b8875ffb8179a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 21:44:42 +00:00
Brian Isganitis e5f48d27db Merge "Add doc clarifying Taskabr icon alpha consumer purpose." into tm-qpr-dev am: a4636922a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19040760

Change-Id: Iffa23a000164d0dd70e1dc1589cd6d6559814230
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 21:13:21 +00:00
Brian Isganitis a4636922a6 Merge "Add doc clarifying Taskabr icon alpha consumer purpose." into tm-qpr-dev 2022-08-29 20:54:07 +00:00
Brian Isganitis 2303eb0aac Simplify calculateEndTarget logic.
This method has grown quite large and has a lot of if-else nesting. We
can address these readability issues by defining some helper methods for
specific cases (e.g. flingY and non-fling).

Bug: 222117127
Test: Manual
Change-Id: Ia6012dbcee9a842b4b5bd2ffdb9aea978cfdfc26
2022-08-29 20:47:32 +00:00
Sebastián Franco 78edb995a4 Merge "Add screen recording to debug test ReorderWidgets.java flakynes" into tm-qpr-dev am: 2886ff0826 am: 76f7cacbc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19607104

Change-Id: I7cc0aa4c50e15c9000806d006bdca27686428cdf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 16:50:43 +00:00
Sebastián Franco 76f7cacbc8 Merge "Add screen recording to debug test ReorderWidgets.java flakynes" into tm-qpr-dev am: 2886ff0826
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19607104

Change-Id: Ic7329575f684cc50869e14eebb0cb67d05702e71
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 16:31:00 +00:00
Sebastián Franco 2886ff0826 Merge "Add screen recording to debug test ReorderWidgets.java flakynes" into tm-qpr-dev 2022-08-29 16:10:44 +00:00
Android Build Coastguard Worker 2a6d13fdfa Snap for 9002697 from 0940c2d92c to tm-qpr1-release
Change-Id: I84138c1d9a597145c164372f8dc205f322239997
2022-08-29 01:25:01 +00:00
Bill Yi 508fc70a75 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: 0940c2d92c -s ours am: 3568ccea4a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19739382

Change-Id: Ie705ec0846bbe6e9c428aa309939da8e2a181561
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-28 00:23:08 +00:00
Bill Yi da56b77925 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4374fc5fb0 -s ours am: a18a9a3f6d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19739382

Change-Id: I4fdc33a4e77397d43fe4c830b562c41d09270942
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-28 00:22:52 +00:00
Bill Yi 3568ccea4a [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: 0940c2d92c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19739382

Change-Id: I889b002323c6f3265fc93af7eda64766f1c9f868
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-27 23:54:05 +00:00
Bill Yi a18a9a3f6d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4374fc5fb0 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19739382

Change-Id: Ic5a5f7958d3c815b3df436f9fa8ec27e29bd4a62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-27 23:53:48 +00:00
Bill Yi 0940c2d92c Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-08-27 23:25:04 +00:00
Brian Isganitis dc643f9bea Add doc clarifying Taskabr icon alpha consumer purpose.
The motivation ternary `alpha > 0 ? 0 : 1` was not immediately clear, so adding some clarification for future readers.

Test: No
Change-Id: I558e86153e68572a519317dba7fbba180cb5678e
Fix: 239074423
2022-08-27 20:46:49 +00:00
Thales Lima f688f1388f Merge "Add screen recording to flaky test" 2022-08-27 01:53:03 +00:00
Android Build Coastguard Worker 4a401b3c5b Snap for 9000567 from 7fb96a5305 to tm-qpr1-release
Change-Id: I7535d8108ce44aba21d0004673c1845c1d71258d
2022-08-27 01:26:11 +00:00
Becky Qiu edea2575e6 [Toast] Add a feature flag for using app search for web zero-state.
Bug: 241001264
Test: local
Change-Id: Id4af1664253182217014a43d8f8025f1a00da291
2022-08-26 16:41:05 -07:00
Alex Chau d00b3c90be Merge "Add screen recording to flaky test" 2022-08-26 21:57:47 +00:00
Bill Yi 009236c217 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-08-26 18:49:50 +00:00
Bill Yi 50af2d8655 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-08-26 18:49:50 +00:00
Bill Yi 90b0be5994 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-08-26 18:49:50 +00:00