Commit Graph

58436 Commits

Author SHA1 Message Date
Pinyao Ting 7fd7e51fa2 Include additional error log around widget removal
As observed in b/248291728, widgets are disappeared after OTA update,
this CL includes additional logging to reveal more information.

Bug: 248291728
Test: manual
Change-Id: I5cf968efc358c3315e5e6ecc4861d5bc888569f1
2022-10-03 17:46:03 -07:00
Jeremy Sim 37638afbec Merge "Fix animation slowdown when splitting from All Apps" into tm-qpr-dev am: 33e57ebc1a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20103367

Change-Id: If54807ba3c13eb9d8a8ccdc0defa69b35beca442
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 00:12:23 +00:00
Winson Chung 1c3f817f89 Updating launcher for pip interface cleanup
Bug: 238217847
Test: atest WMShellUnitTests
Change-Id: I375e67eeb07ffe50bf15eafb65c1e9d215118c73
2022-10-03 23:56:39 +00:00
Vinit Nayak 71af5b7a15 Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev am: 66160e9dd8 am: b03ec55872
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029582

Change-Id: I8ba442186bc330b7ecff0e9ee1b53a22fe20cffb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-03 23:45:45 +00:00
Jeremy Sim 33e57ebc1a Merge "Fix animation slowdown when splitting from All Apps" into tm-qpr-dev 2022-10-03 23:31:59 +00:00
Vinit Nayak b03ec55872 Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev am: 66160e9dd8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029582

Change-Id: I2f2ce0e026d6dbecaacdd7f026e208d658249eae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-03 23:14:57 +00:00
Vinit Nayak 66160e9dd8 Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev 2022-10-03 22:45:42 +00:00
Xin Li 83ecebe8e5 Merge TP1A.221005.003
Merged-In: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
Change-Id: I0c718a2d5b4754c3cb9f2bc1223b3ddec24564b8
2022-10-03 13:17:47 -07:00
Jeremy Sim 86065b81e0 Fix animation slowdown when splitting from All Apps
This patch fixes a tablet bug related to splitting from All Apps. Splitting from AllApps was playing a very slow animation.

The bug occurred because there was no case set in QuickstepAtomicAnimationFactory for animating from the ALL_APPS state.

Fixed by setting the appropriate case in QuickstepAtomicAnimationFactory.

Fixes: 247053528
Test: Manual
Change-Id: I7391dc7049a6ff5a7f8c7e1ae8b69e29899248fa
2022-10-03 12:49:31 -07:00
Stefan Andonian 799a021828 Fix ViewCapture NPE. am: b759de4769 am: 371ba32e44
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20075879

Change-Id: Ia9c46040101719449fcb36d2bd6b7b686de32a97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-03 19:27:46 +00:00
Alex Chau d67ddc4920 Taskbar in overview
- Behind ENABLE_TASKBAR_IN_OVERVIEW which is disabled by defualt
- Make taskbar unstashed in overview with background visible
- Ensure taskbar is touchable in overview

Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with ENABLE_TASKBAR_IN_OVERVIEW x taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ib25d68f68e89564851b226536e456d0b2f6306f8
2022-10-03 20:15:12 +01:00
Stefan Andonian 371ba32e44 Fix ViewCapture NPE. am: b759de4769
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20075879

Change-Id: I1c44ad208cc7d36d070971ef507c735ca385cdfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-03 18:40:33 +00:00
Stefan Andonian b759de4769 Fix ViewCapture NPE.
The ViewPropertyRefs, when copied from 1 frame to another, where also
transferring the same "next" reference. Sometimes, the recycled
ViewPropertyRef would be the same ViewPropertyRef instance as one of the copied
ViewPropertyRefs, which would caused an NPE, since the recycled VPR
would have it's next value set to null.

Bug: 249125402
Test: Repro steps are dragging and dropping around an item on the
workspace to different locations. This consistently repro's the crash in
about 10 seconds of doing this. Afte the fix, the crash stopped.

Change-Id: Ia43d8f788eb4889c0890fea0bb839cb9fed78ada
2022-10-03 15:25:04 +00:00
Alex Chau 58bc281142 Refactor TaskbarLauncherStateController to use a single AnimatedFLoat
- Use a single iconAlignment animation
- Introduced isInLauncher/goingToLauncher/FLAGS_LAUNCHER as combined FLAG_RESUMED|FLAG_RECENTS_ANIMATION_RUNNING
- iconAlignment is now centralized in onStateChangeApplied with single source of truth

Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ie51b602394c155aca060a84585eb0e677e23425c
2022-10-03 11:24:00 +01:00
Arthur Hung 3c7db4901b Merge "Refactor back navigation animtion (2/2)" 2022-10-03 08:15:51 +00:00
Android Build Coastguard Worker b1646165fe Snap for 9128530 from 1aa91f0f7a to tm-qpr1-release
Change-Id: I74548488629e635596ab28dabc21dc7da65fcaab
2022-10-01 21:29:23 +00:00
Federico Baron 226ad3d58c Merge "Fix the entry animation for delightful pagination in folders" into tm-qpr-dev am: 1aa91f0f7a am: bb74f1fce7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20059409

Change-Id: I834ca656ffdbfa108f96e86fc841e3c247d3dab9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-01 08:13:02 +00:00
Federico Baron bb74f1fce7 Merge "Fix the entry animation for delightful pagination in folders" into tm-qpr-dev am: 1aa91f0f7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20059409

Change-Id: Ic31ef18fb69c57dad45dd8502db896e8aabfffa0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-01 07:42:26 +00:00
Federico Baron 1aa91f0f7a Merge "Fix the entry animation for delightful pagination in folders" into tm-qpr-dev 2022-10-01 07:21:53 +00:00
Jeremy Sim b988d224a6 Fix 2 bugs involving split staging task translation am: 978b0021a9 am: 635815666c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20087546

Change-Id: Idda3656d492a90df268c902405c4b6c96266be90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-01 02:08:01 +00:00
Android Build Coastguard Worker b33e0d8151 Snap for 9127121 from f733a716fd to tm-qpr1-release
Change-Id: I4c79e0b918aa6c100474846b1bd9308cd6e7aa8c
2022-10-01 01:25:32 +00:00
Jeremy Sim 635815666c Fix 2 bugs involving split staging task translation am: 978b0021a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20087546

Change-Id: Iffca62d17d40b168ff53c5624dc09dda2fbe4fec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-01 01:23:06 +00:00
Jeremy Sim 978b0021a9 Fix 2 bugs involving split staging task translation
This patch fixes two bugs related to the way tiles slide in when a split is staged. Previously, translations were not being completely reset, so on repeated splits, the thumbnails would retain their old translation setting and cause awkward movements to occur during the slide-in animation.

Fixed by adding setTaskViewsPrimarySplitTranslation() and setTaskViewsSecondarySplitTranslation() in resetFromSplitSelectionState().

Fixes: 249154347
Fixes: 249824716
Test: Manual on grid and non-grid Overview, in a variety of conditions
Change-Id: I2d9aa621a17f178ff8216740d76429d2ac484b39
2022-09-30 14:30:04 -07:00
Thales Lima 517cafff18 Check for view measurement before animating
Sometimes the view is there but it was not measured yet, and that was making the animation run with wrong icon position values.

Fix: 233247401
Test: manual
Change-Id: Ibcce24391e99b02ecdb492191c39b62d332abe4f
2022-09-30 16:04:42 +01:00
Android Build Coastguard Worker 6b7accb4c2 Snap for 9121707 from 888f745490 to tm-qpr1-release
Change-Id: I162b782d4cfcfb01e57a05d524eec980de8fc1b9
2022-09-29 23:26:05 +00:00
Vinit Nayak 7523b94105 Hide back button if IME shows in SUW
Fixes: 230830643
Test: Visually see no back button when IME
shows up on enter pin screen

Change-Id: Icdde92d39962c3891a56bb07de5b16a22635729e
2022-09-29 15:47:15 -07:00
Vinit Nayak c7295ee37a Add margin to SUW back button
* navButtonsLayoutParams marginEnd was removed, and
SUW was relying on that value to add margins to
SUW back button, but was returning 0.

Fixes: 242999939
Test: Visually observed in SUW test activity
adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity

Change-Id: I5ffc421e9b731b0d9c7b7c48eab807d4419721b1
2022-09-29 15:47:15 -07:00
Brian Isganitis 222efcd6ff Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev am: f733a716fd am: 00f9389e4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068647

Change-Id: I3bc1c036de3d27af1113b118e13236c913dcca33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 22:13:43 +00:00
Andy Wickham 2091a2e0a0 Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev am: 7f31d4c0ec am: d74a679987
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040589

Change-Id: I6786cbcc32af51cffb2a4882b904b54b0b62d2bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 22:12:43 +00:00
Brian Isganitis 00f9389e4e Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev am: f733a716fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068647

Change-Id: Ie484ca3d0918573c7e706ddea23823ea82cc9f1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 21:41:47 +00:00
Andy Wickham d74a679987 Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev am: 7f31d4c0ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040589

Change-Id: I3ec33607bb9d2ac702b4b0dc608538a4fd31b022
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 21:41:25 +00:00
Brian Isganitis f733a716fd Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev 2022-09-29 21:13:59 +00:00
Andy Wickham 7f31d4c0ec Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev 2022-09-29 21:08:20 +00:00
Andy Wickham 4c96814b1c Fix layout for multi-element rows (e.g. Screenshots).
Demo with standard 3 element row and overflowing 2 element row:
https://drive.google.com/drive/folders/1o1gvD3mOxFmVW2vqjn3D1Gukz-ie_kmW?resourcekey=0-bHRsdqpUWITEUo39tAMJDg&usp=sharing

Test: Manually with 1, 2, 3, and 4 length rows of 3 screenshots
and putting web suggestions into 2 columns.
Fix: 247837336
Bug: 239927522

Change-Id: I391beb7a24f189b5e55cb7b65c5ffc8349c83cfc
2022-09-29 10:38:20 -07:00
Pat Manning a34a9a0a18 Add screenshot test for edit state drop targets.
see: go/tapl-run-on-hold-event

Bug: 241386128
Test: HomeScreenImageTest.java
Change-Id: I5d6421c8da7d06a9eb77da249957c64d413524f1
2022-09-29 11:12:31 +01:00
Tracy Zhou c0095e81ae Remove ENABLE_QUICKSTEP_LIVE_TILE flag
Fixes: 249627137
Test: manual - (1) swipe up from app (2) swipe home (3) quick switch (4) split in overview
Change-Id: Ibe56ba3824b379b20fb3f0aa09be4d6bdb5abaa1
2022-09-29 04:58:52 +00:00
Android Build Coastguard Worker 53bac7c6b3 Snap for 9115816 from 0c7d83bb14 to tm-qpr1-release
Change-Id: Id1c0e87a0a7ae4b3e857277809aa876cd1de3082
2022-09-28 23:26:13 +00:00
Federico Baron 0602e93426 Fix the entry animation for delightful pagination in folders
Here we fix the animation that was broken in earlier CL's for delightful pagination, now the page indicator has the same smooth entry animation as the dots

Bug: 247561880
Test: manual
Change-Id: I3e2099ba4f5ccfdbc9b4dfe5b48a1c44dbdeda1e
2022-09-28 16:17:51 -07:00
Vinit Nayak 5317efb7fc Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: 888f745490 am: 64e8d014a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20056375

Change-Id: I7984e13e5169750ba8aedffdbf4bc485dc4a00ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 19:41:32 +00:00
Vinit Nayak 64e8d014a0 Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: 888f745490
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20056375

Change-Id: I897b8dde1e1691f4fc2c9ca632dcf7579f186b3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 18:58:35 +00:00
Vinit Nayak 888f745490 Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev 2022-09-28 18:30:16 +00:00
Arthur Hung 401b9b6614 Refactor back navigation animtion (2/2)
Use IBackAnimationRunner to receive the animation leashes.
Use IRemoteAnimationFinishedCallback to callback when animation finished.

Bug: 241808055
Test: atest BackNavigationControllerTests BackAnimationControllerTest
Change-Id: I315df5079b30159fc0f6da2b568af334d14b32a0
2022-09-28 02:27:23 +00:00
Holly Jiuyu Sun a81200b8ee Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev am: 0c7d83bb14 am: 770e65305f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029264

Change-Id: Id17b7fdb1c66e8b317df1c77e0c49da3a1197aab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 01:21:57 +00:00
Holly Jiuyu Sun 770e65305f Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev am: 0c7d83bb14
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029264

Change-Id: I6d3b94b50bc2747df873413216b84cacb34ba87d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 00:25:54 +00:00
Holly Jiuyu Sun 0c7d83bb14 Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev 2022-09-27 23:49:53 +00:00
Brian Isganitis c7c2e8d7e6 Avoid syncing voice interaction background window for skipAnim=true.
Test: Manual
Fix: 236924161
Change-Id: Iaf95221678d36f9b5782fd8c4bda626b946565a9
2022-09-27 23:36:24 +00:00
Android Build Coastguard Worker 1cde8ddd7b Snap for 9111705 from d8b78523ca to tm-qpr1-release
Change-Id: I0b2665d83be388ec57face595d0b3126846d029c
2022-09-27 23:25:18 +00:00
Sebastian Franco fa37a0ad9b Fix repeated empty workspaces after changing the grid size.
There are specific scenarios when you can force an extra empty
workspace after changing the grid, fortunately there is a
function that removes empty workspaces.

Fix:229349287
Test: Add a widget in a new empty workspace page, change the
grid then remove the widget in the new grid size then return
to the previous grid and it shouldn't have an empty workspace.

Change-Id: I7b73ae2ca058bc84b3b361930e3dc856c045281b
2022-09-27 21:51:17 +00:00
Bill Yi 977cad62e0 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 0f57d8fb0c -s ours am: 93105ebf75 -s ours am: 5fb4baf917 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: Iec61180bf7cd3f65efce08a024509dc5bad15b03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 19:54:33 +00:00
Bill Yi c858d86156 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 0f57d8fb0c -s ours am: 986c1a40ca -s ours am: d3902030d6 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: I782e895263a1fd9559122b9ba04933675f3aad90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 19:36:38 +00:00