PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
58,436 Commits 1 Branch 0 Tags
67fa00189dcafe5df7ebc08c3dd1e6ccc2a7e276
Commit Graph

58436 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sunny Goyal 64453ae482 Introducing feature flag for optimizing overlay service connection 
Bug: 254903450
Test: n/a
Change-Id: I2286be8583cc6dc46921b9ba8ef5505e5b8f0bf8
 2022-10-21 14:07:16 -07:00
Vinit Nayak 812bb6604d Merge "Use updateButtonLayoutSpacing() for all states" into tm-qpr-dev am: cb26c1a245 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20247867

Change-Id: Ifbb6aff2ede81eff756128c7b2b35612bee6d86d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-21 21:00:14 +00:00
Vinit Nayak cb26c1a245 Merge "Use updateButtonLayoutSpacing() for all states" into tm-qpr-dev 2022-10-21 20:32:10 +00:00
Sunny Goyal 2e0bdd4f49 Merge "Optimizing some icon generation code:" into tm-qpr-dev am: 415fe0c183 am: ef188e8c23 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040405

Change-Id: Ia9595c728b3ab46b8530a689598bb6cc7c433477
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-21 20:04:34 +00:00
Federico Baron 0abfda8f2f Rename first page pinned widget to mFirstPagePinnedWidget 
mQsb is the name used for the first page pinned widget. This variable name is bad since in some launchers the first page pinned widget is a qsb but sometimes it is a smartspace. Renaming the variable to mFirstPagePinnedWidget is a more accurate name for this variable.

Bug: 251259222
Test: N/A
Change-Id: I6d3c74163995d2267510ee546924917062c4955c
 2022-10-21 13:01:24 -07:00
Federico Baron a56f08e677 Set smartspace to 30% visibility on workspace edit for home gardening 
Here we set the smartspace to have 30% visibility to follow the guidelines set by https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229

Bug: 251259222
Test: Enter drag mode in workspace with SHOW_HOME_GARDENING flag on to see the changes
Change-Id: Ia2ef4f1a49549fef9f8fbea7c007db8b81972f71
 2022-10-21 13:00:58 -07:00
Sunny Goyal ef188e8c23 Merge "Optimizing some icon generation code:" into tm-qpr-dev am: 415fe0c183 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040405

Change-Id: Id325662e61d5cdcc625923536a8458eb44fdd9b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-21 19:17:35 +00:00
Schneider Victor-tulias ee0bc03d58 Decrease TAPL All Apps scrolling flakiness 
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
 2022-10-21 12:12:38 -07:00
Sunny Goyal 415fe0c183 Merge "Optimizing some icon generation code:" into tm-qpr-dev 2022-10-21 18:27:54 +00:00
Federico Baron 79cc65d133 Autohide and autoshow pagination in workspace 
Added code similar to WorkspacePageIndicator.java in order to autoshow and autohide the pagination in Workspace using PageIndicatorDots.java

Bug: 249773534
Test: Manual
Change-Id: I3b26d929d71510cf2f9d5342ee4c59007b8429cd
 2022-10-21 10:55:26 -07:00
Mady Mellor 9a90c2d521 Hide launcher when freeform tasks are visible 
This CL introduces a new controller to manage the visibility of the
launcher workspace when desktop mode is active and freeform tasks
are visible.

This controller will be notified when the sysui state flag related
to freeform task visibility is changed.

The controller will modify the workspace visibility as well as
the flags on the activity indicating if it's been paused / resumed
based on freeform tasks being visible or not.

Bug: 245569277
Test: manual -  enable desktop mode and open some freeform tasks
             => observe that the contents of launcher is hidden and
                taskbar shows
             -  remove all of the freeform tasks
             => observe that the contents of launcher reappears along
                with the hotseat.
Change-Id: I378ab97b40cbb954a06f4e2426b195efddad905c
 2022-10-21 10:06:54 -07:00
Vinit Nayak 2a2fbfe319 Use updateButtonLayoutSpacing() for all states 
* During a merge conflict we prevented
updateButtonLayoutSpacing() from running if device was
in setup mode, however the code that does setup layout
is in there.

Fixes: 254589281
Test: Went through setup, back button shows up
where expected

Change-Id: Ib496bfc0e3ac9023a9fc5071867c3779721ab8ab
 2022-10-20 23:11:33 -07:00
Vinit Nayak 61d94834f7 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev am: b9b7c38d55 am: 05e238ff32 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20169868

Change-Id: I5c1a164b627794f1f25007ce467bd33bcc26c84f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-21 01:16:27 +00:00
Vinit Nayak 05e238ff32 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev am: b9b7c38d55 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20169868

Change-Id: I2d4308adb3a6396732b663a2f05e9af115318261
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-21 00:43:22 +00:00
Vinit Nayak b9b7c38d55 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev 2022-10-21 00:07:53 +00:00
Ats Jenk b5b3b054d1 Clicking on desktop tile brings apps to front 
Override launchTasks() method from TaskView to ensure we always call
into WMShell to bring desktop apps to front. And don't run single task
animation logic.

Bug: 254738174
Test: manual, enable shell transitions, click on desktop tile in recents
Change-Id: Ibe85cbe14d3378a89ba7bfd5f394f0c3e44f304d
 2022-10-20 17:06:47 -07:00
Brian Isganitis cf6e195a43 [automerger skipped] Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev am: 2bcc3f8599 am: 7ed3c82636 -s ours 
am skip reason: Merged-In I9a4679ba82cacb5e2648481274876dbfc95d80ce with SHA-1 c4430c9cd7 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19930974

Change-Id: I90172d37a2a7c5deee67302a85592178c7e8ba7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 23:32:50 +00:00
Treehugger Robot 5f65096bfe Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3 am: 14946c1fa3 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: Id765742b2e4767888137a01116f2bad1bba859a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 23:32:40 +00:00
Brian Isganitis 7ed3c82636 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev am: 2bcc3f8599 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19930974

Change-Id: Id1010f7f19454d51b19a11b1d5ed72fe39632332
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 23:31:44 +00:00
Vinit Nayak eba71a1c8f Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev am: e690ef7f80 am: c136a1f837 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20232996

Change-Id: If5447ddb1e7b0c8f2bad456c82a6993e56f97a7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 23:18:29 +00:00
Treehugger Robot 14946c1fa3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I748f2372116aa8bba282a0f1925e3968a9fed0ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 23:16:08 +00:00
Vinit Nayak c136a1f837 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev am: e690ef7f80 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20232996

Change-Id: Ife8a1a5869452cc869a58b6bac126f74a2afab81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 23:01:33 +00:00
Sukesh Ram c6d4df87f0 Added Tests for Secondary Display Launcher 
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
Merged-In: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
 2022-10-20 22:58:46 +00:00
Brian Isganitis 2bcc3f8599 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev 2022-10-20 22:54:06 +00:00
Vinit Nayak e690ef7f80 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev 2022-10-20 22:49:57 +00:00
Treehugger Robot 533b937fd3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I6b47e8706afe05f5fdac403e79c87a533fbcc2c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 22:45:27 +00:00
Jeremy Sim 9c6a7abf9c Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev am: 8edca84cd5 am: 0c1d05a636 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20155090

Change-Id: I849721e96b7ba080b2367d1dddfd057878108776
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 22:02:28 +00:00
Treehugger Robot 35157974d4 Merge "Fix errorprone warnings that should be errors" 2022-10-20 21:45:41 +00:00
Jeremy Sim 0c1d05a636 Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev am: 8edca84cd5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20155090

Change-Id: Ic5165669dd22c312bf2b73382134c607f48f199f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 21:31:27 +00:00
Jeremy Sim 8edca84cd5 Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev 2022-10-20 20:59:49 +00:00
Brian Isganitis f43016bd7d [automerger skipped] Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev am: ddbe35cc87 am: 043e982d00 -s ours 
am skip reason: Merged-In I817d8ef700f2d7caec6fa63123935502f17f2d2f with SHA-1 189554616c is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915466

Change-Id: I57f59c1fcb08ff226a18c0030c15eb760f57a00a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 19:24:04 +00:00
Brian Isganitis 043e982d00 Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev am: ddbe35cc87 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915466

Change-Id: Ifa46e8a0331d53ae35cc3d4f3cfbaf0e1b39a574
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 18:36:51 +00:00
Sukesh Ram aee55077cc Fix crash on long press of prediction row icons 
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
Merged-In: I9a4679ba82cacb5e2648481274876dbfc95d80ce
 2022-10-20 18:11:15 +00:00
Brian Isganitis ddbe35cc87 Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev 2022-10-20 18:08:07 +00:00
TreeHugger Robot 6c0cda959c Merge "Removing the dependency on LooperExecutor in ViewCapture" into tm-qpr-dev am: 4206239318 am: dc24cc87fc 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20237551

Change-Id: I9c0b7b23f2b748a07e39b45875d9a69b8e299808
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 17:54:07 +00:00
Sunny Goyal fc1928e324 Optimizing some icon generation code: 
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
 2022-10-20 10:40:54 -07:00
TreeHugger Robot dc24cc87fc Merge "Removing the dependency on LooperExecutor in ViewCapture" into tm-qpr-dev am: 4206239318 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20237551

Change-Id: I8130c06a6008981980ba4a7bfe4da8b5f348cbde
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 17:05:14 +00:00
TreeHugger Robot 0ca9454e19 Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev am: 26e7dc1789 am: 3b908345d3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20224650

Change-Id: Id25c25954e185ef9e46fbe9b8f436c7af884af8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 16:55:59 +00:00
TreeHugger Robot 4206239318 Merge "Removing the dependency on LooperExecutor in ViewCapture" into tm-qpr-dev 2022-10-20 16:41:46 +00:00
TreeHugger Robot 3b908345d3 Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev am: 26e7dc1789 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20224650

Change-Id: Ife5fb1ef7445177398bc3daf2e7a6f68897fb1a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 16:38:27 +00:00
TreeHugger Robot 26e7dc1789 Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev 2022-10-20 16:35:52 +00:00
Sunny Goyal a18e285fe7 Removing unnecessary RemoteAnimationTargetCompat 
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
 2022-10-20 16:25:21 +00:00
Thales Lima ed8c69baca Make all handheld grids scalable 
Also increase the icon size in the XML until the icon is sized correctly.

Fix: 239419094
Bug: 235886078
Test: manual
Change-Id: I0c7d75181a61177cc5993ba7002c3ccc8fd60fbf
 2022-10-20 11:51:59 +01:00
Thales Lima a64a914ddf Calculate taskbar content size for edu 
Using the value calculated in layout was not working because TaskbarView onLayout() was being called after TaskbarEduView onMeasure(). Now uses the same value on all orientations based on taskbar icon size.

Fixes: 252945031
Test: manual
Change-Id: Ib6914901638c82f3b3ec4c9b86f6c20e84d34d0f
 2022-10-20 11:48:06 +01:00
Tony Huang 0fb921ef36 Snapshot 2 tasks when swipe up split case 
Swipe up snapshot only capture the top one task, but for split
screen case it should capture two tasks otherwise the snapshot
in overview would be empty in some cases.

Fix: 247420799
Test: manual
Test: pass existing tests
Change-Id: I3acd477eaca3cb98d86e2446dbb2dbd6295c687d
 2022-10-20 14:10:06 +08:00
TreeHugger Robot a826533ee2 Merge "Remove redundant createAdapter override." into tm-qpr-dev am: 8a40f0557b am: 9ae49dcbca 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240748

Change-Id: I932219ddafcfb80ae866c5b25a90ff6e78c88653
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 05:59:39 +00:00
TreeHugger Robot 9ae49dcbca Merge "Remove redundant createAdapter override." into tm-qpr-dev am: 8a40f0557b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240748

Change-Id: I181c471339e2bf293ec19cb5c2ce25cc59b1e4fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 05:26:36 +00:00
TreeHugger Robot 8a40f0557b Merge "Remove redundant createAdapter override." into tm-qpr-dev 2022-10-20 04:57:15 +00:00
Vinit Nayak 981034687a Scale screenWidth for split proportionally for thumbnail matrix 
* Instead of passing in screenWidth to be that
of entire screen when using split, scale screenWidth
to that of only the amount that the given split app
is taking.
* Created TODO(b/254378592) to consolidate different
SplitBounds classes

Fixes: 250817893
Test: Checked phone/tablet swiping quickswitching
portrait and landscape

Change-Id: I5c3b2076110e358366284b2c794fd8df8a79f034
 2022-10-19 21:39:50 -07:00
Sunny Goyal 361da47493 Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev am: d79f84fffe am: cc6290d81f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20215466

Change-Id: Iee38fc975ce911b3a0fa3b43a97047dd094ce956
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-20 01:33:32 +00:00