Commit Graph

58436 Commits

Author SHA1 Message Date
Vinit Nayak 7fb1336de7 Merge "Switch to screenshot when finishing recents animation for split select" into tm-qpr-dev 2022-11-03 22:26:36 +00:00
Sunny Goyal 82379187ea Adding support for multiple overlay callbacks
Bug: 193244407
Test: Presubmit
Change-Id: Ic345972056752238e7e46226533fd8f33d664213
2022-11-03 14:37:40 -07:00
Sebastian Franco 5d990eedfd Ensure that the reorder preview and what gets submited uses the same solution.
Design doc: https://docs.google.com/document/d/1RsId9OFGgkcImkkmDwWZBBvITWnGlxKVqniE3cimkqY/edit#heading=h.xzptrog8pyxf

As can be seen in the diagram in b/256770363 on every reorder the
first call in the process is MODE_SHOW_REORDER_HINT so if we make
sure that only then a solution is calculated and we reuse that
solution in the rest of the calls in the same reorder then we would
have more consistency and the animation will always be the same and
the logic state.

Fix: 256770363
Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I93a1d09f5b8cbfbc461043ee3fc41b1cab294fed
2022-11-03 14:11:01 -07:00
Sunny Goyal 774dcd06ae Relying on the controller state instead of animator state for
icon alignment

Bug: 246644619
Test: Presubmit
Change-Id: Iaa4ddd94a6d85acb9f8501263665ea78394815de
2022-11-03 13:42:09 -07:00
Sunny Goyal 50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00
Schneider Victor-tulias 0d8c5923f1 Update active gesture error detection
- Removed some unused error detection event tracking
- Updated incorrect event tracking
- Added debug new debug gesture logs

Bug: 254250355
Test: attempted several gestures and checked logs
Change-Id: Ia1291a08a9a5842addb93c30eb6d21c6c60916c7
2022-11-03 20:26:09 +00:00
Sebastián Franco ce6e5a3cb5 Merge "Wait in ReorderWidgets test for the workapce to load after changing it." into tm-qpr-dev am: 58502d0236 am: ac44f52134
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20305929

Change-Id: I6db34d93dee53196e086e042644e9819713ed55d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 20:16:20 +00:00
Sunny Goyal 6e78a800c1 Removing unused SplitScreen bounds notification from systemUI
Bug: 221961069
Test: Presubmit
Change-Id: I472a94dd1096a3c44cb378e647927637d9d67bf5
2022-11-03 12:47:41 -07:00
Sebastián Franco ac44f52134 Merge "Wait in ReorderWidgets test for the workapce to load after changing it." into tm-qpr-dev am: 58502d0236
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20305929

Change-Id: Iae0770df2ec2fba58cbe4b18d1038078e05c86c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 19:26:55 +00:00
Sebastián Franco 58502d0236 Merge "Wait in ReorderWidgets test for the workapce to load after changing it." into tm-qpr-dev 2022-11-03 18:55:50 +00:00
TreeHugger Robot 6c9814a92b Merge "Add delay after installing dummy app" into tm-qpr-dev am: 9e1f6002e5 am: e0e2b02ad2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20363621

Change-Id: I87647e4585d9eec544e1436c37b4ddde8d869ee7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 18:43:28 +00:00
Automerger Merge Worker 208c12ab95 Merge "[automerger skipped] Merge "Removing RemoteTransitionCompat and related wrappers" into tm-qpr-dev am: fc01c382bf am: ac725654dd -s ours" 2022-11-03 18:36:09 +00:00
Sunny Goyal 3e4e4a3244 [automerger skipped] Merge "Removing RemoteTransitionCompat and related wrappers" into tm-qpr-dev am: fc01c382bf am: ac725654dd -s ours
am skip reason: Merged-In Ib93640d27a9eb0401882574e37b466163dafa5b3 with SHA-1 b4f2568c69 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20275893

Change-Id: Ie94a61762eb5381635ebff8491c4b791d1a24372
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 18:35:42 +00:00
Sunny Goyal 660be38712 [automerger skipped] Merge "Removing RemoteTransitionCompat and related wrappers" into tm-qpr-dev am: fc01c382bf am: ac725654dd -s ours
am skip reason: Merged-In Ib93640d27a9eb0401882574e37b466163dafa5b3 with SHA-1 b4f2568c69 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20275893

Change-Id: I746815e362411e9ad738f5eb3a4a52ad60d922d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 18:35:41 +00:00
Schneider Victor-tulias 3ec7111a02 Update all set page navigations settings button callback
Updated the all set page navigation settings button callback to allow going back to the all set page.

Fixes: 256998811
Test: going to the navigation settings then swiping home/going to another app does not allow the user to then go back to all set page. going to navigation settings then going back sends the user back to all set page
Change-Id: I502e2264886c43fe15bed3fab3a241e9713c5da5
2022-11-03 11:12:30 -07:00
TreeHugger Robot e0e2b02ad2 Merge "Add delay after installing dummy app" into tm-qpr-dev am: 9e1f6002e5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20363621

Change-Id: If7517d29a21e1ee200c636d3e510a3fc98a9c574
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 17:27:32 +00:00
Sunny Goyal ac725654dd Merge "Removing RemoteTransitionCompat and related wrappers" into tm-qpr-dev am: fc01c382bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20275893

Change-Id: Id2f05ba29fc0c5f65074f1a9f3b3f100db12b1fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 17:24:28 +00:00
TreeHugger Robot 9e1f6002e5 Merge "Add delay after installing dummy app" into tm-qpr-dev 2022-11-03 17:17:09 +00:00
Sunny Goyal fc01c382bf Merge "Removing RemoteTransitionCompat and related wrappers" into tm-qpr-dev 2022-11-03 16:40:27 +00:00
Sam Dubey c07b410a3c Merge "Revert "Support multi users scenarios in Tapl"" into tm-qpr-dev am: 52a3bcd4bb am: 33c4597ca2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20352019

Change-Id: I42996e6b2a3496cf98db4453e82e725bfaf04857
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 14:11:14 +00:00
TreeHugger Robot 429f6e880f Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev am: bcc14682e0 am: cd271794c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20345841

Change-Id: I7aacbf9285271710a08a1356cc363391636106c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 14:05:09 +00:00
Sam Dubey 33c4597ca2 Merge "Revert "Support multi users scenarios in Tapl"" into tm-qpr-dev am: 52a3bcd4bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20352019

Change-Id: I7ddda3585c49f25f65f79ea87e6c272719c3e760
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 13:31:17 +00:00
TreeHugger Robot cd271794c8 Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev am: bcc14682e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20345841

Change-Id: I6f5ca6b81c51b91743384b8fc187788202fbec95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 13:30:30 +00:00
Sam Dubey 52a3bcd4bb Merge "Revert "Support multi users scenarios in Tapl"" into tm-qpr-dev 2022-11-03 11:40:24 +00:00
TreeHugger Robot bcc14682e0 Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev 2022-11-03 11:27:12 +00:00
Sam Dubey a3577293b6 Revert "Support multi users scenarios in Tapl"
Revert "Reduce multi users tests runtime"

Revert "Add PlatformTesting to dependency."

Revert "Move platform testing util to separate gradle module"

Revert submission 20311444-user-switch-nosleep

Reason for revert: Part of DM+Platinum montiro as a likely culprit for b/257210412. Won't be submitted if proven otherwise.
Reverted Changes:
I90b1069de:Support multi users scenarios in Tapl
I706da86a3:Add PlatformTesting to dependency.
I605cd76c4:Move platform testing util to separate gradle modu...
I64b571dc4:Reduce multi users tests runtime

Change-Id: I6310efa59fe1755feb29bef28d890e684b7164c6
2022-11-03 10:08:13 +00:00
Benno Lin ba4a0ee4c0 Merge "Support multi users scenarios in Tapl" into tm-qpr-dev am: 8f669d20d7 am: e1594e8984
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20311444

Change-Id: Iae67e72a27051373898c5451c2d6b4397a37beb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 07:56:19 +00:00
Benno Lin e1594e8984 Merge "Support multi users scenarios in Tapl" into tm-qpr-dev am: 8f669d20d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20311444

Change-Id: I4d4726252df002c9e34f29d922081a982c25e2fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 07:11:31 +00:00
Jon Miranda 82278364d1 Merge "Revert "Revert "Add a way to stash/unstash transient taskbar.""" into tm-qpr-dev am: 8ed5ac05fd am: 1b4a697e56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20356225

Change-Id: I681f41d4be494e5fb4f079d37a63f3873167c8df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 07:02:48 +00:00
Benno Lin 8f669d20d7 Merge "Support multi users scenarios in Tapl" into tm-qpr-dev 2022-11-03 06:42:19 +00:00
Jon Miranda 1b4a697e56 Merge "Revert "Revert "Add a way to stash/unstash transient taskbar.""" into tm-qpr-dev am: 8ed5ac05fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20356225

Change-Id: I105e7ac5928083ef4d3793c76a0da357338c8b3b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 06:30:53 +00:00
Jon Miranda 8ed5ac05fd Merge "Revert "Revert "Add a way to stash/unstash transient taskbar.""" into tm-qpr-dev 2022-11-03 05:58:38 +00:00
Vinit Nayak 20ce6a97fd Switch to screenshot when finishing recents animation for split select
* There's a situation where we can also let the live-tile play
if it wasn't the one selected for split select, but there's
some bug w/ the focused task that causes the thumbnail and live tile
translations to be incorrect.
* But this maintains parity.

Fixes: 255915066
Test: Starting/ending/ignoring live tile in split
never shows the cutout

Change-Id: I2f63ca44a5a1cc16df12e7b3b06ca211dc995f8d
2022-11-02 22:48:36 -07:00
Winson Chung 38779f75da Add delay after installing dummy app
- Testing hypothesis that it's taking a while for the app to be
  properly installed and showing in all apps

Bug: 256659409
Test: com.android.launcher3.ui.TaplTestsLauncher3#testUninstallFromAllApps
Change-Id: Icb1bb8bb9d98751ac8c97b300ecc39372f39c345
2022-11-03 03:47:01 +00:00
Sunny Goyal a084dbd3bd Merge "Fixing background jump when closing a widget" into tm-qpr-dev am: 031ee4cbcb am: 6988b7b308
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20304438

Change-Id: I578ef759545b5bebcf314a2022f99e428bb7ee1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 02:02:24 +00:00
Sunny Goyal 6988b7b308 Merge "Fixing background jump when closing a widget" into tm-qpr-dev am: 031ee4cbcb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20304438

Change-Id: I3d706ddc9847d75f4a5db5966675aa1d7f2be39d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 01:14:26 +00:00
Sunny Goyal 031ee4cbcb Merge "Fixing background jump when closing a widget" into tm-qpr-dev 2022-11-03 00:52:47 +00:00
Sunny Goyal 1319de88b4 Removing RemoteTransitionCompat and related wrappers
Bug: 221961069
Test: Presubmit
Change-Id: Ib93640d27a9eb0401882574e37b466163dafa5b3
Merged-In: Ib93640d27a9eb0401882574e37b466163dafa5b3
2022-11-02 23:40:48 +00:00
Sunny Goyal 5c18d07d6e Merge "Removing RemoteTransitionCompat and related wrappers" 2022-11-02 23:40:22 +00:00
Sebastián Franco c55ec5c580 Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev am: ef24d5954c am: 251567d87b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20317221

Change-Id: I4b2aa1a6b453f79655edfa546be8041850100ab0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 22:21:47 +00:00
Holly Sun a793fc6e2c Bring up IME and focus on input when scroll to top.
Do this behind a feature flag AND only when "Always show keyboard" is selected or in prefix state.

Bug: 218846025
Test: keyboard shown when swiping up for QSB and AA+ (both main and work). Keyboard not shown when either the feature flag or Always show keyboard is disabled.
Change-Id: I3df2e0e44a8313eaf749cd6b91b7f9d0b9b80ec3
2022-11-02 15:19:23 -07:00
Sebastian Franco 4a92267d1d Making code more readable by removing global variable used for optimizations
Using the stack was more efficient because it prevented the creation
of new rectangles but it makes the code harder to read and prone to
bugs if the global state of the stack of rectangles gets corrupted
in any way.

When this optimization was written in 2008 it was necessary but now I
don't think it would have a big impact. The stack size is on average
of 30 and the rectangles are only created when doing the reorder which
runs about once per second if the user moves the finger too quickly.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I35d8ee8d92f01035e72fe5763a7de47f4b6a73de
2022-11-02 22:10:14 +00:00
Sebastián Franco 251567d87b Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev am: ef24d5954c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20317221

Change-Id: I4d0343b12e67e11b0b4fc2a4e5d017f7cfdeeae4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 21:49:34 +00:00
Sebastián Franco ef24d5954c Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev 2022-11-02 21:19:44 +00:00
Saumya Prakash f70e339dfc Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev am: ccc8e9fcf4 am: c8964d66a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20342916

Change-Id: I051cbfe6c23c6242fa54e9bf223cd5645efbc744
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 19:42:17 +00:00
Vinit Nayak 6f4090cee1 Merge "Disable Drag from Taskbar in Overview" into tm-qpr-dev am: 626f322343 am: b7e684ecc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20259172

Change-Id: Ib9868ddc73158998c4000429faa966d32fc1b211
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 19:41:54 +00:00
Sunny Goyal 39b07fd66c Fixing background jump when closing a widget
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
2022-11-02 19:17:18 +00:00
Saumya Prakash c8964d66a7 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev am: ccc8e9fcf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20342916

Change-Id: I540d79b259a7d306496882a460984f11ac98a234
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 18:56:37 +00:00
Vinit Nayak b7e684ecc8 Merge "Disable Drag from Taskbar in Overview" into tm-qpr-dev am: 626f322343
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20259172

Change-Id: Id93c88d1125df4f515bcb66a64b5a739e8d090e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 18:56:24 +00:00
Saumya Prakash ccc8e9fcf4 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-11-02 18:30:21 +00:00