Commit Graph

58436 Commits

Author SHA1 Message Date
TreeHugger Robot a4937b2270 Merge "Revert "Not using shell command to enable test provider"" into sc-v2-dev 2021-08-13 23:27:18 +00:00
Lucas Dupin b259a896f5 Constrain scroll amount
Test: scroll vertically and horizontally
Fixes: 196309367
Change-Id: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
2021-08-13 15:57:41 -07:00
Alex Chau f551c876e4 Merge "launcher: hide grid options for foldables" into sc-v2-dev am: 0cba30e990 am: 298db67fd8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15472531

Change-Id: I82d22dcb706ca5ab2ba83a5994e801c3f369d022
2021-08-13 22:10:36 +00:00
TreeHugger Robot 219dff2349 Merge "launcher: correct the amount of padding for preview" into sc-v2-dev am: f952fd9256 am: 9f76d9d09a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15547452

Change-Id: I1dd9dd360249bdc6545e53498e632a5bad977586
2021-08-13 22:07:49 +00:00
Alex Chau 298db67fd8 Merge "launcher: hide grid options for foldables" into sc-v2-dev am: 0cba30e990
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15472531

Change-Id: Ifd297a22641a8d3a074c27d637ee895a1fc24de0
2021-08-13 21:59:14 +00:00
Vadim Tryshev 169c4e88cd Revert "Not using shell command to enable test provider"
This reverts commit 5f80e92bda.

Reason for revert: We need to see if this has caused b/196586808

Bug: 196586808
Test: presubmit
Change-Id: I078f0d4e83f5f1db19e9e0a5afec4f3058156745
2021-08-13 21:56:07 +00:00
TreeHugger Robot 9f76d9d09a Merge "launcher: correct the amount of padding for preview" into sc-v2-dev am: f952fd9256
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15547452

Change-Id: I1aa02ab7eb194e41a4ecce64a9d849c0d64c0fb6
2021-08-13 21:40:54 +00:00
Dave Mankoff 78f9648aec Merge "Changes to the signature of PluginManagerImpl." into sc-v2-dev 2021-08-13 21:12:40 +00:00
TreeHugger Robot b76df9dbd6 Merge "Removing some instrumentation for a workarounded bug" into sc-v2-dev am: 87cf3efe06 am: e9974d7d4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524189

Change-Id: I59adb5f869d491dbb7720bd79f616a4cc94e1452
2021-08-13 21:12:35 +00:00
Alex Chau 1e4484669d Remove widget panel
- Remove all usage of LEFT_PANEL_ID and fixed left panel code
- For preview renderer, load screen 0 + screen 1 instead
- Added a split display specific default workspace layout, with a placeholder app to pass test before we implement page pairing(b/196376162)
- Known issue: If screenId 1 is deleted, right panel will disappear from Wallpaepr & Style because there is no screenId 1. Will be resovled after page pairing(b/196376162)

Bug: 175939730
Test: manual and TaplTestsLauncher3#testWorkSpace
Change-Id: Icac1c94165c14a49c17897c45355b6cdc4d87e91
2021-08-13 21:48:35 +01:00
Alex Chau 0cba30e990 Merge "launcher: hide grid options for foldables" into sc-v2-dev 2021-08-13 20:44:34 +00:00
Jon Spivack bb7553017c Add callback to ImageActionUtils for unresolved intents
Adding an optional callback to ImageActionUtils.persistBitmapAndStartActivity allows for external handling of the case in which the given intent cannot be resolved. The main use case is for NIU Actions when the user has chosen an assistant that does not support the feature. TaskOverlayFactoryGo provides a callback that shows a dialog in this case.

Various parts of TaskOverlayFactoryGo were also made public for better testability.

Bug: 196125662
Bug: 192406446
Bug: 195681795
Test: m -j RunLauncherGoGoogleRoboTests ROBOTEST_FILTER=TaskOverlayFactoryGoTest
Change-Id: I64f3a1274bc942a64e964dca20bd4245e336ad9d
2021-08-13 13:30:22 -07:00
TreeHugger Robot e9974d7d4c Merge "Removing some instrumentation for a workarounded bug" into sc-v2-dev am: 87cf3efe06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524189

Change-Id: I0172730d135c4584db080447892a498cbca4e876
2021-08-13 20:26:05 +00:00
TreeHugger Robot f952fd9256 Merge "launcher: correct the amount of padding for preview" into sc-v2-dev 2021-08-13 19:19:18 +00:00
Dave Mankoff 3258a9f790 Remove #handleWtfs from PluginInitializer.
This method was empty anyways.

Bug: 194781951
Test: manual
Change-Id: I404704090dc360e05b1db04815d394d47d63af28
2021-08-13 14:56:30 -04:00
Dave Mankoff 24e77c563c Remove PluginInitializer.
Bug: 194781951
Test: manual
Change-Id: I38b90ac7f310e4c2374d60a42f493e723c90401a
2021-08-13 14:56:30 -04:00
Dave Mankoff a6646be349 Remove #getPrivilegedPlugins from PluginInitializer.
Bug: 194781951
Test: manual
Change-Id: I61bcbdd92bdf7295060f00dac9b657b1a67b7f01
2021-08-13 14:56:26 -04:00
TreeHugger Robot 87cf3efe06 Merge "Removing some instrumentation for a workarounded bug" into sc-v2-dev 2021-08-13 18:42:22 +00:00
Thales Lima dab1b2922c launcher: correct the amount of padding for preview
The padding on left and right should be added only on the left for left
page and only on the right for right page.

Fixes: 195410512
Test: open Wallpaper & Style and check the space between the pages
Change-Id: Ib27c632d2fb07d4708bd101e555e14e31a26ff9d
2021-08-13 18:22:26 +01:00
Thales Lima 7ec8382044 launcher: hide grid options for foldables
Some grid options are too dense for foldables (those with 5 icons), so
we are hiding them on those devices.

This also move the parsing to be done on InvariantDeviceProfile only.

Fixes: 183140646
Test: open Wallpaper & style and change app grid options
Change-Id: I771571db02709db5d0f814236060c57ce0180cd1
2021-08-13 16:07:05 +00:00
Tracy Zhou 2bb92ba49d Update LauncherInstrumentation to consider tablet w/o nav bar
Bug: 191660313
Test: TaplTestsLauncher3
Change-Id: I7bbcc2f9c3eb7b62dc2abd94b63df22b7168bf15
2021-08-13 08:54:35 -07:00
Dave Mankoff 08d1a77825 Rename PluginInstanceManager to PluginActionManager.
New PluginInstance class.

Bug: 194781951
Test: manual
Change-Id: I5274b6380acaad8bb2e900cfdce772b71add9483
2021-08-13 10:50:32 -04:00
Dave Mankoff 1095a50dfa Updates to constructor of PluginInstanceManager.Factory
Bug: 194781951
Test: manual

Change-Id: I510dcd3b405988320052944b412e1d18360144ef
2021-08-13 10:50:21 -04:00
Dave Mankoff 630ae94833 Pass main executor to PluginInstanceManager.Factory.
Bug: 194781951
Test: manual
Change-Id: I1667023887e0c8d1dc86fce1717a3032b6721684
2021-08-13 10:18:01 -04:00
Dave Mankoff 1d5e1dc8d1 Pass Executor to to PluginInstanceManager.Factory.
Bug: 194781951
Test: manual
Change-Id: I6dc699869d041aab8f5d1e7a128b4f67adfd78dc
2021-08-13 10:16:09 -04:00
Dave Mankoff 13f50b9898 Changes to the signature of PluginManagerImpl.
Bug: 194781951
Test: manual
Change-Id: Iafc5232dfdb1cc1c554de925c2f0d2ad5f6439e2
2021-08-13 10:01:42 -04:00
Ben Lin 15181b54b0 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev am: 99b5d13952 am: c3d09d22c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524184

Change-Id: I4025427c229838a0104625a266100fcfc184c066
2021-08-13 10:08:32 +00:00
Ben Lin c3d09d22c1 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev am: 99b5d13952
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524184

Change-Id: I1440056c2a451a241ed7b2b55810db958d599c14
2021-08-13 08:41:26 +00:00
TreeHugger Robot 05e2828a6a Merge "Restoring generating artifacts" into sc-v2-dev am: 73ad3abc29 am: 0cce835cf7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15547434

Change-Id: Id1e0b77ad846d586d11dfcb2dc0d42ef99e7676e
2021-08-13 05:11:13 +00:00
TreeHugger Robot 0cce835cf7 Merge "Restoring generating artifacts" into sc-v2-dev am: 73ad3abc29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15547434

Change-Id: Ia9b596701d4d46782c825ff3a37e4da26e91ee81
2021-08-13 04:58:02 +00:00
Android Build Coastguard Worker c340c58745 Snap for 7637695 from 1989770a55 to tm-release
Change-Id: I78e6e2dc735cd830bee557fa340816ddc06703e6
2021-08-13 03:08:23 +00:00
TreeHugger Robot 21cb8f7bd0 Merge "Update two panel specific launcher home icon sizing" into sc-v2-dev am: 00d0ce9b3b am: 39a93b1d8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15472539

Change-Id: I4df81aeab62eb168bb6202b2a3f806e186349b00
2021-08-13 01:41:13 +00:00
TreeHugger Robot 39a93b1d8d Merge "Update two panel specific launcher home icon sizing" into sc-v2-dev am: 00d0ce9b3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15472539

Change-Id: I5d2fbfd71d5d69f3343854e94498ed5c23c84770
2021-08-13 01:26:37 +00:00
Ben Lin 99b5d13952 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev 2021-08-13 01:09:19 +00:00
TreeHugger Robot 73ad3abc29 Merge "Restoring generating artifacts" into sc-v2-dev 2021-08-13 00:44:57 +00:00
TreeHugger Robot 1989770a55 Merge "Not using shell command to enable test provider" into sc-v2-dev am: 7d87779deb am: 841a4fec3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15533100

Change-Id: Idb53cf74dbb1af7d5cc03831f04edaa15af51462
2021-08-12 23:27:26 +00:00
TreeHugger Robot 841a4fec3c Merge "Not using shell command to enable test provider" into sc-v2-dev am: 7d87779deb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15533100

Change-Id: Ia359325ff80abaa1a43d52207d01085d0f700d38
2021-08-12 23:14:39 +00:00
Android Build Coastguard Worker 48f9424777 Snap for 7636897 from 7d87779deb to sc-v2-release
Change-Id: Icd1bcd77369ac673065e5308bfdf97172905a657
2021-08-12 23:08:16 +00:00
vadimt 303298de84 Restoring generating artifacts
Bug: 189874683
Test: presubmit
Change-Id: I82503900a8b7ce916a54437456007dec00016c47
2021-08-12 16:04:05 -07:00
Android Build Coastguard Worker af79a6ff8c Merge cherrypicks of [15548052, 15548053, 15548731, 15548784, 15548801, 15548711, 15548732, 15548733] into sc-release
Change-Id: Ic72b92ffea5eac96a57fcba850588215505f411a
2021-08-12 22:36:02 +00:00
Lucas Dupin b9472327b1 Adjust all apps zoom level
The All Apps scrim fades in early, covering part of the zoom animation.
We need to adjust the max zoom in order to make All Apps consistent with
Overview, -1, and Shade.

Test: pull up the all apps drawer
Fixes: 195992422
Change-Id: Ia7bbe17fe7f227dd0a16ba7d21b402cff57176f0
(cherry picked from commit f168bb7aaf)
(cherry picked from commit 3f6a4e6bf5)
2021-08-12 22:35:49 +00:00
Ben Lin 1e49216401 Do not set user active hints when Shell Transition is on.
Previously, we hint at user active in order to let the launcher know at
an earlier time that the user is about to go home, to provide PiP a
shelf offset. However with Shell Transitions, this is now being done
instantly as the launcher activity is resumed right as user touches down
on the gesture pill. We then no longer need this for shell transitions.

Bug: 165793917
Test: Enable Shell Transitions, go home to enter PIP, and open another
app - see that PIP auto moves downward now that shelf height has changed

Change-Id: I347c885425ce820a42ebfcc15082862d04aa1a7d
2021-08-12 15:17:31 -07:00
TreeHugger Robot 00d0ce9b3b Merge "Update two panel specific launcher home icon sizing" into sc-v2-dev 2021-08-12 21:47:25 +00:00
Brian Isganitis 758c141c3d [automerger skipped] Merge "Update preferences to Material Next styling" into sc-qpr1-dev am: e52a4e39af -s ours am: e0c4a090d8 -s ours am: e562968cde -s ours
am skip reason: Merged-In I346bbf819f3fe1eb13b47125b53c15baab11e439 with SHA-1 93031bc2ae is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15521744

Change-Id: I87ff1bfebaa824100b2a18e14c55fe53d4320486
2021-08-12 21:45:52 +00:00
Brian Isganitis e562968cde [automerger skipped] Merge "Update preferences to Material Next styling" into sc-qpr1-dev am: e52a4e39af -s ours am: e0c4a090d8 -s ours
am skip reason: Merged-In I346bbf819f3fe1eb13b47125b53c15baab11e439 with SHA-1 93031bc2ae is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15521744

Change-Id: I9856d8862dda81e6bfc3e77117f6bf8c1342ff34
2021-08-12 21:36:20 +00:00
Sunny Goyal 57e0866fdd Fixing ModelPreload cancelling existing load
When a model preload call was made while the loader task is running
(eg: on enabling/disabling icon theme, Launcher reloads and then
launcher preview start a model-preload), it would cancel the original
loader and then start a new loader with empty callbacks. So the
model indeed get loaded, but the original callbacks never got notified
of it.

> Instead we only start preload if an existing task is not running.
> Also when preloading, we use existing callbacks, instead of using
  empty callbacks

Bug: 193851085
Bug: 195155924
Test: Verified repro steps
Change-Id: I0a96310be8489756f364aa2a12e4345e1418733d
2021-08-12 21:33:33 +00:00
Brian Isganitis 7d4917ae19 [automerger skipped] Merge "Update preferences to Material Next styling" into sc-qpr1-dev am: e52a4e39af am: 64e6402b2a -s ours am: 5850c24e06 -s ours
am skip reason: Merged-In I346bbf819f3fe1eb13b47125b53c15baab11e439 with SHA-1 93031bc2ae is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15521744

Change-Id: I8fc09038faa6e6f02ff05523c245393847e22b4d
2021-08-12 20:26:04 +00:00
Brian Isganitis 5850c24e06 [automerger skipped] Merge "Update preferences to Material Next styling" into sc-qpr1-dev am: e52a4e39af am: 64e6402b2a -s ours
am skip reason: Merged-In I346bbf819f3fe1eb13b47125b53c15baab11e439 with SHA-1 93031bc2ae is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15521744

Change-Id: Iff24d0b2d4abebfc032124a8f5f1aadf6a762a05
2021-08-12 20:11:28 +00:00
TreeHugger Robot 7d87779deb Merge "Not using shell command to enable test provider" into sc-v2-dev 2021-08-12 19:40:19 +00:00
Brian Isganitis e0c4a090d8 [automerger skipped] Merge "Update preferences to Material Next styling" into sc-qpr1-dev am: e52a4e39af -s ours
am skip reason: Merged-In I346bbf819f3fe1eb13b47125b53c15baab11e439 with SHA-1 93031bc2ae is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15521744

Change-Id: I56c47fca463c096fd4164f0d9d4a8472412ce241
2021-08-12 19:19:57 +00:00