8eb1c3bde5
Merge "Fix issue in RTL where swipes on Launcher Smartspace are intercepted." into tm-qpr-dev
2022-11-22 16:53:04 +00:00
171ee669de
Fix test and DeviceProfile dump
...
The test was parsing the paddings file with the wrong context passed to the dump method.
Fix: 259998761
Test: DeviceProfileTest
Change-Id: Ia5c243348d7334387bd7a15c3e496a1dc81570a5
2022-11-22 15:57:42 +00:00
7d633ecb07
Remove on drag listener after drag ended
...
Remove the on drag listener for the drag layer
in the taskbar after ACTION_DRAG_ENDED is received
This is an additional refactoring discussed
in ag/20490352
Bug: 258850827
Test: manually reproduced the steps in the bug
Change-Id: Ibe207001f41d3ba97a8acaf17d633cbd6682fafd
2022-11-22 06:07:09 +00:00
70fe810931
Merge "Cleanup overview threshold which was only needed for 2-button mode" into tm-qpr-dev am: 654ba7f6a8 am: 8ae825c3ff
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20524510
Change-Id: I4abfaadf653b016bec37778ba245f964e8ca02eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-22 02:24:01 +00:00
8ae825c3ff
Merge "Cleanup overview threshold which was only needed for 2-button mode" into tm-qpr-dev am: 654ba7f6a8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20524510
Change-Id: I4b79ec1b38509bdc5c7e855d06b529e756f2cdbf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-22 01:50:19 +00:00
654ba7f6a8
Merge "Cleanup overview threshold which was only needed for 2-button mode" into tm-qpr-dev
2022-11-22 01:16:26 +00:00
6d66ad20cf
Fix issue in RTL where swipes on Launcher Smartspace are intercepted.
...
The `+ getScrollX()` translation is a duplicate, because
`mapCoordInSelfToDescendant` also does it internally. Same for the `+
getScrollY()`.
This wasn't an issue in LTR because the top left corner of the root view
is the same as the top left corner of the first page. `getScrollX()`
returns 0 in that case.
In RTL, the second page is to the left of the first page. If the touch
is on the first page, `+ getScrollX()` translates it outside of the
first page. This incorrectly sets mIsEventOverFirstPagePinnedItem to
false, leading to the swipe being intercepted.
Bug: 240380590
Fix: 240380590
Test: manual
Change-Id: I51f534695401ce527da8d2158130a4d54b086f3d
2022-11-21 23:52:20 +00:00
3d72ac1a78
Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS.
...
Bug: 260002412
Test: enable flag
Change-Id: I4d82a853061b1540b6c6aea5e58b05a3ea6638e0
2022-11-21 23:46:34 +00:00
dec4305d0c
Refactor GridSizeMigrationTaskV2
...
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.
This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.
Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
2022-11-21 15:24:38 -08:00
d5529bd651
Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev am: db81133e94 am: 1326dc1981
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20523600
Change-Id: Idfed55fab3f55b7b8dfacd42a854c2db5078f5ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 22:36:58 +00:00
04ce9fa3ef
Adding the flag for putting widget host in the background
...
Bug: 235358918
Test: N/A
Change-Id: I300bb5e293de6995a0e69402a6e337739055ca59
2022-11-21 14:17:50 -08:00
1326dc1981
Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev am: db81133e94
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20523600
Change-Id: I021598ca2f8cc2cc159ff0cb849b56ef3cadc682
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 22:01:44 +00:00
db81133e94
Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev
2022-11-21 21:45:47 +00:00
7a19cccafe
Override displacement for transient taskbar instead of mCurrentShift
...
mCurrentShift is based on displacement, but is used and set in different
places. To keep consistency throughout, we should override the
displacement at the source instead.
Test: manually swiped up between home/overview threshold and catch up
threshold; let go to go to overview and ensure no jump occurs.
Flag: teamfood (ENABLE_TRANSIENT_TASKBAR)
Fixes: 259981285
Change-Id: Id9f5b2bcdc2e56e15ddb6d93c4ee5d5ececc094d
2022-11-21 20:14:56 +00:00
654c3d1b98
[Toast] Add a feature flag for rich answer
...
Bug: 241295640
Test: tested with opt-in suggest data.
Change-Id: I424525eed93c60e77566bcaf673f9f1ff61e1fa1
2022-11-21 19:44:44 +00:00
3b47499e3a
Merge "Add onTaskMovedToFront to close floating views" into tm-qpr-dev am: 1a8b95a9d4 am: 5dd9cffa5d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20483285
Change-Id: I6d3f263d76eb6cb7e788da724562a23895b584bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:27:25 +00:00
a1585054e0
Merge "Do not start drag from pre-drag if cancelled during animation." into tm-qpr-dev am: 0ccbd7334c am: 5ff72eaa46
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20522179
Change-Id: I83fb16775b5080ed29fab628b7a4ddf7f3113237
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:27:17 +00:00
817b135167
Merge "Still launch disabled item if we can't handle its click." into tm-qpr-dev am: 455eca41be am: 183f07e0da
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20514045
Change-Id: I1ef05a3627aa58874d4911acd8fba153b01d2b36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:27:09 +00:00
d2f650d1c3
Merge "Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."" into tm-qpr-dev am: b9e03da563 am: 8b9090cc35
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20521649
Change-Id: Ic9eeffb4cdfd4fd065e19de8abd046a9a553f69f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:26:53 +00:00
7b022b93f8
Merge "Increase icon size to be closer to spec" into tm-qpr-dev am: 81a994e9a7 am: 1414f12c14
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20500530
Change-Id: Ic92db57de677e39bb299f7d175b9ed191992d7d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:26:39 +00:00
1450e67a32
Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev am: 104517cefb am: 3ea711d992
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411886
Change-Id: I17213ea8abe889aa6498da94ec543514202af6fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:26:30 +00:00
e447c1699b
Merge "Fix NPE from using DeviceLockedInputConsumer after the surface has been released" into tm-qpr-dev am: 8700307b23 am: d46450dd1f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20501358
Change-Id: I6773cd859ed8190c12468ecf986f0a4a8c158274
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:25:31 +00:00
5dd9cffa5d
Merge "Add onTaskMovedToFront to close floating views" into tm-qpr-dev am: 1a8b95a9d4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20483285
Change-Id: I02c2f8c040064ec5c0f304fc86d76199f799abe1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:21:15 +00:00
661c8b9f04
Merge "Revert "Enable Pinning Deep Shortcuts in Secondary Display""
2022-11-21 19:20:38 +00:00
5ff72eaa46
Merge "Do not start drag from pre-drag if cancelled during animation." into tm-qpr-dev am: 0ccbd7334c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20522179
Change-Id: I19f12060d771c4121642a5dbaf8ccdd291795a66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:20:02 +00:00
183f07e0da
Merge "Still launch disabled item if we can't handle its click." into tm-qpr-dev am: 455eca41be
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20514045
Change-Id: Iada41f7e36da2570cf285c6291de801a7f15597f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:19:09 +00:00
8b9090cc35
Merge "Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."" into tm-qpr-dev am: b9e03da563
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20521649
Change-Id: Iaff26841709cacabfd6254e1e05c8a328eb36da9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:16:40 +00:00
1a8b95a9d4
Merge "Add onTaskMovedToFront to close floating views" into tm-qpr-dev
2022-11-21 19:04:15 +00:00
0ccbd7334c
Merge "Do not start drag from pre-drag if cancelled during animation." into tm-qpr-dev
2022-11-21 19:04:04 +00:00
455eca41be
Merge "Still launch disabled item if we can't handle its click." into tm-qpr-dev
2022-11-21 19:02:44 +00:00
b9e03da563
Merge "Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."" into tm-qpr-dev
2022-11-21 19:01:04 +00:00
1414f12c14
Merge "Increase icon size to be closer to spec" into tm-qpr-dev am: 81a994e9a7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20500530
Change-Id: Ib9eeb7e73e6b84c7dab4c8f89187a454f333bb33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 18:49:50 +00:00
3ea711d992
Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev am: 104517cefb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411886
Change-Id: I0a4f2a8755c49d230417c9b71afaa9ccd6ff410d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 18:49:35 +00:00
d46450dd1f
Merge "Fix NPE from using DeviceLockedInputConsumer after the surface has been released" into tm-qpr-dev am: 8700307b23
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20501358
Change-Id: Ie3cf43c96594bb0201678e189fd874a74535f4b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 18:49:07 +00:00
81a994e9a7
Merge "Increase icon size to be closer to spec" into tm-qpr-dev
2022-11-21 18:35:31 +00:00
104517cefb
Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev
2022-11-21 18:30:19 +00:00
bbe956ef5f
Removing ENABLE_LOCAL_COLOR_POPUPS feature flag
...
The feature has been disabled for a while and is not working correctly.
Also there is no UX plan to revisit this currently
Bug: 206508141
Bug: 259733681
Test: Presubmit
Change-Id: If1279c22b9d074592ba181c7caa0cf38f9cb842e
2022-11-21 10:21:45 -08:00
8700307b23
Merge "Fix NPE from using DeviceLockedInputConsumer after the surface has been released" into tm-qpr-dev
2022-11-21 18:18:49 +00:00
9cddf4133b
Cleanup overview threshold which was only needed for 2-button mode
...
- Removed hasReachedOverviewThreshold() and mPassedOverviewThreshold
- Changed calculateEndTargetForNonFling() to check velocity.y to
determine whether to go HOME or LAST_TASK when no other conditions are
met (e.g. mIsMotionPaused still goes to RECENTS). To allow transient
taskbar to override this so that user stays in LAST_TASK when invoking
the taskbar, kept setHasReachedHomeOverviewThreshold() but renamed it
to setCanSlowSwipeGoHome(),
Test: TaplTestsQuickstep, manually tested on tablet and phone to ensure
the correct end target was chosen when hitting this code path in
calculateEndTargetForNonFling
Flag: teamfood (ENABLE_TRANSIENT_TASKBAR)
Fixes: 259715295
Change-Id: I925be3433d7d2792cdc2a75a18dc575019f2cc95
2022-11-21 17:57:20 +00:00
1ba39205bc
Fix NPE from using DeviceLockedInputConsumer after the surface has been released
...
Fixes: 243154747
Test: swipe up from camera app while device is locked
Change-Id: Ia92e3e3cccb37e0d14592b0f3094f5aba1073300
2022-11-19 12:26:34 -08:00
0de4950f04
Merge "Stash transient taskbar upon icon drag" into tm-qpr-dev am: 793c37153a am: 244d48097f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20490352
Change-Id: Ie56880bc1bcc4c116bcc5009cf77c5261384208c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 03:00:20 +00:00
1fd91813be
Merge "Prevent x-axis window movement during the initial swipe up to show transient taskbar" into tm-qpr-dev am: e912742234 am: 0964f40f1f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470530
Change-Id: I8dd843a17838d3303a580f617c30a677ab9be5f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 02:58:41 +00:00
4ff301eb9d
Do not start drag from pre-drag if cancelled during animation.
...
This change affects the preDragCondition for icons that do not have a
popup menu. The condition assumes we are still in pre-drag after
DragView is finished animating, but the user can cancel the drag in this
time (e.g. by releasing their finger early).
Test: Manual. Holding and releasing on suspended icon does not crash,
while holding and dragging still works as expected.
Fix: 258233476
Change-Id: Ic76f785cffcbfe0fe51eb1473022f2dc34563070
2022-11-19 02:32:08 +00:00
244d48097f
Merge "Stash transient taskbar upon icon drag" into tm-qpr-dev am: 793c37153a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20490352
Change-Id: I26e1675d9832f5c80c430450698a908e93951e1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 02:27:13 +00:00
0964f40f1f
Merge "Prevent x-axis window movement during the initial swipe up to show transient taskbar" into tm-qpr-dev am: e912742234
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470530
Change-Id: Ieb4dd888a30103985cc4a4aa10ce24824d8a41e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 02:27:02 +00:00
793c37153a
Merge "Stash transient taskbar upon icon drag" into tm-qpr-dev
2022-11-19 02:19:25 +00:00
e912742234
Merge "Prevent x-axis window movement during the initial swipe up to show transient taskbar" into tm-qpr-dev
2022-11-19 01:58:37 +00:00
b7f7c71b01
Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev am: c9c45ed783 am: c0eb61e82c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20489432
Change-Id: I3c3e9ae2a90dc3df541f4d4142e46f9d4ba55ab5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 01:09:48 +00:00
c0eb61e82c
Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev am: c9c45ed783
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20489432
Change-Id: I59fa040c912c209f241d70b4d693df5b4d2649f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 01:04:01 +00:00
c9c45ed783
Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev
2022-11-19 00:48:49 +00:00
Xiaowen Lei
Thales Lima
Ikram Gabiyev
TreeHugger Robot
Jon Miranda
Pinyao Ting
Sihua Ma
Tony Wickham
Becky Qiu
Ats Jenk
Brian Isganitis
Schneider Victor-tulias
Sunny Goyal