Commit Graph

58436 Commits

Author SHA1 Message Date
Vinit Nayak 9e6a642d8b Shorten and center TaskMenuView for landscape
* The width of the task menu view for landscape
(both fake and real) is the same as the width
it would be in portrait.
* With the shorter width, we also center the
positioning of the TaskMenuView
* Note this is only for phone, large screen
changes TODO

Bug: 193432925
Test: Tested real/fake landscape + seascape,
view is centered. Portrait same as before.

Change-Id: Ide41e252a3c177c4a911aab544f78930fed2e76f
2021-09-22 14:55:29 -07:00
TreeHugger Robot 851917192a [automerger skipped] Merge "Fix crash in Go Launcher" into sc-v2-dev am: eb2113af00 am: 797a282642 -s ours
am skip reason: Merged-In I37620be4f24a2f0f8f08483991fad7760415b67c with SHA-1 1beab2a3d7 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889274

Change-Id: I98416c1abac0348516934f4dbed4ef4597b43446
2021-09-22 21:27:49 +00:00
TreeHugger Robot 797a282642 Merge "Fix crash in Go Launcher" into sc-v2-dev am: eb2113af00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889274

Change-Id: Id9f717a6b4c4893246bc5ef124423a57f80e7aeb
2021-09-22 21:16:53 +00:00
TreeHugger Robot eb2113af00 Merge "Fix crash in Go Launcher" into sc-v2-dev 2021-09-22 21:06:37 +00:00
Vadim Tryshev 7973cea289 Merge "Revert "Removing unused tracing"" into sc-v2-dev am: f2c35587d6 am: b7d8a00e97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15883599

Change-Id: Ib749336e513aeb2f973d0d672fc6d4f39b69fc9c
2021-09-22 21:02:22 +00:00
Tony Wickham 25b6d9783f Allow visual stashing when going to overview in tests
- Seprate out supportsStashing() into supportsVisualStashing() and supportsManualStashing().
- Manual stashing is when user explicitly long presses to stash, which we disable for tests.

Test: testStressSwipeToOverview
Fixes: 200273854
Change-Id: Ib07efa31a1b073de45fdcfac26215129b1b1985b
2021-09-22 13:58:10 -07:00
Schneider Victor-tulias 2c8966bbc8 Add logging to help debug invalid icon state and UI.
PackageInstallStateChangedTask had some redundant state handling that could lead to invalid states. Removed state handling (potential fix to b/198924992) along with logging to help debug b/198924992.

Test: Started and canceled an app download
Bug: 198924992
Change-Id: I8b8202ceb62a3265186d8d46a0e1be6afc83c080
(cherry picked from commit fbf4178ab7)
2021-09-22 20:53:08 +00:00
Vadim Tryshev b7d8a00e97 Merge "Revert "Removing unused tracing"" into sc-v2-dev am: f2c35587d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15883599

Change-Id: I632c359b9e2d699d53f3610ed8deae3911610f4e
2021-09-22 20:52:31 +00:00
Vadim Tryshev f2c35587d6 Merge "Revert "Removing unused tracing"" into sc-v2-dev 2021-09-22 20:35:06 +00:00
Steven Ng 658a58674a Remove drop target button drawable padding if text is hidden
Test: manual
Fix: 194320733
Change-Id: I12adeaf37cee5a0fcf383641f24b7750f14daf27
(cherry picked from commit a1dcbce15a)
2021-09-22 20:23:41 +00:00
Schneider Victor-tulias b8659607cf Merge "Add logging to help debug invalid icon state and UI." into sc-v2-dev am: f4f17df565 am: f7cb3d3527
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15830460

Change-Id: I239e6d36acd3117c1dce965b55c73417c8f8ec61
2021-09-22 19:59:13 +00:00
Schneider Victor-tulias f7cb3d3527 Merge "Add logging to help debug invalid icon state and UI." into sc-v2-dev am: f4f17df565
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15830460

Change-Id: I69648282f1134a7a04bbb49c66aa402564618216
2021-09-22 19:45:38 +00:00
Schneider Victor-tulias f4f17df565 Merge "Add logging to help debug invalid icon state and UI." into sc-v2-dev 2021-09-22 19:26:59 +00:00
Peter Kalauskas 51ad3bfdb8 Fix crash in Go Launcher
Bug: 198141465
Bug: 200747950
Test: Check that wembley is usable after unlocking
Change-Id: I37620be4f24a2f0f8f08483991fad7760415b67c
Merged-In: I37620be4f24a2f0f8f08483991fad7760415b67c
(cherry picked from commit 1beab2a3d7)
2021-09-22 19:08:35 +00:00
Schneider Victor-tulias b2339e37d7 Fix stalled gesture navigation tutorial.
Touching the screen after completing the gesture removed all callbacks, preventing the tutorial to progess. Added logic to only remove logic if the gesture is incomplete.

Fixes: 198285152
Test: manual, touched screen and attempted all gestures after completing a step
Change-Id: I320b13cd9b7632a9fb722bc10d3d0a96dc111144
2021-09-22 12:04:24 -07:00
Jonathan Miranda 47bd7aeb3a Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev am: e37b51b30f am: 739afa1bec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15741392

Change-Id: I156b5694002f5c5c299b84d019f70c53536c00b0
2021-09-22 18:58:39 +00:00
Jonathan Miranda 739afa1bec Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev am: e37b51b30f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15741392

Change-Id: I95b22ad6b05fb86707aff017eb11fca3af9f9c7d
2021-09-22 18:38:32 +00:00
Jonathan Miranda e37b51b30f Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev 2021-09-22 18:26:44 +00:00
Vinit Nayak 307614c70a Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev am: 9693766477 am: 38935d3441
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15872704

Change-Id: Iff0b89a2307d833ed52c77835e87818c0ddb3ec2
2021-09-22 17:51:25 +00:00
Vinit Nayak 38935d3441 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev am: 9693766477
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15872704

Change-Id: Ie56e8d555cb0f803c30939633dc1533b6e11f17e
2021-09-22 17:38:54 +00:00
Vinit Nayak 9693766477 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev 2021-09-22 17:25:08 +00:00
Steven Ng 0e8a2ce0a9 Fix RecyclerViewFastScroller scrolling in widgets full sheet
See b/200132426 regarding to the bugs.

Test: manually tested full widgets picker scrolling on phone and 2
      panels UI.
Fix: 200132426
Change-Id: I13c7a7262e9357cf0acac1c2c7c069b2118bd527
2021-09-22 18:02:44 +01:00
Alex Chau 998a85e913 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev am: 8f990b94a2 am: f6e67fb067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857676

Change-Id: Iac12c4380cde4270539f93a9fca552e8fd715ac8
2021-09-22 13:56:59 +00:00
Steven Ng c0bb63a113 Merge "Allow WidgetsBottomSheet to wrap its content" into sc-v2-dev am: c137171c8d am: e1cceaeb2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15879754

Change-Id: Iffcd6ddb045e63f44857623c4d5fd7c00a472b67
2021-09-22 13:56:53 +00:00
Alex Chau f6e67fb067 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev am: 8f990b94a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857676

Change-Id: Ied04deccc9e9ed6813831b7a25ad36380d38a783
2021-09-22 13:45:12 +00:00
Steven Ng e1cceaeb2f Merge "Allow WidgetsBottomSheet to wrap its content" into sc-v2-dev am: c137171c8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15879754

Change-Id: Ia9c5c9a7164b81ede54df564fce1c64171d7fa06
2021-09-22 13:45:07 +00:00
Alex Chau 8f990b94a2 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev 2021-09-22 13:34:12 +00:00
Steven Ng c137171c8d Merge "Allow WidgetsBottomSheet to wrap its content" into sc-v2-dev 2021-09-22 13:31:33 +00:00
Jon Miranda 8d3d2757e2 Play window close animation to home for most app to launcher scenarios
- Animates into icon/widget location on workspace (when applicable)
- Excludes unlock animation
- Excludes when user goes back to to All Apps state

Bug: 197656197
Bug: 197450256
Bug: 197656915
Test: go in app, swipe back to land on home
Change-Id: Icdf680bd88599f1b6288822a177087283668431c
2021-09-21 20:19:23 -07:00
Android Build Coastguard Worker ed2f2a43db Snap for 7752803 from b0ca4b3070 to tm-release
Change-Id: I25058f456bc561a2b1c87b1de07577fa27821a7f
2021-09-22 03:08:47 +00:00
Vadim Tryshev 827335f209 Revert "Removing unused tracing"
This reverts commit 1cb868e2f7.

Reason for revert: The problem still happens

Bug: 195319692
Test: presubmit
Change-Id: I468c84af743f04f440b719a561e4e5dd6adbf3b4
2021-09-22 02:58:16 +00:00
Lucas Dupin 2673fce694 Merge "Decrease build time" into sc-v2-dev am: 4f3a750264 am: c11fdafe81
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15882771

Change-Id: I9b880159fd5cb3447970afac242c0996540a4ea0
2021-09-22 01:41:45 +00:00
Lucas Dupin c11fdafe81 Merge "Decrease build time" into sc-v2-dev am: 4f3a750264
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15882771

Change-Id: I3cfdd8d7e1bae3683b277d4a04ce1919e9425144
2021-09-22 01:25:46 +00:00
Lucas Dupin 4f3a750264 Merge "Decrease build time" into sc-v2-dev 2021-09-22 01:14:01 +00:00
Vinit Nayak 7caf5f0ea4 Show distinct TaskMenus for each task in GroupedTaskView
* For now we only show the App Info option
for each task icon clicked for GroupedTaskView
* Have TaskMenuView operate on a specific task instead
of only a TaskView
* NOTE: getItemInfo() in TaskIdAttributeContainer needs to
dynamically call getItemInfo(Task) because at the time of
creation of the container in TaskView#bind(), the task
object provided initially is a palceholder task which only
has a taskId and no other attributes set.
getItemInfo() needs a non-null baseIntent, which the
placeholder task doesn't have.
Right fix for this is to have GestureState hold onto
multiple running tasks when in split screen that are
provided by ActivityManagerWrapper when the gesture starts
(but that change is extensive and out of scope w/ this
workaround available)

Bug: 181704764
Test: Open TaskMenuView's w/ either task icon for
GroupedTaskView, opens up corresponding tasks menu.

Change-Id: I70b7c13394ad4980cabbd611cb928bb03d8a2924
2021-09-21 17:47:54 -07:00
Android Build Coastguard Worker 1f77166295 Snap for 7752790 from 5f412199ad to sc-v2-release
Change-Id: Iaa2ee136e63d0ca5593c815fee81a81d88a3ec84
2021-09-21 23:07:57 +00:00
Jon Spivack b49500a09a Merge "P2P App Sharing: Add Shareability Cache" 2021-09-21 22:31:11 +00:00
Lucas Dupin e3afcee01d Decrease build time
- by enabling parallel execution
- removing references to deprecated repo

Test: make
Bug: 200725337
Change-Id: I571af7a461f9a3526cc8f24142a605d51eca1386
2021-09-21 15:25:22 -07:00
TreeHugger Robot 8005d92d22 Merge "Adding screen record for a flake" into sc-v2-dev am: c48f770a3d am: 21f2b4cc91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15875064

Change-Id: Ic4f372da594e6f726f01211693fdf71f6ab72708
2021-09-21 22:15:55 +00:00
TreeHugger Robot 21f2b4cc91 Merge "Adding screen record for a flake" into sc-v2-dev am: c48f770a3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15875064

Change-Id: I16bc98a32e7b12a871617b4fd622e180c0bb6bca
2021-09-21 22:02:15 +00:00
TreeHugger Robot c48f770a3d Merge "Adding screen record for a flake" into sc-v2-dev 2021-09-21 21:49:58 +00:00
TreeHugger Robot 2429eb6bea Merge "[Search] Sync header Y translation with AllApps y scroll" into sc-v2-dev am: 3b90e1099b am: 6f23f8db58
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862034

Change-Id: I25821c60d97d486c0009f712aefd6183f08236ad
2021-09-21 21:17:24 +00:00
TreeHugger Robot 6f23f8db58 Merge "[Search] Sync header Y translation with AllApps y scroll" into sc-v2-dev am: 3b90e1099b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862034

Change-Id: I3d253d4a724515b5ec9b1401959f57bb5236ce1e
2021-09-21 21:07:14 +00:00
Tony Wickham 21970ccd29 Remove nonOverlappingTaskarInsets
- Override our insets in LauncherRootView to explicitly only care about nav bar size, ignoring any insets due to taskbar.
- Previously we used nonOverlappingTaskbarInsets to belatedly subtract from measurements in e.g. DeviceProfile, but now we can revert most of those calculations since we effectively subtract taskbar insets at the root.

Test: visual in different orientations and navigation modes, and testPressHomeOnAllAppsContextMenu to ensure REQUEST_WINDOW_INSETS still works for automated tests
Fixes: 200607741
Change-Id: I8de5a268c686a1354b4beaa30e101bab6bed5af9
2021-09-21 13:52:43 -07:00
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
TreeHugger Robot 3b90e1099b Merge "[Search] Sync header Y translation with AllApps y scroll" into sc-v2-dev 2021-09-21 20:51:08 +00:00
Vinit Nayak b0ca4b3070 Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev am: 5f412199ad am: 0ada7824c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15854777

Change-Id: I5fd527ce8f4d20a4c915fc6a15e6f1ee00d5d8e6
2021-09-21 17:56:14 +00:00
Vinit Nayak 0ada7824c1 Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev am: 5f412199ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15854777

Change-Id: I474126fe11984793006c8c07529c89d409621a58
2021-09-21 17:41:54 +00:00
Vinit Nayak 5f412199ad Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev 2021-09-21 17:28:01 +00:00
TreeHugger Robot 346af60111 Merge changes I675dbe99,Ia6daa741 into sc-v2-dev am: 139dee45dd am: 8bc27a7ee2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862033

Change-Id: I412985630ce32cd2f544db3b5b50885405983afb
2021-09-21 17:07:01 +00:00