Commit Graph

58436 Commits

Author SHA1 Message Date
Alex Chau 9a5f99bfe6 Resets taskSplitTranslation of inactive orientation
Fix: 204185003
Test: manual

Change-Id: I10e49994e8a9723f39d7f9159de7c1f8216ea77f
2021-11-26 12:04:47 +00:00
Nick Chameyev 71eed5ca35 Handle configuration changes in floating rotation button
Update resources in floating rotation button
when configurations such as screen density, screen size,
current locale have changed.

Bug: 200103245
Test: change display size, locale, fold/unfold
 -> check that floating rotation button resources
    are updated
Change-Id: Ia69f4f8b393a686012e286a1e39822650c562d52
2021-11-26 11:38:28 +00:00
Jerry Chang 79b384b053 Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev am: 71b7d1537d am: 925b1c3fca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16331944

Change-Id: I5e9eec07c468c19d23e9511771072c29fa7b3eae
2021-11-26 06:07:53 +00:00
Jerry Chang 925b1c3fca Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev am: 71b7d1537d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16331944

Change-Id: Ibcfb68a698f52a1efcc45088e5db42b48b17e79e
2021-11-26 05:56:03 +00:00
Jerry Chang 71b7d1537d Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev 2021-11-26 05:43:34 +00:00
Android Build Coastguard Worker a8436bf6ee Snap for 7947497 from 4759d18363 to tm-release
Change-Id: I560887e28a46177bc973c171d4bda8f4e3a3a345
2021-11-26 02:09:30 +00:00
Android Build Coastguard Worker 501130aeb2 Snap for 7947231 from eace1ba76d to sc-v2-release
Change-Id: I85d287543966c4203e006599e26204b88a623cc5
2021-11-26 00:09:16 +00:00
Alex Chau 4759d18363 Merge "Use alternative way to fix split select page snapping issue" into sc-v2-dev am: eace1ba76d am: 1dc16efaf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16343354

Change-Id: I6557aa2980e2a01d15efb216d041473f37832ea1
2021-11-25 19:43:00 +00:00
Alex Chau 1dc16efaf1 Merge "Use alternative way to fix split select page snapping issue" into sc-v2-dev am: eace1ba76d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16343354

Change-Id: I161e62e6fbd34fda5e052381a4db765628ccb314
2021-11-25 19:31:17 +00:00
Alex Chau eace1ba76d Merge "Use alternative way to fix split select page snapping issue" into sc-v2-dev 2021-11-25 19:13:23 +00:00
Alex Chau eab71ab652 Merge "Fix tapl tests for overview actions in fallback recents." into sc-v2-dev am: 22d7524f53 am: eb6be24779
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16182391

Change-Id: I54cf9c8d25be9a3393c122d0bf4135c051d11975
2021-11-25 18:28:10 +00:00
Alex Chau eb6be24779 Merge "Fix tapl tests for overview actions in fallback recents." into sc-v2-dev am: 22d7524f53
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16182391

Change-Id: Iedec936c8c9c904b2be13d4589958b0ccc5f9a73
2021-11-25 18:16:18 +00:00
Alex Chau 22d7524f53 Merge "Fix tapl tests for overview actions in fallback recents." into sc-v2-dev 2021-11-25 17:58:02 +00:00
Alex Chau b3a9386556 Use alternative way to fix split select page snapping issue
- Reverted to before ag/16095449 where reset() is called after state transition completed
- Call pageBeginTransition in dismiss animation to make sure onPageEndTransition is triggered to clear mCurrentPageScrollDiff properly
- Fixed a condition in resetFromSplitSelectionState ot use DeviceProfile.overviewShowAsGrid, as when state is in transition, showAsGrid() would be false

Fix: 207744890
Test: manual
Change-Id: I5a812a7ee26df2f953f7fed0155880620d2c4e66
2021-11-25 16:48:39 +00:00
TreeHugger Robot a6f666f12e Merge "Revert "Migrate workspace item adding tests to kotlin"" into sc-v2-dev am: da014976cd am: 6b17728794
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16340532

Change-Id: Ifb4d6dd8bfcdd914c042dd1681bc9bbd977ce09f
2021-11-25 16:10:20 +00:00
TreeHugger Robot 6b17728794 Merge "Revert "Migrate workspace item adding tests to kotlin"" into sc-v2-dev am: da014976cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16340532

Change-Id: Ic8ad226dab178bd50189b78830d7ea56da55f450
2021-11-25 15:56:20 +00:00
TreeHugger Robot da014976cd Merge "Revert "Migrate workspace item adding tests to kotlin"" into sc-v2-dev 2021-11-25 15:40:06 +00:00
Pat Manning 4433db800c Fix tapl tests for overview actions in fallback recents.
Note: fallback recents test may still fail manual testing if using flag SEPARATE_RECENTS_ACTIVITY

Test: FallbackRecentsTest.java
Bug: 197630182
Change-Id: Id18184e1f6271337adceacc9bac583d84e83afed
2021-11-25 15:39:47 +00:00
Alex Chau 4075f17c2d Revert "Migrate workspace item adding tests to kotlin"
This reverts commit e77eafc263.

Reason for revert: b/207684378
Bug: 207684378
Bug: 199160559

Change-Id: I4a35fea423f1cd7afae4603fd1185150763f8bf0
2021-11-25 11:54:26 +00:00
TreeHugger Robot 4a677ed4cb Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev am: 32ebd9f94f am: cfa85344b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307859

Change-Id: Iae1d568de658269b2abe7a7a52ba7225fb693f30
2021-11-25 04:40:53 +00:00
TreeHugger Robot cfa85344b4 Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev am: 32ebd9f94f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307859

Change-Id: I5a771299623f3c838aef76c5a6b6bf3ac4a850c4
2021-11-25 04:16:57 +00:00
TreeHugger Robot 32ebd9f94f Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev 2021-11-25 04:00:37 +00:00
Jerry Chang 279c3b7fa2 Support to launch app pair from overview with recorded split ratio.
Bug: 207479945
Test: Quickswitch back to app pair keep split ratio
Change-Id: Id24195c15fe59053cc51515a942f72c3b8e87ba7
2021-11-25 11:38:14 +08:00
Android Build Coastguard Worker 70b31dc635 Snap for 7945036 from 9da9172544 to tm-release
Change-Id: Ib9a36a67096386b8e4918efe92fa5370ccc05851
2021-11-25 02:10:14 +00:00
TreeHugger Robot 180c938b2c [automerger skipped] Merge "Add TaskbarControllers#runAfterInit()" into sc-v2-dev am: 79132556f7 am: f9aec4c708 -s ours
am skip reason: Merged-In Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374 with SHA-1 0baf062698 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16336335

Change-Id: I5128ee1e45e8fea1b811f756fe8b2020c26c353b
2021-11-25 00:35:54 +00:00
TreeHugger Robot f9aec4c708 Merge "Add TaskbarControllers#runAfterInit()" into sc-v2-dev am: 79132556f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16336335

Change-Id: If250e156ef4e6b3d568793aeddef14586fd34883
2021-11-25 00:23:05 +00:00
Android Build Coastguard Worker 837120e8bf Snap for 7944517 from 376b09ade2 to sc-v2-release
Change-Id: I9298caef888722c98f5d1cd7b962e45660c8870f
2021-11-25 00:08:33 +00:00
TreeHugger Robot 79132556f7 Merge "Add TaskbarControllers#runAfterInit()" into sc-v2-dev 2021-11-25 00:08:08 +00:00
Tony Wickham a143500a69 Add TaskbarControllers#runAfterInit()
And use it in TaskbarModelCallbacks#commitItemsToUI(), which in rare cases can run during init() before other controllers (namely TaskbarStashController) have been initialized.

Test: call commitItemsToUI() in TaskbarModelCallbacks#init(), ensure no crash
Fixes: 204847702
Change-Id: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
Merged-In: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
2021-11-24 23:14:06 +00:00
TreeHugger Robot 9da9172544 Merge "Add TaskbarControllers#runAfterInit()" 2021-11-24 23:13:37 +00:00
Schneider Victor-tulias 380f8fd890 Fix ClassCastException in QuickstepModelDelegate
- Added a casting check as an immediate fix to b/173838775
- Added logging to help debug the corrupt state where an item of type other than FolderInfo is used as an other item's container.
- Added LoaderMemoryLogger for adding large logs that are only conditionally printed.

Bug: 173838775
Test: manually checked logs
Change-Id: I9491cb421b9fb807d5fb110b04ad069481de768f
2021-11-24 14:26:45 -08:00
Fedor Kudasov 4e678ff6d5 Separate getTaskViewAt usage
getTaskViewAt is used in two different contexts with different
assumptions:
1. In the context of iterating over the all TaskViews, where
the valid tasks indices are know.
2. In the context of requesting some TaskView by index, where
the caller expects null when the input index is invalid.
The nullability status of the method differs in these contexts
and therefore getTaskViewAt usage can be separated into two
different methods.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I42c04c115c309f1849f9dfbb05c74b9b080acf13
(cherry picked from commit 4da3b4bddd)
2021-11-24 21:19:22 +00:00
Fedor Kudasov 8934ad2df6 Merge "Separate getTaskViewAt usage" 2021-11-24 21:18:53 +00:00
Alex Chau f3c6e6fcf3 Merge "Consider two panel in home to overview transition" into sc-v2-dev am: 376b09ade2 am: 07cbd6659f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16330826

Change-Id: I45a672b684a2857e92aa9ea829be487fa915c152
2021-11-24 21:07:45 +00:00
Alex Chau 07cbd6659f Merge "Consider two panel in home to overview transition" into sc-v2-dev am: 376b09ade2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16330826

Change-Id: I9815176bc3421af44e56914020fc4fb613294ddf
2021-11-24 20:47:48 +00:00
Alex Chau 376b09ade2 Merge "Consider two panel in home to overview transition" into sc-v2-dev 2021-11-24 20:33:32 +00:00
Tony Wickham 0baf062698 Add TaskbarControllers#runAfterInit()
And use it in TaskbarModelCallbacks#commitItemsToUI(), which in rare cases can run during init() before other controllers (namely TaskbarStashController) have been initialized.

Test: call commitItemsToUI() in TaskbarModelCallbacks#init(), ensure no crash
Fixes: 204847702
Change-Id: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
2021-11-24 19:18:12 +00:00
Tony Wickham a930bca528 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev am: b4aefc1277 am: cc6b8488bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16325264

Change-Id: I7c71ae9aa8c949907286c31a2e6c75871e599ec7
2021-11-24 18:27:32 +00:00
Tony Wickham cc6b8488bf Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev am: b4aefc1277
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16325264

Change-Id: Ic361bc9236c9df493cc56d7a69a5e9a629b6f05c
2021-11-24 18:17:40 +00:00
Alex Chau 6095333370 Consider two panel in home to overview transition
- Get the value from DeviceProfile directly

Fix: 202444558
Test: manual
Change-Id: Ifadbbf34c8103d7275b8b4043dcae47d1168ae83
2021-11-24 18:11:45 +00:00
Tony Wickham b4aefc1277 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev 2021-11-24 17:54:18 +00:00
Alex Chau ad83e8aed1 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev am: 226bd5b973 am: c28e01c0a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16330423

Change-Id: I2ca737b2d37e0c0de26e6e60f689f621af0dc485
2021-11-24 10:54:17 +00:00
András Klöczl 95b43e593c Merge "Migrate workspace item adding tests to kotlin" into sc-v2-dev am: 283798dbd5 am: 2d1cfb899b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16321893

Change-Id: I1bbd1d40c9f4f69d9c4d6123229dfdf71a3ba849
2021-11-24 10:54:00 +00:00
Alex Chau c28e01c0a6 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev am: 226bd5b973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16330423

Change-Id: I4a768643dcb6f024058c8ff501aa771cad3a80e9
2021-11-24 10:37:34 +00:00
András Klöczl 2d1cfb899b Merge "Migrate workspace item adding tests to kotlin" into sc-v2-dev am: 283798dbd5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16321893

Change-Id: I1fd1ed39633fdc4c48a8d4a6c0b568faa8a39e09
2021-11-24 10:37:26 +00:00
Alex Chau 226bd5b973 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev 2021-11-24 10:32:46 +00:00
András Klöczl 283798dbd5 Merge "Migrate workspace item adding tests to kotlin" into sc-v2-dev 2021-11-24 10:21:39 +00:00
Fedor Kudasov 4da3b4bddd Separate getTaskViewAt usage
getTaskViewAt is used in two different contexts with different
assumptions:
1. In the context of iterating over the all TaskViews, where
the valid tasks indices are know.
2. In the context of requesting some TaskView by index, where
the caller expects null when the input index is invalid.
The nullability status of the method differs in these contexts
and therefore getTaskViewAt usage can be separated into two
different methods.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I42c04c115c309f1849f9dfbb05c74b9b080acf13
2021-11-24 09:08:43 +00:00
Winson Chung b9a3a8f7ab Fix NPE from null thumbnail data when canceling recents animation
Bug: 206339573
Test: Presubmit (unable to reproduce)
Change-Id: Ia4144fe1d09e7a0a178b9d4f102769c3ab3c376a
2021-11-24 04:23:10 +00:00
Android Build Coastguard Worker af8db71eb8 Snap for 7941279 from 9119e1fab3 to tm-release
Change-Id: Iefadbd16c1def8924fc8d1a7de3395aa255a78ae
2021-11-24 02:09:01 +00:00