Commit Graph

58436 Commits

Author SHA1 Message Date
Tony Wickham c6a7ba8163 Adjust taskbar VIS and bottom mandatory gesture insets
- ITYPE_BOTTOM_MANDATORY_GESTURES should always be > 0  in gesture
  navigation mode, but before we were setting it equal to tappableHeight
  which is 0 if the taskbar is stashed. Fixed it to be contentHeight
  instead.
- Updated VIS insets to only override them to be 0 for tappableElement,
  not for others like navigationBars. We still only override this for
  gesture navigation; 3 button mode will continue reporting the same as
  we report to the underlying apps.

Test: manually with 3 button mode, gesture nav mode with taskbar
stashed/unstashed; checked that TaskbarInsetsController dump looks as
expected, and that behaviors like Assistant and IME look correct
Flag: none
Fixes: 262516176

Change-Id: I5a1cdf5a9956777d3189ef6042493e2f5aa9b162
2022-12-15 22:28:40 +00:00
Alex Chau adbbc2f7fa TaskbarViewController should only translate on rotation if icon is aligned with hotseat
Fix: 254191175
Test: With 3 button, rotate at home and overview, nav button are at expected position. Repeat with TASKBAR_IN_OVERVIEW flag off.
Change-Id: I1e629e6be92c4793d3dfdb0dac60c3bfce886e7a
2022-12-15 22:04:16 +00:00
Jeremy Sim 0f4346d057 Merge "Fix juttering problem with split staging animation" into tm-qpr-dev am: 2ebdc76fa5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20716747

Change-Id: Ie9ac3c1a7f4661c2d0f05ed9245e5167c4a89802
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 22:02:09 +00:00
Jeremy Sim 2ebdc76fa5 Merge "Fix juttering problem with split staging animation" into tm-qpr-dev 2022-12-15 21:38:31 +00:00
Pat Manning 7276cba38a Merge "Get home rotation default value from DisplayController Info in case DeviceProfile is not updated." into tm-qpr-dev am: 618df8b34e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20712705

Change-Id: I857c8bc25dc82cf03192bda451bd699db0818448
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 20:47:02 +00:00
Holly Sun f565d1bafa No need to override the isImeEnabledOnSwipeUp flag in Launcher3.
It's only used in NexusLauncher now.

Bug: 262729669
Test: manual
Change-Id: Ic145d7ad007ec314974713b6c4bf880d55607cf7
2022-12-15 12:18:27 -08:00
Tracy Zhou 09f8e4277a Merge "Turn on split from fullscreen with keyboard shortcuts flag" 2022-12-15 20:09:19 +00:00
Pat Manning 618df8b34e Merge "Get home rotation default value from DisplayController Info in case DeviceProfile is not updated." into tm-qpr-dev 2022-12-15 20:02:14 +00:00
Sunny Goyal 37dd2e6691 Merge "Unifying multiple all-apps implementations" into tm-qpr-dev am: 09fab7ee7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713205

Change-Id: I1bd905e44924ec55f8f7cb254d66f9f751357590
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 17:28:53 +00:00
Alex Chau a68164d89e Set iconsSizePx of Taskbar's DeviceProfile directly
- After ag/20691430, iconScale no longer scale app icons (I should rename it later, after QPR2), so we'll need to set the desired iconSize directly for Taskbar's DeviceProfile
- Extracted setting iconSizePx and testSizePx out of updateIconSize, as they are no longer affected by scaling. This allows TaskbarActivityContext to set desired iconsize and then call updateIconSize

Bug: 256976071
Test: Test Taskbar icon size in different density
Change-Id: I741c178b59e0d8ecb4c63689e68767622329379c
2022-12-15 17:05:12 +00:00
Sunny Goyal 09fab7ee7d Merge "Unifying multiple all-apps implementations" into tm-qpr-dev 2022-12-15 17:03:05 +00:00
Alex Chau f8b79d4235 Use overridden default xml for TwoPanelWorkspaceTest
- Partially reverted TAPL and TwoPanelWorkspaceTest changes on http://ag/19195512

Fix: 262627208
Fix: 262632384
Test: TwoPanelWorkspaceTest
Change-Id: I8b793bfb3874cc6305ce8b0f9f7b0a116d01222b
2022-12-15 15:48:09 +00:00
Alex Chau c16fa37888 Merge "Avoid overlapping snackbar with nav buttons in tablets" into tm-qpr-dev am: 3ad5eef4b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20736530

Change-Id: I52702a0a615b63359c1475ddad8278c2f03d271c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 15:37:40 +00:00
Alex Chau 3ad5eef4b8 Merge "Avoid overlapping snackbar with nav buttons in tablets" into tm-qpr-dev 2022-12-15 14:47:02 +00:00
Pat Manning a79880a1d8 Match ArrowTipView width to parent so text can center.
Fix: 260302416
Test: manual
Change-Id: I75478ec57e2535578dacb16fefaf7c45e136f1f5
2022-12-15 14:40:58 +00:00
Bill Yi 8cda671bcd [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: 2d476db8a6 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20740267

Change-Id: I59447c8863f527be10230778e6210921b22f5276
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 14:30:55 +00:00
Bill Yi e4e66e41fb [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 08f6a4e7c1 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20740267

Change-Id: Ia0431ece57cb7270e7a2a9a3cbf590fae9d9c906
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 14:30:47 +00:00
Bill Yi 9339813678 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: ac3930bede -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20739889

Change-Id: I9deaac6e1c9790a2bd1afd2e58fc21ae4ea4d916
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 14:30:32 +00:00
Bill Yi a10143b82c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 78ea5bd253 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20739889

Change-Id: Ic68a0341b08adeaf76687759f978e183471cb6e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 14:30:13 +00:00
Bill Yi 2d476db8a6 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-15 14:08:52 +00:00
Bill Yi ac3930bede Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-15 14:08:52 +00:00
Alex Chau f48915d7fa Merge "Temporarily use 1f bottomSheetDepth for multi-display" into tm-qpr-dev am: 3fa6669261 am: a664fab6ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20725027

Change-Id: I1299e21fa68cf47c24a818ed8a8ee09a9900f017
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 13:40:17 +00:00
Alex Chau a664fab6ad Merge "Temporarily use 1f bottomSheetDepth for multi-display" into tm-qpr-dev am: 3fa6669261
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20725027

Change-Id: I8daf4ee6227a23bb9f1cc3c825ae0083db4552d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 13:03:15 +00:00
Alex Chau 3fa6669261 Merge "Temporarily use 1f bottomSheetDepth for multi-display" into tm-qpr-dev 2022-12-15 12:19:27 +00:00
Schneider Victor-tulias 84eaeccc0e [automerger skipped] Merge "[DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds." into tm-qpr-dev am: 85127b4f47 am: 65c7eeb6b2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20652594

Change-Id: If5db59db6483b2f52e8ceb026faaae663f077a9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 11:05:50 +00:00
Schneider Victor-tulias fcb7b3c7f3 [automerger skipped] [DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds. am: 80b25c756a am: fa854bd707 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20652594

Change-Id: Iea1d41a852db0316a4a1e383e6aab7fdabd21689
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 11:05:47 +00:00
Schneider Victor-tulias 65c7eeb6b2 Merge "[DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds." into tm-qpr-dev am: 85127b4f47
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20652594

Change-Id: I6a706ff04eb86ef655680746de59377c69bb86e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 10:29:04 +00:00
Schneider Victor-tulias fa854bd707 [DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds. am: 80b25c756a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20652594

Change-Id: I546f4a2c97c5dd18f55993cfb528fe2e76aef095
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 10:29:01 +00:00
Schneider Victor-tulias 887b56ce1b Merge "Log gesture velocity to help debug and help direct future gesture nav thresholds." 2022-12-15 09:42:20 +00:00
Schneider Victor-tulias 85127b4f47 Merge "[DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds." into tm-qpr-dev 2022-12-15 09:42:15 +00:00
Jeremy Sim 768e9ec8c0 Fix bug with Taskbar second-app-selection animation
This patch makes it so that the correct animation will play when the user selects a second app from the Taskbar.

Previously, when the user selected a second app from the Taskbar, an animation would play showing the expansion of the app -- but it would come from the wrong place. The error occurred because when we calculate the animation start position, we assume that the starting view is located in the DragLayer, which fills the whole screen. But in cases where the starting view is located in the Taskbar, the root view is actually the TaskbarDragLayer, which only fills an area on the bottom part of the screen.

Fixed by adding a check to see if the starting view is part of the TaskbarActivityContext, and if so, adding an offset to calculate the correct DragLayer coordinates.

Fixes: 258692761
Test: Manual
Change-Id: I4026676fefe1e4c5cdf9d9a47d95c0d6e64672e8
2022-12-14 17:48:14 -08:00
Sihua Ma 95e82c6ec0 Merge "Reducing the no-intercept area to widget picker recycler view" into tm-qpr-dev am: dbaec70d48 am: bcbe294409
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20667156

Change-Id: I28a177eacb4b4f5d7712b297dfaadc3a27d3e7eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 00:46:05 +00:00
Sihua Ma bcbe294409 Merge "Reducing the no-intercept area to widget picker recycler view" into tm-qpr-dev am: dbaec70d48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20667156

Change-Id: I6fb9f5df275b04005c9d101bb435a17c2dc03e57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 00:05:05 +00:00
Sihua Ma dbaec70d48 Merge "Reducing the no-intercept area to widget picker recycler view" into tm-qpr-dev 2022-12-14 23:26:03 +00:00
Alex Chau b015054390 Merge "Remove unnecessary GridDisplayOption_defaultSplitDisplayLayoutId attribute" into tm-qpr-dev am: 8a7dc2b244 am: 4fb5e62810
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19195512

Change-Id: If50694adfcaaf0b98987e7ac840a82740e3e1b41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 22:49:20 +00:00
Bill Yi 08f6a4e7c1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I71ffbebc713309a68b98f159ec3d87bf089c6f40
2022-12-14 14:17:12 -08:00
Bill Yi a0091acd6d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic505774d7ba6077bb238ea03ba53ed6d84b9cdc6
2022-12-14 14:16:22 -08:00
Bill Yi 78ea5bd253 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie78d4416033cc14e78a40771e66524517e2e7d28
2022-12-14 14:15:06 -08:00
Bill Yi e9b7c15e95 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I61ee5cd3d8384e48c03f7f1682bdb325e94defaa
2022-12-14 14:14:32 -08:00
Alex Chau 4fb5e62810 Merge "Remove unnecessary GridDisplayOption_defaultSplitDisplayLayoutId attribute" into tm-qpr-dev am: 8a7dc2b244
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19195512

Change-Id: I781bf1cb012683704193330bd5de35573e2295bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 22:14:00 +00:00
Alex Chau 8a7dc2b244 Merge "Remove unnecessary GridDisplayOption_defaultSplitDisplayLayoutId attribute" into tm-qpr-dev 2022-12-14 21:50:34 +00:00
Brian Isganitis 73d270bf51 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev am: f5c099b528 am: 4aa2644629
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20726289

Change-Id: I82869bb9d8f264bea5f43bff7c652bfdd2c85ee4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 21:34:09 +00:00
Sebastian Franco 5aa71cee20 Clean mPreviousSolution on change of CellLayout target
The previous reorder solution is not peropperly cleaned and
that leads to wrong solution being used. For example when
longpressing an icon, it triggers a drag but the drag never
finishes.

Fix: 261122618
Test: You can no longer overlap a shortcut in the same app icon (see attached bug)
Test: atest ReorderWidget

Change-Id: Iff8651926cc4179561761c7ce0ac5007f13fc9af
2022-12-14 15:20:50 -06:00
Brian Isganitis 4aa2644629 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev am: f5c099b528
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20726289

Change-Id: I0184935622d8892842af29629ed96eff65e9507b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:50:23 +00:00
Brian Isganitis f5c099b528 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev 2022-12-14 20:25:21 +00:00
Jon Miranda a965d14c42 Merge "Taskbar All Apps button visual updates" into tm-qpr-dev am: a0743cf62c am: 80f6ece5ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20724415

Change-Id: Id066aeb46d61d892ce6e30688e1b215d958206db
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:11:38 +00:00
Brian Isganitis 1e37aae1dc Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev am: 8216a26bfe am: 71f9faded9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713695

Change-Id: I8917a9a3f4ceb856cf1fecf8699e61fb5a0bf459
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:10:06 +00:00
Jon Miranda 80f6ece5ad Merge "Taskbar All Apps button visual updates" into tm-qpr-dev am: a0743cf62c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20724415

Change-Id: Ib3ff9ebcfd645a6f929e17e17aec4f14b070b7ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:33:23 +00:00
Brian Isganitis 71f9faded9 Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev am: 8216a26bfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713695

Change-Id: Ic5f32fca6c7f56c9e17cdc68bc0416c0881e2fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:32:50 +00:00
Sunny Goyal adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00