Commit Graph

13651 Commits

Author SHA1 Message Date
Tony Wickham 8426275608 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I37bc83970d5dd6b1c1d59cfd95079826d5c2400f
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:01:47 +00:00
Jeremy Sim 42276318b9 Fix crash bug when splitting with animations disabled
Fixes a bug where disabling animations (through Settings) would cause split staging to crash.

The crash occurs because when animations are disabled, StateManager advances to OVERVIEW_SPLIT_SELECT too quickly, and does not trigger the appropriate code block in RecentsViewStateController#handleSplitSelectionState(). This causes a crash.

Fixed by changing the conditional so that it always runs when OVERVIEW_SPLIT_SELECT is the target state, no matter the starting state.

Note: If more animations are added for this state in the future, the conditional may need to be tweaked further.

Fixes: 223598955
Test: Confirmed not crashing on 2 devices when splitting in a variety of ways.
Change-Id: I7f3def88f124fa1babe9a943adf72c10f58b7131
2022-04-22 19:58:40 +00:00
Tony Wickham 741e4aeb95 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev 2022-04-22 19:55:31 +00:00
TreeHugger Robot 5d315a06e3 Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec am: 0e46bac72f am: 3c2956abcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: Icd0fd5878abd5563e850bed798c3da6d31ad0d18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:53:04 +00:00
Alex Chau 28ffe31159 Update pull back animation for tablet AllApps am: e3b806366a am: a6f8f85436 am: bfd3fafb3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: I008fbfd366687b126e337b1495a3e38b1a9c3547
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:51:59 +00:00
TreeHugger Robot da0d7d3fcc Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec am: e03e7e1f5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: I44be923da02284b6edf86e2b1f3d539ccd6a6c15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:20:07 +00:00
TreeHugger Robot 3c2956abcc Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec am: 0e46bac72f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: I0303221c25206ae054099019d0426b40794cfd73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:19:35 +00:00
Alex Chau bfd3fafb3b Update pull back animation for tablet AllApps am: e3b806366a am: a6f8f85436
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: Ifb298ae872f1a936b7c6d6cd5c0bd6bd01648b3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:18:59 +00:00
Alex Chau a053005db5 Update pull back animation for tablet AllApps am: e3b806366a am: a6f8f85436
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: I79e4523321a3ac8a5d6f806bc075f02bebf29230
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:18:57 +00:00
Alex Chau d5620750fc Update pull back animation for tablet AllApps am: e3b806366a am: 24771d2ef7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: If13ee7fdfaced3a40e45be7e817e03bbcc911413
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:18:37 +00:00
TreeHugger Robot 0e46bac72f Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: Ie2e30df6666338626d6d4575ac68572dba305c43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 17:53:48 +00:00
Alex Chau a6f8f85436 Update pull back animation for tablet AllApps am: e3b806366a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: If9173888b7e3a0680001eed885aa88bd7d93a69a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 17:53:25 +00:00
TreeHugger Robot e03e7e1f5f Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: I182643138fa930f634d313a426725a8603487360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 17:52:52 +00:00
Alex Chau 24771d2ef7 Update pull back animation for tablet AllApps am: e3b806366a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: I82187136a89e794aff6719d2623926f2aa3f159a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 17:52:30 +00:00
TreeHugger Robot 37fa1392ec Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev 2022-04-22 17:33:06 +00:00
Sunny Goyal 7b8d63fcf8 Removing fade in logic during load.
Launcher already blocks the draw during load, which ensures
that system draws the loading screen. Additional fade animation
is not visible since the Launcher window is already getting fade in

Bug: 199120420
Bug: 199120420
Test: Verified on device

Change-Id: I7089cea4c5f97f6ef92eabcba56451de407c98b8
2022-04-22 16:35:40 +00:00
Alex Chau e3b806366a Update pull back animation for tablet AllApps
- This is a follow-up of http://ag/17636490
- Introduced animation property specifically for pullback translation and alpha, which will invoke getRecyclerViewContainer directly on tablet, and invoke aggregate setter of appsView on phones
- Delay reset of pullback animation to after dismiss animation to avoid jump in value during state transition animation
- Introduced property factory for addictive properties similar to MultiScalePropertyFactory

Fix: 220345008
Test: manual on small and large screen
Change-Id: I7b5c0019c1d4d36c3c7ca4ec79e38e4eb09c32ca
2022-04-22 16:27:25 +01:00
Bill Yi 8bdd2c7dc8 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-d1-dev 2022-04-22 04:46:04 +00:00
Bill Yi e8858a2ada Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-04-22 04:45:13 +00:00
TreeHugger Robot 71a63918c6 Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-dev am: df436c364c am: dc06e3be5e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17891361

Change-Id: I49cffc67fb9b7ae6b2cbcd40840f0b4109614c01
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 04:15:13 +00:00
TreeHugger Robot 1cf3c41f3f Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-dev am: df436c364c am: 26a5435136 am: b3894c31fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17891361

Change-Id: If09d773031d13618c2bea8cffd4878957150a402
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 03:38:19 +00:00
TreeHugger Robot 6aa256ea42 Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-dev am: df436c364c am: 26a5435136
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17891361

Change-Id: Icb517661a1120676aaa1df8e946bc1ff6b377d52
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 03:28:53 +00:00
TreeHugger Robot dc06e3be5e Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-dev am: df436c364c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17891361

Change-Id: I1de502b9faaa12f98a2e1838216afe61295730d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 03:28:10 +00:00
Brian Isganitis e10ab8cdcd Snap to last task if swiping down at a greater Y than X velocity.
If you swipe down slightly diagonally, it will almost always be treated as a swipe to the next task rather than a return to the current task. If we are swiping down and the Y velocity is grater, we should snap to the current task instead.

Test: Manually in fully gestural mode.
Bug: 222117127
Change-Id: I0f591fa5117291a9c095c2b733280464d29103d9
2022-04-21 22:50:39 +00:00
Vinit Nayak dd7e132db5 Use new onStartSplitLegacy when starting split from overview
Bug: 223396876
Change-Id: I696749f7674a09b2a12c6ef2c2b7d19d0884049a
2022-04-21 11:51:24 -07:00
TreeHugger Robot 15e9b89a37 Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev am: d880a4fa63 am: b455425f49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17805037

Change-Id: Icf9988913455e02797c9ba183a0ca20895dba201
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 18:40:24 +00:00
TreeHugger Robot 6a75aaee52 Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev am: d880a4fa63 am: b12c1b938d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17805037

Change-Id: Ibd1567306b78855ce80602be657b623598048681
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 18:39:56 +00:00
TreeHugger Robot b12c1b938d Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev am: d880a4fa63
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17805037

Change-Id: I5c57c00aa461387c0d031c9430ecdf7dcdbc314c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 18:23:30 +00:00
TreeHugger Robot d1ab7dc291 Merge "Disallow long press below taskbar icons" into tm-dev am: 8e0177813a am: b2ac0758a4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17872520

Change-Id: I293cc8908f34ec5d8ed6bc77a315b220ff597812
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 18:00:01 +00:00
TreeHugger Robot c1cf8b0e95 Merge "Disallow long press below taskbar icons" into tm-dev am: 8e0177813a am: c922594e6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17872520

Change-Id: I763257e603be7845bd63478505266651a4895bba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 17:59:32 +00:00
TreeHugger Robot d880a4fa63 Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev 2022-04-21 17:54:03 +00:00
TreeHugger Robot c922594e6b Merge "Disallow long press below taskbar icons" into tm-dev am: 8e0177813a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17872520

Change-Id: I91f7d287952a2d187c7e1ac920910348b5d26fd8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 17:36:10 +00:00
TreeHugger Robot 8e0177813a Merge "Disallow long press below taskbar icons" into tm-dev 2022-04-21 17:16:42 +00:00
Tony Wickham f286f9cb98 Address a couple small followups for TaskbarInsetsController
- Added no-op onDestroy()
- Reformated some if conditions, also adding
  AbstractFloatingView.hasOpenView()

Test: TaplTestsTaskbar
Bug: 215411414
Change-Id: I89b39ca5fabd03f5ac0f25d6ef69170683cf060d
2022-04-21 16:16:02 +00:00
Tony Wickham a681cf6abe Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets
- This allows us to distinguish taskbar's ITYPE_EXTRA_NAVIGATION_BAR insets from its ITYPE_BOTTOM_TAPPABLE_ELEMENT insets
- Set nav bar insets as before (contentInsets)
- Set tappable elements insets the same, except when taskbar is stashed, in which case set to 0

Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME, open Calculator (which uses tappableElement() insets) and Contacts (which uses systemBars())
Fixes: 215411414
Change-Id: If00f7a590b0780715d5b8159f5135054364ce84e
2022-04-21 16:15:41 +00:00
Tony Huang 8b260268d8 Merge "Add jank instrument support for split screen" into tm-dev am: 8edc0dfcf1 am: 0e5421b491
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17818645

Change-Id: I7bbd34aa8b2f90c103cceb762e0a2efc4f233963
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 12:09:32 +00:00
Tony Huang ac409540bc Merge "Add jank instrument support for split screen" into tm-dev am: 8edc0dfcf1 am: b01dc823a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17818645

Change-Id: I680bba5206adfb81754b042b7b76748bf5a4d404
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 12:09:23 +00:00
Tony Huang b01dc823a0 Merge "Add jank instrument support for split screen" into tm-dev am: 8edc0dfcf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17818645

Change-Id: Ic2f254e0fa7cf210a5c845b1d7598441dea9ddb1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 11:53:33 +00:00
Tony Huang 8edc0dfcf1 Merge "Add jank instrument support for split screen" into tm-dev 2022-04-21 11:31:22 +00:00
Bill Yi 4991a1fd63 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib39e0efdba7bc474456acd3b49167a6b5efc443f
2022-04-21 04:10:10 +00:00
Bill Yi 04c7ab02d1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia5843c8bd625d12577091fc473ae6f7f435461b0
2022-04-21 04:09:39 +00:00
Bill Yi 1edad5cc73 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I16ce190ed7b0100097bfd33f227b6efa3ba3fee8
2022-04-21 04:09:09 +00:00
Bill Yi e7af40c247 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie56ee2fc9fee1ff17c9554e0727f7d1f41d3d3f6
2022-04-21 04:07:40 +00:00
Tony Wickham 836385240c Merge "Move taskbar insets logic to TaskbarInsetsController" into tm-dev am: 74641da5b8 am: 7ba5a921d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778391

Change-Id: Idbdc6eb3e41710457c7bba8229a489a56fab8c08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 00:20:15 +00:00
Tony Wickham 4ba1c141e0 Merge "Move taskbar insets logic to TaskbarInsetsController" into tm-dev am: 74641da5b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778391

Change-Id: Ie6f9bb9e6eab240e38660cb0705d34725eb9ee1b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 00:03:00 +00:00
Tony Wickham 74641da5b8 Merge "Move taskbar insets logic to TaskbarInsetsController" into tm-dev 2022-04-20 23:43:50 +00:00
Vinit Nayak b614e81ced Merge "Check for auto-rotation when initializing RecentsOrientedState" into tm-dev am: bf33e85cb7 am: 927e6ec8bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17776932

Change-Id: Ia9c6f64e963b38084419ed10ce6671df269fa28f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 21:37:31 +00:00
Vinit Nayak 9d6dc317af Merge "Check for auto-rotation when initializing RecentsOrientedState" into tm-dev am: bf33e85cb7 am: 9085667ac0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17776932

Change-Id: Ie395738aa2a8554d021510fdcafb1e957dc6b4ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 21:37:23 +00:00
Vinit Nayak 9085667ac0 Merge "Check for auto-rotation when initializing RecentsOrientedState" into tm-dev am: bf33e85cb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17776932

Change-Id: I374d1d66a580dc8b2c8925ff66de93c382eac3c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 21:18:34 +00:00
Tony Wickham 81bff9becd Disallow long press below taskbar icons
Test: long press below icons, doesn't stash; can still swipe up
Fixes: 201239461
Change-Id: Ifdf355138d7958c0442814d968f0722f54e12ae1
2022-04-20 13:58:53 -07:00