Commit Graph

13651 Commits

Author SHA1 Message Date
Adam Cohen f243ca416e Merge "Tune Assistant Gesture" into ub-launcher3-qt-dev 2019-04-18 20:35:48 +00:00
Adam Cohen b117707d31 Tune Assistant Gesture
=> bumping detectable region to 48 dp horizontal + vertical within corner
=> centering detectable angle;  total 70 degrees (ie. btw 10 off the vertical and 10 off the horizontal)
=> pilfering touch events when slop is passed and assistant gesture is engaged
=> Fixing issue where we were incorrectly using “sharedState” causing incorrect handling of gestures subsequent to AssistantTouchConsumer being invoked (it was forgetting to clear it’s input state and hence reporting “active” when it wasn’t). The symptom was that gestures after the AssistantTouchConsumer would never actually move the active window even though state was being updated; you’d feel the Overview haptic.
=> Devices with large corner radii are still somewhat problematic as the initial touch down often lands high on the display (ie. above the 48 dp region).

Change-Id: I3d5761112f4cb8b7b1eee987de5afe9aee260304
2019-04-18 12:54:28 -07:00
vadimt dd0b3624a5 Enabling continuous testing of all 3 modes of navigation
This is likely going to result in flaky tests, but we'll benefit more
from having these tests than not.

We'll track all flakes that are going to pop up as bugs.

Change-Id: I73902a1bce8181d522376ff912e238ec84ef1eed
2019-04-18 12:16:01 -07:00
Govinda Wasserman 917af755e4 Makes Launcher hide the all apps content and scrim on assistant visible.
This hides the quick search bar and the suggested apps. Visibility is
unchanged when the all apps view is fully expanded.

Test: Tested locally
Change-Id: I6bc453b5ad89ca3d1280957e595bf2a3f074a72d
BUG:129755311
FIX:129755311
2019-04-17 14:28:15 -04:00
Tony Wickham 3deb42f281 Merge "Don't special case swipe up animation if launcher was visible" into ub-launcher3-qt-dev 2019-04-16 21:19:17 +00:00
Tony Wickham 1e24b6d7d5 Don't special case swipe up animation if launcher was visible
This case originally existed to handle transparent activities, but in
reality it was hit most often when swiping up during transitions, i.e.
before launcher was stopped. So now we do the same thing regardless of
whether launcher was "visible" at the start of the animation: go to the
background state immediately and create our transition from there. This
looks a little strange if the activity truly is transparent, because you
can see launcher jump to the background state, but ultimately leads to a
more consistent experience (and the state animation we used before
looked super weird anyway).

Test:
- Open Calculator from the home screen and immediately swipe up from nav
  bar (before animation finishes)
- Open Calculator from overview and immediately swipe up from nav bar
- Open Caluclator from all apps and immediately swipe up from nav bar
- Open Cortana (which has a translucent activity) from home screen,
  then swipe up.
- Open Cortana and quick switch from it
- Open Rube screenshot (dialog activity) from home screen and swipe up
- Open Rube screenshot from all apps and swipe up
- Open Rube screenshot from all apps and swipe up and back down (ensure
  launcher returns to all apps state)

Change-Id: I87bdbc6ddf41971fd327c807269c0bd94c97c95c
2019-04-16 10:56:59 -07:00
Sunny Goyal 9589916418 ShortcutInfo renamed to WorkspaceItemInfo
Will get rid of ShortcutInfoCompat in a follow up cl

Change-Id: I7d7d9c938635f59b216290ba28bea9d0e0721a7d
2019-04-16 00:08:24 -07:00
Vadim Tryshev 5235a8867b Merge "More diagnostics for dragging failures in the lab, now for OOP tests" into ub-launcher3-qt-dev 2019-04-15 19:29:41 +00:00
vadimt 7d90c653d6 More diagnostics for dragging failures in the lab, now for OOP tests
Bug: 129434166
Change-Id: I38b62ef74c0307f12ee85bbc05940400e9ba2302
2019-04-15 12:10:50 -07:00
Tony Wickham 799f5cfe53 Merge "Don't scale/translate hotseat icons if they are visible in overview" into ub-launcher3-qt-dev 2019-04-15 18:37:29 +00:00
TreeHugger Robot 60e3499bd4 Merge "Change default icons for launcher [3/3]" into ub-launcher3-qt-dev 2019-04-13 19:38:44 +00:00
Hyunyoung Song a19584d820 Change default icons for launcher [3/3]
Bug: 126738409
Bug: 129955150
Change-Id: I9daf5bd253dc72c99ab3a466766a4d30a95d0952
2019-04-13 00:51:33 -07:00
Vadim Tryshev b1303d57f7 Merge "Gestures for zero-button mode" into ub-launcher3-qt-dev 2019-04-13 01:50:16 +00:00
vadimt 679b09d6bd Gestures for zero-button mode
Change-Id: If17ba764ede132694ccf0c56269df1a4117ec0f6
2019-04-12 18:19:38 -07:00
Hyunyoung Song 7924a3c97a Change default icons for launcher [2/3]
Bug: 126738409
Bug: 129955150
Change-Id: Ia140c5d16b74e4719131aa5035313b7b27028ad1
2019-04-12 16:19:53 -07:00
vadimt c6d9ddfddb Removing hourglass_bottom
Now that we don't show DWB toast for negative remaining time

Bug: 127689526
Change-Id: I3ced3ec0da9bd7b09df9b66b4ef608e87339573f
(cherry picked from commit e921bacfb8)
2019-04-12 19:27:17 +00:00
Miranda Kephart 73a4740f7f Don't shrink overview bitmap for chips
Chips in overview will be shown on top of the bitmap, not in
between the bitmap and the QSB, so we no longer need to shrink
the bitmap to make room for chips. This means that the appearance
of the recents view will be consistent between chips being
enabled/disabled.

Change-Id: I1856ccb8babd388ef6c8e6a1a5defcbdd0278a60
2019-04-12 11:09:59 -04:00
TreeHugger Robot bb0c8204f5 Merge ""No recent items" font should use themed font Bug: 126822309" into ub-launcher3-qt-dev 2019-04-12 06:40:47 +00:00
Hyunyoung Song aa0f3b7843 Merge "TaskCornerRadius should not use dialogCornerRadius on devices not supporting rounded corners Bug: 123985787" into ub-launcher3-qt-dev 2019-04-12 06:34:59 +00:00
Hyunyoung Song f952095a2e "No recent items" font should use themed font
Bug: 126822309

Change-Id: I0311b0b002fa1dcda88b87da31019f4ecbb94f62
2019-04-11 17:01:51 -07:00
Winson Chung a876fe7846 Check sysui state before swiping up
Bug: 129785904
Test: Try to swipe up with various sysui states enabled
Change-Id: I654e0efd1f29ee6b4123e7f8aa717f62a55fdb50
(cherry picked from commit f0625fd93a)
2019-04-11 23:56:18 +00:00
Winson Chung 4060a75d8f Add state callback in launcher
Bug: 129785904
Test: Manual, change states and verify state is sent
Change-Id: Ia1f69494a6cbae68085fb09670ffa309ce147430
(cherry picked from commit c4b88c3dfb)
2019-04-11 18:11:51 +00:00
Winson Chung f0625fd93a Check sysui state before swiping up
Bug: 129785904
Test: Try to swipe up with various sysui states enabled
Change-Id: I654e0efd1f29ee6b4123e7f8aa717f62a55fdb50
2019-04-11 10:46:13 -07:00
Winson Chung 85011bdc21 Merge "Add state callback in launcher" into qt-dev 2019-04-11 15:22:36 +00:00
Winson Chung c4b88c3dfb Add state callback in launcher
Bug: 129785904
Test: Manual, change states and verify state is sent
Change-Id: Ia1f69494a6cbae68085fb09670ffa309ce147430
2019-04-10 21:59:25 -07:00
Hyunyoung Song cec2df62b2 Merging ub-launcher3-qt-dev, build 5456758
Test: Manual

Bug:111142970 Icon display blur in all apps page
Bug:114136250 Have a more spartan RecentsActivity on android go
Bug:122609330 Update PIP animation for swiping up to home
Bug:123985787 Respect dialogCornerRadius for all apps / widgets / settings / shortcut menu / dwb / task / overview (everything)
Bug:126587956 Create an app to use with Launcher testing
Bug:126606858 In multiwindow mode, not able to switch between recent apps.
Bug:127766994 Gray app icons disappeared after completing cable transfer for a while
Bug:127987071 Create a proper contract for specifying default Launcher Layout
Bug:129033091 [Q-Preview] I would like the ability to swipe up anywhere on my screen to open up the app li.
Bug:129297464 [Gesture Nav] Exclude edges from most Launcher / Overview states.
Bug:129434166 Lab-only flake: drag to workspace doesn't happen
Bug:129746879 [Q-Preview] Quick search bar overlaying other app
Bug:129874298 Show different string (Wallpaper vs Style & Wallpaper) on Settings depending on device type
Bug:129947426 nexus launcher crash observed randomly during device boot up(NPE:Attempt to invoke virtual method 'android.app.ActivityManager$RunningTaskInfo com.android.systemui.shared.system.ActivityManagerWrapper.getRunningTask(int)' on a null object reference)
Bug:129976669 Implement returning to home from Widgets in 0-button mode Bug:130027168 Can't tap in nav region on home screen
Bug:130151609 Some tests in MultiDisplaySystemDecorationTests.java failing in pre-submit
Bug:130182878 Pixel launcher crashes on secondary display
Bug:130225926 Cannot unpin app while in gesture nav
Bug:130245920 Icons disappear from launcher when selected
Bug:130272454 [C1/B1] Message app crash when opening a video MMS.
Change-Id: I18aa35d2c75deaf5149358d96d4e1d7f26de2f02
2019-04-10 23:51:57 +00:00
Winson Chung 5d7694c237 Merge "Check before the user is unlocked before handling proxied events" into ub-launcher3-qt-dev 2019-04-10 23:15:00 +00:00
Tony Wickham d807724de2 Merge "Track window for 2 button nav as well as 0 button" into ub-launcher3-qt-dev 2019-04-10 23:06:51 +00:00
Tony Wickham 8e5c13f360 Track window for 2 button nav as well as 0 button
This allows us to revert the change that fades in the shelf during swipe
up in 2 button mode, since the shelf doesn't show up until the window is
out of the way anyway.

Bug: 129746879
Change-Id: I929d8095989f9eae32d71b5bc3f67997e9df4ba0
2019-04-10 15:36:07 -07:00
Winson Chung 43b758c454 Check before the user is unlocked before handling proxied events
Bug: 130272454
Test: None, just checking for null state
Change-Id: I6b5a5c0dc7a0dbd8d2d75decd4e7d7ddf6cc3e3d
2019-04-10 15:30:01 -07:00
Winson Chung e9c4c50168 Temporarily disable screen pinning UI in gesture nav
Bug: 130225926
Change-Id: I782a5c6cdf00dfb8e501185f58defed4bfee3ac1
(cherry picked from commit e041ba0d61)
2019-04-10 22:11:19 +00:00
Hyunyoung Song 052624d897 TaskCornerRadius should not use dialogCornerRadius on devices not supporting rounded corners
Bug: 123985787

Change-Id: I4ffe06362256d4cc83bbe34c139d71ea1f6ca92e
2019-04-10 14:29:36 -07:00
TreeHugger Robot 731242ee66 Merge "Put pippable apps to pip mode upon swipe up to home gesture" into ub-launcher3-qt-dev 2019-04-10 21:26:47 +00:00
Tony Wickham 7f78e23ccc Don't scale/translate hotseat icons if they are visible in overview
Bug: 129145824
Change-Id: I02af7ad21b6dbc46041e774dfc6f5d3efb0ab8a9
2019-04-10 14:02:38 -07:00
Tony Wickham 9bbbe9cc14 Use DeviceLockedInputConsumer if !mIsUserUnlocked
There's an edge case where user isn't unlocked even if device is. In
that case, we still need to use DeviceLockedInputConsumer because
variables needed for any other input consumer aren't initialized until
the user is unlocked.

Bug: 129947426
Change-Id: I33a5e9a8d5c4266d45bd0d5a16657fa3c9644a1f
2019-04-10 12:54:54 -07:00
Winson Chung fd378d79e5 Check before the user is unlocked before handling proxied events
Bug: 130272454
Test: None, just checking for null state
Change-Id: I6b5a5c0dc7a0dbd8d2d75decd4e7d7ddf6cc3e3d
2019-04-10 09:51:38 -07:00
Tony Wickham 5dc60a0543 Add some egregious back exclusion rects
- Don't allow back gesture at all whenever we hid back button before
- Exclude RecyclerViewFastScroller thumb rect

Bug: 129297464
Change-Id: I40a33697592b02619218c18d1b3def7c3c203f56
2019-04-09 18:28:43 -07:00
Tracy Zhou d64fe113f5 Put pippable apps to pip mode upon swipe up to home gesture
Fixes: 122609330
Test: manual
Change-Id: I6cd0110b17fba9be6de1b3e6ba5750018d6f0514
(cherry picked from commit b091ed9098)
2019-04-09 21:11:19 +00:00
Tony Wickham 9edc8eb756 Merge "Allow swipe up to all apps anywhere on workspace" into ub-launcher3-qt-dev 2019-04-09 19:51:48 +00:00
Tony Wickham e2e953304f Allow swipe up to all apps anywhere on workspace
Bug: 129033091
Change-Id: Ib0066c59f86b3137aedad8d18393b5a622e0cd80
2019-04-09 12:23:01 -07:00
TreeHugger Robot 563178b173 Merge "Do a full touch dispach when proxying touch" into ub-launcher3-qt-dev 2019-04-09 19:03:02 +00:00
Sunny Goyal d158097cfd Do a full touch dispach when proxying touch
> Workspace can no longer be scrolled when swipin on hotseat

Bug: 130027168
Change-Id: Ie4621e5b7de8d7248227b25fb065249d0c252090
2019-04-09 11:53:41 -07:00
Tony Wickham 5e29395eba Merge "Swipe up on nav bar to go home from -1 and widgets" into ub-launcher3-qt-dev 2019-04-09 18:14:15 +00:00
Tony Wickham 9791bd1555 Swipe up on nav bar to go home from -1 and widgets
More specifically, any window (e.g. qsb search) or AbstractFloatingView.

NavBarToHomeTouchController now implements TouchController directly instead
of AbstractStateChangeTouchController, as it not only dealing with
launcher states. This makes it easier to override intercept logic to
handle cases like not having window focus, for example.

AbstractFloatingViews can createHintCloseAnim() to play an animation
hinting that it is about to be closed by swiping up. Widgets sheets use
this to pull back similar to the all apps transition to home.

Bug: 129976669
Change-Id: Ie157b978d9f1ee36d5fd32cea72ec02ce40878c0
2019-04-09 10:53:24 -07:00
Hyunyoung Song 2aec9c42f5 Change task view / all apps/ widgets / folder radius to dialogCornerRadius
Bug: 123985787
Change-Id: Iaa8088beb51d37dba90d57ad065f9eac0dd46270
2019-04-09 00:27:07 +00:00
Tracy Zhou b091ed9098 Put pippable apps to pip mode upon swipe up to home gesture
Fixes: 122609330
Test: manual
Change-Id: I6cd0110b17fba9be6de1b3e6ba5750018d6f0514
2019-04-08 20:34:31 +00:00
Sunny Goyal c7cc3dc2c5 Removing unnecessary corner size caching in RecentsModel
Change-Id: I1be87dc15a3b9ec8225dccce701bff19785658d6
2019-04-05 15:11:42 -07:00
vadimt 2a0670890a Not using system res ids in tests
Change-Id: I3aad2380dd6cd51ee23803cf5164f8b332a62e98
2019-04-04 14:36:53 -07:00
Hyunyoung Song 01aea983ef Merging ub-launcher3-master, build 5437471
Test: Manual

Bug:129423457 PluginCoreLib is not built from source code in master
Bug:129873705 Launcher crashes with Permission denial: writing to settings requires:android.permission.WRITE_SECURE_SETTINGS

Change-Id: Ib95d4de181eb70a30171c6ef511e803816b88dbf
2019-04-04 21:27:09 +00:00
vadimt 24eb1c9c89 Not using magic constant for edge sensitivity
+Some cleanup in TAPL

Change-Id: I886a6c4abacf8b806ee5507e633ec21f2e7ad1d4
2019-04-04 13:20:34 -07:00