Commit Graph

13651 Commits

Author SHA1 Message Date
Adam Cohen 47f21e8a08 Merge "Fix issue where Assistant could be invoked at the same time as all apps" into ub-launcher3-qt-dev 2019-05-22 03:48:36 +00:00
Tony e246dff69f Fix some issues with shelf jumping/duration
Don't use OvershootParams for 0 button mode, since that interpolator
assumes the shelf is moving in conjunction with recents/app window.
Instead, use OVERSHOOT_1_2 like we do when not flinging.

Also bound the duration when entering recents, since scroller
duration could be 750ms if we are snapping to the current page.
Now we cap at MAX_SWIPE_DURATION (350ms). This case is most likely
to be hit when ending a slow swipe near the final recents scale,
since in that case duration is close to 0 and the scroller duration
is taken instead.

Test:
- Artificially always detect a pause, fling up in 0 button mode;
  ensure shelf doesn't jump
- Either with the above artifical change in 0 button, or 2 button
  mode, end a swipe to recents near its final scale with a slight
  scroll to the right; ensure duration is 350 instead of 750

Bug: 132283018
Bug: 127783075
Change-Id: I8d5fbd0b30af21b9587fba47d141ba90b3b6e778
2019-05-21 20:27:55 -07:00
TreeHugger Robot 0ef504aa71 Merge "Adding tracing for a lab-only flake" into ub-launcher3-qt-dev 2019-05-22 03:12:56 +00:00
vadimt e17d1feb79 Adding tracing for a lab-only flake
We had a resolved case in the past where an app's context menu didn't
open on a long click (thanks to app updates), now the menu opens, but
the drag gesture doesn't drag the icon.

Bug: 133009122
Change-Id: I45d104a92fab6556ecd937aef76f0a8147e67f56
2019-05-21 17:19:23 -07:00
Miranda Kephart 8d70fab0c1 Merge "Pass in fling velocity for gesture progress" into ub-launcher3-qt-dev am: 49e5d8227b
am: 40b95f105b

Change-Id: I74d4ca609b7e42ec1982a2642eae006dd950c684
2019-05-21 16:36:57 -07:00
Sunny Goyal 55958e0331 Merge "Using squared hypot to optimize some comparisions" into ub-launcher3-qt-dev am: 32ba3c1125
am: 4c801fdc2b

Change-Id: I23aab3bee6469692d7c056cf6465fdf429dc2ead
2019-05-21 16:36:26 -07:00
Sunny Goyal 2524b82369 Remove unnecessary dispatchInsets routing
Insets are dispatched to all views. We never consume the insets and
let each view decide what to do with it.
Also fixing scrim in all-apps when in full-gesture navigation

Change-Id: Ib1c6bef5b32aac0c6ea03078b5138d2d0408c6d8
2019-05-21 15:58:44 -07:00
Adam Cohen 8f7d2b0dfd Fix issue where Assistant could be invoked at the same time as all apps
issue 132366412

-> First, we shouldn't accept flings when the delegate has intercepted. This prevents any situation
   where both are triggered.

-> Modified the slop to be the standard 8dp. This acts as a standalone fix because
   it means that there are no situations where we cross all apps slop before assistant slop.
   ie. in a purely vertical gesture from the corner, without this change, it's possible to trigger
   all apps instead of Assistant.

Change-Id: I39e3d8a525e165024399d9802d4cc1d7ae329ee6
2019-05-21 15:52:34 -07:00
Jon Miranda f535787571 Use spring to update window/icon scale for swipe up animation.
Bug: 123900446
Change-Id: I644dae6210ab3c8b72c777a556dfde4ae4cdce8f
2019-05-21 15:05:32 -07:00
Miranda Kephart 49e5d8227b Merge "Pass in fling velocity for gesture progress" into ub-launcher3-qt-dev 2019-05-21 21:05:00 +00:00
TreeHugger Robot 32ba3c1125 Merge "Using squared hypot to optimize some comparisions" into ub-launcher3-qt-dev 2019-05-21 19:48:37 +00:00
Jon Miranda c924f6fe66 Merge "Fix bug where FolderIcon stays visible during swipe up to home animation." into ub-launcher3-qt-dev am: 2445ca0777
am: f8bfb77a64

Change-Id: Ie813115750bba0ce9d0abd7c2efb96b4adf86aa9
2019-05-20 15:22:22 -07:00
Sunny Goyal 822fc2b331 Merge "Fixing inset map in case of display cutouts" into ub-launcher3-qt-dev am: dea6ee23c6
am: 6db1474d68

Change-Id: I34aa684ffd4deef440d966eeb87f9ece1697a6cb
2019-05-20 15:21:27 -07:00
Sunny Goyal 0be8eae4f1 Merge "Using different resource size for touch region in landscape" into ub-launcher3-qt-dev am: 662a14f2de
am: 4fbcb43af2

Change-Id: Ic9a5aaafaebed43ac46cd5e20cbe772cf567ef43
2019-05-20 15:20:59 -07:00
Sunny Goyal 878aa33567 Using squared hypot to optimize some comparisions
Change-Id: Ia5b99c2e60eedf02dea26857819f0e13127db4e2
2019-05-20 15:20:47 -07:00
Zak Cohen 2f48dd5158 Adapt the task footer container to be a named container. am: 418b9bc5fc
am: 1416342a3f

Change-Id: Id8507fbd43ffbe8af38ffdb0d5378278b88aa739
2019-05-20 15:19:41 -07:00
Miranda Kephart b063775eb9 Pass in fling velocity for gesture progress
Calls SystemUIProxy.onGestureCompletion for a completed gesture
(either drag or fling) and passes in the velocity (0 for drags).

Bug: 132356358
Test: manual

Change-Id: I080adc401e19a6141627d1806b425056f7eefcbd
2019-05-20 18:07:44 -04:00
TreeHugger Robot 2445ca0777 Merge "Fix bug where FolderIcon stays visible during swipe up to home animation." into ub-launcher3-qt-dev 2019-05-20 20:16:47 +00:00
TreeHugger Robot dea6ee23c6 Merge "Fixing inset map in case of display cutouts" into ub-launcher3-qt-dev 2019-05-20 19:11:19 +00:00
Sunny Goyal c79bd21471 Fixing inset map in case of display cutouts
Change-Id: Ia2969688d9ae4c89a2da45eb6361f4476e1877ec
2019-05-20 12:00:17 -07:00
TreeHugger Robot 662a14f2de Merge "Using different resource size for touch region in landscape" into ub-launcher3-qt-dev 2019-05-20 18:57:00 +00:00
Zak Cohen 418b9bc5fc Adapt the task footer container to be a named container.
Bug: 126744445
Test: manual
Change-Id: Id00ffac4581bbbe5dfd73a63b05c4512394745c1
2019-05-20 10:44:20 -07:00
Sunny Goyal 1b40b731b2 Using different resource size for touch region in landscape
Bug: 132917885
Change-Id: Ib702fd17fecff980db2e1d00f05cd055bcc3185a
2019-05-20 10:09:26 -07:00
Jon Miranda e543818bb6 Fix bug where FolderIcon stays visible during swipe up to home animation.
This can happen when opening an app from a folder, and then immediately
swiping up back to home.

This happens because when we swipe up to go home, there's a race condition
where the folder close animation finishes and sets the FolderIcon to VISIBLE
right before FloatingIconView sets it to INVISIBLE.

To fix it, in OverviewState#onStateEnabled we call
AbstractFloatingView#closeAllOpenViews(animate=false). Then we added logic
to cancel any Folder closing animation (which there is,
from WindowTransformSwipeHandler#onLauncherStart) and to just close the
folder right then and there.

Bug: 132588097
Change-Id: I4379431815e7cbddede5ea0213fe9323f001484b
2019-05-20 10:01:15 -07:00
Winson Chung 90eb08d838 Merging ub-launcher3-qt-dev, build 5582981
Test: Manual

Bug:118758696 Define grid display options
Bug:123900446 App to home animation should zoom into the app icon
Bug:124510042 [Gesture Nav] Home animation polish
Bug:129985827 [Fully Gestural Navigation] Delay Recents animation when swiping up
Bug:130020567 Handle fullscreen correctly for quick switch
Bug:130193889 Half screenshot in the app switcher
Bug:130292844 App close animation is slightly off for Squircle adaptive icons
Bug:130451254 QSB/Folder icon color depends on three variants of wallpaper shade on light/dark theme
Bug:130521490 Dock bar is too close to the edge when in landscape home screen
Bug:130689544 Unable to quickswitch apps under landscape mode
Bug:131231579 Long-swipe up to app drawer goes to overview
Bug:131360075 [Gesture Nav] Polish/finish landscape
Bug:132269977 Pixel launcher crashed while swiping up home button after disabling an app
Bug:132309376 Launcher held ION buffers after clearing all apps in Recent Apps
Bug:132458092 Recents Go: Transparent apps have double vision for apps to recents
Bug:132584688 Disallowed association between launcher and aiai
Bug:132816938 [Please fix ASAP] Failed test: sometimes home screen doesn't have all_apps
Bug:132892578 Split screen option missing for recent apps after restarting / upgrading the device.
Bug:132898688 NPE in 'com.android.quickstep.views.TaskThumbnailView com.android.quickstep.views.TaskView.getThumbnail()'
Bug:132908798 Gesture haptic double triggers
Bug:132916535 Handle multi-touch
Bug:74500048 Fix launcher transition while in startActivityForResult

Change-Id: I68d6af2ec47f2b379f5607685b2257029ab07a91
2019-05-19 05:03:33 +00:00
Vadim Tryshev 1a392b1bc8 Merge "Make every UI test generate screenshots for local test runs" into ub-launcher3-qt-dev am: ef80b4b491
am: ab4dcb9725

Change-Id: Id37d0bfee478f97d634e497bf12caa860e9ed95b
2019-05-17 20:00:11 -07:00
Vadim Tryshev ef80b4b491 Merge "Make every UI test generate screenshots for local test runs" into ub-launcher3-qt-dev 2019-05-18 01:40:38 +00:00
vadimt c328ac56cf Make every UI test generate screenshots for local test runs
Change-Id: Idb7962e62c0c95f8a50792e9342562c6d8b6ba42
2019-05-17 18:19:13 -07:00
Tony 32e4747b24 Merge "Continue using window's sysui flags if task thumbnail unavailable" into ub-launcher3-qt-dev
am: 7c278b62f9

Change-Id: I4102744697a06ac925b97fee89e083098199752f
2019-05-17 15:40:18 -07:00
Tony Wickham af41f829d7 Merge "Reapply recents attached state in createActivityController()" into ub-launcher3-qt-dev
am: 24200e2757

Change-Id: Ibad5e4777ebe4de6f5527d9b6e20ad9badf62560
2019-05-17 15:39:41 -07:00
Sunny Goyal ac4dda4103 Merge "Cancelling touch interaction on multi-touch event" into ub-launcher3-qt-dev
am: 95b81c3e55

Change-Id: Ic87605da36caa6da9da730a569222b998e7af4ba
2019-05-17 15:39:13 -07:00
Winson Chung 528d4cdad4 Merge "Fix issue with restored task display ids" into ub-launcher3-qt-dev
am: 57ffdc4ec7

Change-Id: Ia8bcd6ffdba37f768457b3c2081d3e5a4bb1bb36
2019-05-17 15:38:44 -07:00
Winson Chung 2720de2a3a Merge "Add more logging and commands to service dump" into ub-launcher3-qt-dev
am: d3b0e8ed61

Change-Id: I7b2f032c6b52ad0b384af99030d69e1fa6d17123
2019-05-17 15:38:14 -07:00
TreeHugger Robot 7c278b62f9 Merge "Continue using window's sysui flags if task thumbnail unavailable" into ub-launcher3-qt-dev 2019-05-17 22:25:42 +00:00
TreeHugger Robot 24200e2757 Merge "Reapply recents attached state in createActivityController()" into ub-launcher3-qt-dev 2019-05-17 22:21:03 +00:00
TreeHugger Robot 95b81c3e55 Merge "Cancelling touch interaction on multi-touch event" into ub-launcher3-qt-dev 2019-05-17 22:21:01 +00:00
TreeHugger Robot 57ffdc4ec7 Merge "Fix issue with restored task display ids" into ub-launcher3-qt-dev 2019-05-17 22:10:02 +00:00
Tony 921da74c64 Continue using window's sysui flags if task thumbnail unavailable
If the centermost task is null or doesn't yet have thumbnail data,
don't use its sysui flags - continue using the window we're swiping
from instead.

Bug: 132898688
Change-Id: I202937d8aa01ee24ef01693d9594c4929e6bd314
2019-05-17 18:04:53 -04:00
Sunny Goyal 78c1a42331 Cancelling touch interaction on multi-touch event
If the second touch happens outside the swipe region, for eg when the user
is using a different gesture like pinch-to-zoom, do not capture the
input events

Bug: 132916535
Change-Id: I59df3831b96689586a2a684bf11805d42f1cb1d9
2019-05-17 14:55:09 -07:00
Winson Chung 5aec768ff4 Fix issue with restored task display ids
- When tasks are restored, they don't have a valid display id yet,
  but they will still be started on the default display and should
  have the same options until proven otherwise.

Bug: 132892578
Change-Id: I8ba0a976bd5682fbcda72ca1a98bf2517eb31312
2019-05-17 14:45:34 -07:00
TreeHugger Robot d3b0e8ed61 Merge "Add more logging and commands to service dump" into ub-launcher3-qt-dev 2019-05-17 21:34:21 +00:00
Winson Chung 9fe9a155ca Add more logging and commands to service dump
Change-Id: I03d5ea5aac618eba7e0e5a1555e45a165918bb60
2019-05-17 14:23:09 -07:00
Tony Wickham 2b98dc3e69 Merge "Remove TaskViewDrawable, scale RecentsView instead" into ub-launcher3-qt-dev
am: c9986f59ac

Change-Id: I5f10a0e26c74ab6f0856f8dd5a6fe60807628a17
2019-05-17 13:55:31 -07:00
Tony 5bb3ae9462 Merge "Add getOverviewFullscreenProgress() to LauncherState" into ub-launcher3-qt-dev
am: b05fbb8915

Change-Id: Ie4f2ea793233f22f9bebe5ac35e30ae5c17efcc4
2019-05-17 13:55:04 -07:00
Tony Wickham c9986f59ac Merge "Remove TaskViewDrawable, scale RecentsView instead" into ub-launcher3-qt-dev 2019-05-17 20:41:55 +00:00
TreeHugger Robot b05fbb8915 Merge "Add getOverviewFullscreenProgress() to LauncherState" into ub-launcher3-qt-dev 2019-05-17 20:39:42 +00:00
Tony 1eb65b8a5b Remove TaskViewDrawable, scale RecentsView instead
Instead of faking recents scaling up when swiping down on a task,
actually scale it up. This is more consistent with what we do
for scaling to/from fullscreen elsewhere, and cleans up some code.

Bug: 130020567
Change-Id: I1a07813468d9a66f8f4e7b5d3d9a191b565f165c
2019-05-17 16:23:07 -04:00
Tony 5406817028 Add getOverviewFullscreenProgress() to LauncherState
- BackgroundAppState sets this to 1, all other states set it to 0
- QuickSwitchState extends BackgroundAppState, and calculations for
  fullscreen scale/translation are moved to BackgroundAppState
- Move fullscreen progress logic out of WindowTransformSwipeHandler
  and into the launcher activity controller, which uses the new
  RecentsView.FULLSCREEN_PROGRESS property to animate it

Bug: 130020567
Change-Id: If6265fcce3749050be354742e7d2c418d11ee9bb
2019-05-17 16:21:02 -04:00
Miranda Kephart 97383f457d Merge "Avoid double triggering assistant gesture haptic" into ub-launcher3-qt-dev
am: fcfac8156d

Change-Id: Ic3b5b77441e04ff45f6f97f9f3824d8577ed7665
2019-05-16 17:23:20 -07:00
Miranda Kephart 6366d377af Avoid double triggering assistant gesture haptic
If the user drags almost all the way to gesture completion and
then flings, the haptic got triggered twice: first for the drag,
and then once the fling was registered. This checks whether the
assistant was already invoked before triggering the fling
invocation.

Bug: 132908798
Test: manual
Change-Id: Ibeed7279b8db32527490a0e11b8e5f0761187bbf
2019-05-16 18:00:14 -04:00