Commit Graph

13651 Commits

Author SHA1 Message Date
Vinit Nayak 974f20f333 Merge "Add logs when clearing TaskViewId" into sc-v2-dev am: 2ad3d6b4c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15584532

Change-Id: If371285b5388c3cbf4bb8d09b7cb2d40368d32af
2021-08-17 01:15:45 +00:00
Vinit Nayak 2ad3d6b4c3 Merge "Add logs when clearing TaskViewId" into sc-v2-dev 2021-08-17 00:59:41 +00:00
Tony Wickham 635e180e56 Extend taskbar color to entire screen in overview
Only when taskbar is unstashed in apps:
- Scrim workspace with the taskbar color when opening apps and in BackgroundAppState
- Crop opening apps to above the taskbar
- Crop TaskViews to above the taskbar during gestures

If taskbar is stashed in apps, behavior is the same as before, i.e. no scrim over the wallpaper and no cropping of tasks.

Added a field DeviceProfile#taskbkarPresentInApps to distinguish these cases. LauncherTaskbarUIController and TaskbarStashController ensure this value is set appropriately.

Test: Ensure tasks don't appear behind taskbar when it's unstashed; set ENABLE_SCRIM_FOR_APP_LAUNCH = true to test the whole screen scrimming when opening an app

Bug: 196257194
Fixes: 190681228
Change-Id: I481501457a5a6d49c380feea3db3b4058e4cf3f8
2021-08-16 16:50:52 -07:00
Vadim Tryshev f11d0fac78 Revert "Removing old workaround"
This reverts commit 714d071f76.

Reason for revert: Perhaps caused b/196876329

Change-Id: I0763c44d54134034885471ce74324a8c6c6c296e
Test: presubmit
Bug: 196876329
2021-08-16 22:54:30 +00:00
Vinit Nayak dda7772452 Add logs when clearing TaskViewId
Bug: 195430732
Change-Id: I0554f27e6b82d98dd585afb895b8ee5eababff9e
2021-08-16 14:56:56 -07:00
Thales Lima 47e0bfa104 Merge "overview: rebalance hidden tasks in grid" into sc-v2-dev am: 242c8c0b0f am: 65dc11d1b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15453918

Change-Id: I0cbcf90477d70eef2bfd1680428c4997860488f1
2021-08-16 19:44:01 +00:00
Thales Lima 65dc11d1b4 Merge "overview: rebalance hidden tasks in grid" into sc-v2-dev am: 242c8c0b0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15453918

Change-Id: I6616a2077517ed66de775cded571cfecccc78f20
2021-08-16 19:33:25 +00:00
Thales Lima 242c8c0b0f Merge "overview: rebalance hidden tasks in grid" into sc-v2-dev 2021-08-16 19:16:30 +00:00
Dave Mankoff 423112d1d7 Merge "Pass main executor to PluginInstanceManager.Factory." into sc-v2-dev am: 9847a6a75b am: 685338f7c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15558874

Change-Id: I20cf971bd58253cb7e50da22fe411571fdcd711d
2021-08-16 15:43:05 +00:00
Dave Mankoff 191e328477 Merge "Pass Executor to to PluginInstanceManager.Factory." into sc-v2-dev am: d72a60f953 am: cc81d631b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15558873

Change-Id: I21f5ec132f552eed8e097fd5307b61863cfdbe1a
2021-08-16 15:42:01 +00:00
Thales Lima 4a08ce60dc overview: rebalance hidden tasks in grid
The tasks that are not showing in the screen will be rearranged. This
doesn't change anything for tasks before the dismissed task because the
grid is already balanced there.

Fixes: 194189955
Test: manual with 10 tasks, normal and RTL mode
Change-Id: I07ddbb752110339751bd1ed6056fe9f645b5497f
2021-08-16 16:24:35 +01:00
Dave Mankoff 685338f7c6 Merge "Pass main executor to PluginInstanceManager.Factory." into sc-v2-dev am: 9847a6a75b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15558874

Change-Id: If1b3510161b952ef3df9876810f314dd771d84e1
2021-08-16 15:23:45 +00:00
Dave Mankoff cc81d631b5 Merge "Pass Executor to to PluginInstanceManager.Factory." into sc-v2-dev am: d72a60f953
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15558873

Change-Id: I23f99561eecd0d2f705d5a2166b9e1e17aa7666a
2021-08-16 15:22:34 +00:00
Dave Mankoff 9847a6a75b Merge "Pass main executor to PluginInstanceManager.Factory." into sc-v2-dev 2021-08-16 15:05:20 +00:00
Dave Mankoff d72a60f953 Merge "Pass Executor to to PluginInstanceManager.Factory." into sc-v2-dev 2021-08-16 15:04:52 +00:00
TreeHugger Robot 339f367922 Merge "Removing old workaround" into sc-v2-dev am: 77c08b045e am: 4a9bf5ab91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15535538

Change-Id: If259b13ab777993002a471c541e80bd77e31e905
2021-08-16 10:50:35 +00:00
TreeHugger Robot 4a9bf5ab91 Merge "Removing old workaround" into sc-v2-dev am: 77c08b045e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15535538

Change-Id: I90431ad3e1773c909d94fc7b0aeacf77c439af24
2021-08-16 10:36:53 +00:00
TreeHugger Robot 77c08b045e Merge "Removing old workaround" into sc-v2-dev 2021-08-16 10:21:45 +00:00
TreeHugger Robot 53239c93a2 Merge "Removing old workaround" into sc-v2-dev am: e22e3aaa9a am: e46b0caee1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15534469

Change-Id: I4bcde01e4feba458ca4597409fddcd2c76980b46
2021-08-16 07:11:17 +00:00
TreeHugger Robot e46b0caee1 Merge "Removing old workaround" into sc-v2-dev am: e22e3aaa9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15534469

Change-Id: Ie05de12b6a74e7cb7f0582791d264ae2557031dd
2021-08-16 07:01:19 +00:00
TreeHugger Robot e22e3aaa9a Merge "Removing old workaround" into sc-v2-dev 2021-08-16 06:45:19 +00:00
TreeHugger Robot e262aede47 Merge "Constrain scroll amount" into sc-v2-dev am: 348065811f am: 33120900b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15564665

Change-Id: I58c2006e93d83fa6aa8917b159cef33736ed7507
2021-08-14 01:26:35 +00:00
TreeHugger Robot 33120900b8 Merge "Constrain scroll amount" into sc-v2-dev am: 348065811f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15564665

Change-Id: Ib61704ae9fd492a7569e191059f3de0acc560073
2021-08-14 01:11:33 +00:00
TreeHugger Robot 348065811f Merge "Constrain scroll amount" into sc-v2-dev 2021-08-14 00:57:13 +00:00
Dave Mankoff bf7f0e5426 Merge "Changes to the signature of PluginManagerImpl." into sc-v2-dev am: 78f9648aec am: f3658027c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15558514

Change-Id: Ib91cd33e8f57b79b61790baa0c9f895ee2f49d7f
2021-08-14 00:24:21 +00:00
Dave Mankoff f3658027c3 Merge "Changes to the signature of PluginManagerImpl." into sc-v2-dev am: 78f9648aec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15558514

Change-Id: I886ec469bea76555fa07452c4f730ed17cd7e456
2021-08-13 23:29:45 +00:00
Lucas Dupin b259a896f5 Constrain scroll amount
Test: scroll vertically and horizontally
Fixes: 196309367
Change-Id: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
2021-08-13 15:57:41 -07:00
Dave Mankoff 78f9648aec Merge "Changes to the signature of PluginManagerImpl." into sc-v2-dev 2021-08-13 21:12:40 +00:00
TreeHugger Robot b76df9dbd6 Merge "Removing some instrumentation for a workarounded bug" into sc-v2-dev am: 87cf3efe06 am: e9974d7d4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524189

Change-Id: I59adb5f869d491dbb7720bd79f616a4cc94e1452
2021-08-13 21:12:35 +00:00
Jon Spivack bb7553017c Add callback to ImageActionUtils for unresolved intents
Adding an optional callback to ImageActionUtils.persistBitmapAndStartActivity allows for external handling of the case in which the given intent cannot be resolved. The main use case is for NIU Actions when the user has chosen an assistant that does not support the feature. TaskOverlayFactoryGo provides a callback that shows a dialog in this case.

Various parts of TaskOverlayFactoryGo were also made public for better testability.

Bug: 196125662
Bug: 192406446
Bug: 195681795
Test: m -j RunLauncherGoGoogleRoboTests ROBOTEST_FILTER=TaskOverlayFactoryGoTest
Change-Id: I64f3a1274bc942a64e964dca20bd4245e336ad9d
2021-08-13 13:30:22 -07:00
TreeHugger Robot e9974d7d4c Merge "Removing some instrumentation for a workarounded bug" into sc-v2-dev am: 87cf3efe06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524189

Change-Id: I0172730d135c4584db080447892a498cbca4e876
2021-08-13 20:26:05 +00:00
Dave Mankoff 3258a9f790 Remove #handleWtfs from PluginInitializer.
This method was empty anyways.

Bug: 194781951
Test: manual
Change-Id: I404704090dc360e05b1db04815d394d47d63af28
2021-08-13 14:56:30 -04:00
Dave Mankoff 24e77c563c Remove PluginInitializer.
Bug: 194781951
Test: manual
Change-Id: I38b90ac7f310e4c2374d60a42f493e723c90401a
2021-08-13 14:56:30 -04:00
Dave Mankoff a6646be349 Remove #getPrivilegedPlugins from PluginInitializer.
Bug: 194781951
Test: manual
Change-Id: I61bcbdd92bdf7295060f00dac9b657b1a67b7f01
2021-08-13 14:56:26 -04:00
TreeHugger Robot 87cf3efe06 Merge "Removing some instrumentation for a workarounded bug" into sc-v2-dev 2021-08-13 18:42:22 +00:00
Dave Mankoff 08d1a77825 Rename PluginInstanceManager to PluginActionManager.
New PluginInstance class.

Bug: 194781951
Test: manual
Change-Id: I5274b6380acaad8bb2e900cfdce772b71add9483
2021-08-13 10:50:32 -04:00
Dave Mankoff 1095a50dfa Updates to constructor of PluginInstanceManager.Factory
Bug: 194781951
Test: manual

Change-Id: I510dcd3b405988320052944b412e1d18360144ef
2021-08-13 10:50:21 -04:00
Dave Mankoff 630ae94833 Pass main executor to PluginInstanceManager.Factory.
Bug: 194781951
Test: manual
Change-Id: I1667023887e0c8d1dc86fce1717a3032b6721684
2021-08-13 10:18:01 -04:00
Dave Mankoff 1d5e1dc8d1 Pass Executor to to PluginInstanceManager.Factory.
Bug: 194781951
Test: manual
Change-Id: I6dc699869d041aab8f5d1e7a128b4f67adfd78dc
2021-08-13 10:16:09 -04:00
Dave Mankoff 13f50b9898 Changes to the signature of PluginManagerImpl.
Bug: 194781951
Test: manual
Change-Id: Iafc5232dfdb1cc1c554de925c2f0d2ad5f6439e2
2021-08-13 10:01:42 -04:00
Ben Lin 15181b54b0 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev am: 99b5d13952 am: c3d09d22c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524184

Change-Id: I4025427c229838a0104625a266100fcfc184c066
2021-08-13 10:08:32 +00:00
Ben Lin c3d09d22c1 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev am: 99b5d13952
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524184

Change-Id: I1440056c2a451a241ed7b2b55810db958d599c14
2021-08-13 08:41:26 +00:00
Ben Lin 99b5d13952 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev 2021-08-13 01:09:19 +00:00
Ben Lin 1e49216401 Do not set user active hints when Shell Transition is on.
Previously, we hint at user active in order to let the launcher know at
an earlier time that the user is about to go home, to provide PiP a
shelf offset. However with Shell Transitions, this is now being done
instantly as the launcher activity is resumed right as user touches down
on the gesture pill. We then no longer need this for shell transitions.

Bug: 165793917
Test: Enable Shell Transitions, go home to enter PIP, and open another
app - see that PIP auto moves downward now that shelf height has changed

Change-Id: I347c885425ce820a42ebfcc15082862d04aa1a7d
2021-08-12 15:17:31 -07:00
TreeHugger Robot 4e9ea58712 Merge "Clean up test logging and ScreenRecord" into sc-v2-dev am: 662af98956 am: 3c7c23aa02
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15542317

Change-Id: I98e7524b37523af64d992768ee073293e748eb71
2021-08-12 18:35:46 +00:00
TreeHugger Robot 3c7c23aa02 Merge "Clean up test logging and ScreenRecord" into sc-v2-dev am: 662af98956
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15542317

Change-Id: I53ccca4501c95f942c71959bbf22c55dcb59c2bd
2021-08-12 18:20:47 +00:00
Alex Chau 2886a13d7a Clean up test logging and ScreenRecord
Bug: 194114179
Bug: 193125090
Test: manual
Change-Id: I086d011a39b74a24d5629d43dc74b741fcf5994e
2021-08-12 11:34:27 +01:00
TreeHugger Robot b99fd2e490 Merge "Adjust all apps zoom level" into sc-dev am: 6b10f4649c am: 4b3c24d0d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15530106

Change-Id: Ie5210a9f9fdf4ccf30e3dd01d5d07549d9880508
2021-08-12 00:45:22 +00:00
TreeHugger Robot 3be0173b14 Merge "Adjust all apps zoom level" into sc-dev am: 6b10f4649c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15530106

Change-Id: Id2a24af3aed6fa4819a2fc46c8a305b06ff31d84
2021-08-12 00:31:19 +00:00
TreeHugger Robot 4f3c68ec43 Merge "Adjust all apps zoom level" into sc-dev am: 6b10f4649c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15530106

Change-Id: I22bed9d6f2e71bfe3c755218fb7469b57d9ed585
2021-08-12 00:30:36 +00:00