Commit Graph

22972 Commits

Author SHA1 Message Date
Helen Cheuk dda022a19b Merge "[Action Corner] Handle go home action" into main 2025-05-13 12:46:40 -07:00
Treehugger Robot 7bacd8f0b7 Merge "Only show the frontend UI on the display if it is supported" into main 2025-05-13 12:03:10 -07:00
Sunny Goyal 43841027b0 Merge "Removing some unnecessary launcher typecast" into main 2025-05-13 11:42:34 -07:00
Will Osborn 635ad53b4f Merge "Fix transition to home on connected display by passing correct displayId to startHomeIntentSafely" into main 2025-05-13 11:09:49 -07:00
helencheuk d681164fe3 [Action Corner] Handle go home action
Handle go home and go back to previous screen for overview, split and full screen task

Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.systemui.shared.cursor_hot_corner
Change-Id: Ia928f102df6908058c02949db02a73430cea5ef1
2025-05-13 17:03:12 +00:00
Treehugger Robot 8a868c571e Merge "Fix IllegalArgumentException in RecentsWindowManger.onDestroy" into main 2025-05-13 09:35:13 -07:00
Treehugger Robot 5b77862850 Merge "Only show the Desktop shortcut when appropriate" into main 2025-05-13 09:15:04 -07:00
Jagrut Desai ac309032ac Merge "Fix NavButton Position when in RTL and Lanscape" into main 2025-05-13 08:35:32 -07:00
Sunny Goyal b2315b69c2 Removing some unnecessary launcher typecast
Bug: 417227133
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ie794e4855441f86441d869d315699bf46fce0db5
2025-05-13 08:26:25 -07:00
Treehugger Robot 54cc5efead Merge "Use TaskViews only for RecentsView CollectionInfo" into main 2025-05-13 08:16:08 -07:00
Schneider Victor-Tulias 099cce39eb Fix IllegalArgumentException in RecentsWindowManger.onDestroy
Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 413003643
Test: issue surfaced, and fix confirmed, in presubmit
Change-Id: I0c4f1ae44bc3868ac4dd8772d2a8989a3506db03
2025-05-13 07:11:57 -07:00
Will Osborn 770ab0cc00 Fix transition to home on connected display by passing correct displayId to startHomeIntentSafely
Bug: 415274390
Flag: EXEMPT bugfix
Test: local + presubmits
Change-Id: I6a825c93a683726c044024e411a8272004ede957
2025-05-13 14:03:01 +00:00
Pierre Barbier de Reuille 8ac46d7e37 Only show the Desktop shortcut when appropriate
The Desktop shortcut should only be shown if the task is on a display
that can host a desktop.

Bug: 405181230
Test: atest DesktopSystemShortcutTest
Test: Manual
Flag: EXEMPT (bug fix)
Change-Id: I4639aade4c3640a3c60b85e08981cbe46974df38
2025-05-13 14:41:13 +01:00
Sam Cackett 7ac8a04cbe Use TaskViews only for RecentsView CollectionInfo
getAccessibilityChildren includes the add desktop and clear all buttons
in the collection, so the list read outs are 2 bigger than they should
be

Fix: 411430606
Flag: EXEMPT. Bugfix
Test: Manual. Talkback
Change-Id: I3dbc4a9692396f7d8c094dd245745b878833c1a6
2025-05-13 05:45:03 -07:00
Treehugger Robot 61962ec222 Merge "Better null handling for OverviewComponentObserver.getContainerInterface" into main 2025-05-13 05:26:16 -07:00
Will Osborn 807d0f9ecf Better null handling for OverviewComponentObserver.getContainerInterface
Bug: 413634484
Test: local + unit tests
Flag: EXEMPT bugfix
Change-Id: I249cd1925ac416e9861be9d0c3c451e2b6cdff43
2025-05-13 09:28:29 +00:00
Johannes Gallmann 3a9aac8358 Merge "Remove haptics for long presses in 3-button-nav" into main 2025-05-13 01:21:00 -07:00
Treehugger Robot cd4e664701 Merge "Prevent unnecessary DisplayInfo refreshment" into main 2025-05-12 18:11:49 -07:00
Jagrut Desai 7c2a76b499 Merge "Fix TaskbarAllApps Icon" into main 2025-05-12 16:58:46 -07:00
Jagrut Desai 10faea6c76 Fix NavButton Position when in RTL and Lanscape
This cl changes the order of adding nav button to contrianer, so upon user rotating phone to landscape more while in RTL will not cause buttons to switch positions.

Test: Manual
Bug: 396135895
Flag: EXEMPT bugfix
Change-Id: If5512cbdac06bc65f10c8d1e326ae6b786de98ba
2025-05-12 16:57:01 -07:00
Mykola Podolian 21fbcbcf84 Merge "Only update handle alpha on system UI flag update." into main 2025-05-12 16:39:50 -07:00
Ebru Kurnaz d397601721 Merge "Update PerDisplayModule to provide IWindowManager to displayLib." into main 2025-05-12 15:51:38 -07:00
minch de7796ec33 Only show the frontend UI on the display if it is supported
Bug: 415367809
Test: Tested desktop mode is disabled in the pixel 9 but enabled
      in the connected display
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Iea257acd1a4468c9ac7d0b301fb66ab7ac59f5d7
2025-05-12 21:34:11 +00:00
Mykola Podolian 37437bafc5 Merge "Restore taskbar stashed state on the overview screen." into main 2025-05-12 14:27:29 -07:00
Treehugger Robot de9b62ed3e Merge "Fix All Apps fallback colors." into main 2025-05-12 14:02:18 -07:00
Treehugger Robot d89bd8d886 Merge "Split BlurStyle and BlurFallbackStyle for All Apps and Overview." into main 2025-05-12 14:02:09 -07:00
Brandon Dayauon 71c4e2881e Merge "Null check during filtering itemInfo by itemType." into main 2025-05-12 14:01:19 -07:00
Treehugger Robot 8381d839f7 Merge "Use RecentsWindowFlags in DisplayController" into main 2025-05-12 13:58:24 -07:00
Schneider Victor-tulias 91d606143d Merge "Fix missing tapl key events in TaplTestsQuickstep" into main 2025-05-12 11:39:29 -07:00
Schneider Victor-tulias 5050b29f23 Merge changes from topic "reapply-load-plan" into main
* changes:
  Add support for save app pairs to recents in window
  Update RecentsView to allow re-apply load plan
  Update AbstractQuickStepTest to check non-recents states correctly
2025-05-12 11:29:33 -07:00
mpodolian 810bfb755d Only update handle alpha on system UI flag update.
Added logic to check if handle view alpha should be updated during SysUi
flag updates.

Fixes: 417125892
Test: Manual. Create a new bubble on the home screen, observe the stash
handle is not visible.
Have stashed bubble bar and multiple system languages.
Go to settings (or ane other apps that has input fields). Click on
search to trigger keyboard pop up. Observe that stash handle is hidden.
Collapse the keyboard and observe that stash handle is shown again.
Flag: EXEMPT bug-fix

Change-Id: I0976f37ca24ba816ee5eed6d4f1b4e6999b54c29
2025-05-12 11:26:42 -07:00
Treehugger Robot dbce6aeefb Merge "Reduce combine() usage as it is expensive" into main 2025-05-12 11:15:52 -07:00
Treehugger Robot de378a054f Merge "Fix FallbackRecentsTest with recents in window enabled" into main 2025-05-12 11:09:45 -07:00
Vinay Joglekar 595f88c8e7 Merge "Fix live tile blur when overview blur flag is off" into main 2025-05-12 10:52:28 -07:00
Jagrut Desai bc28b98b8f Fix TaskbarAllApps Icon
Test: Manual, UX
Bug: 415836854
Flag: EXEMPT bugfix
Change-Id: I8b305ce35e0a6b73559f73083a0ca9b025043e8c
2025-05-12 10:46:57 -07:00
Brandon Dayauon bfa3f776fd Null check during filtering itemInfo by itemType.
Java crash says theres NPE on an itemType on null object reference implying itemInfo is null.

bug: 416662647
Test: presubmit
Flag: EXEMPT crash fix
Change-Id: I3c9724964442435148a720e96f208bd7c2a19ad5
2025-05-12 10:09:20 -07:00
mpodolian a4d2e5aa19 Restore taskbar stashed state on the overview screen.
Added logic to preserve overview screen state on the taskbar.

Fixes: 416418164
Test: Manual. Go to overview with the bubble bar. Expand bubble bar.
Rotate device. Observe the taskbar remains stashed.
Flag: EXEMPT bug-fix

Change-Id: I197c1b7f20b23a6b2a343b18b4da0aa45beb8c52
2025-05-12 10:01:23 -07:00
Uwais Ashraf a9f5aa5016 Merge "Do not take an additional screenshot during Overview transitions as it uses memory unnecessarily and adds load to system server" into main 2025-05-12 10:01:10 -07:00
Uwais Ashraf 16a6b28e1a Do not take an additional screenshot during Overview transitions as it uses memory unnecessarily and adds load to system server
Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Temporary local logging check
Change-Id: Ib8226ea238749097fdb160619b126a843b509529
2025-05-12 09:56:16 -07:00
Artsiom Mitrokhin 57db1826c9 Merge "Fix a crash when changing the observer list while iterating through it" into main 2025-05-12 09:37:25 -07:00
Uwais Ashraf 038c62f14d Merge "Cancel jobs on exit from Overview. Also cleanup Views to prevent leaks." into main 2025-05-12 09:36:48 -07:00
Ajinkya Chalke 36a811aa57 Use RecentsWindowFlags in DisplayController
- Instead of using enableOverviewOnConnectedDisplays from aconfig
  directly, use WindowManagerProxy to use RecentsWindowFlags so that we
  can use DesktopExperiencesFlags version for dev option.

Bug: 413609179
Test: m
Flag: EXEMPT flag infra
Change-Id: Iaacf068be13282017f94360acce1eea9aa1b0e84
2025-05-12 15:44:08 +00:00
Johannes Gallmann 76621e0972 Remove haptics for long presses in 3-button-nav
This CL removes haptics for long presses on 3-button-nav buttons, except
when the long press triggers a user visible action.

This means that for example the haptics for long pressing the recents
button are removed, whereas haptics for long pressing the home button
remain active since that launches circle-to-search.

Bug: 408968370
Test: Manual, i.e. verified that no haptic feedback is played when
      long pressing the recents button
Flag: EXEMPT bugfix
Change-Id: Icfeade8a659a8aa4882ef139696c66f410980303
2025-05-12 15:35:57 +00:00
Schneider Victor-Tulias 0f5f5b4fc9 Fix missing tapl key events in TaplTestsQuickstep
Because we were closing the recents window too quickly, the final ACTION_UP was never getting received. This change also cleans up the exit flow with the correct animation. Also posting touchModeChanged in OverviewCommandHelper to better support recents window, since the recents window may not be attached to window yet

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: TaplTestsQuickstep.testDismissOverviewWithEscKey, TaplTestsQuickstep.testDismissModalTaskAndOverviewWithEscKey, TaplTestsQuickstep.testOpenOverviewWithActionPlusTabKeys
Change-Id: I89e6c5716c0399857722114a243ed23c20a5c43d
2025-05-12 10:31:09 -04:00
Schneider Victor-Tulias b6a3b5d624 Add support for save app pairs to recents in window
Save app pairs does not support 3P launchers, however the way we were checking for that case was incorrect. Updated the checks to support recents in window.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: TaplTestsSplitscreen.testSaveAppPairMenuItemOrActionExistsOnSplitPair
Change-Id: I6c91e0ed2aa5bc16e828f71def422d5a721c1aa1
2025-05-12 10:29:17 -04:00
Schneider Victor-Tulias db74f177a6 Update RecentsView to allow re-apply load plan
If the recents view is not attached to window when reloadIfNeeded is called, then mTaskListChangeId will be set, but applyLoadPlan will exit early without actually applying the loaded tasks. This is an issue since the recents list will remain outdated until the task stack changes. This has been causing issues in tapl tests with recents window enabled. Delaying the setting of mAppliedTaskListChangeId until the end of applyLoadPlan to fix this.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: TaplTestsQuickstep.testDismissLastGridRow
Change-Id: Iaa8441a74b54f86167a7963b0005c044f355d94e
2025-05-12 10:29:06 -04:00
Schneider Victor-Tulias e4c3faa138 Update AbstractQuickStepTest to check non-recents states correctly
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: I7a4381bbc8214beea2e354df2851f0ba1aaddd5c
2025-05-12 10:28:53 -04:00
Schneider Victor-Tulias 82050b85fa Fix FallbackRecentsTest with recents in window enabled
- Added a workaround to listen to onNewIntent without RecentsActivity in TouchInteractionService, allowing us to clean up the recents window appropriately
- Updated LauncherInstrumentation.executeAndWaitForLauncherStop to expect a state change instead of activity stop in 3P + recents window

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I3756e268626d778a13be1f2c68f9d3157602534e
2025-05-12 10:27:41 -04:00
vinayjoglekar 50d27b353a Fix blur jank when app -> overview and app -> home.
This cl fixes conditions of when to skip the blur. While setting any  new surface, we should always apply the blur.

Fix: 417131537
Fix: 416689392
Test: Go to overview from app. Go to home from app
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I16ff00cf0be554eaf9aa4f48adc23b5cec4ae3da
2025-05-12 14:28:07 +01:00
Uwais Ashraf da860e3d46 Reduce combine() usage as it is expensive
Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Perfetto trace comparison shows fewer continuations
Test: TaskViewModelTest
Change-Id: Id5c645afff9850453139b85dbcda907cd12c5d26
2025-05-12 12:54:11 +00:00