dispatchDraw was calling getVisiblePages which in turn calls
getDescendantCoordRelativeToParent and created multiple new abjects
Change-Id: I401fec076183979d30dfdbbdc02a57bd79f3886d
Clearing the focus was causing the first child in the new page to
immediately take focus, which caused FocusIndicatorView jank when
using a keyboard.
Bug: 25256728
Change-Id: I5ab31ebc3fe370d7ac9e9792b30dab3467023738
The navigation bar is opaque on mobile devices in landscape mode.
Launcher should ignore the right insets and draw the edge effect appropriately.
Also draw the black bar under the navigation bar, just in case we assume it
to be opaque, but it was not actually opaque.
Bug: 18526657
Change-Id: I1d49dcb82b8a5ee25009bc738cd9b8c0c5c88263
> Renaming Lmp to Lollipop
> Lollipop_MR1 instead of directly using 22
> Using M APIs directly instead of reflection
Change-Id: I10a307f46e3be15b3299f549a2fd7e0e215a6a1b
> Using the currect right page index in rtl
> Updating current scroll after max scroll has been calculated. This prevens an extra overscroll when the layout happens for the first time.
Bug: 22358804
Change-Id: If07132701936e06f727211122a3b3e6f8426c07b
-> When in overview mode, flinging the pages can leave the scroller
running (invisibly) for much additional time, since the scroller
fling bounds far exceed the alloawble scroll bounds (in order to
achieve a hard wall type effect)
-> When this is happening, user couldn't pick up a page for reordering
-> Ended the scroller early in this case to avoid the problem
Change-Id: I8b6f140d9a87bb742e57625e90ca7d76a2158e28
> Make package-private and @Thunk all private methods and constructors accessed from inner classes.
Change-Id: Ie5913860a0c33e48e9bf68f9b5b1699f64c2f174
The reason for non-scrolling was excluding the pages view from the
accessibility hierarchy by marking it as non-important. So, I just
removed the code manipulating [non]importance of the PagedView.
However, this would make the PagesView accessibility-focusable, which is
undesirable. It becomes focusable because it supports long clicks in "normal"
mode. Since it doesn't support accessibility long clicks (i.e. Overview mode is
fetched NOT via accessibility long-click), I just disabled accessibility
long-clickability, which made PageView non-focusable, and it started to behave
correctly.
Bug: 21281859
Change-Id: I7ab01e5f39cb37c456c961199c27458c9bda1c3d
AccessibilityEvent.TYPE_VIEW_SCROLLED sent by PagedView.
This causes an additional reduntant voice message on scroll (see the
bug).
Also, setting these attributes violate rules set here:
http://developer.android.com/reference/android/view/accessibility/AccessibilityEvent.html
i.e. that these fields should be set only for descendants of
AdapterView.
Note that we can't just stop sending TYPE_VIEW_SCROLLED, because in this
case, accessibility focus won't be set after scrolling.
Bug: 21304383
Change-Id: I84f8e064d8209c0e09d6827551e00c9913829b57
> Fixing some RTL errors by specifying both marginStart and marginLeft
> Moving all layout direction checks to Utilities
> Explicitely adding @TargetApi before every method
Change-Id: Ibe9c52b93b5a6adeadb27ace2b312770fd732ea0
1. Not generating scroll events from snapToPage(). It already gets
generated from computeScrollHelper().
2. Not setting action because doing so is not mentioned here:
http://developer.android.com/reference/android/view/accessibility/AccessibilityEvent.html.
3. Not generating scroll event when the page stays same (before it was
generated, say, when we simply returned from the AllApps view to
Workspace).
4. From/To index is not the old and new page numbers; they are indices
of the first and last item; in our case, the item is the page, and
both FromIndex and ToIndex should be set to this page number.
Bug: 18761184
Change-Id: I3dadf816c3d45b8bd42a13930344874584467499
> Removing fling to delete pages
> Removing delete drop target for pages
> Removing syncpages support (was used by paged all apps)
Change-Id: I0a35ae30da8c48a27aac341bbee9fb5623665902
- Also fix a bug where the focus is not navigating to the next page when there
isn't an icon within +45 and -45 range of the origin.
b/20294717
Change-Id: I16dac5c6a0463fbc9f56a447abedad18abadde98
Elimates 304 methods based on dex analysis
The java compiler generates sythetic accessor methods for all private
fields, methods and contructors accessed from inner classes. By marking them
package-private and @Thunk instead, sythentic accessor methods are no
longer needeed. These annotated elements should be treated as private.
Change-Id: Id0dc2c92733474250d8ff12fa793d3a8adeb1f26
-> This caused funky layout issues with views not appearing
on devices prior to K in addition to log spam.
issue 17282728
Change-Id: Id05856ba2ef3de3a8a636ba9b4b46ddef3eff75e
-> adding dark panel / associated visual updates
-> cleaning up the sizing / padding / to match all apps
-> fixing a couple things from previous CL
-> (removed Context#getDrawable() calls, L-only)
Change-Id: Ia65a6eb704b35f74e7305be9334c27971b22235a
-> separating HW layers during animation to be siblings
instead of parent-child (was destroying parent layer
on each frame)
-> Unifying material transition with pre-L, everything
is the same, just missing the reveal.
Change-Id: I8f7d5e658c2d9298bea83ce8199cb35e6fc0d44e
Sunny Goyal
Tony Wickham
Adam Cohen
Vadim Tryshev
Winson Chung
Hyunyoung Song