Commit Graph

19227 Commits

Author SHA1 Message Date
Stefan Andonian 6284b233bf Maintain Talkback / Voice Access / etc. focus after moving item in Workspace.
Bug: 383456105
Test: Verified this works well manually.
Flag: EXEMPT bug fix
Change-Id: I35377443c4800a53cfa539c7061d5ef1b8b27837
2025-01-07 09:57:43 -08:00
Charlie Anderson 239745aae9 Merge "Convert IconShape to Kotlin" into main 2025-01-06 14:59:26 -08:00
Treehugger Robot eb453571d9 Merge "Converting DesktopVisibilityController to a singleton" into main 2025-01-06 12:05:48 -08:00
Charlie Anderson 825bac83fa Convert IconShape to Kotlin
Bug: 387546047
Test: Just presubmit
Flag: EXEMPT no functionality change
Change-Id: I68029ec02690eaf7cb30a16f87fca71df7c2fd51
2025-01-06 13:39:46 -05:00
Sihua Ma 67db76e847 Merge "Change home screen state description to manifest page change" into main 2025-01-06 10:37:20 -08:00
Treehugger Robot 9817348151 Merge "Call AccessibilityDragListener immediately after Workspace's OnDragListener." into main 2025-01-06 10:09:53 -08:00
Uwais Ashraf b1f28aa75e Use Dispatchers.Main.immediate to run code quickly that runs on main.
immediate dispatcher schedules code on main (post{...}) if the current coroutine context is not main. However, if the coroutine context is main it will run synchronously without scheduling the work.

This removes all the continuations that come from initialisation of flow collectors.

Bug: 387511656
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Checking perfetto traces shows that this reduces the number of continuations on main by ~120 for 30 apps
Change-Id: I6c5ffba893e470c25d81f044f83cf43cb80588b8
2025-01-06 16:06:26 +00:00
Stefan Andonian fa8e3f9292 Call AccessibilityDragListener immediately after Workspace's OnDragListener.
This ensures that the dragInfo has not been set to null before the AccessibilityDragListener's
onDragEnd is called. Previously, this was breaking long accessibility moves.

Bug: 387563703
Test: Verified locally that this fixes the issue.
Flag: EXEMPT bug fix.
Change-Id: I8d25c3865a0a025a9dad341ea39062cb3658a763
2025-01-03 16:19:34 -08:00
Sunny Goyal 6d6529cff9 Merge "Converting LauncherPrefs to dagger" into main 2025-01-03 14:18:19 -08:00
Sunny Goyal e79d453bc8 Converting LauncherPrefs to dagger
Fixing ENABLE_TWOLINE_ALLAPPS_TOGGLE not properly tied to IDP:
http://recall/-/ep7WJ8pKwCEklUN5J1mAkM

Bug: 361850561
Flag: EXEMPT dagger-migration
Test: atest LauncherPrefsTest FakeLauncherPrefsTest
Change-Id: Iba63d060f4a8c2e31033fca2a4638c559c161338
2025-01-03 13:49:53 -08:00
Treehugger Robot c7ce8d588a Merge "Remove Widget Resize Border on Accessibility delete" into main 2025-01-02 18:25:19 -08:00
Stefan Andonian d3d62de59a Remove Widget Resize Border on Accessibility delete
Bug: 384446998
Test: Verified locally that this works as designed.
Flag: EXEMPT bug fix
Change-Id: Ib93e4d574ee5584b955b973005008708ca986ac6
2025-01-02 16:33:50 -08:00
Treehugger Robot fca7701858 Merge "WidgetResizeFrame doesn't disappear during Accessibility Widget Resize" into main 2025-01-02 16:31:18 -08:00
Sihua Ma 2bad402275 Change home screen state description to manifest page change
Bug: 383247157
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I1c2d3aa90d2b4ee9a1beaa4fbe7db57e79ae49dc
2025-01-03 00:00:48 +00:00
Stefan Andonian f1791fe5f0 WidgetResizeFrame doesn't disappear during Accessibility Widget Resize
Bug: 384446925
Test: Verified this works locally after reproducing it.
Flag: EXEMPT bug fix
Change-Id: If5db895358f05b24cb67f7b23d78aada6c79a80a
2025-01-02 14:33:21 -08:00
Treehugger Robot d4bfadf263 Merge "Fixing low res folder icon when preview changes" into main 2025-01-02 10:11:27 -08:00
Sebastián Franco ef414988cc Merge "Fix Widgets in portrait being restricted by landscape grid and vice-versa" into main 2025-01-02 09:50:02 -08:00
Treehugger Robot c3b0330292 Merge "Fix for bug where Talkback announce Folder:null" into main 2024-12-30 16:09:01 -08:00
Sunny Goyal 04b50a08f6 Fixing low res folder icon when preview changes
Also removing legacy for drawable sharing between folder-content and folder-icon, since preview now always creates new drawables

Flag: EXEMPT bugfix
Bug: 386842651
Test: atest PreviewItemManagerTest
Change-Id: Ib8e4b4d5be4fb0c9601b9d8e3cef8a29d6c77651
2024-12-30 15:47:17 -08:00
Treehugger Robot 7482e5cbe2 Merge "Fixing prediction ring color not getting updated if the icon changes while the slot animation is running" into main 2024-12-30 14:27:50 -08:00
Stefan Andonian 25283f0f45 Fix for bug where Talkback announce Folder:null
Bug: 385046797
Test: Verified this works locally.
Flag: EXEMPT bug fix
Change-Id: I9ad23f351df078b6bd40ff861e13b9109bfa8993
2024-12-30 14:01:28 -08:00
Sunny Goyal ad61173ca2 Converting DesktopVisibilityController to a singleton
This avoids a persistant connection to TouchInteractionService from WMProxy,
which keeps the service alive all the time

Bug: 384896306
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Id6fe59471c8c3f9874514f71126631f217ab610c
2024-12-30 12:54:19 -08:00
Sebastian Franco 5a9280203b Fix Widgets in portrait being restricted by landscape grid and vice-versa
Fix: 380049023
Test: Verified locally
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ie06a7eaa059d5b8e675a16da80dc03803d28ea2f
2024-12-30 14:42:37 -06:00
Treehugger Robot cdfec1a942 Merge "Replacing custom parcelables with platform types for test APIs" into main 2024-12-27 10:39:19 -08:00
Sunny Goyal 5bf0742fc5 Fixing prediction ring color not getting updated if the icon changes
while the slot animation is running

Slot animation is only trigerred through prediction update and it sets
final ring color at that point as part of the animation. If the icon
and the color change due to some other reason (like high-res icon or
a package-update), that color is overriden by the ongoing slot animation.

Bug: 381897614
Test: Verified manually by slowing down animation
Flag: EXEMPT bugfix
Change-Id: Ia3b86330afdb91ba6ff3366e3c8057bd7ec34e5d
2024-12-27 02:54:21 -08:00
Sunny Goyal c2639e464f Replacing some fixed lookup flags with specific constant flag
This would make it easier to customize flags used on desktop icons

Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: I0f3f04ddbe73abea207a5b58a65714ff172b2726
2024-12-26 20:19:02 -08:00
Sunny Goyal a39a09ba6a Replacing custom parcelables with platform types for test APIs
Bug: 377772352
Flag: EXEMPT test only
Test: Presubmit
Change-Id: Ie464c67adf6502aee1fe65ef643e1a67260b820f
2024-12-26 17:19:15 -08:00
Sihua Ma 8c141ef524 Merge "Remove disruptive home screen announcement when scrolling" into main 2024-12-26 10:21:57 -08:00
Treehugger Robot 1aea1ea8e0 Merge "Converting BaseIconCache to kotlin" into main 2024-12-26 09:29:00 -08:00
Sunny Goyal d5ad770d2c Converting BaseIconCache to kotlin
Bug: 366237794
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ia191ed468eda24f910bba87221cf1f1714408a55
2024-12-24 21:27:33 -08:00
Sihua Ma 67d2f4b591 Merge "Remove disruptive announcement when exiting folder" into main 2024-12-23 15:17:13 -08:00
Sihua Ma 765df11c2e Merge "Remove disruptive announcement after widget resize" into main 2024-12-23 15:16:29 -08:00
Sihua Ma 32f5d08555 Merge "Remove disruptive confirmation announcement when dropping icon" into main 2024-12-23 15:10:59 -08:00
Shamali P ed5b8ea05f Remove page number announcement on carousel and set it on description
Others e.g. folder etc. will need to handle it separately, so, didn't
update pagedView.

Bug: 383252838
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I43f3818afcdaa4d4805df2af0890b970d71db9a7
2024-12-23 07:58:56 -08:00
Shamali P 9753481abb Remove disruptive announcement when widget is added
Bug: 383423227
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I59aa0c226f197c3e25c50738230ce8c070f7f483
2024-12-23 07:58:46 -08:00
Holly Jiuyu Sun 3bfeb56eca Merge "[a11y] Do not announce "item added to homescreen" after adding web shortcut." into main 2024-12-20 15:05:35 -08:00
Sihua Ma 4cc729ebca Remove disruptive announcement when exiting folder
Accessibility announcement needs to be disabled when folder is closing

Test: Manual
Flag: EXEMPT bug fix
Fix: 383248901
Change-Id: Ie6077a1214c234946bc9fb59ce54dfa7107188bd
2024-12-20 22:06:38 +00:00
Sihua Ma 4ccf8e2957 Remove disruptive home screen announcement when scrolling
Test: Manual
Flag: EXEMPT bug fix
Fix: 383247157
Change-Id: I8470740af2720b328a358a21507270a4735a53a4
2024-12-20 19:07:56 +00:00
Sihua Ma eddeb21b60 Remove disruptive announcement after widget resize
Fix: 383450007
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I9f48970d24fdb425c8e3da40d4a66195bd13dd30
2024-12-20 18:25:33 +00:00
Charlie Anderson 7db906a5ec Merge "Put shape options for picker behind it's own flag" into main 2024-12-20 06:16:24 -08:00
Treehugger Robot 89c4752aa3 Merge "Add Debug Logs to AllAppsStore's dump for Bitmap flags" into main 2024-12-19 17:31:51 -08:00
Willie Koomson b2cd3659b6 Merge "Dismiss resize frame before adding widget with add button" into main 2024-12-19 17:27:22 -08:00
Sihua Ma 41963ef6b2 Remove disruptive confirmation announcement when dropping icon
Bug: 383643519
Flag: EXEMPT bug fix
Test: Manual
Change-Id: I995a4a68f55f3de77cadf3eee20f72c0edb824f2
2024-12-20 00:08:31 +00:00
Charlie Anderson be6f04b11a Put shape options for picker behind it's own flag
Test: presubmit && locally verified switching flags
Flag: com.android.launcher3.enable_launcher_icon_shapes
Bug: 376293447

Change-Id: If2fb8b6dcdcfcaf6ba0f6f1acef45d5bf2b327cb
2024-12-19 17:34:08 -05:00
Stefan Andonian a87a57277d Add Debug Logs to AllAppsStore's dump for Bitmap flags
Bitmap flag state determines whether or not the work badge is shown.
Sometimes, it is not present when it should be. This state is necessary
for determining why the badges are not showing.

Bug: 377618519
Test: Verified that the logs don't crash the app when they are printed. Used command: adb shell dumpsys activity com.google.android.apps.nexuslauncher.NexusLauncherActivity | grep -A 68 "AllAppsStore"
Flag: EXEMPT bug logs
Change-Id: Ia52ae49cdf9dcfda7ffbef1e7c71f2a17782fbae
2024-12-19 12:09:08 -08:00
Holly Sun 52b5d3b4f0 [a11y] Do not announce "item added to homescreen" after adding web shortcut.
Bug: 383457529
Test: manual
Flag: EXEMPT talkback bug fix
Change-Id: I3fe331b17e51e208e2b5ce74be88e35c2b802077
2024-12-19 11:22:58 -08:00
Charlie Anderson 4c89531f9d Merge "cleanup misleading logs around restore and grid migration" into main 2024-12-19 11:03:37 -08:00
Charlie Anderson 9654c08d9d cleanup misleading logs around restore and grid migration
Bug: 378684472
Test: N/A just logs
Flag: EXEMPT just logs
Change-Id: I756ef1926810852453bbc00e6dcf02eec4f8955b
2024-12-19 11:06:42 -05:00
Ana Salazar Maldonado bc2b3ae3b0 Merge "Fix Title padding for the contrast tile" into main 2024-12-18 15:24:04 -08:00
Sebastián Franco f07079d0ff Merge "Revert^2 "Making sure that test go to FixedLandscape on landscape"" into main 2024-12-18 14:16:08 -08:00