PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
51,233 Commits 1 Branch 0 Tags
62193df05901c394aaa3d4a4d35bc72a0e20ec2a
Commit Graph

11268 Commits

Author SHA1 Message Date
Jeremy Sim 69a22b907f Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev am: c528e7e818 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19960985

Change-Id: Ib408c5b8f113d13a63fd6071283cdf73f69af74b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-17 22:18:53 +00:00
Jeremy Sim c528e7e818 Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev 2022-09-17 21:45:24 +00:00
Jeremy Sim 7917ff31cc Fix two bugs with rotation in split select state 
This CL fixes two bugs that were triggered by rotating in split select state:
1) Rotating in split select state will no longer cause a jittery animation to play
2) Initiating split from home, then rotating will no longer create extra split placeholders on screen

The bugs were present because handleSplitSelectionState() animated every state transition into SplitSelect, including SplitSelect > SplitSelect (which happens when rotating). This caused a jittery animation to play, and in certain cases, caused additional copies of FloatingTaskView and SplitInstructionsView to be created.

Fixed by auto-skipping animations for SplitSelect > SplitSelect, and by safely removing views when entering SplitSelect (to prevent duplicates).

Fixes: 242965515
Fixes: 243088958
Test: Verified visually on-device.
Change-Id: Iab813b1fe599bfdc550fe9a1d354b28cedb4b659
 2022-09-16 15:28:33 -07:00
Hongwei Wang 334b1e0ee6 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev am: 93f650d3e0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969480

Change-Id: Id300bb64efa51ca5956fea8bac36b653b732d1c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-16 20:08:46 +00:00
Hongwei Wang 93f650d3e0 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev 2022-09-16 19:26:33 +00:00
TreeHugger Robot d7d05d1d7a Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev am: af2fe7fd12 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967481

Change-Id: Iddbb6898e4acecd61b10a30fefc3fe3134869205
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-16 17:22:10 +00:00
TreeHugger Robot af2fe7fd12 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev 2022-09-16 16:50:04 +00:00
Alex Chau fa83199e62 Turn off changing depth in wallpaper picker 
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
 2022-09-16 16:39:47 +08:00
TreeHugger Robot 3d021d46d9 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev am: 9fb4802a67 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19975454

Change-Id: I8c15a562ab54163907e0b6306280950512fdf923
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-16 07:55:43 +00:00
TreeHugger Robot 9fb4802a67 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev 2022-09-16 06:23:07 +00:00
Stefan Andonian 5df305fed6 Moving ViewCapture to Quickstep level to use hidden apis. 
Bug: 242867462
Test: Compilation succeeded while using private flags.
Change-Id: I9b15967b594963c5573ea1a0000b60f7c705da95
 2022-09-16 03:36:15 +00:00
TreeHugger Robot c3f2fcea3e Merge "Revert "Using Transaction directly instead of building surface p..."" into tm-qpr-dev am: 3187928c51 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19971330

Change-Id: Ia3038d05fa61cb4de901e0a0fd53354b3da2c9ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-16 01:14:41 +00:00
Schneider Victor-tulias cb7e57bd5a Merge "Remove redundant start recents animation logs" into tm-qpr-dev am: 03732ff0f8 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956393

Change-Id: I277f89b48d88d29ee52978b34e56587be9fcea6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-15 21:12:52 +00:00
Schneider Victor-tulias ab78301082 Merge "Reuse log IDs when a GestureState is being reused" into tm-qpr-dev am: ff7e5382b5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944062

Change-Id: I72f3a3bfc3f990e0e0bbc602ea7a4ba78acb8dbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-15 21:12:51 +00:00
Schneider Victor-tulias 3e6519bab1 Merge "Update ActiveGestureLog to print logs from oldest to newest" into tm-qpr-dev am: 11507173a1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944061

Change-Id: Ia0241d2c06fbba9a25e400bfb92e8d6768b70c9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-15 21:12:49 +00:00
Sunny Goyal 9925bbd147 Revert "Using Transaction directly instead of building surface p..." 
Revert "Removing unused surface transaction wrappers"

Revert submission 19933596-tcompat

Reason for revert: b/246899728
Reverted Changes:
I31123dff7:Using Transaction directly instead of building sur...
I2e2526d21:Removing unused surface transaction wrappers

Change-Id: I63d1d8bb723b7bd05d345fb21a67f88e5fb36bc1
 2022-09-15 14:07:51 -07:00
Schneider Victor-tulias 03732ff0f8 Merge "Remove redundant start recents animation logs" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
Schneider Victor-tulias ff7e5382b5 Merge "Reuse log IDs when a GestureState is being reused" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
Schneider Victor-tulias 11507173a1 Merge "Update ActiveGestureLog to print logs from oldest to newest" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
TreeHugger Robot 2d061d279f Merge "Update secondary task menu check to explicitly check for phone" into tm-qpr-dev am: 7532df84c5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944101

Change-Id: Ib0f0babe2fc3d023c713a6cdf7b23725e0d7f7e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-15 19:50:24 +00:00
Hongwei Wang 7da9a38669 No auto-pip animation if SysUI is not available 
The Launcher crash in the bug is a consequence of SysUI being stopped
due to ANR. In this rare case, we should not start the auto-pip
animation to further crash the launcher.

Bug: 245947669
Test: N/A
Change-Id: I2e99a82d4dccf302788fdb0752f70091fe5a18a3
 2022-09-15 12:49:29 -07:00
TreeHugger Robot 7532df84c5 Merge "Update secondary task menu check to explicitly check for phone" into tm-qpr-dev 2022-09-15 19:12:38 +00:00
TreeHugger Robot 1c46220a98 Merge "Add metrics sources for split invocation" into tm-qpr-dev am: e58e123bd7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19820319

Change-Id: Ic52f6edd2b25282d0d5b79d1b9d57d7d7cc53dcc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-15 09:44:00 +00:00
TreeHugger Robot e58e123bd7 Merge "Add metrics sources for split invocation" into tm-qpr-dev 2022-09-15 09:35:12 +00:00
Tony Huang 2bf9faa538 Merge "Fix split divider flash if swipe again quickly" into tm-qpr-dev am: ade8b9d753 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19903469

Change-Id: Ic450af25bf003bced928f761e4709f4a8fed5fed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-15 05:03:48 +00:00
Tony Huang ade8b9d753 Merge "Fix split divider flash if swipe again quickly" into tm-qpr-dev 2022-09-15 04:46:26 +00:00
Jeremy Sim 7439620808 Update animations for TM-QPR: Overview > OverviewSplitSelect transition am: 21a5b12b6f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19728187

Change-Id: I2265c49567d0807e4e9e20cb755180df15e102cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-15 04:24:24 +00:00
Jeremy Sim 21a5b12b6f Update animations for TM-QPR: Overview > OverviewSplitSelect transition 
This change updates the Overview > OverviewSplitSelect animation to the latest spec. This is a re-upload of a previous change, ag/19464657, but no longer will cause the b/241165022 issue.

Includes:
- New timings
- Task thumbnails slide in with an "overshoot" animation
- Icons fade out and fade in appropriately
- SplitInstructionsView has a new compound "unfold" animation

Bug: 236760307
Test: Manual on tablet. Made sure the b/241165022 issue is fixed.
Change-Id: Ia22f6b6d7b9474b782e693fae2320a34a2985b18
 2022-09-14 18:06:05 -07:00
Winson Chung 9023848984 Merge "Update Launcher for removed shared wrappers" into tm-qpr-dev am: d2db9167a8 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915464

Change-Id: I4523beea62144a58ec03126f9a0bd4517d0f5f0f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-14 22:15:02 +00:00
Winson Chung d2db9167a8 Merge "Update Launcher for removed shared wrappers" into tm-qpr-dev 2022-09-14 22:03:05 +00:00
Schneider Victor-tulias b7fd614a42 Remove redundant start recents animation logs 
Fixes: 227514916
Test: completed several gestures and checked the logs
Change-Id: I75ef19efca92e0bc8e9f38f72c440f0c53857322
 2022-09-14 14:30:56 -07:00
Schneider Victor-tulias 75260282e5 Reuse log IDs when a GestureState is being reused 
Fixes: 227514916
Test: completed several gestures in rapid succession then checked the logs
Change-Id: Ieecde51fbf0398470f85bf54d71ccd4a765463e8
 2022-09-14 21:22:46 +00:00
Vinit Nayak 7fb4f997c4 Add metrics sources for split invocation 
* See design doc in bug description for
usage/details

Bug: 231369744
Change-Id: I0c0ec11e924e387c523b5ac5feb7cabf78eaa748
 2022-09-14 11:58:03 -07:00
Schneider Victor-tulias 86b01d948e Merge "Add onTaskAppeared error detection." into tm-qpr-dev am: 56c92899f1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19936975

Change-Id: I9a176f1a4a8cac5d1e70a55aaf7e118ec08c3946
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-14 18:09:00 +00:00
Schneider Victor-tulias 56c92899f1 Merge "Add onTaskAppeared error detection." into tm-qpr-dev 2022-09-14 17:39:27 +00:00
Winson Chung 3f649ef892 Update Launcher for removed shared wrappers 
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
Merged-In: I3f656b6c7fce93243ccb7591e52441e99137dec6
 2022-09-14 17:14:32 +00:00
Tony Huang 3fc57cb50a Fix split divider flash if swipe again quickly 
This bug caused by divider will be set to show when animation
cancelled, because split screen will show divider itself when
both split visible, this call might be unnecessary. Fix it by
removing these lines.

Add surface valid checking when running divider animation to
avoid crash caused if surface was released during animation.

Fix: 242823773
Bug: 246371786
Test: manual
Test: pass existing tests
Change-Id: I10aaf86e4164327b1c6c2f323c62b246c600228a
 2022-09-14 15:37:02 +08:00
Sunny Goyal bb2c85a3eb Using Transaction directly instead of building surface params am: fd2c9eb04e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19933596

Change-Id: I5441961aaae960333dbddd6585568412a88f52a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-14 04:28:16 +00:00
Schneider Victor-tulias 350ebd8f5c Update ActiveGestureLog to print logs from oldest to newest 
Fixes: 227514916
Test: completed several gestures and checked the logs
Change-Id: I8dca4a75c46f7324684a3ba297d1946105825fa6
 2022-09-13 15:33:55 -07:00
Schneider Victor-tulias 56fc942e48 Add onTaskAppeared error detection. 
Bug: 246340474
Test: used several gestures normally, and reproduced b/246340474, then checked logs
Change-Id: I8cdcb9c00c5cacc7737e796dbf5adf544c0220a7
 2022-09-13 15:31:06 -07:00
Sunny Goyal fd2c9eb04e Using Transaction directly instead of building surface params 
Bug: 221961069
Test: Presubmit
Change-Id: I31123dff78de513addd0c851403af9097686c46e
 2022-09-13 22:26:42 +00:00
Tracy Zhou de315c24d8 Merge "Fix subsequent tabbing in recents from alt tab not working" into tm-qpr-dev am: 39d9eb819c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19938037

Change-Id: I0947061c88148842e2a508fea76d611a1bc84f3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-13 21:28:14 +00:00
Tracy Zhou 39d9eb819c Merge "Fix subsequent tabbing in recents from alt tab not working" into tm-qpr-dev 2022-09-13 21:06:26 +00:00
TreeHugger Robot d675769721 Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev am: 839297e232 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19873684

Change-Id: I13328c033aec5653cf82529c4823e84df8c92592
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-13 20:25:50 +00:00
Vinit Nayak 2e39049bdf Update secondary task menu check to explicitly check for phone 
* Non grid check technically also returns
false for secondary app icon on focused task

Test: Open app menu in small and large screen

Bug: 245610772
Change-Id: Icf70c1893aba6a4a79bf51e98ac33c1d204c73c2
 2022-09-13 13:22:51 -07:00
TreeHugger Robot 9c43626a36 Merge "Change wallpaper depth in widget picker" into tm-qpr-dev am: 3ded296cee 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852193

Change-Id: I544623f2c67f846ac5e76bdb520750b5d4cdce2c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-13 20:15:13 +00:00
TreeHugger Robot 839297e232 Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev 2022-09-13 19:49:44 +00:00
TreeHugger Robot 3ded296cee Merge "Change wallpaper depth in widget picker" into tm-qpr-dev 2022-09-13 18:46:53 +00:00
TreeHugger Robot 93d74aa41a Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev am: 22af7c2e7e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19931705

Change-Id: I6d342c9d59e94dc61b393bd53e84e417ccc81782
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-13 18:20:02 +00:00
Tracy Zhou d0f4896c11 Fix subsequent tabbing in recents from alt tab not working 
Fix: 242114350
Test: Alt+tab to go to overview, and then keep tabbing to switch to the previous tasks

Change-Id: I03db23aa5424e46c0eb783379b0c5e959f75507f
 2022-09-13 11:01:57 -07:00