We were setting mGestureState = DEFAULT_STATE when touching outside
of the swipe region. Instead, we should only set mGestureState when
starting a new gesture, and only set it to DEFAULT_STATE on reset.
This also makes it clearer that mGestureState always refers to the
current gesture state, rather than sometimes being the current
gesture and sometimes being the previous gesture depending on
where it was used. Now previousGestureState is passed when needed.
Bug: 159494933
Change-Id: Ib62278b7c591ca4c6b99b26e058a34772e6cec2a
Feedback wasn't working, also Share wasn't showing its preview.
Bug: 159122067
Test: built and run locally
Change-Id: Iccea012a8fc0009a6a980f6233f42c4e7619f4ec
Sometimes other methods modify things like icon scale that setting
the fullscreen progress should override.
Test: open Calculator, open Clock, quick switch to Calculator and
ensure its task icon is not showing
Bug: 157105795
Change-Id: Iaed3e42f540fdff3648e9db7e6d7dc0b0d0a75df
- This was only used in RecentsView#resetTaskVisuals() anyway
- Previously resetVisualProperties() just called resetViewTransforms()
plus setFullscreenProgress(0) and setModalness(0)
- The latter 2, specificially setFullscreenProgress(0) led to problems
such as the bug below. Instead, we should reset to the current
mFullscreenProgress and mTaskModalness.
Bug: task view sometimes shifted up during quick switch
Steps:
- Do the quick switch gesture very quickly
- At the start of the gesture, we call getTasks(), which calls
applyLoadPlan() asynchronously
- applyLoadPlan() calls resetTaskVisuals(), so if this happened
after the gesture ended, we would setFullscreenProgress(0) on all
the task views, hence the upwards shift (if the gesture was still in
progress, it would reapply the real fullscreen progress)
Fixes: 157105795
Change-Id: Idb9d91ff89701d726838b47f955d4300f5ef13bd
- If a user has mostly predicted hotseat, show a snack bar. otherwise, show migration option.
- Guard onboarding activity with permission `com.google.android.apps.nexuslauncher.permission.HOTSEAT_EDU`
Bug: 158569583
Test: Manual
Change-Id: Id0c1c812233fcf288a2f49848720199dedd2015d
Also fixes bug where user continuously swipes to hint view causes count
to increase more than the max count which prevents all apps edu from showing.
Bug: 151768994
Change-Id: I3186398d441e723a2cfb6e396b03944502a65cf5
The first time a user long presses a predicted icon, suppress drag/drop and show a snackbar about app predictions.
Bug: 159170242
Test: Manual
Change-Id: I5f853a9774b38ad9fad22ff55feff417a801f52c
> Adding tests for TaskViewSimulator to ensure proper calculations
> Disabling orientation listener while user is interacting with quickstep
Bug: 158781568
Bug: 156891776
Change-Id: I299c3b1243ac0dbf28faee1b8566c77ea3954e33
Verified window is moving as expected using winscope.
Note: Position is off when launching non-center task.
Bug: 159171509
Change-Id: Ib11ed7df9a877348d76543279203f9bfc25f7829
When display orientation is not the same as device orientation, aiai won't work for select mode highlight. So we should only show the select button in task menu for in-place landscape when the display rotation is the same as the device rotation which is portrait.
Screenshot would be in the task menu for in-place landscape all the time.
Test: demo video: https://drive.google.com/file/d/1OQrjww2lFTTsthz4dB3BSa-jw943KLWp/view?usp=sharing
Change-Id: I58b6f6da234ea36eef0af5bb966c33ebda3625b8
When nav mode state changes, launcher gets
re-instantiated, which means the listener for
nav mode changes often gets destroyed before it
even gets fired. Rely on the initial setup to
set the correct nav mode.
The other bug with relying
on the initial value was that we were initially
getting the old nav mode when initFlags was called
from the ctor, but then the correct updated nav
mode when called from initListeners(). The first
call would enable rotation but then the second
call wasn't disabling it. Now we toggled based on
nav mode each time.
Another bug fix in RecentsView was not calling
update when launcher rotation is enabled. That was
added when previously we were using HOME_ROTATED
and PORTRAIT as different PagedViewHandlers to
differentiate when launcher rotation was enabled.
HOME_ROTATED is now removed, so we no longer need
to change the internal state of RecentsOrientedState.
Fixes: 159176222
Change-Id: I2a37880ce3cf835ca5b9b165ce3840537facee6c
If a view does not handle its long press and return true, View.java calls getParent().showContextMenuForChild(this). However, in Hybrid hotseat case, predicted icons are removed from the hotseat when user long presses an icon. This will result in getParent() returning null.
Bug: 159064799
Change-Id: I80d8f27cbc20b94b0381e767584a1f6854d17e2c
When it is select mode, disabling swiping on the parent container for a11y to avoid exiting select mode UI.
This will only disable swiping and talkback on other tasks and the cleanall button, but will keep the modal task container app info and content description, also keep the action buttons description working.
Test: local
Bug: 155947513
Change-Id: I6d513c7eb3e7deeaa233550749f8be0d95e56daf
Tony Wickham
Zak Cohen
Vadim Tryshev
TreeHugger Robot
Samuel Fufa
Jon Miranda
thiruram
Sunny Goyal
Hyunyoung Song
Andy Wickham
Sreyas
Becky Qiu
Vinit Nayak