Commit Graph

4587 Commits

Author SHA1 Message Date
Shamali P 472709d9ca Delete the filter code as it will be provided differently in refactor
With the dagger update the initialization happens in constructor which
we would avoid once we work on refactor and move it into a repository
class. The list will also be fetched from a different data source, so,
makes sense to delete it at the moment.

Bug: 406324964
Flag: EXEMPT BUGFIX
Test: Not applicable as code is removed
Change-Id: Iab8bb1e94677abf9b5b882f4d3485b002faf3e0f
2025-03-27 14:15:05 -07:00
Sunny Goyal 2201485e22 Merge "Using ItemInflator for inflating Folder instead of duplicating code" into main 2025-03-27 12:45:01 -07:00
Sunny Goyal 0479ff832c Using ItemInflator for inflating Folder instead of duplicating code
Bug: 406668365
Flag: EXEMPT refactor
Test: atest FolderTest
Change-Id: I63186ba620b5380edfc5e8cded253a85379a5d82
2025-03-27 09:48:46 -07:00
Sunny Goyal 3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Priyanka Advani (xWF) 35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Sunny Goyal cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Treehugger Robot 2032de9d20 Merge "Fix miscellaneous TAPL testing issue" into main 2025-03-25 15:24:28 -07:00
Schneider Victor-Tulias 58b82620df Fix miscellaneous TAPL testing issue
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
2025-03-25 12:58:29 -07:00
Sunny Goyal e8d901fbdb Deflaking ShortcutsChangedTaskTest by not using an active model
When using an active model, the data can change on the model thread while
the test is running on a different thread.
Instead using the model data directly without an active model running

Bug: 399155567
Flag: EXEMPT testfix
Test: Presubmit
Change-Id: I332cd7ec0f5a2fb4760ce080f016c725b2233c45
2025-03-25 12:12:20 -07:00
Treehugger Robot e0a018785e Merge "Add screenrecord for TaplUninstallRemoveTest#testUninstallFromAllApps" into main 2025-03-24 11:03:55 -07:00
Charlie Anderson ca9a920fa9 Make sure loading icons from db for archived apps only happens once after restore.
- This is to enable users to theme and shape archived apps

Bug: 402303619
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: performing restore and toggling themed icons on/off
Change-Id: I5883f703c3b0c8df5ee303ea4d99b0c02743faa4
2025-03-21 13:29:14 -07:00
Alex Chau df6dc455a7 Merge changes from topic "revert_task_content_view" into main
* changes:
  Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
  Revert "Remove redundant FrameLayout from task_header_view.xml"
2025-03-21 04:14:36 -07:00
Treehugger Robot d3e559a244 Merge "Add logging for which type of migration occurs." into main 2025-03-20 11:13:55 -07:00
Alex Chau 77ddc254cc Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
This reverts commit e0cc96df62.

Reason for revert: b/403826044, b/402277471

Flag: EXEMPT revert

Change-Id: I0c6e507753bf47be4f74b6056de75d981f0c2848
2025-03-20 04:45:52 -07:00
Federico Baron c7e8c4e8e7 Add logging for which type of migration occurs.
When upgrading from non one grid to one grid, we should do the row
shift migration type, here we are logging data to make sure that is what
happens on upgrade

Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Id09257094bc9bc44da757c73a4f63bf15987772c
2025-03-20 01:31:45 +00:00
Charlie Anderson 19c4a92ebc Avoid downgrading archived app icon when widget is restored and when apps are archived.
- Restored widget were requesting icons through iconcache, and overwriting the restored icon from restored db.
	- Manually archiving icons would delete icon in cache, we should instead reuse the icon from when it was installed.

Bug: 399649982
Test: Manually performing restore with apps, widgets and shortcuts.
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Change-Id: I4184af480f29eb3ef41173fe5edc5307f263d0b0
2025-03-19 21:28:37 -04:00
Federico Baron 896f1a66bf Add screenrecord for TaplUninstallRemoveTest#testUninstallFromAllApps
Flag: EXEMPT test only
Test: TaplUninstallRemoveTest#testUninstallFromAllApps
Bug: 386231522
Change-Id: Ic1f0f343153b2052438ea8ea6b9d84c429f844c1
2025-03-19 21:57:29 +00:00
Sebastián Franco 92330ddaf7 Merge "Removing ZipRule because it seems to break roboelectric tests" into main 2025-03-17 14:34:15 -07:00
Sebastian Franco a67e735606 Removing ZipRule because it seems to break roboelectric tests
Fix: 402136065
Test: DeviceProfileTest
Test: DeviceProfileDumpTest
Flag: TEST_ONLY
Change-Id: I7c3777ebd725e2acb2511aef3874b031a56bcf1a
2025-03-17 14:33:28 -07:00
Sunny Goyal 66916cda10 Moving LauncherAppWidgetHolder to dagger
This would allow customizing the widget holder in LauncherPreview

Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
2025-03-14 14:19:29 -07:00
Sunny Goyal 370eabf534 Merge "Making ModelDbController injectable" into main 2025-03-13 23:20:17 -07:00
Sunny Goyal 25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Sunny Goyal 1ac78b6ec6 Removing listeners from FolderInfo
Folder and FolderIcon are UI objects and can talk to each other directly.
FolderInfo changes are already propogated via model callbacks, and doesn't need a separate listener pattern.

Bug: 398791288
Flag: EXEMPT bugfix
Test: atest FolderTest

Change-Id: Iefd47b8ea12a8ecaf34211a3d908220a0e999187
2025-03-13 10:28:07 -07:00
Andy Wickham 250d85698c Merge "Adds all_apps_blur flag." into main 2025-03-12 11:25:50 -07:00
Thu-Huong Vu 09846676b5 Merge "Register SimpleBroadcastReceiver permission." into main 2025-03-12 10:36:22 -07:00
Andy Wickham ccb3a5c25c Adds all_apps_blur flag.
This enables blur both for Taskbar and Launcher, but in slightly
different ways.

For Taskbar All Apps, we apply blur to the overlay window, and
for Launcher All Apps, we utilize the existing DepthController to
blur the wallpaper window. For similicity, we currently fade out
workspace/hotseat to avoid awkward view + window blurs which
don't look that good. This is not the POR, but I think it achieves
most of the effect and will help us get some blur exposure.

Separately I will continue to investigate options such as blurring
workspace in a clever way so it feels blended with the wallpaper,
reusing the Taskbar window and connecting it to LauncherState, or
using a SurfaceView (though I spent quite some time trying this and
it seemed the same as the original issue).

In both cases, we use a 20-30% opacity scrim with a set color, and a
panel that blends 40% opacity of a dark/light color with 10% white.

Also updated some incorrect isTablet checks which really should have
been checking shouldShowAllAppsOnSheet(), which includes the
all_apps_sheet_for_handheld flag.

Demo: https://drive.google.com/file/d/1Ov9Dg3R9YHNfisfxNf97ZIhlDeEA1IWj/view?usp=sharing&resourcekey=0-l_SDpqpS4HtOb10a3b_jNg

Other upcoming improvements: interpolator tweaks, colors of things
inside the app panel (tabs, private space, search results, etc).

Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic7063cd822f39a5977715b5477f825bf11e57bdf
2025-03-11 23:34:03 +00:00
Treehugger Robot ace69f7644 Merge "Making various model objects injectable" into main 2025-03-11 14:48:30 -07:00
Thu-Huong Vu 48dd9eee1c Register SimpleBroadcastReceiver permission.
Update SimpleBroadcastReceiver API to pass in broadcast permission and
register Growth Broadcast Receiver with permission to prevent other apps
from triggering Growth Nudge on their behalf.

Flag: EXEMPT add separately
Test: Manual
Bug: 397739323
Change-Id: I3a9d5e131ced752af0a1b35d400eed6d170fc81e
2025-03-10 23:29:33 +00:00
Sunny Goyal 42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Treehugger Robot 313d7e1ce3 Merge "Revert "Add screenrecord for uninstallWorkspaceIcon"" into main 2025-03-10 13:36:11 -07:00
Charlie Anderson 24645d732c Merge "Make sure profile badging matches shape" into main 2025-03-10 12:54:31 -07:00
Federico Baron 8dcf879c14 Revert "Add screenrecord for uninstallWorkspaceIcon"
This reverts commit 66999f0a19.

Reason for revert: no longer an issue

Change-Id: I55a045846825e6b62fac4a9ed59380620870e953
2025-03-10 11:26:15 -07:00
Charlie Anderson 567097eee8 Make sure profile badging matches shape
Bug: 398875512
Test: testing different shapes on work profile
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I5cb9e629f711f2fc607ca646d82a8523c0b43d1b
2025-03-07 21:31:11 +00:00
Sebastian Franco aeb99f8d24 Moving zip rule to Multivalent to fix roboelectric test in A-studio
This fixes roboelectric test Running in Android Studio.

Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: Running roboelectric test in Android Studio
Change-Id: I903c6cea3c981a9c38cfcd05b54e4095b6fe2a8a
2025-03-07 11:56:45 -08:00
Federico Baron c3ac9c1c16 Fix attempt 2 for testDragToFolder
The reason the test fails is that since the tap targets are smaller, the
drag is too fast and the hover over icon to create folder time doesn't
elapse

Bug: 383917141
Test: TaplDragTest#testDragToFolder
Flag: TEST_ONLY
Change-Id: I3ba2b621f92f94dc52eb2b7ee6cd459ab9abb894
2025-03-06 15:34:13 -08:00
Sebastián Franco 2bab5687b0 Merge "Enabling Fixed Landscape in Launcher3 tests" into main 2025-03-06 15:06:03 -08:00
Treehugger Robot 3a000d06fa Merge "Revert "Ignore the tests temporarily."" into main 2025-03-06 13:09:43 -08:00
Federico Baron 7610b9c17f Revert "Ignore the tests temporarily."
This reverts commit de0d4498c8.

Reason for revert: b/353505773 seems to have rolled out 

Change-Id: I3ddcdb1b2de2cfd07e12af284f1f784996f82623
2025-03-06 10:58:12 -08:00
Treehugger Robot 872ef49247 Merge "Add TaskContentView parent to TaskThumbnailViewHeader and TTV" into main 2025-03-06 03:37:25 -08:00
Sebastián Franco c55194343a Merge "Add all the dumpt test results into a zip in artifacts" into main 2025-03-05 16:08:57 -08:00
Sunny Goyal 84e0e6a188 Making ActivityContext extend SavedStateRegistryOwner
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor

Change-Id: I8272e95a8d2da95b3c93ec616fdf877b89db5b26
2025-03-05 09:22:47 -08:00
Treehugger Robot 57cab7794a Merge "Simplifying some view iteration methods" into main 2025-03-04 18:42:06 -08:00
Sebastian Franco c9f6668ab1 Add all the dumpt test results into a zip in artifacts
Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: dump files should now be available in test artifacts
Change-Id: Ic77b75f7792bc511e364a6af697eb1282ad49ab3
2025-03-04 13:16:47 -08:00
Sebastian Franco 331fd2dac6 Enabling Fixed Landscape in Launcher3 tests
Bug: 398279312
Test: Any test using PortraitLandscapeRunner
Test: IntegrationFixedLandscape
Flag: com.android.launcher3.one_grid_specs
Change-Id: I5a1801374f39381e678e764f8e417cf0f8bf6ad7
2025-03-04 13:15:26 -08:00
Sunny Goyal 476d926972 Simplifying some view iteration methods
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ieffa3a66fbf8595d542995c348df578a3aec9083
2025-03-04 10:39:55 -08:00
Sunny Goyal 372c483eda Merge "Moving widgetFilter to dagger" into main 2025-03-04 09:03:10 -08:00
Treehugger Robot f42f516621 Merge "Remove unused spec in device_profiles.xml" into main 2025-03-03 17:24:20 -08:00
Treehugger Robot 19e93afd91 Merge "Test all apps -> workspace drag for taskbar on home" into main 2025-03-03 11:59:21 -08:00
David Saff e7c9940df4 Merge "Rename to uiautomatorhelpers" into main 2025-03-03 10:48:03 -08:00
Federico Baron d8f0bed596 Remove unused spec in device_profiles.xml
Bug: 395912263
Flag: com.android.launcher3.one_grid_specs
Test: n/a, code cleanup
Change-Id: Ifd1ecf905427902f895a1b4e16711874fd52ddf3
2025-03-03 18:35:10 +00:00