Commit Graph

17397 Commits

Author SHA1 Message Date
Thales Lima 5fc47806f8 Merge "Make numFolderRows/numFolderColumns accept more values" into main 2023-11-28 11:22:27 +00:00
Sebastián Franco 463131427d Merge "Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout" into main 2023-11-28 00:27:21 +00:00
Sebastian Franco 6c7d817bc7 Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout
The new test generate hundreds of new boards using a fixed seed so the
test cases can be recreated if there is an error.

Some of the new clases where inside of CellLayoutBoard and moved
outside.

Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Test: ReorderAlgorithmUnitTest
Change-Id: I083fb6701b02b7c0b2cf24634ca71acb0c75902e
2023-11-27 17:12:43 -06:00
Sunny Goyal eb29313595 Updating WidgetSheets so that it can be displayed in any
activity and not just Launcher

Bug: 307306823
Test: atest Launcher3Tests
Flag: NA
Change-Id: I0e33323805c6e895e3a1639ecf5933e698212c65
2023-11-27 11:17:04 -08:00
Pat Manning 37cf983825 Merge "Wait for IME to hide in test only if software keyboard." into main 2023-11-27 18:32:23 +00:00
Pat Manning b8145edf05 Wait for IME to hide in test only if software keyboard.
Fix: 311410127
Test: TaplKeyboardFocusTest#testAllAppsExitSearchAndFocusSearchResults
Flag: NONE.
Change-Id: I74f1023bdf9118abaa9cda651b881ef60636da34
2023-11-27 13:53:03 +00:00
Thales Lima 24051842c7 Make numFolderRows/numFolderColumns accept more values
Now they can hold values for different configurations, making it akin to iconSize.

Bug: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I9d5cccda88a0311dbe0beecef194cc8d60c5c280
2023-11-24 15:54:56 +00:00
Jordan Silva 0bb6034f74 Merge "Extract cell size information to responsive grid structure" into main 2023-11-24 14:36:39 +00:00
Alex Chau c95a4e6b1d Merge "Revert "Remove logs for bug investigation"" into main 2023-11-24 14:02:39 +00:00
Jordan Silva 999dd2a06f Extract cell size information to responsive grid structure
Bug: 287975993
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: ResponsiveCellSpecsProviderTest
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Change-Id: I26a87d9b690fdfcff1599d862c09e97fe9f9f930
2023-11-24 12:39:36 +00:00
Pat Manning 78a2dd66b2 Merge "Close allapps on press of ESC key." into main 2023-11-24 12:30:04 +00:00
Jordan Silva 2e1b287038 Merge "Use DeviceProfile numFolderRows and numFolderColumns" into main 2023-11-24 12:29:19 +00:00
Pat Manning a7a04fe901 Close allapps on press of ESC key.
Fix: 310206847
Test: TaplOpenCloseAllApps
Flag: NONE
Change-Id: I9b9f958eb2889680b731dd7134fce2793e62eb74
2023-11-24 11:03:13 +00:00
Avinash Vadlamudi d1047f5415 Merge "Add necessary metric collections for barcode detection in Overview." into main 2023-11-24 01:31:07 +00:00
Sebastián Franco 525b0343f8 Merge "Moving classes inside of CellLayout to their own file" into main 2023-11-24 01:27:13 +00:00
Sebastian Franco 5f0af4f633 Moving classes inside of CellLayout to their own file
This is a no-op change ensure this we have ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I6ffe2a1260f869a4686a9f1e652dd1ab6d406269
2023-11-23 23:13:56 +00:00
Alex Chau 58a8c12713 Revert "Remove logs for bug investigation"
This reverts commit dad61a0098.

Reason for revert: b/279059025

Change-Id: Id8fcd1ddf67d7df0a23c81e3ddf3849c26c529bd
2023-11-23 19:01:16 +00:00
Avinash Vadlamudi cd02807544 Add necessary metric collections for barcode detection in Overview.
- Log required metric events for the barcode content interactions.

Flag: ACONFIG com.google.android.apps.miphone.aiai.matchmaker.overview.ui.enable_barcode_detection_in_overview DEVELOPMENT
Bug: 310757242
Test: Built and tested on Pixel device.
Change-Id: Iff4e4a3aec35d9d096f5b52eab0124f6e7f22e15
2023-11-23 12:26:41 +00:00
Pechetty Sravani d6233c18a0 Merge "Revert "Update status bar scrim"" into main 2023-11-23 10:38:42 +00:00
Pechetty Sravani e620fc80c9 Revert "Update status bar scrim"
Revert submission 25440774-scrim_update

Reason for revert: <Test Revert (b/312861259)>

Reverted changes: /q/submissionid:25440774-scrim_update

Change-Id: Ifdae7cc1754994ef16585859a9b0f08b2d257715
2023-11-23 08:50:59 +00:00
Federico Baron 2b352f6c5f Merge "Update status bar scrim" into main 2023-11-22 19:01:44 +00:00
Vinit Nayak 2bccda4d2d Merge "Add logs for workspace long press" into main 2023-11-22 02:09:55 +00:00
Vinit Nayak 74fb544c27 Add logs for workspace long press
Bug: 311099513
Change-Id: Ided5f317ab3c8bb68a099391f39f0e579b17c2c2
2023-11-21 15:44:44 -08:00
Holly Jiuyu Sun 35e68fb800 Merge "[a11y] Fix Switch Access keyboard input issue in AA+." into main 2023-11-21 22:52:15 +00:00
fbaron e181d221e1 Update status bar scrim
Bug: 311717313
Test: Verified on device
Flag: NONE
Change-Id: I4f4d2c7ced1625f1c58b9e06274d9e3d6250ad63
2023-11-21 09:51:31 -08:00
Andreas Agvard 9ed6d0be04 Merge "Fixed incorrect naming of flags" into main 2023-11-21 12:26:17 +00:00
Thales Lima 07c6b8d96d Use DeviceProfile numFolderRows and numFolderColumns
Invariant hold values that are not related to current DP in use. This is a change needed for IDP to hold more values in the future akin to iconSize.

Bug: 309800141
Change-Id: Iefb388a5f6590d7da3452d2c388c02bd5e9d32bb
Flag: N/A
Test: NexusLauncherTests
2023-11-21 11:47:21 +00:00
Pat Manning 54acb41e8c Merge "Do not hide persistent taskbar during input for physical keyboard." into main 2023-11-20 23:29:55 +00:00
Himanshu Gupta 23876959e5 Merge "Fixing Launcher crases due to methods being called on Ui Threads." into main 2023-11-20 23:02:46 +00:00
Himanshu Gupta 2b5620b295 Fixing Launcher crases due to methods being called on Ui Threads.
This CL fixes the following two issues:
1. Launcher crashing while calling `addPrivateSpaceSettingsButton` from
   BaseAllAppsAdapter as the thread is UI
2. Decorator is not removed from Private Space Header during reset to
   paused state. https://screenshot.googleplex.com/BZdLqaZQwdDApfV

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 311337961, 311342946
Test: Ran Launcher3 tests
Change-Id: I2763338ebf0f5468ad38f61a781e8a8334194c5c
2023-11-20 18:59:13 +00:00
Andreas Agvard 37eac5b585 Merge "Adds a debug & server configurable delay to search haptic hint" into main 2023-11-20 18:04:10 +00:00
Jordan Silva 36fda11792 Merge "Fix folder label text size not downsizing to match app icon" into main 2023-11-20 17:00:55 +00:00
Andreas Agvard fc74c095d6 Adds a debug & server configurable delay to search haptic hint
Fix: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED

Change-Id: Ic050e8426ef91b28e6bf1dc4d86839eaa20b0dc0
2023-11-20 12:49:54 +01:00
Pat Manning a401e15553 Do not hide persistent taskbar during input for physical keyboard.
Fix: 255818649
Test: TaplTestsQuickstep
Flag: NONE.
Change-Id: Id5495163f43464125bfcbd9e255f18e24183d67a
2023-11-20 10:45:05 +00:00
Fengjiang Li f05c0f5843 Merge "Only log COLD_DEVICE_REBOOTING startup latency logs" into main 2023-11-18 16:36:35 +00:00
Sebastián Franco 5f14285de1 Merge "Moving bindSmartspaceWidget to ModelCallbacks" into main 2023-11-17 22:50:07 +00:00
Fengjiang Li e5f91a4c7a Only log COLD_DEVICE_REBOOTING startup latency logs
Fix: 305391017
Test: Unit test
Flag: NA
Change-Id: I976add25ea14d49e2ea84e395985edb9f559370c
2023-11-17 14:00:51 -08:00
Holly Jiuyu Sun 1459fd831c Merge "[ps] Add helper function to scroll a recycler view to bottom and resetAndScrollToPrivateSpace." into main 2023-11-17 21:33:46 +00:00
Sebastián Franco dacb076588 Merge "Make sure ReorderAlgorithm only work on the logic layer and not on the view layer" into main 2023-11-17 19:20:18 +00:00
Sunny Goyal f7e7843a2b Merge "Removing unused title change logic in settings" into main 2023-11-17 18:18:08 +00:00
Sebastian Franco 6336f9bca3 Make sure ReorderAlgorithm only work on the logic layer and not on the view layer
The method isNearestDropLocationOccupied finds the NearestDrop location
using the view models (i.e. the CellLayoutLayoutParams) and the new
method isConfigurationRegionOccupied run over the logic models (i.e. the
CellAndSpan or ItemConfiguration) ensuring a separation between them.

Test: ReorderAlgorithmUnitTest
Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Change-Id: I0b3c6606ee6934ea3a5e41d110677c496d4a4330
2023-11-17 17:02:39 +00:00
Pat Manning d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Andreas Agvard ef8df12ff8 Merge "Makes deep press for LPNH toggelable" into main 2023-11-17 07:51:16 +00:00
Sebastian Franco 50b74c341a Moving bindSmartspaceWidget to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I960cb767e3c4db4a952e019ee489ec1611e2dbd2
2023-11-16 17:18:06 -06:00
Sunny Goyal 2e005e1e28 Removing unused title change logic in settings
Bug: 305084752
Test: Manual
Flag: N/A
Change-Id: I93e8a58c579223d5892528a47cff5bcafd69dbf1
2023-11-16 12:54:19 -08:00
Jordan Silva 9a3bd8f109 Fix folder label text size not downsizing to match app icon
Fix: 311350985
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: ResponsiveFolderImageTest
Change-Id: I98103749541dd1e120908ac06e24dfc38cc7aa59
2023-11-16 18:34:35 +00:00
Pat Manning 43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Sebastián Franco 9739ad2ec8 Merge "Modify getViewsIntersectingRegion to returns rects instead of view since we don't use the views after only the rects." into main 2023-11-16 17:48:02 +00:00
Andreas Agvard 0fc7d52863 Makes deep press for LPNH toggelable
By default when deep press is detected (https://developer.android.com/reference/android/view/MotionEvent#CLASSIFICATION_DEEP_PRESS)
during LPNH triggers the long press action immediately. This change makes this toggelable.

Flag is set to enabled by default, which leads to the default behavior.

Fix: 310952290
Test: Manual
Flag: LEGACY ENABLE_LPNH_DEEP_PRESS ENABLED
Change-Id: I970fed697979ee528e54b8be0139d842f3a64c43
2023-11-16 17:55:34 +01:00
Sebastian Franco 5c8f86815c Modify getViewsIntersectingRegion to returns rects instead of view since we don't use the views after only the rects.
Intermidiate step for b/270395274

Bug: 270395275
Flag: NA
Test: ReorderAlgorithmUnitTest
Test: atest ReorderWidgets
Change-Id: I505372ccd61e954de19852427abe0b54fc06aa57
2023-11-16 10:32:51 -06:00