The recycler view when displayed in single pane picker, for large screen
gets a larger padding. But when displayed in two pane picker, it is not
needed - so we override it.
Foldable's unfolded portrait doesn't seem to have screenshot test
- will look into if we can add one in follow up.
Bug: 322719955
Test: Screenshot test for existing modes & manual (see bug)
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: Ibd72146e7e5230eec0d2ce01c3917819a73d8f32
This Cl restricts item dragging for PS apps from
all launcher surfaces such as AllApps, AppPredictionRow, etc.
Video: https://photos.app.goo.gl/PKGw8n23hJVJMyUk7
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I2c5dbaa325095ec63aedf39b6b2c269f745d58ca
This CL extracts RecentsView methods from PagedOrientationHandler to RecentsPagedOrientationHandler. It will allow to have quickstep specific components in the newer interface, like IconAppChipView.
Bug: 320633351
Flag: N/A
Test: atest NexusLauncherTests
Test: atest TaplTestsSplitscreen
Test: atest TaplTestsQuickstep
Change-Id: Ie7de23bddccbdb8eac93eff66a5d929f5bf0ee3a
1) App pair member icons are now always redrawn when app pair icon is redrawn, allowing greyed out icons to be updated immediately when an app is disabled.
2) App pairs now check for disabled status when clicked. If one or both of the apps is disabled, app pair will not be launched, and the appropriate error message or affordance will be displayed.
Fixes: 323088270
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I7f2af75db0d8579d5d04583c0d3ead32714768e4
* In case app icon is added to workspace after unarchival completes for archived app, it shows a completely filled progress bar around the icon.
* This behaviour exists because the 'FLAG_ARCHIVED' flag is copied from `AppInfo` item.
* This cl updates the 'FLAG_ARCHIVED' flag for 'AllApps' item once unarchival completes.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I739225707a11bc9a6aa23e81775b4e036ce81a7e
This causes app pairs to log an error message if creation or icon inflation is attempted with contents != 2. App pairs with wrong numbers of members should not be created anymore.
Fixes: 317283244
Fixes: 322892793
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I5e454042719bb67187f900c546380bb44cfc34ac
* changes:
Add a default widget category provider that uses application category.
Add a feature flag for displaying categorized widget recommendations.
The category provider can be customized by any launcher via resource
override. For instance, one can override it to provide custom categories
using an allowlist or use a different mechanism such as query play
services.
We still need to get proper strings for categories from UX writer.
Bug: 318410881
Test: WidgetRecommendationCategoryProviderTest
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I5c4e0d22eaffc8254ddd54356f8c62f00e22a3c4
There are some more files relevant to picker, but this CL covers
directory with the primary picker UI.
Change-Id: I53e174d9cd20396b4f56acb5d9e3cc07ec475ea8
This just sets an OP_CODE (cheap operation). It disables a help-dialog
for launchers who have not implemented archiving.
Test: PackageInstallerArchiveTest and also manually
Bug: 302114748
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Ifa9335d7ad250218eec3863dcdd986118bba007c
which will eventually allow us to inflate icons on the background thread
Bug: 318539160
Test: Presubmit
Flag: None
Change-Id: I61e4981c1c3201e92102153d9558a0885637da3a
Previously, if insets had been applied while folded ("phone"),
they would stick around when unfolding ("tablet").
This applies the intended 0 left/right margins when in "tablet"
mode regardless of the insets.
Fix: 321159393
Test: Open all apps in phone landscape, unfold
Flag: NA
Change-Id: Ida1f20711a2a2b9b54f6b2c18abf5abf4fd2b175
This cl fixes following things
- When featureFlag is present, always read the value from FeatureFlag.get() instead of preferences.
- Add new function getIntFlagBackedUpByLauncherPrefs to read from sharedPreferences
- Make FlagTogglerPrefUi.java updateMenu() public
- When intFlag is modified in Developer Options, Apply button will show up. So launcher can restart and values get applied.
- Omnient Int flags will read from Featureflag.get() instead of shared preferences directly.
Bug: 320696242
Test: Manual
Flag: NA. Developer Options related
Change-Id: Id916b25d0397505d240ea8444d896c8ace826e57
- also slightly improve some log messages and simplify some code
Test: presubmit / unit tests
Flag: None
Bug: 294386159
Change-Id: I6f75c0d34bf475d4e20d6250f67a56d5394b9c4e
This will make it easier to test CellLayout, also we should avoid
circular dependencies as much as poisble.
This also allows the CellLayout to be created in other containers
that are not workspace.
Bug: 318417510
Test: creating HotseatReorderUnitTest in follow up cl
Test: TaplReorderWidgets
Test: ReorderAlgorithmUnitTest
Flag: NA
Change-Id: Ic45029a244cb11f8d6775c50b90af9c56f01eaa3
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.
Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
This handles cases that were previously ignored, such as dismissing
the IME with the back key/gesture.
Removed extraneous manual state updates that were used for specific
cases previously. The only remaining state updates are from our
controlled IME animation in KeyboardInsetsHandler, as that correctly
handles the case where you start closing the IME but end up keeping
it open (or vice versa).
Bug: 277738379
Fix: 320659754
Test: Manually go through various IME transitions on Launcher,
open and close apps, lock/unlock, etc to verify keyboard state
is correctly updated. And verify b/320659754 steps do not repro.
Flag: NA
Change-Id: I4787afbb37eed815b909a0215d8afeb3894ab985
The animation ReorderPreviewAnimation handles two animations, one when
the mode is MODE_HINT and the other MODE_PREVIEW. The animation is
basically the same but MODE_PREVIEW ocilates to finalDelta and back
to initDelta. MODE_HINT stays in finalDelta. When finish, we have to
go back to the initial position.
This behaviour is currently done using logic, making sure the view stays
in finalDelta no matter the value of the animation, the bug is in this
logic. I think is better to do this with the current animation API by
setting setRepeatCount to 0 on the HINT case and reverting the animation
when finish so it goes back to the initial position.
This seems to have been there for a long time, at least since the
creating of git_main, but it became more aparent now. In a follow up cl
I will move this class to it's own file and into kotlin to help if there
are issues here again.
Fix: 294473336
Test: manual testing
Flag: NA
Change-Id: I4ac5de3ce8a8170944a072c6ce41c65d0963a780
Shamali P
Himanshu Gupta
Andy Wickham
Jeremy Sim
Jordan Silva
Rohit Goyal
Anushree Ganjam
Jakob Schneider
Sunny Goyal
Sebastián Franco
Charlie Anderson
Helen Cheuk
Brandon Dayauon
Vinit Nayak
Holly Jiuyu Sun