Commit Graph

3916 Commits

Author SHA1 Message Date
TreeHugger Robot 21ff5c4ff0 Merge "Persist prediction cache on every update" into ub-launcher3-rvc-dev am: 1cc0010eba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12077679

Change-Id: I5f2cbe314dfb249594a2dff70cda5188cad60fa1
2020-07-17 19:19:40 +00:00
Sunny Goyal 12f46d521a Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
(cherry picked from commit 141c231d2f)
2020-07-17 18:53:01 +00:00
TreeHugger Robot 4b1d1a0f18 Merge "Prevent showing TaskMenuView if icon isn't present" into ub-launcher3-rvc-qpr-dev 2020-07-17 00:04:41 +00:00
Tony Wickham 94be66acd6 Fix tracking window being slightly off when swiping from an app
Test: swipe up from an app in landscape, seascape, and portrait,
and verify the window tracks with the finger 1:1 until pullback

Bug: 149934536
Change-Id: Ia469877e7152c8135e0b9153f69c191ba86cbd14
(cherry picked from commit f0a1b2ccd8)
2020-07-16 20:03:36 +00:00
TreeHugger Robot eb2eb38cc2 Merge "Move rotation logic to RotationTouchHelper" into ub-launcher3-rvc-qpr-dev 2020-07-16 05:14:25 +00:00
Vinit Nayak 0affd89031 Move rotation logic to RotationTouchHelper
No functional changes.

Fixes: 159764370
Change-Id: Ie7739a62242377bda69c86bd46e24d2f847f17e0
2020-07-15 22:03:14 -07:00
Sreyas Rangaraju e1037c63dd Merge "Disabling overview actions when thumbnail is not loaded." into ub-launcher3-rvc-qpr-dev 2020-07-15 23:31:51 +00:00
Sreyas 0d2eea3316 Reset disabled flags when action buttons lose visibility.
Bug: 159993889
Change-Id: Id2a38eee5de067d5e8f1df425644dfdcb3334cdb
2020-07-15 16:16:43 -07:00
Sreyas 68330a93fa Disabling overview actions when thumbnail is not loaded.
Bug: 160331177
Change-Id: I05eaec7d6f2e3f2ba71d8148a4e97dcf5a1522c6
2020-07-15 19:46:09 +00:00
Sunny Goyal ec78aef4fc Merge "Fixing swiping up on home interrupting animation" into ub-launcher3-rvc-qpr-dev 2020-07-14 16:01:43 +00:00
Sunny Goyal 93188d61da Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
2020-07-13 17:44:56 -07:00
TreeHugger Robot add69c70c4 Merge "Fix velocity in StaggeredWorkspaceAnimation." into ub-launcher3-rvc-qpr-dev 2020-07-13 22:20:33 +00:00
TreeHugger Robot 054280dba4 Merge "Using original taskInfo to create the taskKey instead of fake data" into ub-launcher3-rvc-qpr-dev 2020-07-13 22:06:13 +00:00
Jon Miranda aee792403d Fix velocity in StaggeredWorkspaceAnimation.
* Velocity should match the direction of the spring values.
  (Swipe direction is upwards, but icons move downwards on screen).
* Remove additional conversion to pxPerS since getDimension already does that.

Bug: 160003774
Change-Id: I12912edb2354c4a30c538da6ca3789c46d82b94d
(cherry picked from commit 54003963d8)
2020-07-13 21:48:19 +00:00
Sunny Goyal 55a9b544c9 Using original taskInfo to create the taskKey instead of fake data
Change-Id: Ie4e35b35484e0f6cb939febe6357b37381d81682
(cherry picked from commit fabfb3ae90)
2020-07-13 21:47:16 +00:00
Pinyao Ting 9d51e49cec Fixes the issue Launcher state propagation is slower than onDeferredResume.
There's currently a bug prevents Launcher release drag lock for two step
widgets. Supposedly, onDeferredResume should release the drag lock; However,
in 3-button navigation mode, the transition from Overview -> Normal is
triggered in Launcher#onNewIntent, which happens after onDeferredResume.

This issue is not reproducible with gesture navigation because its
transition from Overview -> Normal is handled in NavBarToHomeTouchController

Test: manual verified with following steps
1. Enable 3-button navigation
2. Long press in WorkSpace -> Widgets
3. Drag Settings Widget to WorkSpace
4. When the config activity is shown, press "recents" button to see Overview
5. press "home" button to go back to workspace
6. repeat 2 and 3, verify the widget can be dragged
Bug: 149659788

Change-Id: I396ffa8a7db44bf3872a10de4208340a99a7efe8
(cherry picked from commit 3bf889a02f)
2020-07-13 21:46:05 +00:00
TreeHugger Robot 5491b2e2e0 Merge "Fix shelf tracking distance for landscape app over portrait launcher" into ub-launcher3-rvc-qpr-dev 2020-07-13 20:44:30 +00:00
Tony Wickham 032db3289a Merge "Wait until activity present before calling onEndTargetCalculated()" into ub-launcher3-rvc-qpr-dev 2020-07-13 20:37:15 +00:00
Tony Wickham 452db0db0c Fix shelf tracking distance for landscape app over portrait launcher
Bug: 149934536
Change-Id: I14fa62fa9f51356613f4a3827446b00af774dbf5
2020-07-13 13:21:02 -07:00
Tony Wickham ddbaadb562 Wait until activity present before calling onEndTargetCalculated()
At least one code path relies on the activity to be created: if the
end target is RECENTS, we add a state manager listener to see when
user goes to NORMAL state.

Fixes: 160903658
Change-Id: I3449dec773399f7e9cf2e7ef8b79734b1baa59b4
2020-07-13 12:32:37 -07:00
Bill Yi 2ef5f38ae5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7f36648a52740ae4e104c8bd2f0321f541ee218f
2020-07-10 14:54:57 -07:00
Vinit Nayak 2060a4b9e1 Prevent showing TaskMenuView if icon isn't present
Also fixed another bug where the wrong layout
orientation was being applied when overview rotated
when launcher was in fixed portrait orientation.

Fixes: 160182914
Test: Tested w/ PIP, split screen,
w/o split screen w/ and w/o home rotation

Change-Id: Iccffb637ae5c22d07745f2108facd4de716dc8d3
2020-07-10 11:55:06 -07:00
TreeHugger Robot c3c15cc946 Merge "Updating some comments and variables" into ub-launcher3-rvc-qpr-dev 2020-07-10 00:50:36 +00:00
TreeHugger Robot 95c620c38d Merge "Let AllAppsEduView consume touch until animation is done and view is removed." into ub-launcher3-rvc-qpr-dev 2020-07-09 21:45:18 +00:00
TreeHugger Robot 24ddf21cea Merge "Updating gesture tutorial home animation" into ub-launcher3-rvc-qpr-dev 2020-07-09 21:44:51 +00:00
Jon Miranda 58d74c3dd9 Let AllAppsEduView consume touch until animation is done and view is removed.
Bug: 160760115
Bug: 160761752
Change-Id: Ie7ab0b4c6e61dc862cac10fa961b8d1c11c6cb10
2020-07-09 14:11:53 -07:00
Sunny Goyal 29266c9ebe Updating some comments and variables
Change-Id: Ib3223c66e9ce187cebc6ce26a46b228f95787778
2020-07-09 12:31:49 -07:00
TreeHugger Robot 6381d38249 Merge "Adding nullcheck while launching task during quickswitch" into ub-launcher3-rvc-qpr-dev 2020-07-09 18:19:54 +00:00
Sunny Goyal 798b5f481d Adding nullcheck while launching task during quickswitch
Bug: 159758771
Change-Id: I04dd1432a1acc49cbc776c89e95cfb1ee6e88061
2020-07-09 11:05:28 -07:00
Bill Yi 6d76207e37 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I3d133ff2ba4e7c0cf1de39cacfdcbe13a9c2a366
2020-07-09 09:31:47 -07:00
Sunny Goyal 6fd105b69a Updating gesture tutorial home animation
> Using a separate View as icon, instead of the taskView
> Updating swipe animation logic to abstract out FloatingIconView dependency

Change-Id: Ib466262afead11ebe4ca035d589f0382c37e3e97
2020-07-09 07:51:34 -07:00
Jon Miranda b59776cd01 Fix all apps edu in landscape.
* Fix bug where All Apps not visible during hint animation.
* Fix bug where All Apps is empty after hint animation.

Bug: 160122854
Change-Id: Id4106a6200df2845b3c041d5aae14fb83c94b4d4
(cherry picked from commit 84b848ad5d)
2020-07-09 00:02:54 +00:00
TreeHugger Robot 1cc0010eba Merge "Persist prediction cache on every update" into ub-launcher3-rvc-dev 2020-07-08 05:03:03 +00:00
Sunny Goyal 141c231d2f Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
2020-07-07 19:50:34 +00:00
Sunny Goyal 451b09ea75 Persist prediction cache on every update
Test: Manual
Bug: 160058750
Change-Id: Icb0b7322b7f9754d3f1c3012e1c98a760f83c787
2020-07-06 11:12:53 -07:00
thiruram 53925ff9c6 Fixes NPE with system shortcuts.
Bug: 160109140
Change-Id: I35c00fc1792fcf11fc61e1876f9184bd5fb309ce
2020-06-29 12:04:32 -07:00
Zak Cohen a3629bd52c Thumbnail Cache - check canceled status on the right thread.
The cache was checking the canceled status on the background
thread, but the cancel call was being made on the main thread.
This was leading to canceled requests still delivering this thumbnail
in some cases.

Bug: 159840851
Test: local build and non-repo of bug
Change-Id: I9a3556f6570eee1db39ebec202c115d58010d7f8
2020-06-28 21:10:07 -07:00
TreeHugger Robot f59922d0d7 Merge "Add NPE check for prediction controller" into ub-launcher3-rvc-dev 2020-06-26 07:42:38 +00:00
Samuel Fufa 514df92bcf Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 13:08:55 -07:00
Tony Wickham 9d69370095 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into ub-launcher3-rvc-dev 2020-06-25 02:10:54 +00:00
Andy Wickham fce6be550b Merge "Updates Assistant gesture regions when no longer tracking multiple." into ub-launcher3-rvc-dev 2020-06-24 22:29:45 +00:00
Andy Wickham 4b531b972d Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
2020-06-24 21:23:35 +00:00
Tony Wickham c6a56ef7a2 Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
2020-06-24 11:59:10 -07:00
Sreyas 2bbce930cb Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:10:29 +00:00
TreeHugger Robot 9f3ae7b573 Merge "Remove hotseat edu flag" into ub-launcher3-rvc-dev 2020-06-24 03:23:54 +00:00
TreeHugger Robot f95cf17a13 Merge "Fixing TaskMenu positioning." into ub-launcher3-rvc-dev 2020-06-24 00:03:27 +00:00
Sreyas 7776d30609 Fixing TaskMenu positioning.
Bug: 159728554
Change-Id: I4a666363f092b5416edecd0731a0f448916c8def
2020-06-23 16:17:11 -07:00
TreeHugger Robot 359a28e934 Merge "Prevent premature resetting of quickswitch mode" into ub-launcher3-rvc-dev 2020-06-23 22:42:48 +00:00
Vinit Nayak f2daafcdf8 Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
2020-06-23 15:07:22 -07:00
Samuel Fufa 3c2a17b6f6 Remove hotseat edu flag
Launcher should not restrict user migration to a one time event if we want users to migrate their hotseat by enabling hotseat prediction from suggestion settings.

Test: Manual
Bug: 159731272
Change-Id: I0e42dd6b6cf6374928e5b399d121d17fe8024ae1
2020-06-23 12:53:37 -07:00