Commit Graph

9763 Commits

Author SHA1 Message Date
Schneider Victor-tulias 38a6d462a2 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev am: ae2e5d9231
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15099479

Change-Id: Icb5e7cdca02fab3c6c165ab3c612ee943d97d947
2021-07-13 23:41:14 +00:00
Schneider Victor-tulias ae2e5d9231 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev 2021-07-13 23:27:45 +00:00
TreeHugger Robot a4821a0bb8 Merge "Fix hole in recycler view" into sc-dev am: 3d6d2e38b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15270060

Change-Id: I7bf9cd8b3ed98c086b0496ce84f5f41d312d68dc
2021-07-13 19:16:02 +00:00
TreeHugger Robot 3d6d2e38b0 Merge "Fix hole in recycler view" into sc-dev 2021-07-13 19:05:22 +00:00
Hyunyoung Song b6acd14d0f Fix hole in recycler view
Bug: 153780395
Test: manual

Without this change, typing single character and then
backspace, and then scrolling down and up will result in
hole in recycler view.

Change-Id: Iff6fa3f147d8bfdb8a7e84847b96e5390941dd4e
2021-07-13 09:51:42 -07:00
Steven Ng 16c9ebabbf Merge "Fix shortcut size calcuation" into sc-dev am: 372e85106d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15259646

Change-Id: I5b37dc1971d67afbc3923774db2256459e389ae6
2021-07-13 14:10:25 +00:00
Steven Ng 372e85106d Merge "Fix shortcut size calcuation" into sc-dev 2021-07-13 13:59:41 +00:00
Steven Ng 6fe115b2ae Fix shortcut size calcuation
Shortcut size should be the size of all apps icon + padding

Test: Check shortcuts and widgets are shown without crash in the
      following surfaces with display & font set to largest and
      display cutout enabled. Repeat the same test with normal
      display setting and no cutout.
      1. Full widgets picker
      2. Bottom widgets picker
      3. Pin widget dialog
Fix: 193422438
Change-Id: Ibfebf94e92eed5e9cd1dd4196d98823b0e4dda6b
2021-07-13 12:46:31 +01:00
TreeHugger Robot fc98f27759 Merge "Add accessibility announcement when user clicks on 'Add automatically to home screen' button" into sc-dev am: 972ab9327c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15242979

Change-Id: Ie8a852ed4ac0d2856a1afc2a33aca3b6905dc9da
2021-07-13 05:20:29 +00:00
TreeHugger Robot 972ab9327c Merge "Add accessibility announcement when user clicks on 'Add automatically to home screen' button" into sc-dev 2021-07-13 05:06:10 +00:00
Alina Zaidi dfa2752d28 Add accessibility announcement when user clicks on 'Add automatically to
home screen' button

Test: Tested manually with talkback on
Bug: 192808036
Bug: 192811245
Change-Id: I1c02738e0e4755b3bbdde12dad96ac2ed1996e6c
2021-07-12 15:37:13 +01:00
Steven Ng fbb82586a7 Clear WidgetCell#mItem before recylcing a WidgetCell
This fixes a bug which reuses a previous widget item spans to
compute the preview size.

Fix: 193133048
Test: manual
Change-Id: I5459882e258dc010898854dbbe52a6fa8d84796c
(cherry picked from commit 3d27207ff6)
2021-07-12 10:29:56 +00:00
Steven Ng ac21df2246 Merge "Clear WidgetCell#mItem before recylcing a WidgetCell" into sc-v2-dev 2021-07-09 22:16:03 +00:00
Schneider Victor-tulias bfe33b057a Update Gesture navigation tutorial to match new specs
- Updated strings
- Updated removed 'next' button when there are followign steps
- Added timeout to automatically continue the tutorial
- Combined back left and right into one step

Bug: 192009114
Bug: 177005427
Test: manual
Change-Id: I58b9017c4d69b5d097326c7d5be156a63951fb1a
2021-07-09 19:38:16 +00:00
Steven Ng 3d27207ff6 Clear WidgetCell#mItem before recylcing a WidgetCell
This fixes a bug which reuses a previous widget item spans to
compute the preview size.

Fix: 193133048
Test: manual
Change-Id: I5459882e258dc010898854dbbe52a6fa8d84796c
2021-07-09 17:45:19 +01:00
Steven Ng 12b2742780 Merge "Restricts the width of pin widget dialog to 89% on large screen devices" into sc-v2-dev 2021-07-09 09:38:33 +00:00
Steven Ng 3572c9100a Merge "Wrap the widget preview of the add item sheet with a scroll view" into sc-v2-dev 2021-07-09 09:00:31 +00:00
Steven Ng 1afca4dce5 Wrap the widget preview of the add item sheet with a scroll view
Test: manual
Fix: 192622015
Change-Id: I1eb676a92201970962c71194682ea70ce42b3d1b
2021-07-08 22:22:17 +01:00
Steven Ng 452e8b8512 Correct # of cells estimation that can fit horizontally in widgets
picker

Fix: 192661517
Test: check widgets are fit correctly in both full & bottom widgets
      picker in portrait and landscape in different grid settings.
Change-Id: Ic1b0589b7ccf62ff1ec1fd5713b4249ba58246a5
2021-07-08 16:23:38 +01:00
Steven Ng a37de9e141 Restricts the width of pin widget dialog to 89% on large screen devices
Test: manual
Fix: 193116981
Change-Id: I6ff8920a3698e6c11729b01a140a6942268f67cc
2021-07-08 16:06:50 +01:00
Vinit Nayak 9241fe62d1 Merge "Set correct divider dimension for task menu options" into sc-dev am: 7d0826f3d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164589

Change-Id: Ia48a1e6b2ebab8f94f374d0c4369bf4b62d13bea
2021-07-07 20:13:15 +00:00
Vinit Nayak 7d0826f3d1 Merge "Set correct divider dimension for task menu options" into sc-dev 2021-07-07 19:56:56 +00:00
Andras Kloczl 88716645cd Fix icon adding issue on two panel home
Test: manual & PromiseIconUITest & RequestPinItemTest
Bug: 192431856
Change-Id: I4a6319fa33c9359057f87d9c008eb139410593b5
2021-07-06 17:41:26 +02:00
Hyunyoung Song 6700b07b95 Merge "Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"" into sc-dev am: 933d2536da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184812

Change-Id: I11f7a50edec21c2ed2adca381f7841a4844b2580
2021-07-02 21:36:55 +00:00
Hyunyoung Song 933d2536da Merge "Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"" into sc-dev 2021-07-02 21:18:18 +00:00
Hyunyoung Song 5881b910e9 Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"
This reverts commit 878dedfb84.

Reason for revert: b/192558017
Bug: 192558017

Change-Id: I41e64ab74c00d7b255be6f3ef1b783c01571d641
2021-07-02 21:18:10 +00:00
Hyunyoung Song 40729fbdd6 Merge "Remove flicker when dismissing snackbar" into sc-dev am: 2d8856537e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15190712

Change-Id: I96da9d1380c2131849080e7835ed30b2b17f16a2
2021-07-02 20:42:24 +00:00
Hyunyoung Song 2d8856537e Merge "Remove flicker when dismissing snackbar" into sc-dev 2021-07-02 20:29:59 +00:00
TreeHugger Robot fc9d97164c Merge "Fix NPE inside dispatchRestoreInstanceState" into sc-dev am: 04d4d0d4f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184364

Change-Id: I2ab86183cc5cd32b233b596364acfd329d8211a9
2021-07-02 19:05:02 +00:00
TreeHugger Robot 04d4d0d4f9 Merge "Fix NPE inside dispatchRestoreInstanceState" into sc-dev 2021-07-02 18:46:30 +00:00
Hyunyoung Song 1b68cbb822 Remove flicker when dismissing snackbar
Bug: 191972314
Test: manual

Change-Id: Icf185b89c07b363ec44c77ba3ac1bdeb34e30e59
2021-07-02 11:35:53 -07:00
Pierre Barbier de Reuille c167b0bdf3 Merge changes Id2a8d12e,I06353ba4 into sc-dev am: 6788b73970
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15171715

Change-Id: I40b331817125cd8f4f56302d004bb77e79ca635b
2021-07-02 14:20:17 +00:00
Pierre Barbier de Reuille 6788b73970 Merge changes Id2a8d12e,I06353ba4 into sc-dev
* changes:
  Use the computation of the widget size including padding.
  Avoid calling AppWidgetHostViedw#updateAppWidgetSize
2021-07-02 14:05:08 +00:00
Pierre Barbier de Reuille a7b3a14e75 Use the computation of the widget size including padding.
Found all the uses of getWidgetSizePx and replaced them with the
computation of padded sizes (checked it all made sense).

Test: Try the various widget pickers.
Bug: 191612352
Change-Id: Id2a8d12ee7ce6baabef186dbb78d817975ea2212
2021-07-02 10:04:06 +01:00
Pierre Barbier de Reuille 199aec50ad Avoid calling AppWidgetHostViedw#updateAppWidgetSize
We cannot call it anymore, because the system padding is not always
used.

Bug: 191612352
Test: Manually, using CtsVerifier and dedicated widgets
Change-Id: I06353ba49a8e62127e593cdbcb86fadcf89ecb24
2021-07-02 10:03:44 +01:00
Hyunyoung Song 9804c0472e Fix NPE inside dispatchRestoreInstanceState
Bug: 192559704
Test: manual
Change-Id: I212518ac4a7feddd8e87f4be601332ea62e99313
2021-07-01 23:26:57 -07:00
Tracy Zhou e54f789de9 Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev 2021-07-01 19:32:39 +00:00
Jonathan Miranda aa560506ba Merge "Cancel existing preview item animation during non-animated update." into sc-dev am: 81501a563c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164771

Change-Id: I667763f65219cf259b8cf0db929d7dc0c848163e
2021-07-01 18:36:16 +00:00
Jonathan Miranda 81501a563c Merge "Cancel existing preview item animation during non-animated update." into sc-dev 2021-07-01 18:32:49 +00:00
Tracy Zhou 99adef95b3 Do not switch to screenshot and finish recents animation for menu options that already do so
The issue is that in landscape mode we add overview shortcuts (e.g. screenshot) to the task view menu, where we switch to screenshot and finish recents animation before executing the shortcut action. However for shortcut actions like screenshot, we do the same, resulting in two chained "switch to screenshot and finish". This is a temporary fix for S given it's late in the cycle and we don't want to introduce unwanted regressions.

Fixes: 192272546
Test: manual
Change-Id: I7ef596e8bce6c15aa4a27163197beac12359b691
2021-07-01 17:46:44 +00:00
Cyrus Boadway 270a9c734f Merge "Use nullable field and boolean rather than optional" into sc-dev am: 048a858575
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15171711

Change-Id: I6b6b6bf2ecb367f81fdb82321c7e7bb3cd8a228a
2021-07-01 17:15:38 +00:00
Cyrus Boadway 551b4297ed Use nullable field and boolean rather than optional
Optional won't hold null parameters, so use a boolean flag and
colorschange fields to represent the value and whether changes are
present.

Bug: 190818220
Test: manual
Change-Id: I794507340345864e73f04039f12a035c8053fd96
2021-07-01 15:05:43 +00:00
Alina Zaidi f03b1aeeb6 Merge "Reduce margin for DropTargetBar to avoid buttons to be truncated." into sc-dev am: eefccccb19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15155531

Change-Id: I92c997fbd0d0f47e78e5169e8cad9938bd2af0a0
2021-07-01 11:52:05 +00:00
Pierre Barbier de Reuille 2fa6e35341 Merge "resolve merge conflicts of 25e37a85ae to sc-v2-dev" into sc-v2-dev 2021-07-01 11:50:42 +00:00
Alina Zaidi eefccccb19 Merge "Reduce margin for DropTargetBar to avoid buttons to be truncated." into sc-dev 2021-07-01 11:10:26 +00:00
Steven Ng d9128413cc Merge "Fix widget animation truncated at drop if a widget is resized" into sc-dev 2021-07-01 10:29:49 +00:00
Pierre Barbier de Reuille 41f78f1e13 resolve merge conflicts of 25e37a85ae to sc-v2-dev
Change-Id: I78062d68d051a5f3c369214929f569b17c5a3471
Fix: 192532604
Bug: 192354264
Test: Manual
Merged-In: If573641e4bb5a98ed6b5008e00f70f4bbe492c24
2021-07-01 09:47:10 +00:00
Steven Ng 39a87fda17 Fix widget animation truncated at drop if a widget is resized
Set the widget outline to DragView rather than the content view
hosting a Picture record of AppWidgetHostView at drop.

Bug: 191646816
Test: Manual
Change-Id: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
Merged-In: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
2021-07-01 09:22:25 +00:00
Alina Zaidi 1b5efa3216 Reduce margin for DropTargetBar to avoid buttons to be truncated.
Bug: 187036287
Test: Tested manually by QA testing team on 4X5 grid size
Change-Id: Iaa4cd3e464ccf50427a5aa96d97093601e1d2948
2021-07-01 09:50:46 +01:00
TreeHugger Robot 25e37a85ae Merge "Correct color extraction on App Widget drop." into sc-dev 2021-07-01 08:31:16 +00:00