Commit Graph

18175 Commits

Author SHA1 Message Date
Randy Pfohl 819b835519 Revert "Revert "abtracting Activity from recentsView through rec..."
Revert submission 26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Reason for revert: Fix for issue has been found and will be included in this revert.

Reverted changes: /q/submissionid:26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Change-Id: I517e7d2fc0d82d250a6ed40862dd31c194d0a302
2024-04-11 08:58:08 -07:00
Shamali Patwa 2a51fc6420 Merge "Fix issue that widgets with config activity jump" into main 2024-04-11 14:08:54 +00:00
Danny Burakov 174e2224b6 Merge "Update predictive back progress interpolator" into main 2024-04-11 08:06:50 +00:00
Priyanka Advani 1d6851083b Merge changes from topic "revert-26414135-RecentsViewContainer-MEROZZOKJQ" into main
* changes:
  Revert "abtracting Activity from recentsView through recentsview..."
  Revert "fixing tests to match new abstraction"
2024-04-10 23:58:09 +00:00
Sunny Goyal 63bf93cf65 Merge "Freezing legacy feature flags" into main 2024-04-10 22:29:24 +00:00
Priyanka Advani 3c71346147 Revert "abtracting Activity from recentsView through recentsview..."
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: I25775cd6531355f1dc042ddb7a8d442ee0b36e58
2024-04-10 21:31:07 +00:00
randypfohl 547d6fc472 abtracting Activity from recentsView through recentsviewcontainer and basecontainerinterface interfaces
This change will let us move from activity to other parent views for recent views.

Summary: In prep for new recentsview containers outside of activity we needed to decouple recentsview from activity and state.
This change will let us move from activity to other parent views for recent views.

Test: Built and tested locally for 1p and 3p launchers on tablet, and portrait modes. Verified working functionality.

Bug: 292269949

Flag: NONE

Change-Id: I5c72745f438d466362ece988c35a97d829e9c1b4
2024-04-10 09:14:28 -07:00
Holly Jiuyu Sun c2ee3f5001 Merge "[omni] Implement 2-stage for LPNH." into main 2024-04-10 15:35:54 +00:00
Shamali P 9f2a4fe816 Fix issue that widgets with config activity jump
This also linked to the overlap we were seeing in
bug 331816144 (as can be seen in before and after video)

Bug: N/A
Test: See videos
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 NEXTFOOD
Change-Id: I21717e0c4d4eab7efa1746e46d3218b8b3cee4ef
2024-04-10 14:53:46 +00:00
Alina Zaidi 0580379e30 Rename freeform tasks to desktop tasks
Bug: b/332878426
Test: refactoring CL. Existing unit tests still pass.
Flag: NONE

Change-Id: I24ad9699223dd383ff794ef3b028bf32beca96d7
2024-04-10 12:30:50 +00:00
Brian Isganitis 3f4e5812ce Merge "Prevent meta shortcut from cancelling split select state." into main 2024-04-10 07:34:47 +00:00
Holly Sun deee0d06f6 [omni] Implement 2-stage for LPNH.
Use existing override duration and touch slop multiplier values for the 1st stage. Times `TWO_STAGE_MULTIPLIER` for the 2nd stage.
See http://shortn/_WqYj0buH7R

Bug: 330446193
Test: manual
Flag: legacy ENABLE_LPNH_TWO_STAGES disabled
Change-Id: Ic200f431524578d17fd98ebfbc65e44e0971e31c
2024-04-09 17:00:15 -07:00
Brian Isganitis 84fbec0b16 Prevent meta shortcut from cancelling split select state.
There are two things that need to be changed for this to work:

1. Make the isInOverview condition check for any Overview UI (including
   the split select state, modal, etc.)
2. Toggle Home All Apps directly, because firing the intent will cause
   Launcher to pause and resume before the intent is handled. We
misinterpret the pause as a request to cancel split screen. Since
TaskbarManager has a reference to Launcher, we might as well call the
method directly.

Test: Manual
Fix: 319076403
Flag: N/A
Change-Id: Ib8899188f593a168a054a16717df4a95be098557
2024-04-09 16:10:56 -07:00
Treehugger Robot 4fc8a9f965 Merge "[2/2] Fix widget resize frame show up at skewed location." into main 2024-04-09 22:26:55 +00:00
Sunny Goyal 8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Song Chun Fan ab21ddb2da Merge "[Launcher/Archive] remove all checks for the archiving system property" into main 2024-04-09 22:05:08 +00:00
Fengjiang Li 59091e4612 [2/2] Fix widget resize frame show up at skewed location.
Wait until launcher is not animating to show resize frame

Fix: 331433240
Test: manual - took a photo
Flag: NONE
Change-Id: I3aec7f8bf2b6081134004b30de3d389e5b1ab253
2024-04-09 13:43:36 -07:00
Sunny Goyal 3b00e7909a Merge "Using resource override instead of code-swap for ApiWrapper" into main 2024-04-09 20:33:20 +00:00
Sunny Goyal 11117d9b2a Using resource override instead of code-swap for ApiWrapper
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Iac19f32e64d2c76ed5b4f8592943ee4ae7af51b5
2024-04-09 11:14:44 -07:00
Alex Chau 3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Johannes Gallmann 75dd62fd22 Update predictive back progress interpolator
Bug: 332512902
Flag: ACONFIG com.android.systemui.predictive_back_sysui TRUNKFOOD
Test: Manual, i.e. analysing screenrecordings and verify that there are no more animation jumps at the start/end of the back animations
Change-Id: I99b13199032f7098fedb1cbd02cfe478d6fbb1f7
2024-04-09 14:11:40 +00:00
Sunny Goyal 8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Jeremy Sim be2a18d3fc Merge "Delete app pairs on model load if flag is turned off" into main 2024-04-09 00:38:42 +00:00
Jeremy Sim fa3eae99a5 Merge "Fix bug where app pair title was not updating with language" into main 2024-04-09 00:22:19 +00:00
Sunny Goyal 89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Song Chun Fan e5ad96ce10 [Launcher/Archive] remove all checks for the archiving system property
No longer needed

Change-Id: I62c8843aa04a245d1dcc30f7787c71d17993f5d1
BUG: 331165939
Test: builds
2024-04-08 23:14:07 +00:00
Shamali P 168d420440 Maintain the recommendations that were initially displayed
- The component names of the widgets shown on first opening the picker
are saved across orientation change - and only those shown initially are
displayed.

* http://screencast/cast/NDkyMDQ0OTg3OTI0NDgwMHw4ZGU1ZjRmNy0zNQ
* https://screencast/cast/NTc1NjQ1NDI5MTExMTkzNnxiZGJlMjQ2Yi01Ng

Bug: 331776686
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions TEAMFOOD
Test: Manual - see videos.
Change-Id: I6af7421c2757fde321d06406514ab2576a48fb47
2024-04-08 16:02:05 +00:00
Saumya Prakash 83646f9b82 Merge "Add Taskbar education for Circle to Search for pinned taskbar" into main 2024-04-06 05:39:28 +00:00
Saumya Prakash 5453c053b9 Add Taskbar education for Circle to Search for pinned taskbar
This change adds a new education tooltip for pinned taskbar that teaches
users how to use Circle to Search invoked through the action key. It won't run on
transient taskbar or if the user is in 3 button mode. The disclosures at
the bottom of the tooltip link to localized legal agreements for the feature.

Fix: 330401405
Test: Pin the taskbar and observe that the next time an app is launched
the edu shows up. After dismissal it shouldn't show up again.
Additionally, click on the disclosures and ensure they launch.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I64aea3004aca77c3ec81b81dea0cfab7a9c1e272
2024-04-06 01:52:49 +00:00
Willie Koomson 2041fd04a4 Merge "Fix resize frame for widgets added with tap-to-add button" into main 2024-04-06 00:45:37 +00:00
Sunny Goyal 8e1f37181d Merge "Allowing base class for ResourceBasedOverride to have Context based constructors" into main 2024-04-05 23:20:38 +00:00
Willie Koomson 7d2d6ced25 Fix resize frame for widgets added with tap-to-add button
This change updates the tap-to-add code to wait for the animations
between each step (close widget sheet, snap to Workspace page)
to finish before continuing with the next step of the flow.

Bug: 331425905
Bug: 331699050
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add TEAMFOOD
Change-Id: I774b86b429cd2e8a397e5605243056e6cea666b3
2024-04-05 22:03:37 +00:00
Jeremy Sim 24284467b5 Fix bug where app pair title was not updating with language
This CL adds the ability for an app pair icon to update its title string when package changes are detected. It also reorganizes some code in the app pairs classes for readability.

Fixes: 316051810
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I833e4f9766b7da8c0a3a5fb4b9fc050d8897437e
2024-04-05 21:35:58 +00:00
Jeremy Sim a7ce667e3a Merge "Fix launch flow when one app in an app pair is paused" into main 2024-04-05 21:30:09 +00:00
Jeremy Sim 08fc2d434f Delete app pairs on model load if flag is turned off
This CL adds a case to processFolderOrAppPair() -- if the ENABLE_APP_PAIRS flag is turned off, we do not load app pairs into launcher.

This prevents a case where a user uses backup+restore to migrate an app pair onto an environment where app pairs is disabled.

Fixes: 330412376
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I4a97e4aadc620f8b727439fcdd70ab0e7a3005a8
2024-04-05 13:07:20 -07:00
Sunny Goyal 21f498c5f3 Merge "Moving all configs from overrides.xml to config.xml" into main 2024-04-05 20:04:15 +00:00
Sunny Goyal 9d28eee769 Allowing base class for ResourceBasedOverride to have Context based constructors
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Ib4d1ef80133596a114a4fb32ea8ae918852a77f5
2024-04-05 12:56:36 -07:00
Treehugger Robot 09cee48a84 Merge "Fix homescreen rotation delay during fold" into main 2024-04-05 18:39:26 +00:00
Jeremy Sim 17db14b107 Fix launch flow when one app in an app pair is paused
This CL changes the error handling logic in ItemClickHandler to continue with app pair launch when only one app in an app pair is paused. It also changes AppPairIconGraphic so that the disabled state of the app pair is drawn modularly (if only one app is paused, only one app will appear visually paused).

Bug: 330795643
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ieaf0120cced07b6ac0f3eb07c75b66666a8dcc85
2024-04-05 11:24:33 -07:00
Sunny Goyal bd07c05446 Moving all configs from overrides.xml to config.xml
> Removing some used configs
> Moving ids to id.xml

Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: I86bd22db49a3980c55f5d42350a7c6368fa86d21
2024-04-05 11:20:17 -07:00
Sebastián Franco 6739770ea0 Merge "Set default grid when doing a backup and restore" into main 2024-04-05 17:23:25 +00:00
yyalan 12bd37ddd8 Fix homescreen rotation delay during fold
The issue is caused by the delay that Launcher handles the rotation; onDisplayInfoChanged that RotationHelper listens to is triggered later than the screen turning on. onDeviceProfileChanged is triggered earlier, but it only receives callback when in foreground. Using both listeners means that if in the background, we can still rely on onDisplayInfoChanged to update, assuming by the delay is tolerable given it takes time to changes to foreground.

Bug: 300929233
Flag: NA
Test: Manual and Perfetto trace in the bug
Change-Id: I5c6983649a38c3e4fe2b8c4a950435ceb07afa5a
2024-04-05 18:15:20 +01:00
Holly Jiuyu Sun a65c0b97c3 Merge "[PS] Disable long press for install app button." into main 2024-04-05 16:59:22 +00:00
Sebastian Franco df7d2b0861 Set default grid when doing a backup and restore
When restoring from a tablet because phones don't have
the same table some issues can ocure because we setup a
non valid grid, the correct thing is to setup a default.

Bug: 325285743
Fix: 332964986
Flag: ACONFIG narrow_grid_restore enabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I28bf02e83dddf5ae84818d879a5e21600eddf67e
2024-04-05 08:53:32 -07:00
Jakob Schneider 221117bcfd Merge "Fix issue where progress around icons is not shown" into main 2024-04-05 09:39:04 +00:00
Brandon Dayauon c752dd032c Merge "Ripple to header and button when click happens" into main 2024-04-05 04:20:49 +00:00
Brandon Dayauon bcb6a62297 Merge "Apply icon alpha animation to expand/collapse private space." into main 2024-04-05 04:18:48 +00:00
Holly Sun b4954547ac [PS] Disable long press for install app button.
For Install button - Disable long press would also disable drag logic altogether.
For apps in PS - Long press is not disabled as it. Drag is disabled in ag/25898351.

Video: https://drive.google.com/file/d/1g5jJ2vebZdiKUwjDMfkUnLwQ1oK1fWXB/view?usp=sharing

Bug: 332572841
Test: manual
Flag: aconfig com.android.launcher3.private_space_app_installer_button trunkfood
Change-Id: I418a31785b25c4f19dde2136747a74811628e92f
2024-04-04 18:14:25 -07:00
Jeremy Sim 324c2478d8 Merge "Update app pair icon colors when switching containers" into main 2024-04-05 00:00:56 +00:00
Fengjiang Li a197a4f3ae Merge "[1/2] Fix resize frame showing at left top corner of workspace." into main 2024-04-04 22:45:39 +00:00