The functionality should go back to the same as with phones.
There shouldn't be issues with the reorder or similar behavior since we
are switching form using the MultipageCellLayout to the regular
CellLayout.
The things we need to pay attention to is the the behavior of having two
panels like adding the right number of panels when loading (folding, unfolding and rotating).
Bug: 291822492
Test: ReorderWidgets
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8d606e89d3511a6f65e3a80add97c0fae580fb97)
Merged-In: I903873e32f35c5ee9e0f3da8581a37d4087d021f
Change-Id: I903873e32f35c5ee9e0f3da8581a37d4087d021f
Fix: 289960317
Test: Verify in unfolded felix that going from 2 icon folder and dragging 2nd icon out of folder lets you open the app that remains where the folder was
Test: Verify in unfolded felix that going from 2 icon folder and dragging 2nd icon into remove droptarget removes the folder and turns it into a single clickable icon
flag: no flag
(cherry picked from commit 5a7ea3069b)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:326ec97ab6a4d348708830cd2860d4dd90a59039)
Merged-In: I26138ee9f8e7cdb45cafe2446dc4d1e3d6d8347f
Change-Id: I26138ee9f8e7cdb45cafe2446dc4d1e3d6d8347f
On ag/21680045 I copy the previous mOccupied but the right thing to do is to
create a new one with all the views information.
Some test stoped running inadvertently that's why we didn't catch this issue.
There is a separate cl with the test to ensure we can catch it later on.
Fix: 289584301
Test: ReorderWidgets
(cherry picked from commit 1c5514b566)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:52d9d9780fb5a83302dd6fb3d875635a2ee57e1c)
Merged-In: I27b5a6e38a556d1c73ff8fbbdd552da6045e5b64
Change-Id: I27b5a6e38a556d1c73ff8fbbdd552da6045e5b64
- In the case where the system does not play the requested animation
we can still ensure that this doesn't result in a leak of the
activity by resetting the result when launcher is hidden (which
happens after the launch transition)
Bug: 285995223
Test: Presubmit
Test: Take heapdump after repro steps in b/285995223#comment6 and verify
there are no lingering static icon load results
Change-Id: I1d169df158cfaab64fbe1f4ce597d8f73d86a1c1
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys
Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
`BaseLauncherBinder.bindAllApps` and `BaseModelUpdateTask.bindApplicationsIfNeeded` can be called on both UI and Background thread.
Bug: 285711446
Test: Manual
Flags: NA
Change-Id: If6f6cce5f6e37fb21609aded8587afbdffda7545
This reverts commit 80bb8a12da.
Reason for revert: Cleanup after the bug is fixed. Tracing is not necessary anymore.
Change-Id: I1bb2bc59dd5debb51b094f14430cd18a203ed33c
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.
Log Uid in Impression Logging.
Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA
Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
In order to support multi-line titles in an RTL configuration we have to override
the androidx preferences library and manually set the text direction of the list view to be locale
Bug: 279880739
Test: Manual
Change-Id: I1f837a14a289e2ced8f8f3655f5ce061b37baa74
The flake was caused by the fact that addOnDrawListener(), the redraw is not guaranteed. This ultimately results to the workspace loading never finishing.
Forcing the redraw.
Bug: 267200150
Test: atest Launcher3Tests:com.android.launcher3.celllayout.ReorderWidgets#simpleReorder --rerun-until-failure
Flag: N/A
Change-Id: I47683425150a07ab2632e2bebdeca4d304e30d1b
The update will always be considered as failed because we always return 0 for all the commits.
Test: N/A
Bug: 234700507
Change-Id: I33ee8af996cef62dbc14349f9a7dd3cb72836ab6
It looks like if shouldClearVisibleEntries() evaluates to true and we clear mVisibleEntries, we get an Inconsistency IndexOutOfBounds error, the same as the one reported in the crash.
Bug: 276766307
Test: Verify that with these changes the widgets still update correctly when changing languages
Change-Id: I9f92e61d967aab2c8297cfc2fb4b04193df67650
- LauncherWidgetHolder.startListening is called before Launcher.setupView, so it's possible for getWorkspace() to be called as part of the appWidgetRemovedCallback. Reordered these calls to fix this null pointer
Flag: not needed
Fixes: 283850341
Test: Screenshot tests
Change-Id: Ied1f23647721fc4199eab2a5a79def1e306b00f3
Sebastián Franco
fbaron
Becky Qiu
Jagrut Desai
Winson Chung
Jon Miranda
Fengjiang Li
Treehugger Robot
Vinit Nayak
Schneider Victor-tulias
TreeHugger Robot
Tony Wickham
Anushree Ganjam
Andrew Cole
Vadim Tryshev
Brandon Dayauon
Sunny Goyal
Nick Chameyev
Sihua Ma
Alex Chau