Commit Graph

11899 Commits

Author SHA1 Message Date
Alina Zaidi 57cdcceb07 Merge "Remove scrim from navigation bar from full widget picker." into sc-dev 2021-06-26 18:01:23 +00:00
Jonathan Miranda 7a582f2d7d Merge "Update colors for non-v31 devices." into sc-dev 2021-06-26 00:09:59 +00:00
Jonathan Miranda 48dbfcd1c8 Merge "Fix folder icon text alignment." into sc-dev 2021-06-25 22:31:46 +00:00
Jon Miranda 2be425b6b0 Fix folder icon text alignment.
- We set the parent view padding to be cellYPadding, so we no longer need to
  account for it when setting the text LayoutParams.

Bug: 191954558
Test: grid where scalableGrid=true and scalableGrid=false (4x5, and 5x5)
Change-Id: I8d7578b2589f801ceef229b663446d868d135ad0
2021-06-25 10:33:20 -07:00
Hilary Huo 7a5a96ea73 Merge "[settings-pixel-search] Flag guard slice logging." into sc-dev 2021-06-25 16:54:59 +00:00
TreeHugger Robot 1491ec31c5 Merge "Update widget manipulation colors." into sc-dev 2021-06-25 15:18:45 +00:00
Pinyao Ting bbb9a9c033 Extra logging related to widget removal upon restore
As observed in b/187799223, widgets are removed after restore. We cannot
identify the root cause from the bugreport. This CL includes more
logging in the hope of identifying the root cause.

Bug: 18779922
Bug: 190565858
Test: manual
Change-Id: Ibdc9876716028592d17beac4542e1d8c498f9e4c
(cherry picked from commit 655ac082c2)
2021-06-25 09:22:33 +00:00
Yogisha Dixit c0ac1dda74 Update widget manipulation colors.
Spec:
* Resize frame: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.OeO4S0j
* Drop target bar: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187910396
Change-Id: I6fd433796970c428841ee96e45ee4fca1ded3665
Merged-In: I6fd433796970c428841ee96e45ee4fca1ded3665
2021-06-25 08:43:29 +00:00
Hilary Huo b4538d1ef4 [settings-pixel-search] Flag guard slice logging.
Test: m
Bug: 191297465
Change-Id: I3f5f1ef5ad295e5d8ccedac00f290080653df5a3
2021-06-24 16:08:09 -07:00
Jonathan Miranda a754e678a7 Merge "Move qsb according to spec." into sc-dev 2021-06-24 21:14:11 +00:00
Alina Zaidi e92c63f45b Remove scrim from navigation bar from full widget picker.
Bug: 191926325
Test: Manually tested
Change-Id: Idc5fded9e8227a6aa9cf58c9e2cce146dc52a2c6
2021-06-24 20:20:05 +01:00
Jon Miranda 8bdb222a18 Move qsb according to spec.
Bug: 175329686
Test: visual test
      checked 5x5 and confirmed no visual change
      checked 4x5 and confirmed visual change
      - tested various display sizes to ensure no overlapping is caused

Change-Id: I95a80b484516f634fa13347534810c7a51cecc8d
Merged-In: I95a80b484516f634fa13347534810c7a51cecc8d
2021-06-24 18:51:46 +00:00
TreeHugger Robot 6604eb54bf Merge "Measure WidgetsBottomPicker again when the number of spans changes" into sc-dev 2021-06-24 18:43:32 +00:00
Jon Miranda 6a936e3ec4 Update colors for non-v31 devices.
Also renamed to popup color to popup shade to better differentiate
between the primary/secondary/tertirary popup colors.

Bug: 191496301
Test: Removed v31 colors to verify the non-v31 colors, that the shades are as expected
      Tested on wallpapaper with light text, again with dark mode
      Tested on wallpaper with dark text, and then again with dark mode

Change-Id: I3ec9ee7f85696ee48224740a1ec7f4abe42348ee
2021-06-24 11:07:52 -07:00
Steven Ng 53e8b46f66 Measure WidgetsBottomPicker again when the number of spans changes
Bug: In onMeasure, we calculate the number of spans that can be fit
horizontally. If the number of spans has changed, we re-organize
widgets shown in the table. However, after that, we didn't measure
WidgetsBottomPicker and its children again. As a result, the newly
added widget previews' dimensions are never measured.

Test: Long press clock app and then click widgets. Rotates the screen
      and observe widgets correctly shown.
Fix: 191644950
Change-Id: Iae94fba5b137807483e061d785b18d59defb013e
2021-06-24 18:16:05 +01:00
Jonathan Miranda bd51e6e3f3 Merge "Update popup colors. Add local color extraction behind a flag." into sc-dev 2021-06-23 22:51:20 +00:00
Hilary Huo 08843d8e37 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev 2021-06-23 22:18:00 +00:00
Jon Miranda 27de7d2643 Update popup colors. Add local color extraction behind a flag.
- Also updating folder backgrounds, lStar only works in ColorStateList.

Bug: 191496301
Test: test wallpaper with light text, in light mode
      test again in dark mode
      test wallpaper with dark text, in light mode
      test again in dark mode

Change-Id: I2d43d874e7e2fad6a9a0e039058beb58b204fa96
2021-06-23 14:18:25 -07:00
Steven Ng fa9f70be03 Merge "Use default spans as min spans if the min spans > default spans" into sc-dev 2021-06-23 21:05:43 +00:00
Steven Ng 5b786ca88d Merge "Add null check before detach content view from dragView at onDropComplete" into sc-dev 2021-06-23 21:01:57 +00:00
Samuel Fufa 1e70c235cf Merge "Polish work for work profile" into sc-dev 2021-06-23 18:58:29 +00:00
Jonathan Miranda 23415e214c Merge "Fix bug where icons in hotseat were clipped when display size is Small." into sc-dev 2021-06-23 18:27:19 +00:00
Hyunyoung Song 93068d1c39 Merge "Hide searchbox when header protection is on." into sc-dev 2021-06-23 18:15:27 +00:00
Hilary Huo e83189593a [settings-pixel-search] Add ww logging to track slice fetching timeout
Test: https://paste.googleplex.com/6310936320147456
Bug: 191297465
Change-Id: I0a4a65295e7290b55dccdb63830ff60c6838fbb2
2021-06-23 10:16:21 -07:00
Samuel Fufa ce820f51e2 Polish work for work profile
Bug: 191478900 Work profile toggle specs
Bug: 187761192 Fix issue where Installing app scrolling apps to top
Bug: 191121890	Fix issue where top of AllApps becomes empty when returning to AllApps
Bug: 191477329 String change for work profile paused state
Test: local
Change-Id: Idbaab333566b54afa3dc879f5bea98e1f77c44fc
2021-06-23 16:46:52 +00:00
Steven Ng 0571a370d1 Use default spans as min spans if the min spans > default spans
This is to match the behavior described in
AppWidgetProviderInfo#minResizeWidth/Height documentation.

Test: run LauncherAppWidgetProviderInfoTest
Bug: 191223844
Change-Id: I37c0c8bf5e4588919e5b30fab6d2fde7236e114b
2021-06-23 17:11:05 +01:00
Jon Miranda 0d284852d9 Fix bug where icons in hotseat were clipped when display size is Small.
Simplify calculations to ensure the hotseat sizes are always accurate.

Bug: 186556930
Test: changed display setting from small to largest on different grid
      sizes (5x5, 4x4, 4x5, 3x3, 2x2)

Change-Id: I97580c50a9d821577eb63335950d5695d9bf035d
2021-06-23 08:08:12 -07:00
Hyunyoung Song 7d3b25734a Hide searchbox when header protection is on.
Bug: 191726215
Test: manual
Change-Id: I086a05654faf718683ebe5dfbcf64b6bd6347ca8
2021-06-23 00:44:49 -07:00
Steven Ng 92335ed7bd Add null check before detach content view from dragView at onDropComplete
Test: Drop a conversation widget on a configuration button. No crash
      is observed.
Fix: 191762933
Change-Id: I483c6f4dbc9fc6c096383682284a4c854707f583
2021-06-22 23:26:05 +01:00
Jonathan Miranda 835fab2305 Merge "Polish folder icon bugs." into sc-dev 2021-06-22 22:00:17 +00:00
Jon Miranda fa1e14c4b8 Polish folder icon bugs.
- Fix bug where folders are misaligned.
- Fix bug when closing on 2nd page of large folder.

Bug: 184822585
Test: drag folder originally in hotseat to workspace, vice versa
      test on grid where isScalable=true and isScalable=false

Change-Id: I08a79b8d280df3e3974baaa07e80db6bc4165e58
2021-06-22 11:12:47 -07:00
Cyrus Boadway 719be9a9e4 Merge "Suppress Splash Screen on widget reconfiguration activity start" into sc-dev 2021-06-22 12:30:23 +00:00
Steven Ng cec6edf78e Merge "Update all apps & widget pickers personal / work tabs" into sc-dev 2021-06-22 10:37:00 +00:00
Cyrus Boadway 263a00c738 Suppress Splash Screen on widget reconfiguration activity start
When a widget configuration activity is started, it's started from
the launcher. Under some circumstances the launcher's splash screen
would be shown, rather than the splash screen corresponding to the
tapped app.

To avoid confusion, we suppress the splash screen for configuration
starts.

Bug: 190153065
Test: manual
Change-Id: Ib18851f1bb50b64bc5d47b8aa5931490c969b54b
2021-06-22 09:22:33 +00:00
Sunny Goyal b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
Steven Ng 50f1ff1808 Update all apps & widget pickers personal / work tabs
Test: Open all apps to confirm tab style match the mock in both dark &
      light mode.
      Open widgets picker to confirm tab style match the mock in both
      dark & light mode.
Bug: 191387242
Change-Id: Ie0111f65813128fef5befbdefd451cf0e9f01be9
2021-06-21 22:02:54 +01:00
Sunny Goyal de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Brian Isganitis fe139cdf69 Merge "Revert "Fix home settings landing page"" into sc-dev 2021-06-21 19:27:24 +00:00
Stevie Kideckel e03784478d Merge "Add spacing between items as decorations instead of margins" into sc-dev 2021-06-21 16:47:30 +00:00
Steven Ng 95c969530c Merge "Copy minSpanX & minSpanY when copying from an existing ItemInfo" into sc-dev 2021-06-21 16:20:39 +00:00
Stevie Kideckel ded80076db Add spacing between items as decorations instead of margins
There are bugs in the accounting for the margins if we manipulate the
view directly, causing the wrong top to be reported and the view to be
shifted when we call scrollToPosition. Item decorations ensure that the
layout system for the recycler view always has the right details about
the spacing.

Fix: 191642682
Test: verified locally
Change-Id: Ie80563757079e885c8178883ab16e314d01c5b32
2021-06-21 15:11:33 +00:00
Steven Ng 7b27e7d061 Copy minSpanX & minSpanY when copying from an existing ItemInfo
Test: Drop Gmail widget to home screen and configure it. Then, drop
      the widget to a home screen that doesn't have sufficient space
      to accommodate it. The gmail widget can't be dropped to that
      home page and is returned to its original position.
Fix: 190582606
Change-Id: I177c09562d059b658e835cbb7fdde0d7bc6565d2
2021-06-21 15:38:26 +01:00
Stevie Kideckel e99f3c9666 Fix bug in equals implementation for search headers
Fix: 191626327
Test: verified locally
Change-Id: I8103059a2759a8533581ff86cb57b28913cf5731
2021-06-21 10:42:16 +00:00
Jonathan Miranda 1bfd350ead Merge "Update notification popup UI." into sc-dev 2021-06-19 03:52:23 +00:00
Brian Isganitis aefcc5a300 Revert "Fix home settings landing page"
This reverts commit 96cc3c533c.

Reason for revert: Causes back to close sub-settings (b/191257243).

Change-Id: I3aa01bed1d73874176fc2568bac4ca714e9f2df7
Bug: 188565060
2021-06-18 23:46:20 +00:00
Jon Miranda 313b2c2d28 Update notification popup UI.
- Update UI to match specs.
- Only shows one notification (removed footer, animation code)

Bug: 175329686
Bug: 190402054
Test: open popup, dismiss notification from shade,
      open popup, click on notification
      checked RTL

Change-Id: I92672f94233d986ae5b5c54979980967308cb156
2021-06-18 22:42:44 +00:00
Stevie Kideckel dd19a24769 Merge "Load widget preview images before adding the rows to the adapter" into sc-dev 2021-06-18 22:37:32 +00:00
Jonathan Miranda 576179199a Merge "Fix bug where ripple extends out of bounds in pop up container." into sc-dev 2021-06-18 22:27:45 +00:00
Jon Miranda f13ddbd333 Fix bug where ripple extends out of bounds in pop up container.
Bug: 186820908
Test: test apps with diff. pop up container arrangements
      test prefs in all apps

Change-Id: I4d3e26871416835ab2a851fcc6fe2c4f70235b62
2021-06-18 20:58:14 +00:00
Stevie Kideckel a093523299 Load widget preview images before adding the rows to the adapter
This allows for smooth animations as the items will have their full
height resolved

Bug: 190892517
Test: verified locally
Test: CachingWidgetPreviewLoaderTest
Change-Id: I86afc6951a4cc82ae45e63795791d259a3bb3cda
2021-06-18 19:18:29 +00:00