Commit Graph

14204 Commits

Author SHA1 Message Date
Andy Wickham 5429b8fd86 Adds SearchRecyclerView as a notification dot listener.
This way app dots get updated as notifications come in or get
dismissed.

Bug: 246962476
Test: Dismissed notification while Search active.
Change-Id: I41e1b44561fb5ccd43deff342afb722cc5107330
2022-09-15 11:21:04 -07:00
Becky Qiu 1c8e630381 Merge "[Toast] Switch to use a device config instead of feature flag for appSearch." into tm-qpr-dev 2022-09-14 06:53:49 +00:00
TreeHugger Robot 839297e232 Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev 2022-09-13 19:49:44 +00:00
Becky Qiu cdac570298 [Toast] Switch to use a device config instead of feature flag for appSearch.
Bug: 241001264
Test: local
Change-Id: I47416b07a62379ab5c2c17b3b769c8bc8b2ef106
2022-09-13 12:26:42 -07:00
TreeHugger Robot 3ded296cee Merge "Change wallpaper depth in widget picker" into tm-qpr-dev 2022-09-13 18:46:53 +00:00
TreeHugger Robot 22af7c2e7e Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev 2022-09-13 17:57:44 +00:00
Alex Chau 3d2c062567 Change wallpaper depth in widget picker
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
Becky Qiu a7be354913 Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev 2022-09-13 00:33:26 +00:00
Sunny Goyal 42beb544e9 Removing UiThreadHelper and moving code to corresponding classes
This allows for better code organization based on the code logic

Bug: 246382466
Test: Presubmit
Change-Id: I6148143a60afdd917a11587e327f5e8a4d7def9e
2022-09-12 22:14:15 +00:00
TreeHugger Robot d581f40b30 Merge "Removing some unused code:" into tm-qpr-dev 2022-09-12 19:24:20 +00:00
Brandon Dayauon f17c581165 Merge "Work toggle button staying at the top when moving keyboard down" into tm-qpr-dev 2022-09-12 19:15:20 +00:00
Vinit Nayak f5e5c8e1ce Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev 2022-09-12 18:29:22 +00:00
Sunny Goyal 676d19c171 Merge "Removing back-button alpha animation code" into tm-qpr-dev 2022-09-12 16:04:34 +00:00
TreeHugger Robot 69b9e736a8 Merge "Simplifying hideKeyboardAsync method" into tm-qpr-dev 2022-09-10 05:03:23 +00:00
Sunny Goyal 8958a7078a Simplifying hideKeyboardAsync method
Bug: 246000321
Test: Presubmit
Change-Id: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
Merged-In: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
2022-09-10 04:01:48 +00:00
TreeHugger Robot 1c22b7e57c Merge "Support for animating A-Z <-> Search." into tm-qpr-dev 2022-09-10 01:11:36 +00:00
Sunny Goyal 1eb1124d82 Removing back-button alpha animation code
Back button is only animation in 2-button UI which is not supported anymore

Bug: 246006580
Test: Presubmit
Change-Id: I7385b07272e44c1f9f0488c158e1b4ee67060120
2022-09-09 17:15:24 -07:00
Sunny Goyal eb018d8004 Removing some unused code:
> intrinsicIconScaleFactor is no longer read
> We no longer generatepreview outline for drag

Bug: 245997823
Test: Presubmit
Change-Id: I17ed25239d0affe89482da3406d529d323a426d9
2022-09-09 16:02:13 -07:00
Andy Wickham 94d5d3cb6c Support for animating A-Z <-> Search.
Demo videos (1/5 speed) and APK: https://drive.google.com/drive/folders/1qQNzcoibiFMzxYhvXc7UEHCaBhJg6SjN?resourcekey=0-OWD06iLXg3wf_eWce4rUPA&usp=sharing

Bug: 234882587
Bug: 243688989
Test: Manually tested a bunch of cases at 1/10 animation speed.
Such as work profile or not, suggested apps enabled/disabled,
typing during the animation, going back during the animation,
web results injected above apps, etc.

Change-Id: Id4f1a858d387bf3a7f9cf2d23564a276544abef1
2022-09-09 15:37:57 -07:00
Brandon Dayauon fa6011fcdf Work toggle button staying at the top when moving keyboard down
- Same fix from implementation when implementing extendedFAB. ag/19223926
- Essentiall remove isEnabled() check since it is not needed
bug: 235873194
test: Manual - before: https://drive.google.com/file/d/1JjDSudWS56fiDyMnP8Btvy0pWFyUIXND/view?usp=sharing
after: https://drive.google.com/file/d/1Ja-OVpXKK1yUrixpU_V6WsLV0Ryw152w/view?usp=sharing

Change-Id: Ibca405deccfcd61845dd4f5952ad196af1ab3fe2
2022-09-09 15:04:42 -07:00
Sebastián Franco b64894b095 Merge "Adding specific case for applications in getEntryMigrationId" into tm-qpr-dev 2022-09-09 21:50:52 +00:00
Becky Qiu 431aed846e [Toast] Add a debug log config for app search flow.
Bug: 241001264
Test: manual
Change-Id: Ifb102477278f41ebf51d736cf6f0114dadcb94ce
2022-09-09 13:19:21 -07:00
TreeHugger Robot d0aba60767 Merge "Introduce KeyboardStateManager to maintain keyboardstate as show or hide." into tm-qpr-dev 2022-09-09 20:10:37 +00:00
Vinit Nayak 2e4dcb16a7 Place TaskMenuView aligned with secondary split thumbnail
* Use consistent divider calculations in
different methods

Fixes: 245610772
Fixes: 218784487

Test: Open task menu view in split pair in landscape/
seascape/portrait, real and fake.

Change-Id: If1bbc7a0d4f1767584d0fc8cf549130f35b8e4a3
2022-09-09 11:25:08 -07:00
Winson Chung 607a976635 Merge "Fix missing call to super cancel method" into tm-qpr-dev 2022-09-09 16:16:09 +00:00
Aurélien Pomini 687c6e415c Merge "Hide keyboard when transitioning from all-apps state to overview state." into tm-qpr-dev 2022-09-09 14:25:16 +00:00
Winson Chung 82638f6ef1 Fix missing call to super cancel method
- Without the call, it's interpreted as a successful animation to the
  listener even though it was canceled

Bug: 245829938
Test: Swipe to previous task, immediately after settling touch the
      swipe area again
Change-Id: I531cbda0c2bc8168a312a14854a7a73fafd8f678
2022-09-09 05:58:27 +00:00
Anushree Ganjam a461660fa8 Introduce KeyboardStateManager to maintain keyboardstate as show or hide.
- Add a feature flag for IME Latency logging.

- Removed mShowImeAfterFirstLayout from ExtendedEditText.

   http://ag/1414509 added `mShowImeAfterFirstLayout`and cl description
   says "Show IME when search query != null after rotation".

   I verified the behavior by turning on "Allow home screen rotation".
   Keyboard is not getting dismissed on rotation in AA+ screen in a-z list
   or even in the search screen.
   Video : https://drive.google.com/file/d/1BWUTrW9OSEo6ojErj8INMwjFCPArVD4B/view?usp=sharing&resourcekey=0-SXTcKyUw1wCSi8Bm37ktow

Bug: 240192346
Test: Manual.

Verified by setting `ENABLE_KEYBOARD_TRANSITION_SYNC` to false and for
following usecases.

- All apps entry with ime enabled, scrolling a-z list to hide keyboard
- Folder name change - showing and dismissing keyboard
- Toast entry from Allapps and QSB - showing and dismissing keyboard

Change-Id: I1a6b5759b8e71e77744f58677b6d1b73e2f633e8
2022-09-09 04:32:33 +00:00
Raj Garg 2e106277d7 Merge "Introducing new variable to enable/disable shortcuts." into tm-qpr-dev 2022-09-09 03:41:47 +00:00
Sebastian Franco b0ac461e06 Adding specific case for applications in getEntryMigrationId
A string like this are sued as id when migrating the grid:

The problem is that sourceBounds can chagne for the same app
and then return the same app as different. To fix it I added
a new case for Aplications and remove the variable sourceBounds
for the default case if there is anotherr Favorites item that
has the same problem but we don't know.

Test: Manually migrated between different grids.
Fix: 232004084
Change-Id: Ida015c971c70c8de2915fca1ebc38f446c21a310
2022-09-08 17:10:53 -07:00
TreeHugger Robot 3426372ff8 Merge "Explicit Nullbility in Launcher (Part 3)" into tm-qpr-dev 2022-09-08 21:37:30 +00:00
Schneider Victor-tulias 82e112c2a4 Merge "Enable input consumer selection reason logging and gesture navigation error detection." into tm-qpr-dev 2022-09-08 17:53:26 +00:00
Pinyao Ting 96d3c589ef Explicit Nullbility in Launcher (Part 3)
This CL updates the nullabality on ItemInfo related classes.

Bug: 242895652
Test: manual
Change-Id: I5fa17a17ff876486431f48d750abdc31afbc56a0
2022-09-08 09:36:00 -07:00
Anushree Ganjam 94a54203f3 Merge "Add a feature flag for showing Search Educard in QSB" into tm-qpr-dev 2022-09-07 22:05:38 +00:00
Schneider Victor-tulias a602a0a895 Add error detection for aborting the recents scrolling during transition to home
Bug: 227514916
Test: swiped to overview, to home and quick switch and checked the logs
Change-Id: Ie02d3933e2fb05eedd9c264a381329bc04feac2d
2022-09-07 14:16:08 -07:00
Anushree Ganjam c74ef95d50 Add a feature flag for showing Search Educard in QSB
Bug: 243680092
Test: Manual
Change-Id: I3ba1f577df2a5cfb2eb5f7acad20b47980c20916
2022-09-07 19:14:35 +00:00
Alex Chau 0f1001c7b1 Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev 2022-09-07 13:45:16 +00:00
Alex Chau e818bcb997 Use real IDP in DeviceProfileTest
- Mock WindowManagerProxy instead of IDP in DeviceProfileTest
- Extracted NavigationMode to standalone class
- Moved parseNavigationMode to WindowManagerProxy so it can be mocked
- Moved DeviceProfileTest to internal repo

Bug: 242086027
Test: DeviceProfileTest
Change-Id: Ia5a43293b1380f04d786d2adf8503cfd10f7674a
2022-09-07 10:35:21 +01:00
Sunny Goyal 7a6c610626 Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev 2022-09-07 04:47:19 +00:00
TreeHugger Robot db32818a4e Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev 2022-09-06 17:29:28 +00:00
Brian Isganitis 2d82ad2664 Merge "Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI" into tm-qpr-dev 2022-09-06 17:21:51 +00:00
Pat Manning b11dedc254 Merge "Use full screen width for drop target buttons to support higher screen densities from truncating text." into tm-qpr-dev 2022-09-06 14:59:48 +00:00
Jeremy Sim afff936235 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev 2022-09-02 20:46:41 +00:00
Anushree Ganjam 37bcfaddba Merge "Add a boolean to track QSB edu card dismissal." into tm-qpr-dev 2022-09-02 15:37:17 +00:00
Alex Chau f28c9f14a4 Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev 2022-09-02 10:06:37 +00:00
Jeremy Sim b33471a21f Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect
This commit fixes a bug where the user could cancel animations when transitioning between Launcher states, potentially resulting in a state where Overview elements (task thumbnails etc.) were wrongly hidden or invisible.

The bug occurred because functions such as createInitialSplitSelectAnimation() and createAtomicAnimation() did not carry out any cleanup upon animation failure. This resulted in RecentsView potentially being in a polluted state for the next launch.

Bug was fixed by adding cleanup routines to two onAnimationEnd listeners.

Fixes: 242715097
Test: Manual
Change-Id: I05415ecf515e247aa535e3ca8371e540c3189b01
2022-09-01 20:51:53 -07:00
Sukesh Ram 8d3d944d5d Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI
Bug: 238325716
Test: Manual
Change-Id: I66a85eb79cda89a63c3116a56a52b51526720158
Merged-In: I66a85eb79cda89a63c3116a56a52b51526720158
2022-09-02 00:44:39 +00:00
Schneider Victor-tulias 119ae79e3c Enable input consumer selection reason logging and gesture navigation error detection.
Bug: 227514916
Test: ran locally, tested multiple gestures and checked logs
Change-Id: Iab0c9a21ee0141744cf82afd16ee941f2b49a9cc
2022-09-01 15:59:07 -07:00
Sukesh Ram 82da9fc5be Made getOnBoardingPrefs @Nullable & avoid NPE
Bug: 236679197
Test: Manual
Change-Id: I3cbb0891cbfcf7cab956a4e05a28dbbcc2b33e19
(cherry picked from commit c0650e7725)
2022-09-01 22:20:35 +00:00
Alex Chau 3193522616 Change wallpaper depth value in AllApps bottomsheet
- Cap AllApps wallpaper zoom to workspaceContentScale rather than all the way to max depth (config_wallpaperMaxScale)
- Changed both workspace scale and depth interpolator to correlate with AllApps threshold

Bug: 240580498
Test: manual
Change-Id: I0342a37c72206268dcffc5697a212704a41b020f
2022-09-01 21:26:30 +01:00