Commit Graph

7833 Commits

Author SHA1 Message Date
Tony Wickham 52240a3aa0 Only detect swipe directions that lead to new states
This cleans up the code and ensures that the current state animation
is always initialized when we get drag events.

Also log when we pass through states.

Bug: 78017680
Change-Id: I54ab42923ed539940ea708973ad65f5793669c11
2018-05-03 14:04:25 -07:00
Tony Wickham 7a5d4ae64f Merge "Fix some state issues with user-controlled animations" into ub-launcher3-edmonton 2018-05-02 16:20:19 +00:00
Jorim Jaggi bbeedd1d2f Merge "Fix some jank with transitions" into ub-launcher3-edmonton 2018-05-02 13:17:42 +00:00
android-build-team Robot cacf90cc48 Merge "Reusing the same bitmap and pixel array for shape detection" into ub-launcher3-edmonton 2018-05-01 23:32:17 +00:00
android-build-team Robot 4d9c414cdb Merge "Bound overscroll shift amount to avoid content from drawing on top (Y-val) of the QSB." into ub-launcher3-edmonton 2018-05-01 21:07:59 +00:00
android-build-team Robot 3adb0b9f2a Merge "Fade in LauncherRootView in finishFirstPageBind." into ub-launcher3-edmonton 2018-05-01 20:59:00 +00:00
Jon Miranda 5916709219 Bound overscroll shift amount to avoid content from drawing on top (Y-val)
of the QSB.

Bug: 77538324
Change-Id: Idabc4365c5fe5cb1894fa0eb84ea9309b85f99a3
2018-05-01 13:57:33 -07:00
Jon Miranda dbd9286abd Fade in LauncherRootView in finishFirstPageBind.
This ensures that the fade in animation will actually run, as DragLayer alpha
can be set by other means.

Bug: 72728697
Change-Id: I3ca0a6811b113e331119c74539a4421cfbdb51c9
2018-05-01 13:49:54 -07:00
Tony 31fbd4c08b Fix some state issues with user-controlled animations
Previously, user-controlled animations weren't properly being canceled when a
non-user-controlled animation started, e.g. when hitting home. Thus, we could
end in the wrong or inconsistent state because the user-controlled animation's
end runnable was still used. Now we add a cleanup callback for when we reset
the user-controlled animation for one that isn't user-controlled.

Also fixed a couple typos.

Tests (easier with animation durations extended):
- Swipe up and hit home before reaching overview -> land on home
- Go to overview, swipe down slightly (before threshold to go to workspace)
  and let go -> return to overview without flash (recents was resetting)
- Swipe up, press home while swiping -> goes home, stops responding to drag
- Start dismissing task and hit home before it finishes (or while dragging)
  -> goes home, stops responding to drag

Bug: 78249220
Change-Id: If11d8999e3fadba38c987b25af67cd2304cd859b
2018-05-01 13:45:27 -05:00
android-build-team Robot 1e0b98fa6e Merge "Fixes the incorrect hover icon color in drop bar when dark theme" into ub-launcher3-edmonton 2018-04-30 23:22:00 +00:00
Mehdi Alizadeh 3e024c0e1c Fixes the incorrect hover icon color in drop bar when dark theme
Bug: 78641863
Test: Manual test with dark and light wallpapers
Change-Id: Ic3fb68f5c5f746482a7f23b11284e30ac3e10168
2018-04-30 16:05:25 -07:00
Sunny Goyal 36d090df67 Adding a round rect background for the self in Overview
Bug: 78771910
Change-Id: I71460a284ed185e82d66fe65104402fb99d6b312
2018-04-30 15:37:39 -07:00
android-build-team Robot 1ea6d9cb8e Merge "Fixing Search box not getting aligned properly based on insets" into ub-launcher3-edmonton 2018-04-30 21:31:50 +00:00
Sunny Goyal df296898da Fixing Search box not getting aligned properly based on insets
Bug: 77893699
Change-Id: If195395af7858c3115d695a308810480474541a5
2018-04-30 12:35:40 -07:00
Vadim Tryshev 1c56935c30 Revert "a11y: disabling accessibility scrolling of the home screen"
This reverts commit 52b2b43c56.

Reason for revert: Per an email thread, this CL is considered a hack.

Change-Id: Id97fc9a398184ba18c2188d858218bc2d9ddc16e
(cherry picked from commit 310093d050)
2018-04-30 18:07:13 +00:00
Sunny Goyal 2e4596a448 Reusing the same bitmap and pixel array for shape detection
Bug: 76162466
Change-Id: I785d9b8673b2b8b0a56a146143b375c412e9322a
2018-04-30 09:23:29 -07:00
Vadim Tryshev 84b46f0257 Fixing task misalignment
Bug: 78793769
Test: Manual
Change-Id: I49f8213bf412f63fc296a8be5bd49950e4c01175
2018-04-27 18:00:14 -07:00
Mehdi Alizadeh 7ad04f35f8 Merge "Refactor initializing LauncherAccessibilityDelegate" into ub-launcher3-edmonton 2018-04-27 23:14:01 +00:00
Mehdi Alizadeh 8588fd0ea2 Refactor initializing LauncherAccessibilityDelegate
Bug: 77638406
Test: None
Change-Id: Ibf9f4fcabe42400abc91aa4b94417a8ff0449248
2018-04-27 15:38:52 -07:00
android-build-team Robot 15260fdd00 Merge "Enable Clear-all button by default" into ub-launcher3-edmonton 2018-04-27 20:44:02 +00:00
Vadim Tryshev cc0c98ad94 Enable Clear-all button by default
Making it work with all 4 combinations of RTL and flip-recents.

Bug: 72222505
Test: Manual
Change-Id: Ifb2428e006674abfe9a2609fd3d8f3f648eff0b8
2018-04-27 13:32:28 -07:00
Winson Chung 473730fcf9 Call Activity.onTrimMemory() to ensure render thread cache is also trimmed
Bug: 76162466
Change-Id: Ie3cf9076ba8149c0f2d7e58b5ca0c974ae914c18
2018-04-26 12:07:39 -07:00
Roger Olsson 4ac406db22 Avoid crash when widget previews have no intrinsic size
Intrinsic size for widget preview drawable checked.
Needed since some drawables, like color drawables,
do not have any intrinsic size.

Bug: 78452220
Test: manual, see Bug info.
Change-Id: I815353773e38b1fce2fe19962f07c1727e1b0768
2018-04-26 10:44:09 -07:00
Jorim Jaggi 118295e07c Fix some jank with transitions
- Animations in WorkspacePageIndicator while the app transition
was running was causing layer trashing, potentially leading to
jank.
- Make sure to use a layer in the wallpaper open animation.

Test: Open app while indicators are about to fade out.
Bug: 75985430
Change-Id: Iad6a511d98dff81b5cde727f4472f0f039ffc4be
2018-04-26 14:47:44 +02:00
Mehdi Alizadeh 8517b69b9e Prepares SecondaryDropTarget to inherit from
Bug: 77638406
Test: None
Change-Id: I8a1b1e2ef4cb9b090da33b3b56de177c9ddc6171
2018-04-25 14:49:12 -07:00
TreeHugger Robot 69ac60381c Merge "Improving highlight for Clear-all button." into ub-launcher3-edmonton 2018-04-25 20:37:37 +00:00
Vadim Tryshev 77cb385d47 Improving highlight for Clear-all button.
Better shape + now has hover state.

Bug: 72222505
Test: Manual
Change-Id: I24ba55c760b15d71406a35ea5f7bf54f505741d6
2018-04-25 13:20:37 -07:00
TreeHugger Robot 730ee62e41 Merge "Call close for AbstractFloatingViews that were removed while still open." into ub-launcher3-edmonton 2018-04-25 18:42:23 +00:00
Jon Miranda 83337f9e8e Call close for AbstractFloatingViews that were removed while still open.
I'm not sure how/when this case occurs (perhaps during some transition/state
change), but manually removing the floating view matches the symptoms in the
bug.

Bug: 72996404
Change-Id: I1e7c1a338fcd16c8e07b3c49fb9c9b2097eb2708
2018-04-25 11:25:40 -07:00
TreeHugger Robot ad007ba9f1 Merge "Fix bug where workspace taps were not being sent to WallpaperManager." into ub-launcher3-edmonton 2018-04-24 22:41:33 +00:00
Jon Miranda d2d39cbfc7 Fix bug where workspace taps were not being sent to WallpaperManager.
Bug: 77218814
Change-Id: Ied464f08dce6f96fd3c56aa790f60a2561edcc84
2018-04-24 15:24:21 -07:00
Winson Chung 2d18c688d4 Merge "Send trim memory to trim icon cache when stopped" into ub-launcher3-edmonton 2018-04-24 21:32:22 +00:00
Winson Chung dea51350d6 Send trim memory to trim icon cache when stopped
- Workaround for b/78520668

Bug: 76162466

Change-Id: I2c225c59484984a671186415cb1eb19161f57ba6
2018-04-24 14:07:49 -07:00
Sunny Goyal 8546213d01 Passing stateHandler information to the callback
Bug: 78478167
Bug: 78478567
Change-Id: Ie3334c4473037c31d87bda950239c628e219dc46
2018-04-24 11:40:38 -07:00
TreeHugger Robot 406c08727e Merge "Ensure workspace is still in a valid state when handling long press." into ub-launcher3-edmonton 2018-04-24 16:10:42 +00:00
Jon Miranda ce2c6ebdd9 Ensure workspace is still in a valid state when handling long press.
Bug: 77826453
Change-Id: Iddb62597de0073630aafc95075fb62312524c412
2018-04-23 21:14:11 -07:00
Jon Miranda 5918662f32 Fix bug where scroll position jumps when in overscroll.
When bouncing between top/bottom overscroll, mDistance calculation
allows it to increase without bounds. This solution resets
mDistance to 0 for the edge that is not being overscrolled.

Bug: 78364220
Change-Id: I8371b3aee37e82d40aaa6adc2473a87f2b69931c
2018-04-23 15:51:49 -07:00
Sunny Goyal 0bbacc705c Moving some swipe up complete logic to when the handler is completed.
Bug: 76449024
Change-Id: I136e665495ab7164c79e1dfa0ef61090ba50fc7a
2018-04-23 12:09:22 -07:00
TreeHugger Robot 8b5c7d9315 Merge "Implement all apps discovery bounce." into ub-launcher3-edmonton 2018-04-23 17:36:22 +00:00
Tracy Zhou e5575f9fff Implement all apps discovery bounce.
Mock: https://docs.google.com/presentation/d/1TCp1mREgsFAWq4hCnUaSRCpaqvDbzCVkN1mJuRMylIg/edit#slide=id.g36a3e190fb_0_6

Demo video: go/shelf_bounce_animation

Fixes: 70180942
Test: manual test
Change-Id: I6ecceb63612dd63cea62f2e6cb19d7522f3d76e0
2018-04-23 10:26:40 -07:00
Sunny Goyal d3f717c765 Merge "Fixing flakiness in shape detection" into ub-launcher3-edmonton 2018-04-21 00:48:31 +00:00
TreeHugger Robot bea26c1502 Merge "Fixing preference highlight when opening notification access" into ub-launcher3-edmonton 2018-04-21 00:48:13 +00:00
Winson Chung f23931f915 Reset the force-invisible flag after the animation into launcher completes.
- In the case where an app auto-enters into PiP, we don't run the
  predefined remote animation, which means that the force-invisible flag
  is never reset. With ag/3876550, we can rely on enter animation complete
  to be called after the transition, and we can reset the flag here as well.

Bug: 77730018
Change-Id: Ifa4cbe518047eed7ab327721ff6d17db1a2b8cd5
2018-04-20 16:12:37 -07:00
TreeHugger Robot d39b8755b5 Merge "Force finish any pending animations if the insets or orientation change" into ub-launcher3-edmonton 2018-04-20 21:10:17 +00:00
Sunny Goyal ed2d2bcbb8 Force finish any pending animations if the insets or orientation change
Some animation might be running from a previous orientation, which can cuase property changes
to get skipped.

Bug: 77848165
Bug: 77774619
Change-Id: I3e198196192746abdd72a1970ff2ef407bf4aff9
2018-04-20 20:53:16 +00:00
Sunny Goyal c919a4fa94 Kepping the rotation setting UI always enabled and accessible
Bug: 77654352
Change-Id: Iade9ef33bc70fdbdac9ab39d6fa77113fb21549a
2018-04-20 12:00:43 -07:00
Sunny Goyal 40253329c5 Bringing back auto-rotate settings
Bug: 77654352
Change-Id: I0910fc8afe2fb7e125d57912abc35bbbd5df9d74
2018-04-19 09:27:56 -07:00
Sunny Goyal 6275b0ae7e Fixing flakiness in shape detection
The shape detection logic was setting a transform on the mask path, which
overrides the original transform set by the drawable, which causes it
to give different transforms depending on how many times the method is called.

Bug: 77875383
Change-Id: I3054b8f48ba698a6c7866ed27e1129665b79c447
2018-04-18 16:57:41 -07:00
Sunny Goyal d47f2d26cc Fixing preference highlight when opening notification access
Bug: 77590799
Change-Id: Ife3f9d94cb9c469c6e9e000002c6277d5bf47189
2018-04-18 14:12:06 -07:00
TreeHugger Robot 971a476cb7 Merge "WallpaperManagerCompat: correct build version check" into ub-launcher3-edmonton 2018-04-18 19:01:48 +00:00