Commit Graph

6651 Commits

Author SHA1 Message Date
Brian Isganitis 5208317c64 Merge "Add doc clarifying Taskabr icon alpha consumer purpose." into tm-qpr-dev am: a4636922a6 am: e5f48d27db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19040760

Change-Id: I4b1c43eb7e117f655e1a19664b8875ffb8179a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 21:44:42 +00:00
Brian Isganitis dc643f9bea Add doc clarifying Taskabr icon alpha consumer purpose.
The motivation ternary `alpha > 0 ? 0 : 1` was not immediately clear, so adding some clarification for future readers.

Test: No
Change-Id: I558e86153e68572a519317dba7fbba180cb5678e
Fix: 239074423
2022-08-27 20:46:49 +00:00
Schneider Victor-tulias 305a1df9d9 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev am: 7fb96a5305 am: 2ed4c84e68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19517498

Change-Id: If267d42f6d15fef03373ffe0c77fc1ebb1a7dd3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 21:31:02 +00:00
Schneider Victor-tulias 7fb96a5305 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev
* changes:
  Update ActiveGestureLog to store n-gestures rather than n-events.
  Add input consumer selection reason to active gesture logs
  Collapse EventLogArray into ActiveGesture log.
2022-08-25 20:42:13 +00:00
Schneider Victor-tulias 976fdbe623 Update ActiveGestureLog to store n-gestures rather than n-events.
Test: printed logs after several gestures
Bug: 227514916
Change-Id: I562abc6c5c43e53a53b085234b0be01dae90ac06
2022-08-25 17:05:01 +00:00
Schneider Victor-tulias 24637f50c5 Add input consumer selection reason to active gesture logs
Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I7a48d960ef5a41ddee95153fa08a2345f00cbef7
2022-08-25 10:03:30 -07:00
Schneider Victor-tulias a0cd3e0295 Collapse EventLogArray into ActiveGesture log.
EventLogArray is never used directly, only used as a super class of ActiveGestureLog. Simplifying the hierarchy to simplify follow-up changes.

Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I0916f969a776953ddc4886846ad2f4936566e7d7
2022-08-25 09:59:13 -07:00
Sunny Goyal 4b0dc5b562 Inlining BaseQuickstepLauncher to QuickstepLauncher am: d6801af69a am: 85c106aba1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668510

Change-Id: If899cc781782346d4aedd1562033c774171388fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 23:21:10 +00:00
Sunny Goyal d6801af69a Inlining BaseQuickstepLauncher to QuickstepLauncher
Bug: 243022799
Test: Presubmit
Change-Id: I3706fc1f10d88ea73bd873c7e94c3e78795791eb
2022-08-24 12:51:21 -07:00
Evan Rosky 2cfc8abceb Merge "Use SysUI/Shell's transaction apply token in Launcher" 2022-08-24 15:02:47 +00:00
Jeff Chang 7cffefbe9b Merge "Launch split task with correct UserHandle" into tm-qpr-dev am: 831f5ee748 am: ede6d7b35c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668512

Change-Id: I64778a8e2f7930a5a132c897e3dee6dbd2532e36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 08:52:12 +00:00
Jeff Chang 831f5ee748 Merge "Launch split task with correct UserHandle" into tm-qpr-dev 2022-08-24 07:48:09 +00:00
Winson Chung 19da9249dc Merge "Defer adding surface changed callback until view root is valid" into tm-qpr-dev am: c04576ad6e am: 9411d64586
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19628908

Change-Id: I8bb7d072097f0b1b22fac5f63ea8e525e3b88af5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:27:03 +00:00
Pinyao Ting 292d0d3dc9 Merge "Explicit Nullbility in Launcher (Part 2)" into tm-qpr-dev am: 775b0d21dc am: ff8f09b5b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19679564

Change-Id: I569d5e6fd9ebbcb31266c6683c129481ee3c2144
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 05:08:54 +00:00
Jeff Chang 9f27fa3687 Launch split task with correct UserHandle
PendingIntent#getActivity gets the owner UserHandle from the app
context. That makes the activity launch fail since the app only exists
in the work profile environment(secondary user).

This CL gets the correct Userhandle from Launcher and use
PendingIntent#getActivityAsUser to launch split task.

Bug: 242039471
Test: Launch Google chat by shortcut to enter split (work-profile)
Change-Id: Ie1db8a858bf9cee700cb3ff3a9e607a5d1dbad30
2022-08-24 10:39:04 +08:00
Evan Rosky 6e326cf205 Use SysUI/Shell's transaction apply token in Launcher
Launcher and SysUI/Shell have a lot of interactions
that require careful synchronization and ordering (at-least
with shell-transitions). As a result, they need to share
the same apply token or else some operations can end up
out-of-order despite being applied in-order.

Bug: 242193885
Test: Open an app, quickswitch repeatedly.
Change-Id: I4cbe8b5db28516db7a08b4022f1199f3f6b89591
2022-08-24 00:06:18 +00:00
Winson Chung c04576ad6e Merge "Defer adding surface changed callback until view root is valid" into tm-qpr-dev 2022-08-23 21:32:48 +00:00
Pinyao Ting 023b973d15 Explicit Nullbility in Launcher (Part 2)
This CL updates the nullabality on methods associated with IconCache in Launcher.

Bug: 242895652
Test: manual
Change-Id: I4832c0950141c8a52c8a9e62659ccabb082897c8
2022-08-22 17:15:44 -07:00
Sunny Goyal ca5761d21f Merge "Removing some obsolete features" into tm-qpr-dev am: 211496e3d8 am: a3dacac8b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19505122

Change-Id: I8a0157caa803b2edcef458895d7e9ded06ea5fe0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 21:07:20 +00:00
Sunny Goyal 211496e3d8 Merge "Removing some obsolete features" into tm-qpr-dev 2022-08-22 20:27:45 +00:00
Ats Jenk 84fb0cf390 Merge "Hide freeform button from app menu in recents" into tm-qpr-dev am: 5db5015fe2 am: a2c0473d94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19681296

Change-Id: I9886b4c60c692bb8a9cd1030ebbc3a70317162d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-20 01:19:18 +00:00
Ats Jenk 5db5015fe2 Merge "Hide freeform button from app menu in recents" into tm-qpr-dev 2022-08-20 00:37:56 +00:00
Ats Jenk 6b31ed99d9 Hide freeform button from app menu in recents
When desktop windowing prototype is enabled, we should only be able to
switch apps to freeform mode via the quick tile.
Disabling other routes to put individual apps to freeform.

Test: visually verified that freeform button is not visible when desktop
windowing prototype flag is enabled
Bug: 242906219

Change-Id: Ib1ce75969b67f30d82262927e2e4113fab2c4956
2022-08-19 12:35:26 -07:00
Jeremy Sim 235bd0c0d4 Merge "Revert "Update animations for TM-QPR: Overview > OverviewSplitSelect transition"" into tm-qpr-dev am: 5ea6cfdb7e am: 2351d8dee3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19669397

Change-Id: Ie12aac6a63ff32c8fd0a443554898ba77c65d471
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-19 14:21:11 +00:00
Jeremy Sim 5ea6cfdb7e Merge "Revert "Update animations for TM-QPR: Overview > OverviewSplitSelect transition"" into tm-qpr-dev 2022-08-19 13:37:58 +00:00
Jeremy Sim 2fe7dd7306 Revert "Update animations for TM-QPR: Overview > OverviewSplitSelect transition"
This reverts commit a50bb39048.

Reason for revert: Causes a P1 bug (b/241165022).

Fixes: 241165022
Bug: 236760307
Change-Id: Icc080d9a37e26d70d0f4cf846a4fd39df3b71625
2022-08-18 21:28:54 +00:00
Winson Chung b8a2a026a5 Defer adding surface changed callback until view root is valid
- It appears there are cases where the view root is not valid (in
  which case schedule() returns false and we don't wait to handle
  the callback) which causes an NPE, but in these cases we don't
  need to add the surface changed callback at all.

Bug: 202776119
Bug: 242347940
Bug: 242897135
Test: Launch an app with sharesheet, swipe up and verify that
      screenshot callbacks

Change-Id: Icc3afc604bd925c5d49c693b7de51755f5a8bd42
2022-08-17 20:27:57 +00:00
Evan Rosky 0fb2346e57 Merge "Notify recents controller when no-longer finishing-to-home" into tm-qpr-dev am: 4a8871ce4c am: cce589834c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19583219

Change-Id: Ie50e504f09172342f3ffcecf3ea92aaaad880da4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17 16:48:02 +00:00
Evan Rosky 4a8871ce4c Merge "Notify recents controller when no-longer finishing-to-home" into tm-qpr-dev 2022-08-16 16:02:45 +00:00
Jeremy Sim 6044de1977 Merge "Update animations for TM-QPR: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: cf03d04469 am: 6a6b5e4e9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19464657

Change-Id: Ifb097d77968dd73d80aa42327e53dcb1fdc1c2c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-15 22:47:36 +00:00
Jeremy Sim cf03d04469 Merge "Update animations for TM-QPR: Overview > OverviewSplitSelect transition" into tm-qpr-dev 2022-08-15 21:19:21 +00:00
Evan Rosky 4b8f86ebcc Notify recents controller when no-longer finishing-to-home
Bug: 241818882
Test: open app, swipe to recents, restore app
Change-Id: Ifb258319b7a54917f9f6ac08ccefeed5a47480e2
2022-08-15 10:26:49 -07:00
Jeremy Sim a50bb39048 Update animations for TM-QPR: Overview > OverviewSplitSelect transition
The animation from Overview to OverviewSplitSelect is now updated to the latest spec. See bug for details.
- New timings
- Task thumbnails slide in with a new spring animation
- Icons fade out and fade in appropriately
- SplitInstructionsView has a new compound "unfold" animation

Bug: 236760307
Test: Manual on tablet and phone. Looks good on both true and fake orientations.
Change-Id: If98d4464aa51c876d79bee9672279992a2cf9026
2022-08-14 10:34:51 -07:00
Stefan Andonian 4ec179f13a Merge "Fix for bug where expensive launcher animations were being paused and never resumed." into tm-qpr-dev am: 28d354c9a1 am: a79e5705bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19600849

Change-Id: I8438e9e45e9a453ba586c4a834ba0d24a61b99b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-12 17:38:18 +00:00
Stefan Andonian 28d354c9a1 Merge "Fix for bug where expensive launcher animations were being paused and never resumed." into tm-qpr-dev 2022-08-12 17:07:03 +00:00
Stefan Andonian 8b336195a6 Fix for bug where expensive launcher animations were being paused and never resumed.
Bug: 240623130
Test: Verified on device that the issue is not reproducible after fix.
Change-Id: I7b1e2f70fd75b1eddf340a4f85465cc6d5b65f73
2022-08-11 20:36:41 +00:00
Pat Manning 2c60b25805 Merge "Add logging to help debug flake when swiping home to overview." 2022-08-11 09:54:17 +00:00
Jerry Chang 7498703aa9 Merge "Integrate split pair cold launch transition with shell transition" into tm-qpr-dev am: 4322190a24 am: f3d0d066bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19467311

Change-Id: I603efb13f3e6f2d7b9f536e6455fa51e4c1fe789
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-11 07:54:31 +00:00
Jerry Chang 4322190a24 Merge "Integrate split pair cold launch transition with shell transition" into tm-qpr-dev 2022-08-11 07:05:18 +00:00
Winson Chung 99f80d2364 Merge "Force finish pending frame drawn callback once launcher is stopped" into tm-qpr-dev am: 99b1580d79 am: 6245c43bb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19569180

Change-Id: I2673009a718d4accfc69720f562c5e57ee4cca2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-11 06:37:43 +00:00
Winson Chung 99b1580d79 Merge "Force finish pending frame drawn callback once launcher is stopped" into tm-qpr-dev 2022-08-11 05:32:41 +00:00
Alex Chau ea521f4857 Merge "Use WindowManagerProxy.getRotation to determine if rotation has changed" into tm-qpr-dev am: 5d9625b865 am: d86d6223b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19582532

Change-Id: I93957f96b19647c873580ae014e275be2060b3f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-11 00:03:29 +00:00
Winson Chung e7bf15932b Force finish pending frame drawn callback once launcher is stopped
- In rare cases, we may schedule to update the taskview with a
  screenshot but Launcher will not finish calling back because
  the activity is stopped (can be the result of the animation
  cancelling back to the app), which prevents Launcher from
  scheduling any frames and properly decrementing the frame
  count.

Bug: 202776119
Test: Launch an app with sharesheet, swipe up and verify that
      screenshot callbacks
Change-Id: I6b7e121fd5d9ef27ef5cccca060a4ff819fe9acc
2022-08-10 19:58:19 +00:00
Alex Chau 360ec033ac Use WindowManagerProxy.getRotation to determine if rotation has changed
- Follow-up of http://ag/19559863 as Config diff on windowConfiguration does not work on 3P Launcher, so diff WindowManagerProxy.getRotation instead
- Also centralized Configuration diff logic into StatefulActivity

Bug: 240730723
Test: manual on 90/180 degree rotation in Launcher, RecentsActivity and 3P Launcher
Change-Id: Ib368ed5d749841a6873a03e2644608ff68885922
2022-08-10 18:14:06 +01:00
Pat Manning 1edba8b0a6 Add logging to help debug flake when swiping home to overview.
Bug: 238461210
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: I8ee9af4f4a331c43761ba3738e12acb376ababc2
2022-08-10 13:37:02 +00:00
Nicolò Mazzucato b399812c6e Merge "Disable hinge sensor while the screen is off" into tm-qpr-dev am: 92b4a88f78 am: b793cac638
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19536889

Change-Id: I6a2a49f39db26fce7cbff4dc359eda8cc47248bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 09:49:05 +00:00
Alex Chau 1edf184cc9 Merge "Detect potential WindowConfiguration change at onApplyWindowInsets" into tm-qpr-dev am: 16b6511e14 am: 76865013bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19559863

Change-Id: Ibe53bcf7d1839224bf2b8e0d8d5bec6a25096b9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 09:48:54 +00:00
Nicolò Mazzucato 92b4a88f78 Merge "Disable hinge sensor while the screen is off" into tm-qpr-dev 2022-08-10 09:32:53 +00:00
Alex Chau 16b6511e14 Merge "Detect potential WindowConfiguration change at onApplyWindowInsets" into tm-qpr-dev 2022-08-10 09:14:11 +00:00
Vinit Nayak 2d6442c5e6 Merge "Show 3 button nav on phone in Taskbar (1/2)" into tm-qpr-dev am: 89be3a4c6d am: 72864a13db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19534821

Change-Id: Ib9ef7e0923dea9e1700208b9dbdd20ee4368b063
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 04:19:00 +00:00