Commit Graph

1915 Commits

Author SHA1 Message Date
Sebastian Franco 51231ee5c2 Remove the initialize method from setUp since is now on being called on the super method.
Bug: 324261526
Test: most Tapl test
Flag: NA
Change-Id: Icbf9883613069101a3c8428e8e3b02b1eb01dcd0
2024-02-21 17:24:12 -08:00
Sebastián Franco e6bab556a1 Merge "Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments" into main 2024-02-08 19:33:13 +00:00
Sebastián Franco 9a8ecd954e Merge "Investigating test" into main 2024-02-08 19:05:12 +00:00
Jagrut Desai a6bf72fe5b Merge "Making AbstractDeviceProfileTest tnd FakeInvariantDeviceProfileTesto only run on CF_PHONE" into main 2024-02-08 16:31:09 +00:00
Jagrut Desai f584d784f8 Making AbstractDeviceProfileTest tnd FakeInvariantDeviceProfileTesto only run on CF_PHONE
Test: Presubmit
Bug: 315230497
Bug: 322418756
Bug: 321596072
Flag: NONE

Change-Id: I668f87304df0ba1dcace3d802906c8a66912d381
2024-02-08 12:06:44 +00:00
Sebastian Franco 3f6194dcaf Investigating test
Flag: NA
Bug: 322823478
Test: waiting for falkes to see results
Change-Id: I447b0f22fe307ade4920e1b12cdc63f375126a5a
2024-02-07 16:33:23 -08:00
Shamali Patwa e2849a0de0 Merge "Remove the "expand/collapse" actions on the apps list in 2 pane picker." into main 2024-02-07 22:53:34 +00:00
Sebastián Franco 458de20538 Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments
Bug: 324261526
Test: atest TaplDragTest
Flag: NA
Change-Id: I0802d725eea222d19c8d8e60878c2f88be854ddc
2024-02-07 22:48:26 +00:00
Anushree Ganjam faa35a81bb Merge "Add Unit tests for System Shortcut." into main 2024-02-07 19:38:32 +00:00
Fengjiang Li 7f827e1527 Merge "[Predictive Back] Replace legacy flag with aconfig flag in launcher" into main 2024-02-06 21:57:34 +00:00
Shamali P 55fded376b Remove the "expand/collapse" actions on the apps list in 2 pane picker.
In a single pane picker, apps list is expandable / collapsable, but,
its not applicable for 2-pane variant. in 2-pane one, it should just
say "double tap to activate".

Also opened b/324073588 to make it clear from a11y perspective that it
is two pane and on click, right pane change should be announced.
(just like it does in settings with talkback).

see screencast/cast/NTQ1Mjk0MjIzOTg1ODY4OHw4OTc5ZjAzNS0wOQ

Bug: 319195592
Flag: None
Test: WidgetsListHeaderAccessibilityTest & manual.
Change-Id: I9ae3fbacc29364bd7459f6e6d85e0a1e919de3f8
2024-02-06 20:07:41 +00:00
Sunny Goyal a90500d233 Using system API for rotating DisplayCutout instead of rotating it ourselves
Bug: 321913010
Flag: NONE
Test: Manual
Change-Id: Iebbc8c17dc3b92a73866b7e22dfbde18eb3a52ff
2024-02-06 10:26:18 -08:00
Fengjiang Li cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Anushree Ganjam 9858a3e0f4 Add Unit tests for System Shortcut.
Update SystemShortcut<T extends ActivityContext> and remove dependency on Launcher so we can write unit tests.

Introduce TestSandboxModelContextWrapper , wrapper around SandboxModelContext and ActivityContext.

Use SandboxModelContext for testing since we need UserCache, AllAppsContainerView, AllAppsStore to be spied and verified for function calls.

StatsLogManager is not verified in this cl, We can do as follow up.

Bug: 319250810
Test: Manual.
Flag: aconfig com.android.launcher3.enable_private_space TEAMFOOD

Change-Id: If767128a502e40d2016a331db4a342f20f24c588
2024-02-05 10:59:52 -08:00
Vadim Tryshev 94477b23e9 Send finish callback even if there is no icon to animate to
Fixes: 321297170
Test: TaplAllAppsIconsWorkingTest#testAppIconLaunchFromAllAppsFromHome
Flag: none
Change-Id: Ia6084dd14715bab36c7dd1c983fabedcf9b10630
2024-02-02 20:42:02 +00:00
Vadim Tryshev 3f4401aa7e Merge "Adding text messages to some asserts in TaplAddConfigWidgetTest" into main 2024-02-02 18:21:35 +00:00
Sebastián Franco fe5c308a11 Merge "Adding unit test to makeSpaceForHotseatMigration" into main 2024-02-02 17:52:52 +00:00
Rohit Goyal c475f22d8b UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Id9ba2ea833e8360ac8aa2c765beff402cff12ae2
2024-02-02 00:27:16 +00:00
Vadim Tryshev 1784a329e6 Adding text messages to some asserts in TaplAddConfigWidgetTest
Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: Ia8164f60f49b377e41db72f97c4f90d167292574
2024-02-01 11:33:23 -08:00
Sebastian Franco 2d8be10856 Adding unit test to makeSpaceForHotseatMigration
Flag: NA
Bug: 318417510
Test: atest HotseatReorderUnitTest
Change-Id: If4fe388d00138b2d43693df0cf79abb16f354291
2024-02-01 17:08:52 +00:00
Shamali Patwa bb28770a01 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211 am: 962f362912
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: I82c1df4c6ad2a4fa09f700f8f3d73f5fb671141d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:45:06 +00:00
Shamali Patwa 962f362912 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: Ic9b3be62af2271286292cfaf30bda03351c1aaf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:05:01 +00:00
Shamali Patwa d3f5010ac5 Merge changes from topic "categories" into main
* changes:
  Add a default widget category provider that uses application category.
  Add a feature flag for displaying categorized widget recommendations.
2024-01-31 02:24:05 +00:00
Shamali P c5fbb42dcb Add a default widget category provider that uses application category.
The category provider can be customized by any launcher via resource
override. For instance, one can override it to provide custom categories
using an allowlist or use a different mechanism such as query play
services.

We still need to get proper strings for categories from UX writer.

Bug: 318410881
Test: WidgetRecommendationCategoryProviderTest
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I5c4e0d22eaffc8254ddd54356f8c62f00e22a3c4
2024-01-31 00:43:22 +00:00
Shamali P 6a9d114d40 Update OWNERS for picker directory to include new owners.
There are some more files relevant to picker, but this CL covers
directory with the primary picker UI.

Change-Id: I53e174d9cd20396b4f56acb5d9e3cc07ec475ea8
2024-01-30 20:10:24 +00:00
Sebastián Franco ea73bf5d77 Merge "Removing the Worskapce as a dependency of CellLayout" into main 2024-01-30 02:19:19 +00:00
Shamali Patwa 279544e718 Merge "Add the testDragCustomShortcut back for phones." into main 2024-01-29 20:52:49 +00:00
Charlie Anderson 9147575693 Merge "Add unit tests to WorkspaceItemProcessor for processing apps" into main 2024-01-29 20:27:13 +00:00
Federico Baron 8960937d47 Merge "Fix testDragToFolder test" into main 2024-01-29 19:27:24 +00:00
Shamali P 458825a3fc Add the testDragCustomShortcut back for phones.
testDragCustomShortcut was ignored, but as discussed, enabling it for
phones - where the layout of picker is unchanged.

Bug: 322820039
Test: Un-ignoring the test
Flag: N/A
Change-Id: I3607812befc58c8a46b49a2587dfa6a1b572cd5b
2024-01-29 19:07:03 +00:00
Himanshu Gupta ea9522eee5 Merge "Adding Test Parameters to Asserts." into main 2024-01-27 04:39:08 +00:00
Charlie Anderson ca6f66cd88 Add unit tests to WorkspaceItemProcessor for processing apps
- also slightly improve some log messages and simplify some code

Test: presubmit / unit tests
Flag: None
Bug: 294386159
Change-Id: I6f75c0d34bf475d4e20d6250f67a56d5394b9c4e
2024-01-26 15:42:51 -06:00
Sebastian Franco 2986e0b4d1 Removing the Worskapce as a dependency of CellLayout
This will make it easier to test CellLayout, also we should avoid
circular dependencies as much as poisble.

This also allows the CellLayout to be created in other containers
that are not workspace.

Bug: 318417510
Test: creating HotseatReorderUnitTest in follow up cl
Test: TaplReorderWidgets
Test: ReorderAlgorithmUnitTest
Flag: NA
Change-Id: Ic45029a244cb11f8d6775c50b90af9c56f01eaa3
2024-01-26 09:28:57 -08:00
Himanshu Gupta 39d87bf229 Adding Test Parameters to Asserts.
Bug: 320703862
Flag: NA
Test: NA
Change-Id: I1dba86e3a24dc5b67c754087deca8794a38d83a0
2024-01-26 20:23:42 +05:30
Himanshu Gupta eaeb666e43 Merge "Separating system and user-installed apps in PS container." into main 2024-01-26 14:22:19 +00:00
Jakob Schneider fc433dd84d Merge "Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests." into main 2024-01-26 10:48:09 +00:00
Himanshu Gupta 0cc11dbcac Separating system and user-installed apps in PS container.
We add a horizontal line separator in PS container which demarcates
user-installed vs system installed apps in private space.
User-installed are shown above the separator, system ones below.

UX Mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=11546%3A310574&mode=dev
Mock Image: https://photos.app.goo.gl/Wj8sJkS7P7bRbovg8
Demo video: https://photos.app.goo.gl/MBw6HpDnf6PJqUfs8

Bug: 308054233
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Test: AlphabeticalAppsListTest
Change-Id: Iad8e289c49a05ac7ef1978bd8e4ebe7aa0add0ca
2024-01-26 11:04:13 +05:30
Rohit Goyal 9977121e8e Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests.
* Currently unarchival tests only pass for Launcher3. We extend the broadcast receiver to AndroidManifest-common to also support NexusLauncher tests.

Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I9be459a2a0648063d62538eed20c0a6e7644ad44
2024-01-26 00:40:17 +05:30
fbaron 9a16ca5215 Fix testDragToFolder test
The issue seems to be that when we begin drag we enter spring loaded mode which triggers the 'app swap' interaction, leading us to getting the wrong position for the app icon we're trying to drag into. Using photos app instead of gmail should make it so that we don't enter the app swap operation with playstore, meaning we would get the correct position for play store and we will drag the app there

Fix: 320484402
Flag: NONE
Test: TaplDragTest#testDragToFolder
Change-Id: Id6f09be997046e7c450a2760ee95cc5735ad5673
2024-01-25 10:55:27 -08:00
Sebastián Franco a808e7ea98 Merge "Moving ReorderPreviewAnimation into it's own file and rewrite to Kotlin." into main 2024-01-25 17:16:25 +00:00
Himanshu Gupta f591ce5f17 Restricting Accessibility flows for Private Profile.
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.

Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
2024-01-25 04:19:20 +00:00
Sebastian Franco f7654252b1 Moving ReorderPreviewAnimation into it's own file and rewrite to Kotlin.
This will make it easier to write unit testing.

Fix: 294473336
Test: manual testing
Flag: NA
Change-Id: I2d6cfd8110c5c2ef09c49150a0bd071bc948995c
2024-01-24 14:04:48 -08:00
Uwais Ashraf 77b97c0729 Replace existing Robolectric test task with functioning one.
This CL does the following:
- Creates a dir for multivalentTests
- Creates symlinks for the dir to keep Android Studio happy
- Moves many files to the multivalentTests dir
- Adjusts gradle and soong build files to use the new dir as part of
their source sets.

Test: ./gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Fix: 316553886
Bug: 316553889
Flag: NA
Change-Id: Iae28fd0c0191b3ecf9bd2950800875950cca2622
2024-01-19 21:39:23 +00:00
Vadim Tryshev 82bf25b017 Merge "Adding TestStabiility so that demoting transitioningToUnlocked_resetCallsPendingRunnable from presubmit works" into main 2024-01-19 21:14:20 +00:00
Fengjiang Li a6142fff95 Merge "Fix flaky ExecutorRunnableTest" into main 2024-01-19 21:05:23 +00:00
Fengjiang Li 8e2797c52e Fix flaky ExecutorRunnableTest
Use lock to pause/resume execution of Executor

Fix: 316588649
Test: Unit test
Flag: NONE
Change-Id: I5a3c5dece279c6bdaaba579754678108b4bf75b8
2024-01-19 11:44:17 -08:00
Vadim Tryshev 840a97d7ff Adding TestStabiility so that demoting transitioningToUnlocked_resetCallsPendingRunnable from presubmit works
Bug: 320703862
Test: presubmit
Flag: N/A
Change-Id: Ie0e49ffb4d1efabe1c79fac9342f186f15f8cf23
2024-01-19 18:28:05 +00:00
Vadim Tryshev a3e2c59716 Merge "Demoting unstable transitioningToUnlocked_resetCallsPendingRunnable from presubmit" into main 2024-01-18 18:14:11 +00:00
Rohit Goyal d16a574524 Merge "Add support for progress bar for archived apps in AllApps view." into main 2024-01-18 17:56:04 +00:00
Sunny Goyal 7c44333f0e Merge "Using WidgetInflater in loader task" into main 2024-01-17 19:21:31 +00:00