Commit Graph

6795 Commits

Author SHA1 Message Date
Brian Isganitis 4aa2644629 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev am: f5c099b528
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20726289

Change-Id: I0184935622d8892842af29629ed96eff65e9507b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:50:23 +00:00
Brian Isganitis f5c099b528 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev 2022-12-14 20:25:21 +00:00
Jon Miranda 80f6ece5ad Merge "Taskbar All Apps button visual updates" into tm-qpr-dev am: a0743cf62c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20724415

Change-Id: Ib3ff9ebcfd645a6f929e17e17aec4f14b070b7ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:33:23 +00:00
Brian Isganitis 71f9faded9 Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev am: 8216a26bfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713695

Change-Id: Ic5f32fca6c7f56c9e17cdc68bc0416c0881e2fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:32:50 +00:00
Jon Miranda a0743cf62c Merge "Taskbar All Apps button visual updates" into tm-qpr-dev 2022-12-14 19:00:18 +00:00
Brian Isganitis 8216a26bfe Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev 2022-12-14 18:54:42 +00:00
Jon Miranda e7417ce2ae Taskbar All Apps button visual updates
- Moved to new position
- Using 3x3 icon
- New Colors

Checked with visd that this half is good to go,
will follow up with positioning of the 3x3 icon within
its container.

Bug: 259712417
Test: manual, LTR/RTL modes, transient/persisent models

Change-Id: I298b6dbca004cdb8920e6533fffc8ca83e0197f9
2022-12-13 15:16:01 -08:00
Brian Isganitis 47da4167ea Assign taskbar EDU same interpolator as all apps.
This polishes closing both at the same time when they are on top of each
other.

Test: Manual
Bug: 217261955
Change-Id: Iecb8658b98debb0225d3b59da99ecb34d008971a
2022-12-13 16:43:36 -05:00
Brian Isganitis 2a2f1b6cd3 Polish all apps taskbar unstash behavior for transient and persistent.
- During gestures from taskbar all apps, unstash immediately in
  transient.
- Overlay closes sooner if all apps is open (still done later for EDU).
- Taskbar stashes in overview when All Apps is opened.
- Transient app-window threshold is ignored if All Apps is opened.

Test: Manual
Fix: 262076812
Change-Id: I46b2dcdc75ee0cc15c1b47da2139ff8c20cf618a
2022-12-13 16:24:35 -05:00
Pat Manning 2eca15a02f Merge "Include taskbar cropped insets in thumbnail aspect ratio difference calculation." into tm-qpr-dev am: 59c4fff67c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643015

Change-Id: Id044d04b165d334931afb3cfc3754c5b4e0f4abf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 18:59:11 +00:00
Jeremy Sim 8ccaa6a33d Merge "Use already-running app instances when splitting" into tm-qpr-dev am: 538281db37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20625907

Change-Id: If7edcfa37908409a48c6a4db9031fab0fe2414a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 18:57:59 +00:00
Pat Manning 59c4fff67c Merge "Include taskbar cropped insets in thumbnail aspect ratio difference calculation." into tm-qpr-dev 2022-12-13 18:29:27 +00:00
Jeremy Sim 538281db37 Merge "Use already-running app instances when splitting" into tm-qpr-dev 2022-12-13 18:21:12 +00:00
Pat Manning 0333ec1d21 Include taskbar cropped insets in thumbnail aspect ratio difference calculation.
Bug: 260861673
Test: manual.
Change-Id: I3abed4dfab5dccf99ae81e0f2d0ae840a3aabed5
2022-12-13 11:45:05 +00:00
Andy Wickham a89df1e47f Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev am: 29b95b58ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546292

Change-Id: I09030c24485b7b25a2eb72d90e4515d6e9ea3960
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-12 19:29:48 +00:00
Andy Wickham 29b95b58ba Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev 2022-12-12 19:08:37 +00:00
Jon Miranda e34202df54 Merge "Better support transient and persistent taskbar in taskbar's overlays." into tm-qpr-dev am: a76222d209
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20693438

Change-Id: I54a1a4198047d658def291ec70fc8530b42ad6b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-10 02:03:49 +00:00
Brian Isganitis 3030ccf26b Merge "Add logging to investigate updateOverviewTargets state." into tm-qpr-dev am: 570c5146d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680311

Change-Id: If5371ef5eaf0b1c37ee506dae619e311977490b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-10 02:02:59 +00:00
Jon Miranda a76222d209 Merge "Better support transient and persistent taskbar in taskbar's overlays." into tm-qpr-dev 2022-12-10 02:02:54 +00:00
Brian Isganitis 570c5146d3 Merge "Add logging to investigate updateOverviewTargets state." into tm-qpr-dev 2022-12-10 01:22:13 +00:00
Federico Baron 2263b57d8d Merge "Move AnimatedFloat from quickstep to launcher" into tm-qpr-dev am: 9a6a2c8a2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20683305

Change-Id: Ib0f4ad639670fce70e9431f8c8cb9f2663722c77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 23:56:31 +00:00
Federico Baron 9a6a2c8a2d Merge "Move AnimatedFloat from quickstep to launcher" into tm-qpr-dev 2022-12-09 23:33:17 +00:00
Brian Isganitis 85ccf120f2 Better support transient and persistent taskbar in taskbar's overlays.
- Transient taskbar nav threshold now works in overlays.
- Delay closing overlay to transient app-window threshold if necessary.
- Persistent taskbar no longer stashes for EDU overlay.
- EDU overlay provides enough bottom padding for transient and
  persistent taskbar.

Test: Manual
Bug: 217261955
Change-Id: I2ae5612ef70a6d09e22f83f8117cdbf2a0a053b8
Fix: 260769010
2022-12-09 11:24:27 -08:00
Sunny Goyal deffe8f8df Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev am: d31c8baef1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20676568

Change-Id: Ie215c1933dce65d87204e5969c470548452a7998
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 15:47:35 +00:00
Sunny Goyal d31c8baef1 Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev 2022-12-09 15:35:59 +00:00
Ats Jenk 7868989e50 Merge "Check for both proto flags for common logic" into tm-qpr-dev am: e8c57e94e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20653403

Change-Id: I155bba8ce3621fcb235d3b5cc245e381f3c22947
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 00:54:23 +00:00
Ats Jenk e8c57e94e7 Merge "Check for both proto flags for common logic" into tm-qpr-dev 2022-12-09 00:43:04 +00:00
Brian Isganitis 2b5ba5eb5f Merge "Add EDU lottie animations for persistent and transient." into tm-qpr-dev am: ddc7ef2eb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20672612

Change-Id: Ie302f00d1ba369210caf9910422a1df305a8a4ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 00:02:31 +00:00
Brian Isganitis ddc7ef2eb1 Merge "Add EDU lottie animations for persistent and transient." into tm-qpr-dev 2022-12-08 23:11:27 +00:00
Federico Baron 47d81686e6 Move AnimatedFloat from quickstep to launcher
We are moving AnimatedFloat to launcher to be able to use this in class in launcher. Having it in launcher will allow us to do restore icon treatment animations to do with scaling the icon size

Bug: 254858049
Test: verified that the device still works
Change-Id: I1c4c47ab436c389a94abf7c910c1a44724efc955
2022-12-08 13:58:07 -08:00
Jeremy Sim 2cbd7bbfdf Use already-running app instances when splitting
This patch makes it so that when the user initiates a split from Home, a running app instance is used instead of always attempting to spawn a new Intent. If no matching app instance is found, behavior is unchanged.

Previously, splitting from Home always resulted in a new Intent being staged, which ignored the fact that an app of the same type could already be running. This resulted in undesirable situations like being able to attempt splitting an app with itself in Overview.

Fixed by querying the RecentsModel when a split of this type is initiated, checking to see if there is a running task of the desired type, and using that to perform the split operation if one is found. When Overview is loaded, applyLoadPlan() will now check to see if there is a staged task, and remove the associated tile as needed. If the removed task is part of a pair, this involves creating a temporary TaskView to hold the other task.

Also fixes a bug where using the Taskbar to select one's second app would incorrectly choose the oldest instance of a multi-instance app rather than the newest.

Fixes: 257513447
Fixes: 259936298
Test: Manual
Change-Id: I97a62f34c03aa4980f9cd743e35e9fc6ef4c092d
2022-12-08 13:24:43 -08:00
Brian Isganitis b962950ae9 Add logging to investigate updateOverviewTargets state.
Test: Manual (logcat)
Bug: 258022658
Change-Id: I50640124f1e8fd5ae4aaf6240c044ded108849b5
2022-12-08 18:26:22 +00:00
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
2022-12-08 10:15:55 -08:00
Schneider Victor-tulias d132ad4393 Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev am: ad48decd4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20664263

Change-Id: Icfdd29ce44e4ff73bfb79b3150addca41b7517cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 15:25:37 +00:00
Schneider Victor-tulias ad48decd4f Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev 2022-12-08 14:55:15 +00:00
Brian Isganitis 77de0d5a28 Add EDU lottie animations for persistent and transient.
This CL introduces separate lottie assets for light and dark themes, as
well as each step. Each asset contains all of the steps currently but is
constrained to a min and max frame. In future CLs, we will optimize the
storage these take up by using the global assets and controlling min and
max frames programmatically, or trimming each individual asset.
Additionally, we should only be importing one theme variant and then
converting to the opposite programmatically, but the color mappings are
not ready yet.

Future polish to the EDU sheet, such as better handling the stashed
taskbar, will be introduced in future CLs.

Test: Manual in transient and persistent modes.
Bug: 217261955
Change-Id: I5b219ea02e25de0c5c887b5b5640f909e1219287
2022-12-08 14:06:09 +00:00
Schneider Victor-tulias f0de6cc2ca Revert "Cancel gestures on launcher destroy"
Revert "Refactor SchedulerCallback implementation"

Revert submission 20555112-launcher-destroy-gestures

Reason for revert: causes test failures
Reverted Changes:
Ib43cdd597:Refactor SchedulerCallback implementation
Ia8e936e26:Cancel gestures on launcher destroy

Change-Id: I2199e39237b7c9fe25784b46e16960cd5f17c46c
2022-12-07 19:46:00 +00:00
TreeHugger Robot 602ef0772d Merge "Add logs to aid missing unfold animation on launcher investigation" into tm-qpr-dev am: db8b97068b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20637474

Change-Id: I30d189b40676bdc62f4c5d8fa243eae9b10b23d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 19:24:07 +00:00
TreeHugger Robot db8b97068b Merge "Add logs to aid missing unfold animation on launcher investigation" into tm-qpr-dev 2022-12-07 19:06:21 +00:00
Ats Jenk 8f5b9dd833 Check for both proto flags for common logic
Desktop mode has prototype 1 and prototype 2.
Check for both flags when logic is shared.

Bug: 260645044
Test: manual, check desktop mode 1 works
Change-Id: I40e84440222a9d5f007c2450606cd7c8f9628da2
2022-12-07 10:12:37 -08:00
Andy Wickham 0adad24408 Adds header protection on tablet all apps panel.
Removes background and manually draws it while drawing scrim. Then
draws header protection on top as needed.

Currently this only applies to all apps from Launcher, as Taskbar
doesn't seem to use the same scrim flow. So taskbar adds the same
static background that was previously used.

Demo videos: https://drive.google.com/drive/folders/11PyFsrLV6-QhU_E-zD3s5bfzZK2nOU87?resourcekey=0-E41uw5TP9xuqTifLAs71yw&usp=sharing

Test: Manually on phone and tablet with dark/light mode, floating
search bar on/off, work profile present/absent, taskbar/home entry
Bug: 240670050

Change-Id: I81dcc956d9dbbc7552c8a227a49741bcf71eed71
2022-12-06 18:31:33 -08:00
Nicolo' Mazzucato 1ee66e943a Add logs to aid missing unfold animation on launcher investigation
Bug: 261320823
Test: Manual
Change-Id: If714750c85ee49e66e21462ab9d2675ab0be8b55
2022-12-06 13:06:01 +00:00
Tony Wickham c9740c89aa Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev am: ef8677169c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20622942

Change-Id: Ia758acdad42c8f95b9ee52d37d0bf7a3f2c63e80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 06:29:09 +00:00
Tony Wickham ef8677169c Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev 2022-12-06 06:12:23 +00:00
Tony Wickham 7286c5be98 Add feature flag to force taskbar to be persistent.
This will allow us to test taskbar pinning before the entrypoint for
such a setting is finalized.

Test: manual, TODO: will need to update TaplTestsTaskbar to account for
this mode
Flag: FORCE_PERSISTENT_TASKBAR [off]
Bug: 258604917

Change-Id: I4535978563ffbe9a6cc6ece7720cdb75e787ff44
2022-12-06 00:51:46 +00:00
TreeHugger Robot f77ad4afd4 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev am: c4d6dee069
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20555112

Change-Id: I5907940eac2de90c913e1d8ed965b35f013815f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 21:13:20 +00:00
TreeHugger Robot c4d6dee069 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev 2022-12-05 20:25:47 +00:00
Schneider Victor-tulias 65dda6d03e Cancel gestures on launcher destroy
A wide variety of gesture navigation bugs were caused if launcher happened to be recreated mid-gesture and we didn't handle it gracefully. Updated lifecycle callbacks to immediately cancel the ongoing gesture if launcher is destroyed.

Fixes: 244593270
Fixes: 257976590
Test: forcefully(programmatically) recreate on every other gesture nav handle touch down; check that following gestures are not broken and animations are not frozen
Change-Id: Ia8e936e26a42cfe26fc6bcd9eefb25d37bc08749
2022-12-05 08:11:50 -08:00
Sebastián Franco e8786a176d Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev am: fba141a3dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20611319

Change-Id: Idb38e0a166a18455a2bed40822c0ed8547359b8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 01:59:43 +00:00
Sebastián Franco fba141a3dc Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev 2022-12-03 01:32:25 +00:00